From bugzilla-daemon@bugs.koha-community.org Mon Apr 23 14:35:12 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7996] New: Patron Modification Log Requires Parameters Permission Date: Mon, 23 Apr 2012 12:41:18 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2877479286670905896==" --===============2877479286670905896== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Priority: P5 - low Change sponsored?: --- Bug ID: 7996 CC: gmcharlt@gmail.com Assignee: kyle.m.hall@gmail.com Summary: Patron Modification Log Requires Parameters Permission QA Contact: koha.sekjal@gmail.com Severity: normal Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: NEW Version: master Component: Patrons Product: Koha Created attachment 9274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9274&action=edit without parameters permission See attached. The "Modification Log" tab does not appear while viewing a patron's record (Detail, Check Out) unless the staff member has the "Set Koha system parameters" priviledge enabled. -- You are receiving this mail because: You are watching all bug changes. --===============2877479286670905896==-- From bugzilla-daemon@bugs.koha-community.org Mon Apr 23 14:35:45 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7996] Patron Modification Log Requires Parameters Permission Date: Mon, 23 Apr 2012 12:41:53 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5313891521701026991==" --===============5313891521701026991== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 --- Comment #1 from Nicole C. Engard --- Created attachment 9275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9275&action=edit with parameters permission -- You are receiving this mail because: You are watching all bug changes. --===============5313891521701026991==-- From bugzilla-daemon@bugs.koha-community.org Tue Jan 6 15:24:39 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7996] Patron Modification Log Requires Parameters Permission Date: Tue, 06 Jan 2015 14:24:35 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5112724104539542219==" --===============5112724104539542219== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7996 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer --- Maybe this would be a good one to clean up for the academy too. As far I can see there are 4 files linking to the modification logs: koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc =20 33 [% IF ( CAN_user_tools_view_system_logs ) %][% IF ( logview ) %]
  • [% ELSE %]
  • [% END %]Modification log
    • [% END %] koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc =20 77 [% IF ( logview ) %]
  • [% ELSE %]
  • [% END %]Modification log
    • koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.tt =20 77 [% IF ( CAN_user_parameters ) %][% IF ( logview ) %]
  • [% ELSE %]
  • [% END %]Modification log
    • [% END %] koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc =20 13 [% IF ( logview ) %]
  • [% ELSE %]
  • [% END %]Modification log
    • Only the first seems to be using the correct permission check. --=20 You are receiving this mail because: You are watching all bug changes. --===============5112724104539542219==-- From bugzilla-daemon@bugs.koha-community.org Tue Jan 6 19:59:42 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7996] Patron Modification Log Requires Parameters Permission Date: Tue, 06 Jan 2015 18:59:37 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7770458480640106052==" --===============7770458480640106052== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. --===============7770458480640106052==-- From bugzilla-daemon@bugs.koha-community.org Tue Jan 6 20:09:19 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7996] Patron Modification Log Requires Parameters Permission Date: Tue, 06 Jan 2015 19:09:17 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8815306349620116159==" --===============8815306349620116159== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. --===============8815306349620116159==-- From bugzilla-daemon@bugs.koha-community.org Wed Jan 14 23:06:23 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7996] Patron Modification Log Requires Parameters Permission Date: Wed, 14 Jan 2015 22:06:20 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7811615652716710057==" --===============7811615652716710057== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 --- Comment #3 from Rochelle Healy --- Created attachment 35262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35262&action=edit Bug 7996: Patron Modification Log Requires Parameters Permission To test 1- Open 'set permissions' on patron page and uncheck '(parameters) Set koha system parameters' 2- Open patron page and notice that there is no 'modification log' tab 3- Apply patch 4- Refresh page and notice 'modification log' tab is there -- You are receiving this mail because: You are watching all bug changes. --===============7811615652716710057==-- From bugzilla-daemon@bugs.koha-community.org Wed Jan 14 23:06:51 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7996] Patron Modification Log Requires Parameters Permission Date: Wed, 14 Jan 2015 22:06:49 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6784744779313325292==" --===============6784744779313325292== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Rochelle Healy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |rochellehealy.student@wegc. | |school.nz -- You are receiving this mail because: You are watching all bug changes. --===============6784744779313325292==-- From bugzilla-daemon@bugs.koha-community.org Mon Jan 19 07:56:32 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7996] Patron Modification Log Requires Parameters Permission Date: Mon, 19 Jan 2015 06:56:31 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3071843086818094676==" --===============3071843086818094676== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7996 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer --- Hi Rochelle, the way it works after your patch, it will need both the permission 'parameters' and 'view_system_logs'. I think what we need to do here is take a look at all the conditions [IF ...] that apply to show the link and check whi= ch are really needed / make sense.=20 My feeling is that it would make sense to use 'view_system_logs' everywhere, = as this is the more specific permission. What do others think? --=20 You are receiving this mail because: You are watching all bug changes. --===============3071843086818094676==-- From bugzilla-daemon@bugs.koha-community.org Fri Jan 22 14:01:45 2016 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7996] Patron Modification Log Requires Parameters Permission Date: Fri, 22 Jan 2016 13:01:40 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1122907161458433372==" --===============1122907161458433372== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. --===============1122907161458433372==--