From bugzilla-daemon@bugs.koha-community.org Fri Aug 30 19:16:08 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 23526] New: Shibboleth login url with query has double encoded '?' %3F Date: Fri, 30 Aug 2019 17:16:06 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4030709366250531147==" --===============4030709366250531147== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D23526 Bug ID: 23526 Summary: Shibboleth login url with query has double encoded '?' %3F Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org In login_shib_url we place an encoded '?' into the login url: 65 if ( $query->query_string() ) { 66 $param =3D $param . '%3F' . $query->query_string(); 67 } Then in the templates we filter that using the URL filter:

If you have a Shibboleth account, please click here to login.

The URL filter turns the % into %25 and the string comes out as https://anykoha.bywatersolutions.com/Shibboleth.sso/Login?target=3Dhttps://an= ykoha.bywatersolutions.com/cgi-bin/koha/opac-search.pl%253Fq=3Dcats This returns a 4040 on successful login --=20 You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============4030709366250531147==-- From bugzilla-daemon@bugs.koha-community.org Tue Sep 10 18:46:39 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 23526] Shibboleth login url with query has double encoded '?' %3F Date: Tue, 10 Sep 2019 16:46:38 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3397055789316047604==" --===============3397055789316047604== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============3397055789316047604==-- From bugzilla-daemon@bugs.koha-community.org Tue Sep 10 18:46:49 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 23526] Shibboleth login url with query has double encoded '?' %3F Date: Tue, 10 Sep 2019 16:46:41 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6644854309172587072==" --===============6644854309172587072== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 --- Comment #1 from Nick Clemens --- Created attachment 92699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92699&action=edit Bug 23526: Don't use encoded question mark in shib_login_url To test: 1 - Enable shib 2 - Do a search 3 - Try to login from search 4 - Get an error 5 - Apply patch 6 - Retry Note: You don't haveto really enable shib, you can simply enable it in koha-conf.xml and check the URLs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============6644854309172587072==-- From bugzilla-daemon@bugs.koha-community.org Wed Sep 18 15:23:51 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 23526] Shibboleth login url with query has double encoded '?' %3F Date: Wed, 18 Sep 2019 13:23:50 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9051381230931681570==" --===============9051381230931681570== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92699|0 |1 is obsolete| | --- Comment #2 from Matthias Meusburger --- Created attachment 92939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92939&action=edit Bug 23526: Don't use encoded question mark in shib_login_url To test: 1 - Enable shib 2 - Do a search 3 - Try to login from search 4 - Get an error 5 - Apply patch 6 - Retry Note: You don't haveto really enable shib, you can simply enable it in koha-conf.xml and check the URLs Signed-off-by: Matthias Meusburger -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============9051381230931681570==-- From bugzilla-daemon@bugs.koha-community.org Wed Sep 18 15:24:32 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 23526] Shibboleth login url with query has double encoded '?' %3F Date: Wed, 18 Sep 2019 13:24:31 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7176021039408299789==" --===============7176021039408299789== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger@biblibr | |e.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============7176021039408299789==-- From bugzilla-daemon@bugs.koha-community.org Sun Sep 22 12:29:00 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 23526] Shibboleth login url with query has double encoded '?' %3F Date: Sun, 22 Sep 2019 10:28:59 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8197780738294186286==" --===============8197780738294186286== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer --- I am moving this PQA as the change is tiny and I trust Nick and Matthias. Also our RM is a Shibboleth pro. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============8197780738294186286==-- From bugzilla-daemon@bugs.koha-community.org Mon Sep 23 11:44:42 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 23526] Shibboleth login url with query has double encoded '?' %3F Date: Mon, 23 Sep 2019 09:44:25 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5455680133189124825==" --===============5455680133189124825== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============5455680133189124825==-- From bugzilla-daemon@bugs.koha-community.org Mon Sep 23 11:44:52 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 23526] Shibboleth login url with query has double encoded '?' %3F Date: Mon, 23 Sep 2019 09:44:27 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0623655646334903059==" --===============0623655646334903059== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============0623655646334903059==-- From bugzilla-daemon@bugs.koha-community.org Tue Sep 24 08:59:52 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 23526] Shibboleth login url with query has double encoded '?' %3F Date: Tue, 24 Sep 2019 06:59:51 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0775944854484289527==" --===============0775944854484289527== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.04 released in| | --- Comment #5 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============0775944854484289527==-- From bugzilla-daemon@bugs.koha-community.org Tue Sep 24 09:45:45 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 23526] Shibboleth login url with query has double encoded '?' %3F Date: Tue, 24 Sep 2019 07:45:44 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4689088935079483472==" --===============4689088935079483472== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 --- Comment #6 from Fridolin SOMERS --- Oh but UT needs to be fixed : Auth_with_shibboleth.t "login shib url" calls : is( login_shib_url($query), 'https://testopac.com' . '/Shibboleth.sso/Login?target=' . 'https://testopac.com/cgi-bin/koha/opac-user.pl' . '%3F' . $query_string, "login shib url" ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============4689088935079483472==-- From bugzilla-daemon@bugs.koha-community.org Tue Sep 24 10:00:18 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 23526] Shibboleth login url with query has double encoded '?' %3F Date: Tue, 24 Sep 2019 08:00:17 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3572385384895480439==" --===============3572385384895480439== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 --- Comment #7 from Fridolin SOMERS --- (In reply to Fridolin SOMERS from comment #6) > Oh but UT needs to be fixed : > > Auth_with_shibboleth.t "login shib url" calls : > > is( > login_shib_url($query), > 'https://testopac.com' > . '/Shibboleth.sso/Login?target=' > . 'https://testopac.com/cgi-bin/koha/opac-user.pl' . '%3F' > . $query_string, > "login shib url" > ); Corrected by : Bug 23526: (RM follow-up) Fix failing test Perfect 👌 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============3572385384895480439==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 17 21:36:02 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 23526] Shibboleth login url with query has double encoded '?' %3F Date: Thu, 17 Oct 2019 19:36:01 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7562153503192611272==" --===============7562153503192611272== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Lucas Gass --- backported to 18.11.x for 18.11.11 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============7562153503192611272==--