From bugzilla-daemon@bugs.koha-community.org Thu Mar 23 16:09:24 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33323] New: Select button in patron search modal is not translatable Date: Thu, 23 Mar 2023 15:09:23 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1972660152285291442==" --===============1972660152285291442== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Bug ID: 33323 Summary: Select button in patron search modal is not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr The modal is used in different places, one example is adding an owner/user to an acquisition fund. When you search for patrons to add, the select button in the last table column is not translatable: It's build with JS and we are missing the right mark-up. koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc: action_node += 'Select'; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============1972660152285291442==-- From bugzilla-daemon@bugs.koha-community.org Thu Mar 23 18:41:34 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable Date: Thu, 23 Mar 2023 17:41:33 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8412241928784718647==" --===============8412241928784718647== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Keywords|Academy | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============8412241928784718647==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 24 12:21:04 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable Date: Fri, 24 Mar 2023 11:21:03 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1610638426823218928==" --===============1610638426823218928== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============1610638426823218928==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 24 12:21:14 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable Date: Fri, 24 Mar 2023 11:21:05 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7272692200145195685==" --===============7272692200145195685== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 --- Comment #1 from Owen Leonard --- Created attachment 148655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148655&action=edit Bug 33323: Select button in patron search modal is not translatable This patch modifies the JS which generates some markup during some kinds of patron searches so that the strings labeling submit buttons can be translated. To test, apply the patch and go to Administration -> Funds. - Add a fund or edit an existing one. - Test the "Select owner" link - A popup should appear, and after performing a patron search which returns results you should see a "Select" column in the last column of the patron search results table. - Test the "Add users" link - Perform the same test as above. The button in the last column should be "Add" - The template accommodates two other cases, "Edit" and "Check out" but I was unable to find a place where they were used. - To test translatability, run the translation tool for any language, e.g. perl misc/translator/translate update fr-FR Search the regenerated po file (in this example misc/translator/po/fr-FR-staff-prog.po) to confirm that the correct strings are there: "Select", "Add", "Edit, and "Check out" should each have entries for line 234, e.g. koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:234 c-format msgid "Select" msgstr "Sélectionner" -- You are receiving this mail because: You are watching all bug changes. --===============7272692200145195685==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 24 12:55:14 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable Date: Fri, 24 Mar 2023 11:55:13 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1378797179266259474==" --===============1378797179266259474== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148655|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 148656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148656&action=edit Bug 33323: Select button in patron search modal is not translatable This patch modifies the JS which generates some markup during some kinds of patron searches so that the strings labeling submit buttons can be translated. To test, apply the patch and go to Administration -> Funds. - Add a fund or edit an existing one. - Test the "Select owner" link - A popup should appear, and after performing a patron search which returns results you should see a "Select" column in the last column of the patron search results table. - Test the "Add users" link - Perform the same test as above. The button in the last column should be "Add" - The template accommodates two other cases, "Edit" and "Check out" but I was unable to find a place where they were used. - To test translatability, run the translation tool for any language, e.g. perl misc/translator/translate update fr-FR Search the regenerated po file (in this example misc/translator/po/fr-FR-staff-prog.po) to confirm that the correct strings are there: "Select", "Add", "Edit, and "Check out" should each have entries for line 234, e.g. koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:234 c-format msgid "Select" msgstr "Sélectionner" -- You are receiving this mail because: You are watching all bug changes. --===============1378797179266259474==-- From bugzilla-daemon@bugs.koha-community.org Fri Apr 7 20:29:38 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable Date: Fri, 07 Apr 2023 18:29:37 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9075744516221176941==" --===============9075744516221176941== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============9075744516221176941==-- From bugzilla-daemon@bugs.koha-community.org Fri Apr 7 20:29:48 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable Date: Fri, 07 Apr 2023 18:29:40 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2805675511822022251==" --===============2805675511822022251== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148656|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 149287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149287&action=edit Bug 33323: Select button in patron search modal is not translatable This patch modifies the JS which generates some markup during some kinds of patron searches so that the strings labeling submit buttons can be translated. To test, apply the patch and go to Administration -> Funds. - Add a fund or edit an existing one. - Test the "Select owner" link - A popup should appear, and after performing a patron search which returns results you should see a "Select" column in the last column of the patron search results table. - Test the "Add users" link - Perform the same test as above. The button in the last column should be "Add" - The template accommodates two other cases, "Edit" and "Check out" but I was unable to find a place where they were used. - To test translatability, run the translation tool for any language, e.g. perl misc/translator/translate update fr-FR Search the regenerated po file (in this example misc/translator/po/fr-FR-staff-prog.po) to confirm that the correct strings are there: "Select", "Add", "Edit, and "Check out" should each have entries for line 234, e.g. koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:234 c-format msgid "Select" msgstr "Sélectionner" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. --===============2805675511822022251==-- From bugzilla-daemon@bugs.koha-community.org Sat Apr 8 23:29:38 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable Date: Sat, 08 Apr 2023 21:29:37 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5564954311354384571==" --===============5564954311354384571== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============5564954311354384571==-- From bugzilla-daemon@bugs.koha-community.org Sat Apr 8 23:29:48 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable Date: Sat, 08 Apr 2023 21:29:40 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6262775310195103047==" --===============6262775310195103047== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149287|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 149317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149317&action=edit Bug 33323: Select button in patron search modal is not translatable This patch modifies the JS which generates some markup during some kinds of patron searches so that the strings labeling submit buttons can be translated. To test, apply the patch and go to Administration -> Funds. - Add a fund or edit an existing one. - Test the "Select owner" link - A popup should appear, and after performing a patron search which returns results you should see a "Select" column in the last column of the patron search results table. - Test the "Add users" link - Perform the same test as above. The button in the last column should be "Add" - The template accommodates two other cases, "Edit" and "Check out" but I was unable to find a place where they were used. - To test translatability, run the translation tool for any language, e.g. perl misc/translator/translate update fr-FR Search the regenerated po file (in this example misc/translator/po/fr-FR-staff-prog.po) to confirm that the correct strings are there: "Select", "Add", "Edit, and "Check out" should each have entries for line 234, e.g. koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:234 c-format msgid "Select" msgstr "Sélectionner" Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. --===============6262775310195103047==-- From bugzilla-daemon@bugs.koha-community.org Sat Apr 8 23:29:58 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable Date: Sat, 08 Apr 2023 21:29:48 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2436352857198673315==" --===============2436352857198673315== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. --===============2436352857198673315==-- From bugzilla-daemon@bugs.koha-community.org Wed Apr 12 16:46:30 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable Date: Wed, 12 Apr 2023 14:44:33 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3395431047942046594==" --===============3395431047942046594== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. --===============3395431047942046594==-- From bugzilla-daemon@bugs.koha-community.org Wed Apr 12 16:46:41 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable Date: Wed, 12 Apr 2023 14:44:35 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6060275161388462377==" --===============6060275161388462377== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. --===============6060275161388462377==-- From bugzilla-daemon@bugs.koha-community.org Mon Apr 17 11:12:13 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable Date: Mon, 17 Apr 2023 09:11:20 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8912697205786403264==" --===============8912697205786403264== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. --===============8912697205786403264==-- From bugzilla-daemon@bugs.koha-community.org Mon Apr 17 11:12:23 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable Date: Mon, 17 Apr 2023 09:11:22 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8756242281876312840==" --===============8756242281876312840== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 --- Comment #6 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. --===============8756242281876312840==-- From bugzilla-daemon@bugs.koha-community.org Sat May 6 00:05:16 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable Date: Fri, 05 May 2023 22:05:15 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6256592457410654420==" --===============6256592457410654420== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.13. -- You are receiving this mail because: You are watching all bug changes. --===============6256592457410654420==-- From bugzilla-daemon@bugs.koha-community.org Tue May 23 11:54:42 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable Date: Tue, 23 May 2023 09:54:41 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8096001384601216389==" --===============8096001384601216389== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com --- Comment #8 from Arthur Suzuki --- doesn't to apply to 21.11. provide a backport if needed. -- You are receiving this mail because: You are watching all bug changes. --===============8096001384601216389==--