From bugzilla-daemon@bugs.koha-community.org Wed Feb 14 11:58:28 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20195] New: Untranslatable Show/Hide title attr replacement in opac detail Date: Wed, 14 Feb 2018 10:58:24 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6585825222790042621==" --===============6585825222790042621== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20195 Bug ID: 20195 Summary: Untranslatable Show/Hide title attr replacement in opac detail Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@joensuu.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr opac-detail.tt contains this: var newtitle = $(this).attr('title').replace('Show', 'Hide') $(this).attr('title',newtitle); This tries to replace "Show" in the title attribute of this element: Browse results Which will of course fail on other languages. (There's also the matching code to replace "Hide" with "Show") -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============6585825222790042621==-- From bugzilla-daemon@bugs.koha-community.org Wed Feb 14 11:59:50 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20195] Untranslatable Show/Hide title attr replacement in opac detail Date: Wed, 14 Feb 2018 10:59:46 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7353516640192562892==" --===============7353516640192562892== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20195 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pasi.kallinen@joensuu.fi |ity.org | Status|NEW |Needs Signoff --- Comment #1 from paxed --- Created attachment 71606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71606&action=edit [PATCH] Bug 20195: Untranslatable Show/Hide title attr replacement There's javascript code in opac detail view that tries to replace the word "Show" with "Hide" (and vice versa) in a title attribute. In addition to those words being untranslatable, a word replacement like that would not work properly when using other languages. Replace the single title attribute with two translatable strings, one for the "Show" case and one "Hide", and use the whole string instead of trying to replace a single word. Test plan: 1) Make sure OpacBrowseResults is on 2) in OPAC, search the catalog and go to the detail view 3) Hover the mouse over the "Browse results" text in the grey box on the right side. The popup text should show something like "Show pagination list (1-5 / 5)" 4) Click on the "Browse results" 5) Hover the mouse again over the text. The popup should show "Hide pagination list (1-5 / 5)" 6) Update a language xx-YY, translate the new msgids "Show pagination list (%s-%s / %s)" and "Hide pagination list (%s-%s / %s)", and install the language 7) Repeat 2-5 with that language, making sure the popup texts show up correctly in that language -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============7353516640192562892==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 27 15:49:38 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20195] Untranslatable Show/Hide title attr replacement in opac detail Date: Tue, 27 Feb 2018 14:49:08 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8856910068555580520==" --===============8856910068555580520== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20195 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart = --- It will not work for JS turned off, maybe we should use a generic title by default? --=20 You are receiving this mail because: You are watching all bug changes. --===============8856910068555580520==-- From bugzilla-daemon@bugs.koha-community.org Mon Mar 12 10:16:36 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20195] Untranslatable Show/Hide title attr replacement in opac detail Date: Mon, 12 Mar 2018 09:16:33 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4345291041242477225==" --===============4345291041242477225== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20195 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============4345291041242477225==-- From bugzilla-daemon@bugs.koha-community.org Mon Mar 12 10:16:39 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20195] Untranslatable Show/Hide title attr replacement in opac detail Date: Mon, 12 Mar 2018 09:16:36 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2981752692477168236==" --===============2981752692477168236== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20195 --- Comment #3 from Brendan Gallagher --- Created attachment 72627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72627&action=edit Bug 20195: Untranslatable Show/Hide title attr replacement in opac detail There's javascript code in opac detail view that tries to replace the word "Show" with "Hide" (and vice versa) in a title attribute. In addition to those words being untranslatable, a word replacement like that would not work properly when using other languages. Replace the single title attribute with two translatable strings, one for the "Show" case and one "Hide", and use the whole string instead of trying to replace a single word. Test plan: 1) Make sure OpacBrowseResults is on 2) in OPAC, search the catalog and go to the detail view 3) Hover the mouse over the "Browse results" text in the grey box on the right side. The popup text should show something like "Show pagination list (1-5 / 5)" 4) Click on the "Browse results" 5) Hover the mouse again over the text. The popup should show "Hide pagination list (1-5 / 5)" 6) Update a language xx-YY, translate the new msgids "Show pagination list (%s-%s / %s)" and "Hide pagination list (%s-%s / %s)", and install the language 7) Repeat 2-5 with that language, making sure the popup texts show up correctly in that language Signed-off-by: Pasi Kallinen Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. --===============2981752692477168236==-- From bugzilla-daemon@bugs.koha-community.org Mon Mar 12 10:17:01 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20195] Untranslatable Show/Hide title attr replacement in opac detail Date: Mon, 12 Mar 2018 09:16:59 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5854856572786952936==" --===============5854856572786952936== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20195 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Attachment #71606|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. --===============5854856572786952936==-- From bugzilla-daemon@bugs.koha-community.org Mon Mar 12 10:18:15 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20195] Untranslatable Show/Hide title attr replacement in opac detail Date: Mon, 12 Mar 2018 09:18:12 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3193799339510022903==" --===============3193799339510022903== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20195 --- Comment #4 from Brendan Gallagher --- Just seeing Jonathan's comment - should be a consideration for QA team. Perhaps a generic title would work. (this patch works though) (In reply to Brendan Gallagher from comment #3) > Created attachment 72627 [details] [review] > Bug 20195: Untranslatable Show/Hide title attr replacement in opac detail > > There's javascript code in opac detail view that tries to replace > the word "Show" with "Hide" (and vice versa) in a title attribute. > In addition to those words being untranslatable, a word replacement > like that would not work properly when using other languages. > > Replace the single title attribute with two translatable strings, > one for the "Show" case and one "Hide", and use the whole > string instead of trying to replace a single word. > > Test plan: > > 1) Make sure OpacBrowseResults is on > 2) in OPAC, search the catalog and go to the detail view > 3) Hover the mouse over the "Browse results" text in the grey box on the > right side. The popup text should show something like > "Show pagination list (1-5 / 5)" > 4) Click on the "Browse results" > 5) Hover the mouse again over the text. The popup should show > "Hide pagination list (1-5 / 5)" > 6) Update a language xx-YY, translate the new msgids > "Show pagination list (%s-%s / %s)" and > "Hide pagination list (%s-%s / %s)", and install the language > 7) Repeat 2-5 with that language, making sure the popup > texts show up correctly in that language > > Signed-off-by: Pasi Kallinen > > Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. --===============3193799339510022903==-- From bugzilla-daemon@bugs.koha-community.org Mon Mar 12 16:24:40 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20195] Untranslatable Show/Hide title attr replacement in opac detail Date: Mon, 12 Mar 2018 15:24:36 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2136814610247758507==" --===============2136814610247758507== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20195 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer --- (In reply to Jonathan Druart from comment #2) > It will not work for JS turned off, maybe we should use a generic title by > default? I just tested - Browse results doesn't work without Javascript, so I think we should move forward with the fix and worry about how to improve that bit later :) -- You are receiving this mail because: You are watching all bug changes. --===============2136814610247758507==-- From bugzilla-daemon@bugs.koha-community.org Mon Mar 12 16:27:32 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20195] Untranslatable Show/Hide title attr replacement in opac detail Date: Mon, 12 Mar 2018 15:27:29 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1897904308008759795==" --===============1897904308008759795== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20195 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============1897904308008759795==-- From bugzilla-daemon@bugs.koha-community.org Mon Mar 12 16:27:39 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20195] Untranslatable Show/Hide title attr replacement in opac detail Date: Mon, 12 Mar 2018 15:27:33 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3765570649939353163==" --===============3765570649939353163== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20195 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72627|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 72707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72707&action=edit Bug 20195: Untranslatable Show/Hide title attr replacement in opac detail There's javascript code in opac detail view that tries to replace the word "Show" with "Hide" (and vice versa) in a title attribute. In addition to those words being untranslatable, a word replacement like that would not work properly when using other languages. Replace the single title attribute with two translatable strings, one for the "Show" case and one "Hide", and use the whole string instead of trying to replace a single word. Test plan: 1) Make sure OpacBrowseResults is on 2) in OPAC, search the catalog and go to the detail view 3) Hover the mouse over the "Browse results" text in the grey box on the right side. The popup text should show something like "Show pagination list (1-5 / 5)" 4) Click on the "Browse results" 5) Hover the mouse again over the text. The popup should show "Hide pagination list (1-5 / 5)" 6) Update a language xx-YY, translate the new msgids "Show pagination list (%s-%s / %s)" and "Hide pagination list (%s-%s / %s)", and install the language 7) Repeat 2-5 with that language, making sure the popup texts show up correctly in that language Signed-off-by: Pasi Kallinen Signed-off-by: Brendan Gallagher Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. --===============3765570649939353163==-- From bugzilla-daemon@bugs.koha-community.org Mon Mar 19 19:31:20 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20195] Untranslatable Show/Hide title attr replacement in opac detail Date: Mon, 19 Mar 2018 18:31:11 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0898978292280119328==" --===============0898978292280119328== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20195 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart = --- Pushed to master for 18.05, thanks to everybody involved! --=20 You are receiving this mail because: You are watching all bug changes. --===============0898978292280119328==--