From bugzilla-daemon@bugs.koha-community.org Wed Feb 23 15:15:15 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] New: XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Wed, 23 Feb 2022 14:15:14 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6909715764068202424==" --===============6909715764068202424== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D30162 Bug ID: 30162 Summary: XSLT has broken link for traced series because of OPAC/staff interface confusion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org In the Utils file for the OPAC XSLT is a hardcoded link for the staff interface, which means the link is broken in OPAC and generates an ugly error when clicked: https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha-tmp= l/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl#L473 a_t It should use the searchurl variable used in other spots of the same template. Also it doesn't work for me with the {} - I believe they might only work with Elasticsearch or ICU? Removing them makes the link behave correctly. The record for testing should have these fields and USeControlNumber needs to be set to use: 490 _1=20 _aKirche, Wirtschaft, Gesellschaft _v1=20 830 _0 =20 _aKirche, Wirtschaft, Gesellschaft _v1 _w(DE-627)577593544 --=20 You are receiving this mail because: You are watching all bug changes. --===============6909715764068202424==-- From bugzilla-daemon@bugs.koha-community.org Wed Feb 23 15:18:35 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Wed, 23 Feb 2022 14:18:34 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4019108129445220662==" --===============4019108129445220662== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D30162 --- Comment #1 from Katrin Fischer --- Locally fixed as: - + ?q=3Drcn: --=20 You are receiving this mail because: You are watching all bug changes. --===============4019108129445220662==-- From bugzilla-daemon@bugs.koha-community.org Fri Sep 9 08:16:24 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Fri, 09 Sep 2022 06:16:23 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3247433701332761946==" --===============3247433701332761946== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 Mark Hofstetter changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@trust-box.at --- Comment #2 from Mark Hofstetter --- We always have problems with the rcn search Please try on koha testing docker: 1. set UseControlNumber to "Use" 2. for the BKS Framework make 830 $0 $w $t $v editable 3. choose two records: A (eg Perl best practices / Damian Conway. (Record number 5)) as child B Programming Perl / Tom Christiansen, Brian D. Foy & Larry Wall. (Record number 262) as parent record 4. edit the child record, - set 490 indicator 1 to 1 - set 830$w (and maybe 830$0 to control-number of the parent in my case 17259930) - set 830$t = "perl series title" and 830$v = "Volume 1" 5. apply the patch as suggested by Katrin Fischer 2022-02-23 14:18:34 UTC 6. go to the child record, the "Series" link will be something like opac-search.pl?q=rcn:17259930 7. if you click the link it leads to the child record itself and not to the parent record 8. I would suggest the following patch point to the control-number diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl index b734afd754..20d2c0ae83 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl +++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl @@ -470,7 +470,7 @@ - + ?q=control-number: -- You are receiving this mail because: You are watching all bug changes. --===============3247433701332761946==-- From bugzilla-daemon@bugs.koha-community.org Fri Sep 9 08:21:02 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Fri, 09 Sep 2022 06:21:02 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2668533415460522837==" --===============2668533415460522837== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 --- Comment #3 from Mark Hofstetter --- Created attachment 140360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140360&action=edit the Series link koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl is not generated correctly to reproduce 1. set UseControlNumber to "Use" 2. for the BKS Framework make 830 $0 $w $t $v editable 3. choose two records: A (eg Perl best practices / Damian Conway. (Record number 5)) as child B Programming Perl / Tom Christiansen, Brian D. Foy & Larry Wall. (Record number 262) as parent record 4. edit the child record, - set 490 indicator 1 to 1 - set 830$w (and maybe 830$0 to control-number of the parent in my case 17259930) - set 830$t = "perl series title" and 830$v = "Volume 1" 5. apply the patch as suggested by Katrin Fischer 2022-02-23 14:18:34 UTC 6. go to the child record, the "Series" link will be something like opac-search.pl?q=rcn:17259930 7. if you click the link it leads to the child record itself and not to the parent record 8. I would suggest the following patch point to the control-number diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl index b734afd754..20d2c0ae83 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl +++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl @@ -470,7 +470,7 @@ - + ?q=control-number: -- You are receiving this mail because: You are watching all bug changes. --===============2668533415460522837==-- From bugzilla-daemon@bugs.koha-community.org Sun Sep 11 15:25:43 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Sun, 11 Sep 2022 13:25:43 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2996674027301354105==" --===============2996674027301354105== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D30162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #4 from Katrin Fischer --- Not sure if this was ready for testing yet, but: The proposed fix doesn't only fix the link, but it changes the functionality. :( When this feature was introduced, we decided on a horizontal search for traced series. Meaning that if you click on the link, you find the other volumes of the series. (using rcn search for $w) This patch changes it go a hierarchical link linking upwards to the traced serial record. (using control-number search for 001) I think if you really want to change this, it should be a system preference A= ND a separate bug. This here is only about fixing a broken link, so changing the behaviour is out of scope. Having separate bugs also helps with backporting. Please also have a look at: https://wiki.koha-community.org/wiki/Commit_messages We need the bug number first in the commit message, so the tools work right: Bug XXXX: .... Commit message also needs to have a problem description and the test plan. Bug status and Assignee should also be changed. Hmm - maybe this was still wo= rk in progress? I am feeling a little guilty for filing and forgetting about this one - so if you don't have the time now - I could try and provide the link fix myself. --=20 You are receiving this mail because: You are watching all bug changes. --===============2996674027301354105==-- From bugzilla-daemon@bugs.koha-community.org Sun Sep 11 15:25:57 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Sun, 11 Sep 2022 13:25:56 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0079804387256741336==" --===============0079804387256741336== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============0079804387256741336==-- From bugzilla-daemon@bugs.koha-community.org Sun Sep 11 15:26:07 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Sun, 11 Sep 2022 13:26:04 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9002466240285338047==" --===============9002466240285338047== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. --===============9002466240285338047==-- From bugzilla-daemon@bugs.koha-community.org Sun Sep 11 16:07:38 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Sun, 11 Sep 2022 14:07:37 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0312392219675155874==" --===============0312392219675155874== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 Mark Hofstetter changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |koha@trust-box.at -- You are receiving this mail because: You are watching all bug changes. --===============0312392219675155874==-- From bugzilla-daemon@bugs.koha-community.org Sun Sep 11 16:25:17 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Sun, 11 Sep 2022 14:25:16 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4666557825078325784==" --===============4666557825078325784== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 --- Comment #5 from Mark Hofstetter --- Created attachment 140403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140403&action=edit Bug 30162 - XSLT has broken link for traced series because of OPAC/staff interface confusion the link to for series defined in 830$w in OPAC is generated incorrectly this patch creates the link properly to test: 1. set UseControlNumber to "Use" 2. for the BKS Framework make 830 $0 $w $t $v editable 3. choose two records: A (eg Perl best practices / Damian Conway. (Record number 5)) as child B Programming Perl / Tom Christiansen, Brian D. Foy & Larry Wall. (Record number 262) as parent record 4. edit the child record, - set 490 indicator 1 to 1 - set 830$w (and maybe 830$0 to control-number of the parent in my case 17259930) - set 830$t = "perl series title" and 830$v = "Volume 1" 5. before the pathc you'll get a 404 error because of the wrong 6. apply patch 7. the link should now work, and point to the series, (not to the parent record) -- You are receiving this mail because: You are watching all bug changes. --===============4666557825078325784==-- From bugzilla-daemon@bugs.koha-community.org Sun Sep 11 16:25:46 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Sun, 11 Sep 2022 14:25:46 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9182719109189166801==" --===============9182719109189166801== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 Mark Hofstetter changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============9182719109189166801==-- From bugzilla-daemon@bugs.koha-community.org Sun Sep 11 16:27:48 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Sun, 11 Sep 2022 14:27:48 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2739437572289552195==" --===============2739437572289552195== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 --- Comment #6 from Mark Hofstetter --- ok now that I understand the intention it makes sense for me, made "just" a bugfix -- You are receiving this mail because: You are watching all bug changes. --===============2739437572289552195==-- From bugzilla-daemon@bugs.koha-community.org Mon Sep 26 18:35:44 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Mon, 26 Sep 2022 16:35:43 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8824656517440164251==" --===============8824656517440164251== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Attachment #140360|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo --- Comment on attachment 140360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140360 the Series link koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl is not generated correctly I'm assuming this attachement: https://bugs.koha-community.org/bugzilla3/buglist.cgi?quicksearch=30162 isn't valid anymore and is just a previous version of the current patch. -- You are receiving this mail because: You are watching all bug changes. --===============8824656517440164251==-- From bugzilla-daemon@bugs.koha-community.org Mon Sep 26 19:03:16 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Mon, 26 Sep 2022 17:03:15 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7682748261437858901==" --===============7682748261437858901== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D30162 Anke changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anke.bruns@gwdg.de --- Comment #8 from Anke --- We tried to test this patch but couldn't reproduce the 404 error, and we couldn't even link the two records either by proceding as mentioned. 490 was empty so we couldn't set the indicator to 1 in the first place. Then, the entries in 830$0, $t, $v and $w didn't seem to have any effect (we made sure to set UseControlNumber to "Use"). Even when we put some content into 490 so we were able to set the indicator to 1, it didn't have any effect visible = to us. Can you detail the steps to take in order to get linked records (and/or to reproduce the error)? Which is the name of the link that is broken (that leads to 404)? --=20 You are receiving this mail because: You are watching all bug changes. --===============7682748261437858901==-- From bugzilla-daemon@bugs.koha-community.org Mon Sep 26 19:10:27 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Mon, 26 Sep 2022 17:10:26 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8274311099115147135==" --===============8274311099115147135== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D30162 --- Comment #9 from Anke --- False alert :-) All I said above applies to the Staff client but we can reproduce the error in the OPAC! However, we tried the patch, but it couldn't be applied in the sandbox: error: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl). error: could not build fake ancestor Patch failed at 0001 Bug 30162 - XSLT has broken link for traced series becau= se of OPAC/staff interface confusion --=20 You are receiving this mail because: You are watching all bug changes. --===============8274311099115147135==-- From bugzilla-daemon@bugs.koha-community.org Mon Sep 26 19:12:42 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Mon, 26 Sep 2022 17:12:41 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8345494049123273467==" --===============8345494049123273467== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 Anke changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. --===============8345494049123273467==-- From bugzilla-daemon@bugs.koha-community.org Sun Nov 20 14:49:57 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Sun, 20 Nov 2022 13:49:56 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5643836000679856474==" --===============5643836000679856474== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D30162 --- Comment #10 from Katrin Fischer --- Patch doesn't apply in a mean way, wondering if this was maybe written for an older version/not on master branch? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 30162 - XSLT has broken link for traced series because of OPAC/staff interface confusion error: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl). error: could not build fake ancestor Patch failed at 0001 Bug 30162 - XSLT has broken link for traced series becau= se of OPAC/staff interface confusion hint: Use 'git am --show-current-patch=3Ddiff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-30162---XSLT-has-broken-link-for-traced-series-_pb72j.patch --=20 You are receiving this mail because: You are watching all bug changes. --===============5643836000679856474==-- From bugzilla-daemon@bugs.koha-community.org Sun Nov 20 15:03:25 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Sun, 20 Nov 2022 14:03:25 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0338049815977075023==" --===============0338049815977075023== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D30162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|Patch doesn't apply |RESOLVED --- Comment #11 from Katrin Fischer --- I tried rewriting this patch for master, but there is no longer any mention of the control-number index in the Utils file on master: More so, to me it looks like it has always been rcn and not control-numer - could this have been a local change? Scratching my head looking at the git histories here: https://git.koha-community.org/Koha-community/Koha/commit/c4e04e2cbaff0a9af12= 4dc5a28ddbdc7058405d0 --=20 You are receiving this mail because: You are watching all bug changes. --===============0338049815977075023==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 14 10:33:27 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Tue, 14 Feb 2023 09:33:27 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3017984634645448828==" --===============3017984634645448828== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Assignee|koha@trust-box.at |katrin.fischer@bsz-bw.de Resolution|WORKSFORME |--- -- You are receiving this mail because: You are watching all bug changes. --===============3017984634645448828==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 14 10:58:28 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Tue, 14 Feb 2023 09:58:27 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1377140427317278700==" --===============1377140427317278700== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. --===============1377140427317278700==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 14 10:58:38 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Tue, 14 Feb 2023 09:58:29 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0669823214423517408==" --===============0669823214423517408== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 --- Comment #12 from Katrin Fischer --- Created attachment 146610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146610&action=edit Bug 30162: Fix staff interface link in OPAC XSLT files for 830$w All the links in the Utils files shoudl be built using the $searchurl variable to adapt the link to either staff or OPAC. To test: * Enable UseControlNumber system preference * Create a record with the following fields: 490 1 _ ‡aEffective software development series 830 _ 0 ‡aEffective software development series.‡w13736978 $w can be anything for this use case or another $w from your catalog. Easiest might be to enable the Advanced cataloguing editor to be able to insert these lines easily. If you are using the sample data, the example shoudl work as is. * Save the record and open it in the staff interface and the OPAC * The link in the OPAC should be broken, staff should work * Apply patch * Now both links should work Co-authored-by: Anke Bruns -- You are receiving this mail because: You are watching all bug changes. --===============0669823214423517408==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 14 19:06:44 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Tue, 14 Feb 2023 18:06:43 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5119339595841000843==" --===============5119339595841000843== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 Anke Bruns changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Anke Bruns --- Tried to test the patch today but found some unexpected behavior in the sandbox: - Link in OPAC was broken as expected, but... - Link in Staff interface didn't lead to other titles in the same series but instead to the detail view of the very record in which the link was clicked. This was true as well for my catalogued test record as for the record already in the sandbox which belonged to the same series "Effective software development series". - I tried to apply the patch anyway but received an error message: "fatal: detected dubious ownership in repository at '/kohadevbox/koha' To add an exception for this directory, call: git config --global --add safe.directory /kohadevbox/koha Traceback (most recent call last): File "/usr/bin/git-bz", line 2716, in applied = do_apply(bug_ref) File "/usr/bin/git-bz", line 1688, in do_apply git_dir = git.rev_parse(git_dir=True) File "/usr/bin/git-bz", line 192, in f return git_run(command, *args, **kwargs) File "/usr/bin/git-bz", line 174, in git_run raise CalledProcessError(process.returncode, " ".join(to_run)) subprocess.CalledProcessError: Command 'git rev-parse --git-dir' returned non-zero exit status 128" -- You are receiving this mail because: You are watching all bug changes. --===============5119339595841000843==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 14 19:10:05 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Tue, 14 Feb 2023 18:10:04 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2334770644196528616==" --===============2334770644196528616== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Status|Failed QA |Needs Signoff --- Comment #14 from Katrin Fischer --- Hi Anke, the patch $w link here works as expected - it finds other records (including itself) with the same $w link. As we faked the example, it doesn't make a lot of sense. The error you see is due to the sandbox issue :( Adding Joubu. -- You are receiving this mail because: You are watching all bug changes. --===============2334770644196528616==-- From bugzilla-daemon@bugs.koha-community.org Wed Feb 15 07:52:28 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Wed, 15 Feb 2023 06:52:27 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2350005111063554241==" --===============2350005111063554241== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 --- Comment #15 from Jonathan Druart --- Can you retry today on biblibre's sandboxes please? https://sandboxes.biblibre.eu/ There was an error that should be fixed now. -- You are receiving this mail because: You are watching all bug changes. --===============2350005111063554241==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 17 10:30:09 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Fri, 17 Feb 2023 09:30:08 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8642552359242809763==" --===============8642552359242809763== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D30162 --- Comment #16 from Katrin Fischer --- I believe this should test ok now with the hopefully fixed sandboxes. Maybe t= ry the Biblibre ones first since we had some issues yesterday on the others. --=20 You are receiving this mail because: You are watching all bug changes. --===============8642552359242809763==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 24 12:00:03 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Fri, 24 Feb 2023 11:00:02 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1353504584239170139==" --===============1353504584239170139== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 Anke Bruns changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #17 from Anke Bruns --- Sandbox needs some more fixing. -- You are receiving this mail because: You are watching all bug changes. --===============1353504584239170139==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 24 14:29:42 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Fri, 24 Feb 2023 13:29:41 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6326590596882018971==" --===============6326590596882018971== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140403|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. --===============6326590596882018971==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 24 14:29:53 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Fri, 24 Feb 2023 13:29:52 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4960749491940835294==" --===============4960749491940835294== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146610|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 147329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147329&action=edit Bug 30162: Fix staff interface link in OPAC XSLT files for 830$w All the links in the Utils files shoudl be built using the $searchurl variable to adapt the link to either staff or OPAC. To test: * Enable UseControlNumber system preference * Create a record with the following fields: 490 1 _ ‡aEffective software development series 830 _ 0 ‡aEffective software development series.‡w13736978 $w can be anything for this use case or another $w from your catalog. Easiest might be to enable the Advanced cataloguing editor to be able to insert these lines easily. If you are using the sample data, the example shoudl work as is. * Save the record and open it in the staff interface and the OPAC * The link in the OPAC should be broken, staff should work * Apply patch * Now both links should work Co-authored-by: Anke Bruns -- You are receiving this mail because: You are watching all bug changes. --===============4960749491940835294==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 24 14:30:57 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Fri, 24 Feb 2023 13:30:45 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3911560408933070810==" --===============3911560408933070810== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D30162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #19 from Katrin Fischer --- Sorry, I forgot to obsolete Mark's patch and mine did not apply on top of thi= s. It should be ok now and I just rebased the patch on master too. --=20 You are receiving this mail because: You are watching all bug changes. --===============3911560408933070810==-- From bugzilla-daemon@bugs.koha-community.org Sun Mar 12 18:51:28 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Sun, 12 Mar 2023 17:51:27 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6421396985463550753==" --===============6421396985463550753== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============6421396985463550753==-- From bugzilla-daemon@bugs.koha-community.org Sun Mar 12 18:51:38 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Sun, 12 Mar 2023 17:51:31 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3004063869920355268==" --===============3004063869920355268== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147329|0 |1 is obsolete| | --- Comment #20 from David Nind --- Created attachment 148111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148111&action=edit Bug 30162: Fix staff interface link in OPAC XSLT files for 830$w All the links in the Utils files shoudl be built using the $searchurl variable to adapt the link to either staff or OPAC. To test: * Enable UseControlNumber system preference * Create a record with the following fields: 490 1 _ ‡aEffective software development series 830 _ 0 ‡aEffective software development series.‡w13736978 $w can be anything for this use case or another $w from your catalog. Easiest might be to enable the Advanced cataloguing editor to be able to insert these lines easily. If you are using the sample data, the example shoudl work as is. * Save the record and open it in the staff interface and the OPAC * The link in the OPAC should be broken, staff should work * Apply patch * Now both links should work Co-authored-by: Anke Bruns Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. --===============3004063869920355268==-- From bugzilla-daemon@bugs.koha-community.org Tue Mar 28 11:55:54 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Tue, 28 Mar 2023 09:55:53 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8160438320672696979==" --===============8160438320672696979== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============8160438320672696979==-- From bugzilla-daemon@bugs.koha-community.org Tue Mar 28 11:56:04 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Tue, 28 Mar 2023 09:55:56 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4945153027889434718==" --===============4945153027889434718== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148111|0 |1 is obsolete| | --- Comment #21 from Nick Clemens --- Created attachment 148809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148809&action=edit Bug 30162: Fix staff interface link in OPAC XSLT files for 830$w All the links in the Utils files shoudl be built using the $searchurl variable to adapt the link to either staff or OPAC. To test: * Enable UseControlNumber system preference * Create a record with the following fields: 490 1 _ ‡aEffective software development series 830 _ 0 ‡aEffective software development series.‡w13736978 $w can be anything for this use case or another $w from your catalog. Easiest might be to enable the Advanced cataloguing editor to be able to insert these lines easily. If you are using the sample data, the example shoudl work as is. * Save the record and open it in the staff interface and the OPAC * The link in the OPAC should be broken, staff should work * Apply patch * Now both links should work Co-authored-by: Anke Bruns Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. --===============4945153027889434718==-- From bugzilla-daemon@bugs.koha-community.org Thu Mar 30 12:14:43 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Thu, 30 Mar 2023 10:14:43 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2672349925834658796==" --===============2672349925834658796== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. --===============2672349925834658796==-- From bugzilla-daemon@bugs.koha-community.org Thu Mar 30 12:14:54 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Thu, 30 Mar 2023 10:14:47 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7528448508699909271==" --===============7528448508699909271== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 --- Comment #22 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. --===============7528448508699909271==-- From bugzilla-daemon@bugs.koha-community.org Tue Apr 11 13:12:15 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Tue, 11 Apr 2023 11:12:14 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5934673921611516990==" --===============5934673921611516990== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. --===============5934673921611516990==-- From bugzilla-daemon@bugs.koha-community.org Tue Apr 11 13:12:25 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion Date: Tue, 11 Apr 2023 11:12:16 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6462373075599621105==" --===============6462373075599621105== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 --- Comment #23 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. --===============6462373075599621105==--