From bugzilla-daemon@bugs.koha-community.org Wed Feb 19 23:58:42 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
Date: Wed, 19 Feb 2020 22:58:40 +0000
Message-ID: <bug-14715-70-Xv0Kq9ttmk@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5376740220055458896=="

--===============5376740220055458896==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D14715

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #96 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Hi Aleisha,=20

can you please take a look at David'd comment#95?

I also got a lot of fails with the QA tools for missing filters :(

 FAIL   koha-tmpl/intranet-tmpl/prog/en/includes/page-numbers.inc
   FAIL   filters
                missing_filter at line 4 (        <li><a class=3D"nav"
href=3D"/cgi-bin/koha/catalogue/search.pl?[% query_cgi | $raw %][% limit_cgi |
$raw %][% IF ( sort_by ) %]&amp;sort_by=3D[% sort_by |url %][% END %][% IF
results_per_page %]&amp;count=3D[% results_per_page %][% END %]"><i class=3D"=
fa
fa-fw fa-angle-double-left"></i> First</a></li>)
                missing_filter at line 6 (        <li><a class=3D"nav"
href=3D"/cgi-bin/koha/catalogue/search.pl?[% query_cgi | $raw %][% limit_cgi |
$raw %]&amp;offset=3D[% previous_page_offset | html %][% IF ( sort_by )
%]&amp;sort_by=3D[% sort_by |url %][% END %][% IF results_per_page
%]&amp;count=3D[% results_per_page %][% END %]"><i class=3D"fa fa-fw
fa-angle-left"></i> Previous</a></li>)
                missing_filter at line 12 (            <li><a class=3D"nav"
href=3D"/cgi-bin/koha/catalogue/search.pl?[% query_cgi | $raw %][% limit_cgi |
$raw %]&amp;offset=3D[% PAGE_NUMBER.offset | html %][% IF ( sort_by )
%]&amp;sort_by=3D[% sort_by |url %][% END %][% IF results_per_page
%]&amp;count=3D[% results_per_page %][% END %]">[% PAGE_NUMBER.pg | html
%]</a></li>)
                missing_filter at line 16 (        <li><a class=3D"nav"
href=3D"/cgi-bin/koha/catalogue/search.pl?[% query_cgi | $raw %][% limit_cgi |
$raw %]&amp;offset=3D[% next_page_offset | html %][% IF ( sort_by )
%]&amp;sort_by=3D[% sort_by |url %][% END %][% IF results_per_page
%]&amp;count=3D[% results_per_page %][% END %]">Next <i class=3D"fa fa-fw
fa-angle-right"></i></a></li>)
                missing_filter at line 17 (        <li><a class=3D"nav"
href=3D"/cgi-bin/koha/catalogue/search.pl?[% query_cgi | $raw %][% limit_cgi |
$raw %]&amp;offset=3D[% last_page_offset | html %][% IF ( sort_by )
%]&amp;sort_by=3D[% sort_by |url %][% END %][% IF results_per_page
%]&amp;count=3D[% results_per_page %][% END %]">Last <i class=3D"fa fa-fw
fa-angle-double-right"></i></a></li>)
   OK     forbidden patterns
   OK     git manipulation
   OK     js_in_body
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
   FAIL   filters
                missing_filter at line 274 (                                 =
 =20
    Results per page: [% results_per_page %] <span class=3D"caret"></span>)
                missing_filter at line 281 (                                 =
 =20
            [% END %] Library default: [% Koha.Preference('numSearchResults')
%])
   OK     forbidden patterns
   OK     git manipulation
   OK     js_in_body
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc
   FAIL   filters
                wrong_html_filter at line 6 (                <li
class=3D"page-first"><a href=3D"/cgi-bin/koha/opac-search.pl?[% query_cgi | $=
raw
%][% limit_cgi | $raw %][% IF ( sort_by ) %]&amp;sort_by=3D[% sort_by | uri %=
][%
END %][% IF results_per_page %]&amp;count=3D[% results_per_page %][% END %]">=
<i
class=3D"fa fa-fw fa-angle-double-left"></i>  First</a></li>)
                missing_filter at line 6 (                <li
class=3D"page-first"><a href=3D"/cgi-bin/koha/opac-search.pl?[% query_cgi | $=
raw
%][% limit_cgi | $raw %][% IF ( sort_by ) %]&amp;sort_by=3D[% sort_by | uri %=
][%
END %][% IF results_per_page %]&amp;count=3D[% results_per_page %][% END %]">=
<i
class=3D"fa fa-fw fa-angle-double-left"></i>  First</a></li>)
                wrong_html_filter at line 7 (                <li
class=3D"page-prev"><a href=3D"/cgi-bin/koha/opac-search.pl?[% query_cgi | $r=
aw
%][% limit_cgi | $raw %]&amp;offset=3D[% previous_page_offset | uri %][% IF (
sort_by ) %]&amp;sort_by=3D[% sort_by | uri %][% END %][% IF results_per_page
%]&amp;count=3D[% results_per_page %][% END %]"> <i class=3D"fa fa-fw
fa-angle-left"></i>  Previous</a></li>)
                missing_filter at line 7 (                <li
class=3D"page-prev"><a href=3D"/cgi-bin/koha/opac-search.pl?[% query_cgi | $r=
aw
%][% limit_cgi | $raw %]&amp;offset=3D[% previous_page_offset | uri %][% IF (
sort_by ) %]&amp;sort_by=3D[% sort_by | uri %][% END %][% IF results_per_page
%]&amp;count=3D[% results_per_page %][% END %]"> <i class=3D"fa fa-fw
fa-angle-left"></i>  Previous</a></li>)
                wrong_html_filter at line 13 (                    <li
class=3D"page-num"><a href=3D"/cgi-bin/koha/opac-search.pl?[% query_cgi | $ra=
w %][%
limit_cgi | $raw %]&amp;offset=3D[% PAGE_NUMBER.offset | uri %][% IF ( sort_b=
y )
%]&amp;sort_by=3D[% sort_by | uri %][% END %][% IF results_per_page
%]&amp;count=3D[% results_per_page %][% END %]">[% PAGE_NUMBER.pg | html
%]</a></li>)
                missing_filter at line 13 (                    <li
class=3D"page-num"><a href=3D"/cgi-bin/koha/opac-search.pl?[% query_cgi | $ra=
w %][%
limit_cgi | $raw %]&amp;offset=3D[% PAGE_NUMBER.offset | uri %][% IF ( sort_b=
y )
%]&amp;sort_by=3D[% sort_by | uri %][% END %][% IF results_per_page
%]&amp;count=3D[% results_per_page %][% END %]">[% PAGE_NUMBER.pg | html
%]</a></li>)
                wrong_html_filter at line 17 (                <li
class=3D"page-next"><a href=3D"/cgi-bin/koha/opac-search.pl?[% query_cgi | $r=
aw
%][% limit_cgi | $raw %]&amp;offset=3D[% next_page_offset | uri %][% IF ( sor=
t_by
) %]&amp;sort_by=3D[% sort_by | uri %][% END %][% IF results_per_page
%]&amp;count=3D[% results_per_page %][% END %]">Next <i class=3D"fa fa-fw
fa-angle-double-right"></i></a></li>)
                missing_filter at line 17 (                <li
class=3D"page-next"><a href=3D"/cgi-bin/koha/opac-search.pl?[% query_cgi | $r=
aw
%][% limit_cgi | $raw %]&amp;offset=3D[% next_page_offset | uri %][% IF ( sor=
t_by
) %]&amp;sort_by=3D[% sort_by | uri %][% END %][% IF results_per_page
%]&amp;count=3D[% results_per_page %][% END %]">Next <i class=3D"fa fa-fw
fa-angle-double-right"></i></a></li>)
                wrong_html_filter at line 18 (                <li
class=3D"page-last"><a href=3D"/cgi-bin/koha/opac-search.pl?[% query_cgi | $r=
aw
%][% limit_cgi | $raw %]&amp;offset=3D[% last_page_offset | uri %][% IF ( sor=
t_by
) %]&amp;sort_by=3D[% sort_by | uri %][% END %][% IF results_per_page
%]&amp;count=3D[% results_per_page %][% END %]">Last <i class=3D"fa fa-fw
fa-angle-double-right"></i></a></li>)
                missing_filter at line 18 (                <li
class=3D"page-last"><a href=3D"/cgi-bin/koha/opac-search.pl?[% query_cgi | $r=
aw
%][% limit_cgi | $raw %]&amp;offset=3D[% last_page_offset | uri %][% IF ( sor=
t_by
) %]&amp;sort_by=3D[% sort_by | uri %][% END %][% IF results_per_page
%]&amp;count=3D[% results_per_page %][% END %]">Last <i class=3D"fa fa-fw
fa-angle-double-right"></i></a></li>)
   OK     forbidden patterns
   OK     git manipulation
   OK     js_in_body
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
   FAIL   filters
                missing_filter at line 172 (                                 =
 =20
                            <option value=3D"[%
Koha.Preference('OPACnumSearchResults') %]" selected=3D"selected">Library
default: [% Koha.Preference('OPACnumSearchResults') %]</option>)
                missing_filter at line 172 (                                 =
 =20
                            <option value=3D"[%
Koha.Preference('OPACnumSearchResults') %]" selected=3D"selected">Library
default: [% Koha.Preference('OPACnumSearchResults') %]</option>)
                missing_filter at line 174 (                                 =
 =20
                            <option value=3D"[%
Koha.Preference('OPACnumSearchResults') %]">Library default: [%
Koha.Preference('OPACnumSearchResults') %]</option>)
                missing_filter at line 174 (                                 =
 =20
                            <option value=3D"[%
Koha.Preference('OPACnumSearchResults') %]">Library default: [%
Koha.Preference('OPACnumSearchResults') %]</option>)

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============5376740220055458896==--