From bugzilla-daemon@bugs.koha-community.org Wed Feb 14 08:46:10 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 36091] New: Spelling: Patron card number/cardnumber
Date: Wed, 14 Feb 2024 07:46:09 +0000
Message-ID:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1894763003740257749=="
--===============1894763003740257749==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D36091
Bug ID: 36091
Summary: Spelling: Patron card number/cardnumber
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: trivial
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs@lists.koha-community.org
Reporter: magnus@libriotech.no
QA Contact: testopia@bugs.koha-community.org
CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com
Not sure which spelling is correct, but consistency is good.=20
$ grep -rn "Patron cardnumber" *
koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/reports/cash_register_st=
ats.tt:4:
"[% t("Manager name") | html %]"[% sep | html %]"[% t("Patron
cardnumber") | html %]"[% sep | html %]"[% t("Patron name") | html %]"[% sep |
html %]"[% t("Transaction library") | html %]"[% sep | html %]"[%
t("Transaction date") | html %]"[% sep | html %]"[% t("Updated") | html %]"[%
sep | html %]"[% t("Transaction type") | html %]"[% sep |html %]"[% t("Notes")
| html %]"[% sep | html %]"[% t("Amount") | html %]"[% sep | html %]"[%
t("Title") | html %]"[% sep | html %]"[% t("Barcode") | html %]"[% sep | html
%]"[% t("Item type") | html %]"
grep:
misc/translator/po/.git/objects/pack/pack-b0a884343922aff65f857e780adda0f2bcc=
2203f.pack:
binary file matches
grep: misc/translator/po/.git/objects/pack/tmp_pack_O9fPOy: binary file match=
es
misc/release_notes/release_notes_20_05_00.html:1588:
[24=
329]
Patron cardnumber change times are lost during upgrade for bug 3820
misc/release_notes/release_notes_20_05_00.md:1194:-
[[24329]](http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D24329)
Patron cardnumber change times are lost during upgrade for bug 3820
$ grep -rn "Patron card number" *
koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt:172: =
=20
Patron card number |
--=20
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
--===============1894763003740257749==--
From bugzilla-daemon@bugs.koha-community.org Wed Feb 14 14:54:22 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 36091] Spelling: Patron card number/cardnumber
Date: Wed, 14 Feb 2024 13:54:21 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0662730480738642352=="
--===============0662730480738642352==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091
--- Comment #1 from Owen Leonard ---
I think we should add something like this to our Terminology page
(https://wiki.koha-community.org/wiki/Terminology):
'card number (noun)
When referring to a patron's library card, use "card number," not
"cardnumber." "cardnumber" should be used only when referring to the database
column.'
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
--===============0662730480738642352==--
From bugzilla-daemon@bugs.koha-community.org Wed Feb 14 15:14:23 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 36091] Spelling: Use "card number" instead of
cardnumber in text
Date: Wed, 14 Feb 2024 14:14:22 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1808263072799557254=="
--===============1808263072799557254==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Spelling: Patron card |Spelling: Use "card number"
|number/cardnumber |instead of cardnumber in
| |text
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
--===============1808263072799557254==--
From bugzilla-daemon@bugs.koha-community.org Wed Feb 14 15:33:32 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 36091] Spelling: Use "card number" instead of
cardnumber in text
Date: Wed, 14 Feb 2024 14:33:25 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5973324475006431322=="
--===============5973324475006431322==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |String patch
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
--===============5973324475006431322==--
From bugzilla-daemon@bugs.koha-community.org Wed Feb 14 15:33:43 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 36091] Spelling: Use "card number" instead of
cardnumber in text
Date: Wed, 14 Feb 2024 14:33:27 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4011193082561203428=="
--===============4011193082561203428==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091
--- Comment #2 from Owen Leonard ---
Created attachment 162148
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162148&action=edit
Bug 36091: Spelling: Use "card number" instead of cardnumber in text
This patch replaces the term "cardnumber" with "card number" in labels
and text where the patron's library card number is referred to. Where
the database column is referenced "cardnumber" is kept.
A full test plan would be very time-consuming and I think examining the
patch should be verification enough for changes which are limited to
adding a space.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
--===============4011193082561203428==--
From bugzilla-daemon@bugs.koha-community.org Wed Feb 14 15:33:54 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 36091] Spelling: Use "card number" instead of
cardnumber in text
Date: Wed, 14 Feb 2024 14:33:37 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6956803007221307015=="
--===============6956803007221307015==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
--===============6956803007221307015==--
From bugzilla-daemon@bugs.koha-community.org Thu Feb 15 08:29:54 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 36091] Spelling: Use "card number" instead of
cardnumber in text
Date: Thu, 15 Feb 2024 07:29:53 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1415409799828937272=="
--===============1415409799828937272==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
--===============1415409799828937272==--
From bugzilla-daemon@bugs.koha-community.org Thu Feb 15 08:30:04 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 36091] Spelling: Use "card number" instead of
cardnumber in text
Date: Thu, 15 Feb 2024 07:29:56 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6194732661392071566=="
--===============6194732661392071566==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162148|0 |1
is obsolete| |
--- Comment #3 from Magnus Enger ---
Created attachment 162170
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162170&action=edit
Bug 36091: Spelling: Use "card number" instead of cardnumber in text
This patch replaces the term "cardnumber" with "card number" in labels
and text where the patron's library card number is referred to. Where
the database column is referenced "cardnumber" is kept.
A full test plan would be very time-consuming and I think examining the
patch should be verification enough for changes which are limited to
adding a space.
Signed-off-by: Magnus Enger
Verified that the patch only changes "visible" text, and not
references to the database column.
--
You are receiving this mail because:
You are watching all bug changes.
--===============6194732661392071566==--
From bugzilla-daemon@bugs.koha-community.org Fri Feb 23 11:07:39 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 36091] Spelling: Use "card number" instead of
cardnumber in text
Date: Fri, 23 Feb 2024 10:07:38 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6820004925936180531=="
--===============6820004925936180531==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #162170|0 |1
is obsolete| |
--- Comment #4 from Julian Maurice ---
Created attachment 162370
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162370&action=edit
Bug 36091: Spelling: Use "card number" instead of cardnumber in text
This patch replaces the term "cardnumber" with "card number" in labels
and text where the patron's library card number is referred to. Where
the database column is referenced "cardnumber" is kept.
A full test plan would be very time-consuming and I think examining the
patch should be verification enough for changes which are limited to
adding a space.
Signed-off-by: Magnus Enger
Verified that the patch only changes "visible" text, and not
references to the database column.
Signed-off-by: Julian Maurice
--
You are receiving this mail because:
You are watching all bug changes.
--===============6820004925936180531==--
From bugzilla-daemon@bugs.koha-community.org Fri Feb 23 11:07:50 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 36091] Spelling: Use "card number" instead of
cardnumber in text
Date: Fri, 23 Feb 2024 10:07:49 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3341402213981337118=="
--===============3341402213981337118==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |julian.maurice@biblibre.com
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
--===============3341402213981337118==--
From bugzilla-daemon@bugs.koha-community.org Thu Mar 7 15:08:12 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 36091] Spelling: Use "card number" instead of
cardnumber in text
Date: Thu, 07 Mar 2024 14:04:28 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8850980283943915633=="
--===============8850980283943915633==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |24.05.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
--===============8850980283943915633==--
From bugzilla-daemon@bugs.koha-community.org Thu Mar 7 15:08:22 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 36091] Spelling: Use "card number" instead of
cardnumber in text
Date: Thu, 07 Mar 2024 14:04:29 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1722123975358573373=="
--===============1722123975358573373==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091
--- Comment #5 from Katrin Fischer ---
Pushed for 24.05!
Well done everyone, thank you!
--
You are receiving this mail because:
You are watching all bug changes.
--===============1722123975358573373==--
From bugzilla-daemon@bugs.koha-community.org Mon Mar 11 10:25:39 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 36091] Spelling: Use "card number" instead of
cardnumber in text
Date: Mon, 11 Mar 2024 09:25:38 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2850965204131403742=="
--===============2850965204131403742==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers@biblibre.co
| |m
Version(s)|24.05.00 |24.05.00,23.11.04
released in| |
Status|Pushed to master |Pushed to stable
--- Comment #6 from Fridolin Somers ---
Pushed to 23.11.x for 23.11.04
--
You are receiving this mail because:
You are watching all bug changes.
--===============2850965204131403742==--
From bugzilla-daemon@bugs.koha-community.org Tue Mar 19 16:12:10 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 36091] Spelling: Use "card number" instead of
cardnumber in text
Date: Tue, 19 Mar 2024 15:12:09 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6111940684862853550=="
--===============6111940684862853550==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
CC| |lucas@bywatersolutions.com
Status|Pushed to stable |RESOLVED
--- Comment #7 from Lucas Gass ---
Doesn't apply to 23.05.x cleanly, no baackport.
--
You are receiving this mail because:
You are watching all bug changes.
--===============6111940684862853550==--