From bugzilla-daemon@bugs.koha-community.org Wed May  6 00:09:38 2026
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 42534] New: wrapper-staff-tool-plugin.inc interferes
 with js and includes in template files
Date: Tue, 05 May 2026 22:09:37 +0000
Message-ID: <bug-42534-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7045154238703612591=="

--===============7045154238703612591==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D42534

            Bug ID: 42534
           Summary: wrapper-staff-tool-plugin.inc interferes with js and
                    includes in template files
   Initiative type: ---
        Sponsorship ---
            status:
           Product: Koha
           Version: Main
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs@lists.koha-community.org
          Reporter: lisette@bywatersolutions.com
        QA Contact: testopia@bugs.koha-community.org

Wrapper changes in Bug 42163 to support the vue changes made in Bug 41367 mea=
ns
you can't use a separate [% MACRO jsincludes BLOCK %] in plugins.=20


Additionally if you're using any includes (such as datatables.inc) they no
longer load because the wrapper [% MACRO jsincludes BLOCK %] overrides any
inline [% MACRO jsincludes BLOCK %]

You can use [% INCLUDE datatables.inc %] outside the wrapper, but most exampl=
es
have it inside and I fear plugins using the wrapper will break on an update to
26.05.

You can also put your <script> after the wrapper for loading it.=20

We could try and make changes to the plugin structure/wrapper to make this wo=
rk
a little smoother. We could add common includes like datatable, calendar,
select2, etc into the wrapper, but that seems like a long term maintenance
issue.=20

Another way could be to undo the vue change/figure out another way to load the
admin menu or otherwise contain it so it's not overriding in page [% MACRO
jsincludes BLOCK %]=20

This would be the least disruptive for existing plugins, so is probably the w=
ay
to go, but I'm not sure there's a good way to handle this.=20

I'm very open to ideas about how to best handle this.

--=20
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============7045154238703612591==--


From bugzilla-daemon@bugs.koha-community.org Wed May  6 00:10:01 2026
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 42534] wrapper-staff-tool-plugin.inc interferes with
 js and includes in template files
Date: Tue, 05 May 2026 22:10:01 +0000
Message-ID: <bug-42534-70-LOhAZL50zS@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-42534-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5487859477590722962=="

--===============5487859477590722962==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D42534

Lisette Scheer <lisette@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |42163, 41367


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D41367
[Bug 41367] Staff user interface - no sidebar menu when on record sources pag=
es
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D42163
[Bug 42163] wrapper-staff-tool-plugin.inc no longer loads the admin menu
--=20
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============5487859477590722962==--


From bugzilla-daemon@bugs.koha-community.org Wed May  6 00:10:33 2026
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 42534] wrapper-staff-tool-plugin.inc interferes with
 js and includes in template files
Date: Tue, 05 May 2026 22:10:33 +0000
Message-ID: <bug-42534-70-aDiMrDweH4@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-42534-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8585238188879691154=="

--===============8585238188879691154==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42534

Lisette Scheer <lisette@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas@bywatersolutions.com,
                   |                            |martin.renvoize@openfifth.c
                   |                            |o.uk,
                   |                            |nick@bywatersolutions.com,
                   |                            |pedro.amorim@openfifth.co.u
                   |                            |k, tomascohen@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8585238188879691154==--


From bugzilla-daemon@bugs.koha-community.org Wed May  6 00:10:43 2026
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 42534] wrapper-staff-tool-plugin.inc interferes with
 js and includes in template files
Date: Tue, 05 May 2026 22:10:42 +0000
Message-ID: <bug-42534-70-pO2PqHg1qv@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-42534-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5148027439252601852=="

--===============5148027439252601852==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42534

Lisette Scheer <lisette@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matt.blenkinsop@openfifth.c
                   |                            |o.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5148027439252601852==--


From bugzilla-daemon@bugs.koha-community.org Wed May  6 01:28:49 2026
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 42534] wrapper-staff-tool-plugin.inc interferes with
 js and includes in template files
Date: Tue, 05 May 2026 23:28:48 +0000
Message-ID: <bug-42534-70-tzakVfPeLL@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-42534-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3509320079492960492=="

--===============3509320079492960492==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42534

David Cook <dcook@prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook@prosentient.com.au

--- Comment #1 from David Cook <dcook@prosentient.com.au> ---
Yeah, that was the concern I had back on comments like
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163#c6

I think the best bet is going to be create a new mechanism and adapt
koha-tmpl/intranet-tmpl/prog/en/includes/wrapper-staff-tool-plugin.inc and
intranet-bottom.inc to using it

I'll try a really quick little proof of concept...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============3509320079492960492==--


From bugzilla-daemon@bugs.koha-community.org Wed May  6 02:06:27 2026
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 42534] wrapper-staff-tool-plugin.inc interferes with
 js and includes in template files
Date: Wed, 06 May 2026 00:06:27 +0000
Message-ID: <bug-42534-70-OTiagG7iFy@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-42534-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8336188429359337322=="

--===============8336188429359337322==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42534

--- Comment #2 from David Cook <dcook@prosentient.com.au> ---
Hmmm actually it looks like [% MACRO jsincludes BLOCK %] in
koha-tmpl/intranet-tmpl/prog/en/includes/wrapper-staff-tool-plugin.inc isn't
actually doing anything.

I think it's because the MACRO is scoped within the wrapper. Let's see...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============8336188429359337322==--


From bugzilla-daemon@bugs.koha-community.org Wed May  6 02:20:16 2026
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 42534] wrapper-staff-tool-plugin.inc interferes with
 js and includes in template files
Date: Wed, 06 May 2026 00:20:16 +0000
Message-ID: <bug-42534-70-gyGlz8bb8G@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-42534-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4848509922701969242=="

--===============4848509922701969242==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42534

--- Comment #3 from David Cook <dcook@prosentient.com.au> ---
Ah wait I see it now. Too easy.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============4848509922701969242==--


From bugzilla-daemon@bugs.koha-community.org Wed May  6 03:22:41 2026
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 42534] wrapper-staff-tool-plugin.inc interferes with
 js and includes in template files
Date: Wed, 06 May 2026 01:22:40 +0000
Message-ID: <bug-42534-70-cUhCF8MiNz@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-42534-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2068373047491650336=="

--===============2068373047491650336==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42534

David Cook <dcook@prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion
           Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============2068373047491650336==--


From bugzilla-daemon@bugs.koha-community.org Wed May  6 03:22:51 2026
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 42534] wrapper-staff-tool-plugin.inc interferes with
 js and includes in template files
Date: Wed, 06 May 2026 01:22:43 +0000
Message-ID: <bug-42534-70-M2x8eMeivv@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-42534-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3076404645930116060=="

--===============3076404645930116060==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D42534

--- Comment #4 from David Cook <dcook@prosentient.com.au> ---
Created attachment 198656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D198656&action=
=3Dedit
Bug 42534: Add global mechanism for adding Javascript snippets to staff
interface footers

This change adds a global mechanism where any template (regardless of its pla=
ce
in
the WRAPPER/INCLUDE structure) can add Javascript to the footer of the webpag=
e.

Technically, it could be used for any HTML content, but we're assuming it's
Javascript
here.

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============3076404645930116060==--


From bugzilla-daemon@bugs.koha-community.org Wed May  6 03:26:08 2026
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 42534] wrapper-staff-tool-plugin.inc interferes with
 js and includes in template files
Date: Wed, 06 May 2026 01:26:07 +0000
Message-ID: <bug-42534-70-tbeolnlRnP@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-42534-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1262566387880076771=="

--===============1262566387880076771==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D42534

--- Comment #5 from David Cook <dcook@prosentient.com.au> ---
So the patch I've attached is an idea I've had for a while. The idea being th=
at
any template wrapper/include could inject Javascript into the page footer.=20

It's probably worth mentioning that it relies on the Template::Toolkit being
evaluated at define time rather than call time. I think that should be OK in
most cases.=20

--

As for koha-tmpl/intranet-tmpl/prog/en/includes/wrapper-staff-tool-plugin.inc
more specifically... I don't think it actually needs admin-menu.js because the
wrapper will never match any of the paths in it.

And it doesn't need the island stuff because main-container.inc takes care of
that. So another option is to just take it all out.=20

I thought I'd use this as an opportunity to showcase this idea of pushing
output chunks into an array and then printing them out in the page footer.

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============1262566387880076771==--