From bugzilla-daemon@bugs.koha-community.org Tue Sep 30 22:37:48 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13017] New: koha h1 tag on staff login Date: Tue, 30 Sep 2014 20:30:11 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6864156892188705203==" --===============6864156892188705203== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Bug ID: 13017 Summary: koha h1 tag on staff login Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 31959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31959&action=edit koha h1 If you zoom out on the staff client you will see Koha to the far left (see attached). The code reads:

Koha

-- You are receiving this mail because: You are watching all bug changes. --===============6864156892188705203==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 10 02:36:38 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels Date: Fri, 10 Oct 2014 00:36:28 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2904892029282228416==" --===============2904892029282228416== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D13017 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|koha h1 tag on staff login |Login page image | |replacement technique fails | |when browser width exceeds | |2000 pixels --- Comment #1 from Owen Leonard --- =E2=80=98Doctor, doctor, it hurts when I do this.=E2=80=99 =E2=80=98Then don=E2=80=99t do that!=E2=80=99 Sorry, I couldn't resist. Yes it's true. If your browser window goes much wid= er than 2000 pixels the image replacement technique which displays the Koha logo will fail, having this style: text-indent: -1000px; ...which at the time of implementation was expected to be PLENTY of space to exclude the possibility that someone's browser would be wide enough that the text would be visible. It may be that we need to increase that number, or it may be that there is a more modern image replacement technique which we should switch to. --=20 You are receiving this mail because: You are watching all bug changes. --===============2904892029282228416==-- From bugzilla-daemon@bugs.koha-community.org Tue Nov 11 17:38:01 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels Date: Tue, 11 Nov 2014 16:37:51 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4277050075853550550==" --===============4277050075853550550== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. --===============4277050075853550550==-- From bugzilla-daemon@bugs.koha-community.org Tue Nov 11 17:41:20 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels Date: Tue, 11 Nov 2014 16:41:03 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6517682302807403531==" --===============6517682302807403531== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. --===============6517682302807403531==-- From bugzilla-daemon@bugs.koha-community.org Tue Nov 11 17:41:33 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels Date: Tue, 11 Nov 2014 16:41:05 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3077823615213764213==" --===============3077823615213764213== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D13017 --- Comment #2 from Owen Leonard --- Created attachment 33462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D33462&action=3De= dit Bug 13017 - Login page image replacement technique fails when browser width exceeds 2000 pixels This patch updates the image replacement technique used for Koha's login page. The old technique used a negative text-indent value to move the text offscreen, but that begins to fail more and more often as screens get larger. The new technqiue is described here: http://www.zeldman.com/2012/03/01/replacing-the-9999px-hack-new-image-replace= ment/ Note: This patch has not been tested in any Internet Explorer version! To test you must have a screen which is wider than 2000 pixels. Apply the patch, clear your browser cache and view the staff client login page. The logo on the login form should look correct with no corresponding text appearing anywhere on the screen. --=20 You are receiving this mail because: You are watching all bug changes. --===============3077823615213764213==-- From bugzilla-daemon@bugs.koha-community.org Mon Dec 1 17:22:02 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels Date: Mon, 01 Dec 2014 16:21:57 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2389705368526906030==" --===============2389705368526906030== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #3 from Christopher Brannon --- (In reply to Owen Leonard from comment #2) > Note: This patch has not been tested in any Internet Explorer version! Works in IE 11. -- You are receiving this mail because: You are watching all bug changes. --===============2389705368526906030==-- From bugzilla-daemon@bugs.koha-community.org Mon Dec 1 17:23:58 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels Date: Mon, 01 Dec 2014 16:23:55 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7470985454737085244==" --===============7470985454737085244== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============7470985454737085244==-- From bugzilla-daemon@bugs.koha-community.org Mon Dec 1 17:24:00 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels Date: Mon, 01 Dec 2014 16:23:57 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0198494171446011315==" --===============0198494171446011315== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D13017 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33462|0 |1 is obsolete| | --- Comment #4 from Christopher Brannon --- Created attachment 34045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D34045&action=3De= dit [SIGNED OFF] Bug 13017 - Login page image replacement technique fails when browser width exceeds 2000 pixels This patch updates the image replacement technique used for Koha's login page. The old technique used a negative text-indent value to move the text offscreen, but that begins to fail more and more often as screens get larger. The new technqiue is described here: http://www.zeldman.com/2012/03/01/replacing-the-9999px-hack-new-image-replace= ment/ Note: This patch has not been tested in any Internet Explorer version! To test you must have a screen which is wider than 2000 pixels. Apply the patch, clear your browser cache and view the staff client login page. The logo on the login form should look correct with no corresponding text appearing anywhere on the screen. Signed-off-by: Christopher Brannon --=20 You are receiving this mail because: You are watching all bug changes. --===============0198494171446011315==-- From bugzilla-daemon@bugs.koha-community.org Fri Dec 5 16:43:20 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels Date: Fri, 05 Dec 2014 15:43:17 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0741421010192290673==" --===============0741421010192290673== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============0741421010192290673==-- From bugzilla-daemon@bugs.koha-community.org Fri Dec 5 16:43:26 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels Date: Fri, 05 Dec 2014 15:43:19 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7763252399432836989==" --===============7763252399432836989== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D13017 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34045|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 34156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D34156&action=3De= dit [PASSED QA] Bug 13017 - Login page image replacement technique fails when browser width exceeds 2000 pixels This patch updates the image replacement technique used for Koha's login page. The old technique used a negative text-indent value to move the text offscreen, but that begins to fail more and more often as screens get larger. The new technqiue is described here: http://www.zeldman.com/2012/03/01/replacing-the-9999px-hack-new-image-replace= ment/ Note: This patch has not been tested in any Internet Explorer version! To test you must have a screen which is wider than 2000 pixels. Apply the patch, clear your browser cache and view the staff client login page. The logo on the login form should look correct with no corresponding text appearing anywhere on the screen. Signed-off-by: Christopher Brannon Signed-off-by: Kyle M Hall --=20 You are receiving this mail because: You are watching all bug changes. --===============7763252399432836989==-- From bugzilla-daemon@bugs.koha-community.org Sun Dec 28 15:22:00 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels Date: Sun, 28 Dec 2014 14:21:56 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6125271786823072809==" --===============6125271786823072809== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. --===============6125271786823072809==-- From bugzilla-daemon@bugs.koha-community.org Mon Dec 29 20:18:03 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels Date: Mon, 29 Dec 2014 19:17:52 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2610636217043884184==" --===============2610636217043884184== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. --===============2610636217043884184==-- From bugzilla-daemon@bugs.koha-community.org Fri Jan 16 20:10:48 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels Date: Fri, 16 Jan 2015 19:10:45 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8289509151440948624==" --===============8289509151440948624== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Version|master |3.16 --- Comment #8 from Mason James --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. --===============8289509151440948624==--