From bugzilla-daemon@bugs.koha-community.org Wed Nov 26 07:38:31 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13341] New: Hard-coded "Preview" text in OPAC openlibrary.js Date: Wed, 26 Nov 2014 06:38:28 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8793664727041128038==" --===============8793664727041128038== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Bug ID: 13341 Summary: Hard-coded "Preview" text in OPAC openlibrary.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr ./koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js: $(this).append('
' + 'Preview
'); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============8793664727041128038==-- From bugzilla-daemon@bugs.koha-community.org Wed Dec 10 15:02:15 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js Date: Wed, 10 Dec 2014 14:02:08 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6940485552554885468==" --===============6940485552554885468== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============6940485552554885468==-- From bugzilla-daemon@bugs.koha-community.org Wed Dec 10 15:35:26 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js Date: Wed, 10 Dec 2014 14:35:19 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0385563511672388571==" --===============0385563511672388571== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. --===============0385563511672388571==-- From bugzilla-daemon@bugs.koha-community.org Wed Dec 10 15:35:27 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js Date: Wed, 10 Dec 2014 14:35:21 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8055222334048438738==" --===============8055222334048438738== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 --- Comment #1 from Owen Leonard --- Created attachment 34279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34279&action=edit Bug 13341 - Hard-coded "Preview" text in OPAC openlibrary.js The OpenLibrary JavaScript includes an untranslated string, "Preview." This patch move the string to the template so that it can be translated. To test, apply the patch and test that the translator picks up the string: 1. From misc/translator run 'perl translate update [lang]' (e.g. de-DE) 2. Edit misc/translator/po/[lang]-opac-bootstrap.po and add a translation for the updated "Preview" string 3. Remove the "#, fuzzy" marker from that entry 4. From misc/translator run 'perl translate install [lang]' 5. Enable the [lang] translation for the OPAC in system preferences 6. Enable the OpenLibraryCovers system preference. 7. In the OPAC switch to the [lang] translation. 7. View the detail page for a title for which there is an OpenLibrary cover image. Below it you should see a preview link with the translated string you added in step 2. -- You are receiving this mail because: You are watching all bug changes. --===============8055222334048438738==-- From bugzilla-daemon@bugs.koha-community.org Sat Dec 20 20:04:55 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js Date: Sat, 20 Dec 2014 19:04:51 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4912345703894914968==" --===============4912345703894914968== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 --- Comment #2 from Marc Véron --- Created attachment 34607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34607&action=edit [Signed-off] Bug 13341 - Hard-coded "Preview" text in OPAC openlibrary.js The OpenLibrary JavaScript includes an untranslated string, "Preview." This patch move the string to the template so that it can be translated. To test, apply the patch and test that the translator picks up the string: 1. From misc/translator run 'perl translate update [lang]' (e.g. de-DE) 2. Edit misc/translator/po/[lang]-opac-bootstrap.po and add a translation for the updated "Preview" string 3. Remove the "#, fuzzy" marker from that entry 4. From misc/translator run 'perl translate install [lang]' 5. Enable the [lang] translation for the OPAC in system preferences 6. Enable the OpenLibraryCovers system preference. 7. In the OPAC switch to the [lang] translation. 7. View the detail page for a title for which there is an OpenLibrary cover image. Below it you should see a preview link with the translated string you added in step 2. Works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. --===============4912345703894914968==-- From bugzilla-daemon@bugs.koha-community.org Sat Dec 20 20:05:16 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js Date: Sat, 20 Dec 2014 19:05:13 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2327562803322526061==" --===============2327562803322526061== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Marc Véron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34279|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes. --===============2327562803322526061==-- From bugzilla-daemon@bugs.koha-community.org Sat Dec 20 20:05:25 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js Date: Sat, 20 Dec 2014 19:05:21 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1975585969709020795==" --===============1975585969709020795== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Marc Véron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============1975585969709020795==-- From bugzilla-daemon@bugs.koha-community.org Sat Dec 27 14:35:03 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js Date: Sat, 27 Dec 2014 13:34:56 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2875006495481153401==" --===============2875006495481153401== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 --- Comment #3 from Katrin Fischer --- Created attachment 34714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34714&action=edit [PASSED QA] [PASSED QA] Bug 13341 - Hard-coded "Preview" text in OPAC openlibrary.js The OpenLibrary JavaScript includes an untranslated string, "Preview." This patch move the string to the template so that it can be translated. To test, apply the patch and test that the translator picks up the string: 1. From misc/translator run 'perl translate update [lang]' (e.g. de-DE) 2. Edit misc/translator/po/[lang]-opac-bootstrap.po and add a translation for the updated "Preview" string 3. Remove the "#, fuzzy" marker from that entry 4. From misc/translator run 'perl translate install [lang]' 5. Enable the [lang] translation for the OPAC in system preferences 6. Enable the OpenLibraryCovers system preference. 7. In the OPAC switch to the [lang] translation. 7. View the detail page for a title for which there is an OpenLibrary cover image. Below it you should see a preview link with the translated string you added in step 2. Works as expected. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. --===============2875006495481153401==-- From bugzilla-daemon@bugs.koha-community.org Sat Dec 27 14:35:27 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js Date: Sat, 27 Dec 2014 13:35:25 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2871716742747852033==" --===============2871716742747852033== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. --===============2871716742747852033==-- From bugzilla-daemon@bugs.koha-community.org Sat Dec 27 14:35:29 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js Date: Sat, 27 Dec 2014 13:35:26 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2821847173183454906==" --===============2821847173183454906== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34607|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. --===============2821847173183454906==-- From bugzilla-daemon@bugs.koha-community.org Mon Dec 29 00:53:04 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js Date: Sun, 28 Dec 2014 23:53:01 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5589888368554025173==" --===============5589888368554025173== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. --===============5589888368554025173==-- From bugzilla-daemon@bugs.koha-community.org Tue Dec 30 22:46:41 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js Date: Tue, 30 Dec 2014 21:46:39 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4965384114974833707==" --===============4965384114974833707== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. --===============4965384114974833707==-- From bugzilla-daemon@bugs.koha-community.org Fri Jan 16 21:43:13 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js Date: Fri, 16 Jan 2015 20:43:09 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3309961434617122041==" --===============3309961434617122041== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #6 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. --===============3309961434617122041==--