From bugzilla-daemon@wilbur.katipo.co.nz Tue Aug 12 12:34:56 2003
From: bugzilla-daemon@wilbur.katipo.co.nz
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 577] New: Move HTML out of authorised_values.pl and
 marctagstructure.pl
Date: Tue, 12 Aug 2003 19:15:22 +0000
Message-ID: <20030812191522.17109.qmail@wilbur.katipo.co.nz>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7163805222032027882=="

--===============7163805222032027882==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=3D577

           Summary: Move HTML out of authorised_values.pl and
                    marctagstructure.pl
           Product: Koha
           Version: CVS
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Parameters
        AssignedTo: tonnesen@cmsd.bc.ca
        ReportedBy: oleonard@athenscounty.lib.oh.us
         QAContact: koha-bugs@lists.sourceforge.net


In authorisedvalues.pl and marctagstruture.pl, variables are created to enable
'previous page' and 'next page' links.  This is done like this:

		$template->param(previous =3D> "<a
href=3D\"$script_name?offset=3D$prevpage&searchfield=3D$searchfield\">");

...So the template reads something like this:

    <TMPL_VAR NAME=3D"previous">Previous Page</a>

It makes more sense to me to create individual variables for $prevpage and
$searchfield so that the link could be constructed more flexibly:

<a href=3D"<TMPL_VAR NAME=3D"script_name">?offset=3D<TMPL_VAR
NAME=3D"offset">&amp;searchfield=3D<TMPL_VAR NAME=3D"searchfield">">Previous =
Page</a>

This would allow alternatives like:

<form action=3D"<TMPL_VAR NAME=3D"script_name">" method=3D"get">
<input type=3D"hidden" name=3D"offset" value=3D"<TMPL_VAR NAME=3D"offset">
<input type=3D"hidden" name=3D"searchfield" value=3D"<TMPL_VAR NAME=3D"search=
field">">
<input type=3D"submit" value=3D"Previous Page">
</form>



------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


--===============7163805222032027882==--