From bugzilla-daemon@bugs.koha-community.org Wed Sep  3 03:34:32 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] New: HTML fixes triggered by cleaning up
 language="javascript"
Date: Wed, 03 Sep 2014 01:16:21 +0000
Message-ID: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0914637271708385294=="

--===============0914637271708385294==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D12862

            Bug ID: 12862
           Summary: HTML fixes triggered by cleaning up
                    language=3D"javascript"
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Browser compatibility
          Assignee: oleonard@myacpl.org
          Reporter: mtompset@hotmail.com
        QA Contact: testopia@bugs.koha-community.org

Tweak the <script> tags to remove or modify the obsolete tag in question,
perhaps move the script to fix another bug, tweak the one other simple HTML b=
ug
while I'm at it in a file, and fix a hardcoded opac-tmpl when koha-qa
complains.

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============0914637271708385294==--


From bugzilla-daemon@bugs.koha-community.org Wed Sep  3 04:11:09 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Wed, 03 Sep 2014 01:52:55 +0000
Message-ID: <bug-12862-70-ErIb5LOmrL@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4987885314693161561=="

--===============4987885314693161561==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

M. Tompsett <mtompset@hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4987885314693161561==--


From bugzilla-daemon@bugs.koha-community.org Wed Sep  3 04:11:09 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Wed, 03 Sep 2014 01:52:57 +0000
Message-ID: <bug-12862-70-vlia75Pj8C@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1263599050427593425=="

--===============1263599050427593425==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

--- Comment #1 from M. Tompsett <mtompset@hotmail.com> ---
Created attachment 31325
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31325&action=edit
Bug 12862: Staff client tweaks related to obsolete language="javascript"

As a result, this patch removed the deprecated tag from the
intranet templates.

And since there was just 1 other tiny error in the same template
file, the checked="checked" was removed from a text box.

TEST PLAN
---------
1) Install the HTML Validator 0.9.5.8 for FireFox.
2) Open Intranet to Home -> Tools -> News
3) View Page Source
   -- you'll notice the message about language="javascript" being
      one of the error messages.
4) Click Edit beside one of the news items.
5) View Page Source
   -- you'll notice the message about language="javascript" being
      one of the error messages.
6) Apply patch
7) Repeat steps 2 to 5 without "language="javascript" related
   error messages.
8) Run koha QA test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1263599050427593425==--


From bugzilla-daemon@bugs.koha-community.org Wed Sep  3 04:11:14 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Wed, 03 Sep 2014 01:53:06 +0000
Message-ID: <bug-12862-70-nAB08MiedX@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4243497754653573344=="

--===============4243497754653573344==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

--- Comment #2 from M. Tompsett <mtompset@hotmail.com> ---
Created attachment 31326
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31326&action=edit
Bug 12862: OPAC bootstrap - clean up language="javascript"

There was a <script language="javascript"> tag.
It was cleaned up to be <script type="text/javascript">.
Also, the div was being chopped because the script was
in the middle of the div. Moving it to head solved the issues.

This is difficult to test, since the printslip is triggered
when you click Finish.

TEST PLAN
---------
 1) Home -> Koha administration -> Global system parameters -> OPAC
 2) Set the OPAC system preference 'opacthemes' to 'bootstrap'.
 3) Start the self-checkout client (/cgi-bin/koha/sco/sco-main.pl)
 4) Log in.
 5) Check something out.
 6) Change the address url text box to
    .../cgi-bin/koha/sco/printslip.pl?borrowernumber=##&amp;print=qslip
    Where ## is your borrower number which just checked something out.
 7) Click Cancel on the print dialogue
 8) View Page Source
    -- The HTML validation plugin will point out multiple errors.
 9) Apply patch
10) Refresh page
11) View Page Source
    -- Much happier validation results.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4243497754653573344==--


From bugzilla-daemon@bugs.koha-community.org Wed Sep  3 04:11:26 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Wed, 03 Sep 2014 01:53:11 +0000
Message-ID: <bug-12862-70-iHN4nZLRml@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7733339789924558020=="

--===============7733339789924558020==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

--- Comment #3 from M. Tompsett <mtompset@hotmail.com> ---
Created attachment 31327
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31327&action=edit
Bug 12862: CCSR and Prog - language="javascript" is obsolete.

Corrected/removed the obsolete HTML.
Fixed a hard coded opac-tmpl, as per koha-qa's demand.

Trigger all the templates and check of the language="javascript"
error is listed in the validation done by the HTML Validator
plugin for FireFox that Owen pointed me at.

TEST PLAN
---------
1) Test with opactheme set to ccsr. Any opac page with
   opac-bottom.inc will do.
2) Test with opactheme set to prog.
   - Any opac page with opac-bottom.inc
   - Any opac page with doc-head-close.inc
   - Advanced search
   - Authority search -> Submit -> View full heading -> MARC View
   - staff client, home, serials, submit by the title text box,
     click one of the subscriptions
     (you don't have subscriptions?! can't help you),
     determine the biblionumber, opac,
     search for the biblio number and get to an opac details page,
     click on more details
3) Test the self-checkout printslip, just like the bootstrap
   one previously.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7733339789924558020==--


From bugzilla-daemon@bugs.koha-community.org Wed Sep  3 04:13:56 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Wed, 03 Sep 2014 01:55:48 +0000
Message-ID: <bug-12862-70-0sB17CpAuL@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4927412734675731786=="

--===============4927412734675731786==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

--- Comment #4 from M. Tompsett <mtompset@hotmail.com> ---
I split up the prog and ccsr from the boot strap, so that this could
potentially be included as a backport.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4927412734675731786==--


From bugzilla-daemon@bugs.koha-community.org Wed Sep 17 00:23:06 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Tue, 16 Sep 2014 10:34:33 +0000
Message-ID: <bug-12862-70-qL56Yi6ycz@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4632893576639430534=="

--===============4632893576639430534==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

M. Tompsett <mtompset@hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard@myacpl.org         |mtompset@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4632893576639430534==--


From bugzilla-daemon@bugs.koha-community.org Fri Oct 10 20:47:15 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Fri, 10 Oct 2014 18:47:08 +0000
Message-ID: <bug-12862-70-WciqSx8txn@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2289094562195332034=="

--===============2289094562195332034==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31325|0                           |1
        is obsolete|                            |

--- Comment #5 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 32186
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32186&action=edit
[SIGNED-OFF] Bug 12862: Staff client tweaks related to obsolete
language="javascript"

As a result, this patch removed the deprecated tag from the
intranet templates.

And since there was just 1 other tiny error in the same template
file, the checked="checked" was removed from a text box.

TEST PLAN
---------
1) Install the HTML Validator 0.9.5.8 for FireFox.
2) Open Intranet to Home -> Tools -> News
3) View Page Source
   -- you'll notice the message about language="javascript" being
      one of the error messages.
4) Click Edit beside one of the news items.
5) View Page Source
   -- you'll notice the message about language="javascript" being
      one of the error messages.
6) Apply patch
7) Repeat steps 2 to 5 without "language="javascript" related
   error messages.
8) Run koha QA test tools.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2289094562195332034==--


From bugzilla-daemon@bugs.koha-community.org Fri Oct 10 20:47:26 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Fri, 10 Oct 2014 18:47:15 +0000
Message-ID: <bug-12862-70-sB9KawqYTf@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5408639676338053604=="

--===============5408639676338053604==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31326|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 32187
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32187&action=edit
[SIGNED-OFF] Bug 12862: OPAC bootstrap - clean up language="javascript"

There was a <script language="javascript"> tag.
It was cleaned up to be <script type="text/javascript">.
Also, the div was being chopped because the script was
in the middle of the div. Moving it to head solved the issues.

This is difficult to test, since the printslip is triggered
when you click Finish.

TEST PLAN
---------
 1) Home -> Koha administration -> Global system parameters -> OPAC
 2) Set the OPAC system preference 'opacthemes' to 'bootstrap'.
 3) Start the self-checkout client (/cgi-bin/koha/sco/sco-main.pl)
 4) Log in.
 5) Check something out.
 6) Change the address url text box to
    .../cgi-bin/koha/sco/printslip.pl?borrowernumber=##&amp;print=qslip
    Where ## is your borrower number which just checked something out.
 7) Click Cancel on the print dialogue
 8) View Page Source
    -- The HTML validation plugin will point out multiple errors.
 9) Apply patch
10) Refresh page
11) View Page Source
    -- Much happier validation results.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5408639676338053604==--


From bugzilla-daemon@bugs.koha-community.org Fri Oct 10 20:47:58 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Fri, 10 Oct 2014 18:47:52 +0000
Message-ID: <bug-12862-70-4VyBghdBf4@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1866134340402184623=="

--===============1866134340402184623==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1866134340402184623==--


From bugzilla-daemon@bugs.koha-community.org Fri Oct 10 20:48:02 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Fri, 10 Oct 2014 18:47:54 +0000
Message-ID: <bug-12862-70-lwiluVMePg@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5662251122241300283=="

--===============5662251122241300283==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31327|0                           |1
        is obsolete|                            |

--- Comment #7 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 32188
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32188&action=edit
[SIGNED-OFF] Bug 12862: CCSR and Prog - language="javascript" is obsolete.

Corrected/removed the obsolete HTML.
Fixed a hard coded opac-tmpl, as per koha-qa's demand.

Trigger all the templates and check of the language="javascript"
error is listed in the validation done by the HTML Validator
plugin for FireFox that Owen pointed me at.

TEST PLAN
---------
1) Test with opactheme set to ccsr. Any opac page with
   opac-bottom.inc will do.
2) Test with opactheme set to prog.
   - Any opac page with opac-bottom.inc
   - Any opac page with doc-head-close.inc
   - Advanced search
   - Authority search -> Submit -> View full heading -> MARC View
   - staff client, home, serials, submit by the title text box,
     click one of the subscriptions
     (you don't have subscriptions?! can't help you),
     determine the biblionumber, opac,
     search for the biblio number and get to an opac details page,
     click on more details
3) Test the self-checkout printslip, just like the bootstrap
   one previously.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5662251122241300283==--


From bugzilla-daemon@bugs.koha-community.org Sat Oct 11 21:17:41 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Sat, 11 Oct 2014 19:17:33 +0000
Message-ID: <bug-12862-70-cZvJV7F2kw@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3189707713262246633=="

--===============3189707713262246633==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer@bsz-bw.de

--- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
I think there is a line in the first patch, that does not belong there, could
you please check?

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3189707713262246633==--


From bugzilla-daemon@bugs.koha-community.org Sat Oct 11 21:44:40 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Sat, 11 Oct 2014 19:44:31 +0000
Message-ID: <bug-12862-70-XFnCrPX3ID@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0878592345326942711=="

--===============0878592345326942711==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

--- Comment #9 from M. Tompsett <mtompset@hotmail.com> ---
(In reply to Katrin Fischer from comment #8)
> I think there is a line in the first patch, that does not belong there,
> could you please check?

Which one?
You can't have checked="checked" on a text box. It is a scope creep, but it is
a valid clean up.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0878592345326942711==--


From bugzilla-daemon@bugs.koha-community.org Sat Oct 11 21:48:20 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Sat, 11 Oct 2014 19:48:11 +0000
Message-ID: <bug-12862-70-159PVQ8y47@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4817724718756560910=="

--===============4817724718756560910==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
I didn't see why it was there - if you scope creep, please put a note in your
commit message ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4817724718756560910==--


From bugzilla-daemon@bugs.koha-community.org Sat Oct 11 21:54:42 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Sat, 11 Oct 2014 19:54:31 +0000
Message-ID: <bug-12862-70-ngLEnVffvp@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7709209321879902614=="

--===============7709209321879902614==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

--- Comment #11 from M. Tompsett <mtompset@hotmail.com> ---
(In reply to Katrin Fischer from comment #10)
> I didn't see why it was there - if you scope creep, please put a note in
> your commit message ;)

That's why I tweaked the title to "HTML clean up triggered by", so it would
include it. ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7709209321879902614==--


From bugzilla-daemon@bugs.koha-community.org Mon Oct 13 23:40:03 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Mon, 13 Oct 2014 21:39:57 +0000
Message-ID: <bug-12862-70-R5Nj3XYy8E@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6883812224295223331=="

--===============6883812224295223331==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

--- Comment #12 from M. Tompsett <mtompset@hotmail.com> ---
(In reply to M. Tompsett from comment #0)
> Tweak the <script> tags to remove or modify the obsolete tag in question,
> perhaps move the script to fix another bug, tweak the one other simple HTML
> bug while I'm at it in a file, and fix a hardcoded opac-tmpl when koha-qa
> complains.

I also did mention it indirectly here "tweak the other simple HTML bug".
You'll also notice how the script was moved to the head block, and I did fix
the hardcoded opac-tmpl too.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6883812224295223331==--


From bugzilla-daemon@bugs.koha-community.org Fri Oct 17 16:41:43 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Fri, 17 Oct 2014 14:41:35 +0000
Message-ID: <bug-12862-70-wjO4HklswT@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4322348959083215219=="

--===============4322348959083215219==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

Kyle M Hall <kyle@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32186|0                           |1
        is obsolete|                            |
  Attachment #32187|0                           |1
        is obsolete|                            |
  Attachment #32188|0                           |1
        is obsolete|                            |

--- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> ---
Created attachment 32508
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32508&action=edit
[PASSED QA] Bug 12862: Staff client tweaks related to obsolete
language="javascript"

As a result, this patch removed the deprecated tag from the
intranet templates.

And since there was just 1 other tiny error in the same template
file, the checked="checked" was removed from a text box.

TEST PLAN
---------
1) Install the HTML Validator 0.9.5.8 for FireFox.
2) Open Intranet to Home -> Tools -> News
3) View Page Source
   -- you'll notice the message about language="javascript" being
      one of the error messages.
4) Click Edit beside one of the news items.
5) View Page Source
   -- you'll notice the message about language="javascript" being
      one of the error messages.
6) Apply patch
7) Repeat steps 2 to 5 without "language="javascript" related
   error messages.
8) Run koha QA test tools.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4322348959083215219==--


From bugzilla-daemon@bugs.koha-community.org Fri Oct 17 16:41:55 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Fri, 17 Oct 2014 14:41:42 +0000
Message-ID: <bug-12862-70-PnQJyKhuqV@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5027941736099825171=="

--===============5027941736099825171==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

--- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> ---
Created attachment 32509
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32509&action=edit
[PASSED QA] Bug 12862: OPAC bootstrap - clean up language="javascript"

There was a <script language="javascript"> tag.
It was cleaned up to be <script type="text/javascript">.
Also, the div was being chopped because the script was
in the middle of the div. Moving it to head solved the issues.

This is difficult to test, since the printslip is triggered
when you click Finish.

TEST PLAN
---------
 1) Home -> Koha administration -> Global system parameters -> OPAC
 2) Set the OPAC system preference 'opacthemes' to 'bootstrap'.
 3) Start the self-checkout client (/cgi-bin/koha/sco/sco-main.pl)
 4) Log in.
 5) Check something out.
 6) Change the address url text box to
    .../cgi-bin/koha/sco/printslip.pl?borrowernumber=##&amp;print=qslip
    Where ## is your borrower number which just checked something out.
 7) Click Cancel on the print dialogue
 8) View Page Source
    -- The HTML validation plugin will point out multiple errors.
 9) Apply patch
10) Refresh page
11) View Page Source
    -- Much happier validation results.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5027941736099825171==--


From bugzilla-daemon@bugs.koha-community.org Fri Oct 17 16:42:01 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Fri, 17 Oct 2014 14:41:45 +0000
Message-ID: <bug-12862-70-4Ek7sLVDs1@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6659473820132874174=="

--===============6659473820132874174==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

--- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> ---
Created attachment 32510
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32510&action=edit
[PASSED QA] Bug 12862: CCSR and Prog - language="javascript" is obsolete.

Corrected/removed the obsolete HTML.
Fixed a hard coded opac-tmpl, as per koha-qa's demand.

Trigger all the templates and check of the language="javascript"
error is listed in the validation done by the HTML Validator
plugin for FireFox that Owen pointed me at.

TEST PLAN
---------
1) Test with opactheme set to ccsr. Any opac page with
   opac-bottom.inc will do.
2) Test with opactheme set to prog.
   - Any opac page with opac-bottom.inc
   - Any opac page with doc-head-close.inc
   - Advanced search
   - Authority search -> Submit -> View full heading -> MARC View
   - staff client, home, serials, submit by the title text box,
     click one of the subscriptions
     (you don't have subscriptions?! can't help you),
     determine the biblionumber, opac,
     search for the biblio number and get to an opac details page,
     click on more details
3) Test the self-checkout printslip, just like the bootstrap
   one previously.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6659473820132874174==--


From bugzilla-daemon@bugs.koha-community.org Fri Oct 17 16:42:15 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Fri, 17 Oct 2014 14:41:56 +0000
Message-ID: <bug-12862-70-ksiPi4GESV@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1281054900289361067=="

--===============1281054900289361067==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

Kyle M Hall <kyle@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |kyle@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1281054900289361067==--


From bugzilla-daemon@bugs.koha-community.org Sat Oct 18 16:16:49 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Sat, 18 Oct 2014 14:16:42 +0000
Message-ID: <bug-12862-70-TkbLUli8Pg@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8834208339078441320=="

--===============8834208339078441320==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

Tomás Cohen Arazi <tomascohen@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen@gmail.com

--- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> ---
Patches pushed to master.

Thanks Mark!

Note: I didn't understand the description of the bug. Keep in mind that
non-english speakers (as I am) might need a more detailed explanation.

RMaints: I ommited the CCSR/Prog patch for master.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8834208339078441320==--


From bugzilla-daemon@bugs.koha-community.org Sat Oct 18 17:46:47 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up
 language="javascript"
Date: Sat, 18 Oct 2014 15:46:38 +0000
Message-ID: <bug-12862-70-jQcEFWvstb@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12862-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0565010279623432608=="

--===============0565010279623432608==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

--- Comment #17 from M. Tompsett <mtompset@hotmail.com> ---
(In reply to Tomás Cohen Arazi from comment #16)
> Note: I didn't understand the description of the bug. Keep in mind that
> non-english speakers (as I am) might need a more detailed explanation.

When I went to fix that one specific error, I noticed 3 other errors as well.
Hence, the fixing of language="javascript" HTML problems caused me to want to
clean up and do (triggered) clean up of three other nearby HTML issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0565010279623432608==--