From bugzilla-daemon@bugs.koha-community.org Tue Apr 28 13:14:36 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25302] New: The indentations should be in accordance with the Coding guidelines. Date: Tue, 28 Apr 2020 11:14:35 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2302251323738553650==" --===============2302251323738553650== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Bug ID: 25302 Summary: The indentations should be in accordance with the Coding guidelines. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: timothy_alexis.vass@ub.lu.se QA Contact: testopia@bugs.koha-community.org Simply put, the indentations are inconsistent. -- You are receiving this mail because: You are watching all bug changes. --===============2302251323738553650==-- From bugzilla-daemon@bugs.koha-community.org Tue Apr 28 13:18:44 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines. Date: Tue, 28 Apr 2020 11:18:43 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5225909940968377086==" --===============5225909940968377086== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|oleonard@myacpl.org |timothy_alexis.vass@ub.lu.s | |e Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. --===============5225909940968377086==-- From bugzilla-daemon@bugs.koha-community.org Tue Apr 28 16:44:39 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines. Date: Tue, 28 Apr 2020 14:44:38 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7876333109642785294==" --===============7876333109642785294== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D25302 --- Comment #1 from Timothy Alexis Vass --- Created attachment 103863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D103863&action= =3Dedit =3D=3D=3D Indentations are now consistently 4 spaces and opening/closing tags= are now aligned. =3D=3D=3D example:
[% FOREACH ... = %] =20

...

[% END %]
is now:
=20 =3D=3D=3D Whitespaces are now consistent =3D=3D=3D 1. Occuring > < and ] [ changed to >< and ][ example:
  • In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0790612389102520067==" --===============0790612389102520067== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D25302 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The indentations should be |The indentations should be |in accordance with the |in accordance with the |Coding guidelines. |Coding guidelines and | |whitespaces/linebreaks | |should be consistent. --- Comment #2 from Timothy Alexis Vass --- Seems like the first part of the comment was different from the commit messag= e, it should be: =3D=3D=3D Indentations are now consistently 4 spaces and otherwise correct =3D=3D=3D example:
    [% FOREACH ... %]

    ...

    [% END %]
    is now:
    [% FOREACH ... %]

    ...

    [% END %]
    --=20 You are receiving this mail because: You are watching all bug changes. --===============0790612389102520067==-- From bugzilla-daemon@bugs.koha-community.org Tue Apr 28 17:07:48 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. Date: Tue, 28 Apr 2020 15:07:48 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2437561569908679917==" --===============2437561569908679917== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============2437561569908679917==-- From bugzilla-daemon@bugs.koha-community.org Tue Apr 28 18:42:38 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. Date: Tue, 28 Apr 2020 16:42:37 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1726163133020892993==" --===============1726163133020892993== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- I'm marking this "Failed QA" so that this patch can wait for an amended commit message as we discussed on IRC. -- You are receiving this mail because: You are watching all bug changes. --===============1726163133020892993==-- From bugzilla-daemon@bugs.koha-community.org Thu Apr 30 11:40:27 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. Date: Thu, 30 Apr 2020 09:40:26 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3644134080469586459==" --===============3644134080469586459== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 --- Comment #4 from Timothy Alexis Vass --- Created attachment 104010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104010&action=edit Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. To test: 1) Open an item in OPAC and see if it works. -- You are receiving this mail because: You are watching all bug changes. --===============3644134080469586459==-- From bugzilla-daemon@bugs.koha-community.org Thu Apr 30 11:45:36 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. Date: Thu, 30 Apr 2020 09:45:35 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3080687406639783829==" --===============3080687406639783829== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103863|=== Indentations are now |=== Indentations are now description|consistently 4 spaces and |consistently 4 spaces and |opening/closing tags are |opening/closing tags are |now aligned. === example: |now aligned. === example: |
    |
    | [% FOREACH ... %] | [% FOREACH ... %] |

    ... |

    ... |

    [% END %] |

    [% END %] |
    is now:
    is now:
    |id="html5media"> -- You are receiving this mail because: You are watching all bug changes. --===============3080687406639783829==-- From bugzilla-daemon@bugs.koha-community.org Thu Apr 30 11:47:23 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. Date: Thu, 30 Apr 2020 09:47:22 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7841948390025158572==" --===============7841948390025158572== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103863|1 |0 is patch| | Attachment #103863|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. --===============7841948390025158572==-- From bugzilla-daemon@bugs.koha-community.org Thu Apr 30 14:22:31 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. Date: Thu, 30 Apr 2020 12:22:31 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4742896353534456671==" --===============4742896353534456671== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104010|0 |1 is obsolete| | --- Comment #5 from Timothy Alexis Vass --- Created attachment 104029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104029&action=edit Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. To test: 1) Open an item in OPAC and see if it works. -- You are receiving this mail because: You are watching all bug changes. --===============4742896353534456671==-- From bugzilla-daemon@bugs.koha-community.org Thu Apr 30 16:07:08 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. Date: Thu, 30 Apr 2020 14:07:08 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8038629510915306547==" --===============8038629510915306547== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104029|0 |1 is obsolete| | --- Comment #6 from Timothy Alexis Vass --- Created attachment 104036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104036&action=edit Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. To test: 1) Open an item in OPAC and see if it works. -- You are receiving this mail because: You are watching all bug changes. --===============8038629510915306547==-- From bugzilla-daemon@bugs.koha-community.org Thu Apr 30 16:16:49 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. Date: Thu, 30 Apr 2020 14:16:49 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3732072867307026713==" --===============3732072867307026713== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============3732072867307026713==-- From bugzilla-daemon@bugs.koha-community.org Mon May 4 16:51:38 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. Date: Mon, 04 May 2020 14:51:37 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5208271392419388633==" --===============5208271392419388633== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104036|0 |1 is obsolete| | --- Comment #7 from Timothy Alexis Vass --- Created attachment 104299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104299&action=edit Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. To test: 1) Open an item in OPAC and see if it works. -- You are receiving this mail because: You are watching all bug changes. --===============5208271392419388633==-- From bugzilla-daemon@bugs.koha-community.org Mon May 4 17:00:10 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. Date: Mon, 04 May 2020 15:00:10 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7866155902487649337==" --===============7866155902487649337== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104299|0 |1 is obsolete| | --- Comment #8 from Timothy Alexis Vass --- Created attachment 104301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104301&action=edit Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. To test: 1) Open an item in OPAC and see if it works. -- You are receiving this mail because: You are watching all bug changes. --===============7866155902487649337==-- From bugzilla-daemon@bugs.koha-community.org Tue May 5 09:57:11 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. Date: Tue, 05 May 2020 07:57:10 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3695822835362784419==" --===============3695822835362784419== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. --===============3695822835362784419==-- From bugzilla-daemon@bugs.koha-community.org Tue May 5 10:01:26 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. Date: Tue, 05 May 2020 08:01:25 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7239994970865146187==" --===============7239994970865146187== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D25302 --- Comment #9 from Katrin Fischer --- Hi Timothy, what happened here? Keen on helping you to get a patch in, catch = me on IRC if you need any help. --=20 You are receiving this mail because: You are watching all bug changes. --===============7239994970865146187==--