From bugzilla-daemon@bugs.koha-community.org Fri Feb 19 21:07:58 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports
Date: Fri, 19 Feb 2021 20:07:57 +0000
Message-ID: <bug-5697-70-xhxJ9RIaXI@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-5697-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1771763894363285803=="

--===============1771763894363285803==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D5697

--- Comment #11 from Owen Leonard <oleonard@myacpl.org> ---
(In reply to Katrin Fischer from comment #6)
> I think the feature is super nice, but there is a big issue for me as it
> will currently only work on the English column names.

I hadn't tested it with the new placeholder system, but after rebasing the
patch and looking again my tests were successful, with one glitch: If there is
a space inside the column name placeholder it won't work. So the SQL you trie=
d:

SELECT=20
i.itemnumber,
i.itemnumber as Exemplarnummber,
[[i.itemnumber| itemnumber for batch]],
CONCAT('<a
href=3D\"/cgi-bin/koha/cataloguing/additem.pl?op=3Dedititem&biblionumber=3D',
i.biblionumber, '&itemnumber=3D', i.itemnumber, '#edititem', '\">', i.itemnum=
ber,
'</a>' ) AS "itemnumber as edit link"
FROM items i

"[[i.itemnumber| itemnumber for batch]]" has a space before "itemnumber for
batch." With that space removed it works as expected. I think this must be
considered a bug in the placeholder parsing, since this query will fail to
trigger the expected batch item modification menu:

SELECT=20
i.itemnumber AS ' itemnumber for batch'
FROM items i

--=20
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

--===============1771763894363285803==--