From bugzilla-daemon@bugs.koha-community.org Thu Jan 30 08:20:45 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
[Koha-bugs] [Bug 11638] New: Untranslatable "Tag editor" in addbiblio.pl
Date: Thu, 30 Jan 2014 07:20:40 +0000
Message-ID:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5232365011792837891=="
--===============5232365011792837891==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D11638
Bug ID: 11638
Summary: Untranslatable "Tag editor" in addbiblio.pl
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: I18N/L10N
Assignee: koha-bugs@lists.koha-community.org
Reporter: pasi.kallinen@pttk.fi
QA Contact: testopia@bugs.koha-community.org
CC: frederic@tamil.fr
addbiblio.pl has a hard-coded (and therefore untranslatable) "Tag editor" tex=
t.
It appears in two places in the code.
Also:
print "Content-Type: text/html\n\nERROR when DELETING BIBLIO
$biblionumber : $error
";
--=20
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
--===============5232365011792837891==--
From bugzilla-daemon@bugs.koha-community.org Thu Jan 30 14:38:16 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 11638] Untranslatable "Tag editor" in addbiblio.pl
Date: Thu, 30 Jan 2014 13:38:11 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5079432044833911234=="
--===============5079432044833911234==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
--- Comment #1 from Owen Leonard ---
I find these instances of the phrase "tag editor" in .pl and .pm files:
Line 220 of authorities\authorities.pl
Line 252 of authorities\authorities.pl
Line 2833 of C4\Items.pm
Line 398 of cataloguing\addbiblio.pl
Line 427 of cataloguing\addbiblio.pl
Line 238 of cataloguing\additem.pl
Line 255 of cataloguing\additem.pl
Line 404 of tools\batchMod.pl
Line 418 of tools\batchMod.pl
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
--===============5079432044833911234==--
From bugzilla-daemon@bugs.koha-community.org Sat May 3 00:06:29 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 11638] Untranslatable "Tag editor" in addbiblio.pl
Date: Fri, 02 May 2014 22:05:27 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8626029492094043647=="
--===============8626029492094043647==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638
--- Comment #2 from Bernardo Gonzalez Kriegel ---
Created attachment 27922
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27922&action=edit
Bug 11638 - Remove HTML from addbiblio.pl
This patch extracts variables with HTML from addbiblio.pl
and an instance of CGI::scrolling_list
As it changes how MARC editor show input fields, I prefer
not add patches for other cases mentioned on Comment #1
To test:
1. Verify there are no regressions on MARC editor
Add/Edit records, modify values
About the error message on error when deleting biblio,
it must be localized but the script is not trying to
use a template file, only prints a basic html and aborts.
Perhaps a way of handling errors more gracefully is needed,
but again it need to be solved on it's own bug.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
--===============8626029492094043647==--
From bugzilla-daemon@bugs.koha-community.org Sat May 3 00:09:27 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl
Date: Fri, 02 May 2014 22:08:26 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6820965834149997045=="
--===============6820965834149997045==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
CC| |bgkriegel@gmail.com
Component|I18N/L10N |Templates
Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com
|ity.org |
Summary|Untranslatable "Tag editor" |Remove HTML from
|in addbiblio.pl |addbiblio.pl
--- Comment #3 from Bernardo Gonzalez Kriegel ---
Changed Bug description and component
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
--===============6820965834149997045==--
From bugzilla-daemon@bugs.koha-community.org Sun May 4 00:26:29 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl
Date: Sat, 03 May 2014 22:25:16 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1754771049544711434=="
--===============1754771049544711434==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27922|0 |1
is obsolete| |
--- Comment #4 from Bernardo Gonzalez Kriegel ---
Created attachment 27928
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27928&action=edit
Bug 11638 - Remove HTML from addbiblio.pl
This patch extracts variables with HTML from addbiblio.pl
and an instance of CGI::scrolling_list
As it changes how MARC editor show input fields, I prefer
not add patches for other cases mentioned on Comment #1
To test:
1. Verify there are no regressions on MARC editor
Add/Edit records, modify values
2. Update translation file for a language,
check new string 'Tag editor'
About the error message on error when deleting biblio,
it must be localized but the script is not trying to
use a template file, only prints a basic html and aborts.
Perhaps a way of handling errors more gracefully is needed,
but again it need to be solved on it's own bug.
Updated test plan
--
You are receiving this mail because:
You are watching all bug changes.
--===============1754771049544711434==--
From bugzilla-daemon@bugs.koha-community.org Sun May 4 00:30:19 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl
Date: Sat, 03 May 2014 22:29:06 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7984337520585362788=="
--===============7984337520585362788==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |oleonard@myacpl.org
--- Comment #5 from Bernardo Gonzalez Kriegel ---
*** Bug 682 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
--===============7984337520585362788==--
From bugzilla-daemon@bugs.koha-community.org Sun May 4 00:33:15 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl
Date: Sat, 03 May 2014 22:32:02 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4250365790580959180=="
--===============4250365790580959180==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638
--- Comment #6 from Bernardo Gonzalez Kriegel ---
(In reply to Owen Leonard from comment #1)
> I find these instances of the phrase "tag editor" in .pl and .pm files:
>
> Line 238 of cataloguing\additem.pl
> Line 255 of cataloguing\additem.pl
This two in Bug 12176
--
You are receiving this mail because:
You are watching all bug changes.
--===============4250365790580959180==--
From bugzilla-daemon@bugs.koha-community.org Sun May 4 04:12:18 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl
Date: Sun, 04 May 2014 02:11:05 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9134004139507762452=="
--===============9134004139507762452==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638
--- Comment #7 from Bernardo Gonzalez Kriegel ---
(In reply to Owen Leonard from comment #1)
> I find these instances of the phrase "tag editor" in .pl and .pm files:
>
> Line 220 of authorities\authorities.pl
> Line 252 of authorities\authorities.pl
This two in Bug 12177
--
You are receiving this mail because:
You are watching all bug changes.
--===============9134004139507762452==--
From bugzilla-daemon@bugs.koha-community.org Sun May 4 19:35:29 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl
Date: Sun, 04 May 2014 17:34:08 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0324152532832421746=="
--===============0324152532832421746==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638
--- Comment #8 from Bernardo Gonzalez Kriegel ---
(In reply to Owen Leonard from comment #1)
> I find these instances of the phrase "tag editor" in .pl and .pm files:
>
> Line 404 of tools\batchMod.pl
> Line 418 of tools\batchMod.pl
This two in Bug 12180
--
You are receiving this mail because:
You are watching all bug changes.
--===============0324152532832421746==--
From bugzilla-daemon@bugs.koha-community.org Thu May 22 12:37:16 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl
Date: Thu, 22 May 2014 10:34:24 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6960953802896349412=="
--===============6960953802896349412==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=766
--
You are receiving this mail because:
You are watching all bug changes.
--===============6960953802896349412==--
From bugzilla-daemon@bugs.koha-community.org Thu Jul 3 07:17:11 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl
Date: Thu, 03 Jul 2014 05:10:33 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7353304441515159048=="
--===============7353304441515159048==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
--===============7353304441515159048==--
From bugzilla-daemon@bugs.koha-community.org Thu Jul 3 07:17:17 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl
Date: Thu, 03 Jul 2014 05:10:39 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9075483630738802169=="
--===============9075483630738802169==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27928|0 |1
is obsolete| |
--- Comment #9 from Chris Cormack ---
Created attachment 29462
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29462&action=edit
Bug 11638 - Remove HTML from addbiblio.pl
This patch extracts variables with HTML from addbiblio.pl
and an instance of CGI::scrolling_list
As it changes how MARC editor show input fields, I prefer
not add patches for other cases mentioned on Comment #1
To test:
1. Verify there are no regressions on MARC editor
Add/Edit records, modify values
2. Update translation file for a language,
check new string 'Tag editor'
About the error message on error when deleting biblio,
it must be localized but the script is not trying to
use a template file, only prints a basic html and aborts.
Perhaps a way of handling errors more gracefully is needed,
but again it need to be solved on it's own bug.
Updated test plan
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
--===============9075483630738802169==--
From bugzilla-daemon@bugs.koha-community.org Thu Jul 3 17:32:37 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl
Date: Thu, 03 Jul 2014 15:25:52 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5500284288877318502=="
--===============5500284288877318502==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
--===============5500284288877318502==--
From bugzilla-daemon@bugs.koha-community.org Thu Jul 3 17:32:38 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl
Date: Thu, 03 Jul 2014 15:25:54 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7548614792259444181=="
--===============7548614792259444181==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29462|0 |1
is obsolete| |
--- Comment #10 from Kyle M Hall ---
Created attachment 29492
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29492&action=edit
[PASSED QA] Bug 11638 - Remove HTML from addbiblio.pl
This patch extracts variables with HTML from addbiblio.pl
and an instance of CGI::scrolling_list
As it changes how MARC editor show input fields, I prefer
not add patches for other cases mentioned on Comment #1
To test:
1. Verify there are no regressions on MARC editor
Add/Edit records, modify values
2. Update translation file for a language,
check new string 'Tag editor'
About the error message on error when deleting biblio,
it must be localized but the script is not trying to
use a template file, only prints a basic html and aborts.
Perhaps a way of handling errors more gracefully is needed,
but again it need to be solved on it's own bug.
Updated test plan
Signed-off-by: Chris Cormack
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
--===============7548614792259444181==--
From bugzilla-daemon@bugs.koha-community.org Thu Jul 3 20:17:27 2014
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 11638] Remove HTML from addbiblio.pl
Date: Thu, 03 Jul 2014 18:10:43 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8977622848082754380=="
--===============8977622848082754380==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
CC| |tomascohen@gmail.com
--- Comment #11 from Tomás Cohen Arazi ---
Patch pushed to master.
Thanks Bernardo!
--
You are receiving this mail because:
You are watching all bug changes.
--===============8977622848082754380==--