From bugzilla-daemon@bugs.koha-community.org Fri Nov 6 10:58:38 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 26946] New: Limit size of cash register's name on the UI Date: Fri, 06 Nov 2020 09:58:37 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0777055180339482220==" --===============0777055180339482220== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D26946 Bug ID: 26946 Summary: Limit size of cash register's name on the UI Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Staff Client Assignee: martin.renvoize@ptfs-europe.com Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 23321 If you create a new cash register with a "long" (not that long actually) name, the submit form fails with: 2020/11/06 09:56:19] [WARN] DBD::mysql::st execute failed: Data too long for column 'name' at row 1 [for Statement "INSERT INTO `cash_registers` ( `branch= `, `description`, `name`, `starting_float`) VALUES ( ?, ?, ?, ? )" with ParamValues: 0=3D"CPL", 1=3D"", 3=3D"0.00"] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D23321 [Bug 23321] Add 'cash registers' to the accounts system --=20 You are receiving this mail because: You are watching all bug changes. --===============0777055180339482220==-- From bugzilla-daemon@bugs.koha-community.org Fri Nov 6 11:02:04 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 26946] Limit size of cash register's name on the UI Date: Fri, 06 Nov 2020 10:02:03 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1223523650381084236==" --===============1223523650381084236== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26946 --- Comment #1 from Martin Renvoize --- Good catch, I'll take a look now -- You are receiving this mail because: You are watching all bug changes. --===============1223523650381084236==-- From bugzilla-daemon@bugs.koha-community.org Mon Nov 9 14:00:06 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 26946] Limit size of cash register's name on the UI Date: Mon, 09 Nov 2020 13:00:05 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7589968493354907008==" --===============7589968493354907008== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26946 --- Comment #2 from Martin Renvoize --- Created attachment 113310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113310&action=edit Bug 26946: Set maxlength for cash register name The cash register names is limited to 24 characters at the database level and so that restriction should also be reflected in the UI. Test plan 1/ Add or Edit a cash register ( admin > accounts > cash registers ) 2/ Note that you can enter a cash register name longer than 24 characters, but upon save the value is truncated. 3/ Apply patch 4/ Note you can not longer enter a cash register name longer than 24 characters. 5/ Signoff -- You are receiving this mail because: You are watching all bug changes. --===============7589968493354907008==-- From bugzilla-daemon@bugs.koha-community.org Mon Nov 9 14:00:21 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 26946] Limit size of cash register's name on the UI Date: Mon, 09 Nov 2020 13:00:20 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5331212234647297065==" --===============5331212234647297065== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26946 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============5331212234647297065==-- From bugzilla-daemon@bugs.koha-community.org Mon Nov 9 14:00:35 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 26946] Limit size of cash register's name on the UI Date: Mon, 09 Nov 2020 13:00:34 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1939250438500160182==" --===============1939250438500160182== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26946 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. --===============1939250438500160182==-- From bugzilla-daemon@bugs.koha-community.org Tue Nov 10 11:51:12 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 26946] Limit size of cash register's name on the UI Date: Tue, 10 Nov 2020 10:51:12 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6894408919004575667==" --===============6894408919004575667== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26946 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113310|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 113338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113338&action=edit Bug 26946: Set maxlength for cash register name The cash register names is limited to 24 characters at the database level and so that restriction should also be reflected in the UI. Test plan 1/ Add or Edit a cash register ( admin > accounts > cash registers ) 2/ Note that you can enter a cash register name longer than 24 characters, but upon save the value is truncated. 3/ Apply patch 4/ Note you can not longer enter a cash register name longer than 24 characters. 5/ Signoff Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. --===============6894408919004575667==-- From bugzilla-daemon@bugs.koha-community.org Tue Nov 10 11:51:58 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 26946] Limit size of cash register's name on the UI Date: Tue, 10 Nov 2020 10:51:57 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8995755522147286960==" --===============8995755522147286960== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26946 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #4 from Sally --- Works perfectly, signed off. -- You are receiving this mail because: You are watching all bug changes. --===============8995755522147286960==-- From bugzilla-daemon@bugs.koha-community.org Sat Nov 28 12:56:21 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 26946] Limit size of cash register's name on the UI Date: Sat, 28 Nov 2020 11:56:19 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7928713697997568750==" --===============7928713697997568750== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26946 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | CC| |victor@tuxayo.net --- Comment #5 from Victor Grousset/tuxayo --- Is ther -- You are receiving this mail because: You are watching all bug changes. --===============7928713697997568750==-- From bugzilla-daemon@bugs.koha-community.org Sat Nov 28 18:52:29 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 26946] Limit size of cash register's name on the UI Date: Sat, 28 Nov 2020 17:52:27 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0308122554929760035==" --===============0308122554929760035== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26946 --- Comment #6 from Victor Grousset/tuxayo --- Is there a reason to limit the size of the description? The database type is a LONGTEXT (2147483647). And also, the initial float limit is actually 22 before the decimal (number (28,6)) -- You are receiving this mail because: You are watching all bug changes. --===============0308122554929760035==-- From bugzilla-daemon@bugs.koha-community.org Mon Dec 7 17:49:06 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 26946] Limit size of cash register's name on the UI Date: Mon, 07 Dec 2020 16:49:05 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6178681602364966015==" --===============6178681602364966015== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D26946 --- Comment #7 from Martin Renvoize --- (In reply to Victor Grousset/tuxayo from comment #6) > Is there a reason to limit the size of the description? The database type is > a LONGTEXT (2147483647). And also, the initial float limit is actually 22 > before the decimal (number (28,6)) We're only setting 'length' and not 'maxlength' for description.. it's purely= a styleing thing to keep the two text boxes lined up, it doesn't actually limit the input in the description case. --=20 You are receiving this mail because: You are watching all bug changes. --===============6178681602364966015==-- From bugzilla-daemon@bugs.koha-community.org Tue Dec 8 21:20:57 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 26946] Limit size of cash register's name on the UI Date: Tue, 08 Dec 2020 20:20:56 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2227978773593949631==" --===============2227978773593949631== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26946 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113338|0 |1 is obsolete| | --- Comment #8 from Victor Grousset/tuxayo --- Created attachment 114269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114269&action=edit Bug 26946: Set maxlength for cash register name The cash register names is limited to 24 characters at the database level and so that restriction should also be reflected in the UI. Test plan 1/ Add or Edit a cash register ( admin > accounts > cash registers ) 2/ Note that you can enter a cash register name longer than 24 characters, but upon save the value is truncated. 3/ Apply patch 4/ Note you can not longer enter a cash register name longer than 24 characters. 5/ Signoff Signed-off-by: Sally Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. --===============2227978773593949631==-- From bugzilla-daemon@bugs.koha-community.org Tue Dec 8 21:23:37 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 26946] Limit size of cash register's name on the UI Date: Tue, 08 Dec 2020 20:23:36 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8854518417048546444==" --===============8854518417048546444== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26946 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Victor Grousset/tuxayo --- (In reply to Martin Renvoize from comment #7) > We're only setting 'length' and not 'maxlength' for description.. Indeed! I forgot about that one, thanks. So, works as expected and no QA issue ^^ -- You are receiving this mail because: You are watching all bug changes. --===============8854518417048546444==-- From bugzilla-daemon@bugs.koha-community.org Wed Dec 9 11:54:12 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 26946] Limit size of cash register's name on the UI Date: Wed, 09 Dec 2020 10:53:22 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5258940058475916279==" --===============5258940058475916279== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26946 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. --===============5258940058475916279==-- From bugzilla-daemon@bugs.koha-community.org Wed Dec 9 11:54:23 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 26946] Limit size of cash register's name on the UI Date: Wed, 09 Dec 2020 10:53:23 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5609201520676727391==" --===============5609201520676727391== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D26946 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! --=20 You are receiving this mail because: You are watching all bug changes. --===============5609201520676727391==-- From bugzilla-daemon@bugs.koha-community.org Thu Dec 10 11:30:32 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 26946] Limit size of cash register's name on the UI Date: Thu, 10 Dec 2020 10:30:32 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8182194224618293787==" --===============8182194224618293787== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26946 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.01 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. --===============8182194224618293787==-- From bugzilla-daemon@bugs.koha-community.org Thu Dec 17 15:41:40 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 26946] Limit size of cash register's name on the UI Date: Thu, 17 Dec 2020 14:41:39 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6709806436284172534==" --===============6709806436284172534== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26946 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01,20.05.07 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. --===============6709806436284172534==-- From bugzilla-daemon@bugs.koha-community.org Thu Dec 17 17:36:00 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 26946] Limit size of cash register's name on the UI Date: Thu, 17 Dec 2020 16:35:59 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3003568068358788380==" --===============3003568068358788380== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26946 --- Comment #13 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. --===============3003568068358788380==-- From bugzilla-daemon@bugs.koha-community.org Thu Dec 17 17:36:10 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 26946] Limit size of cash register's name on the UI Date: Thu, 17 Dec 2020 16:36:07 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1999386030879732198==" --===============1999386030879732198== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26946 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. --===============1999386030879732198==--