From bugzilla-daemon@bugs.koha-community.org Fri Dec 22 15:32:08 2017 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 19875] New: When & is in the title of a search result, subscribing via rss can be broken Date: Fri, 22 Dec 2017 14:32:04 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4806658969128483188==" --===============4806658969128483188== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875 Bug ID: 19875 Summary: When & is in the title of a search result, subscribing via rss can be broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: christophe.croullebois@biblibre.com QA Contact: testopia@bugs.koha-community.org This issue is not in all cases (depend on many factors). It is due to the xml syntax where the use of "&" is forbidden and must be "&" Koha do the job in this line : [% SEARCH_RESULT.title |html %]....... With the use of "|html" But not in this line : Place Hold on <i>[% SEARCH_RESULT.title %]</i>...... The patch is very light just adds "|html" in the line above. ################# Test Plan : 1° in opac do a search where you can find "&" in the title 2° in the result page click on the rss button on the right of "Your search returned n results." (Subscribe to this search) 3° if your subscribe is ok you can not perform the test :o( 4° if your subscribe is nok you can apply the patch 5° test the same work flow with the patch the subscribe must be ok. Thx -- You are receiving this mail because: You are watching all bug changes. --===============4806658969128483188==-- From bugzilla-daemon@bugs.koha-community.org Fri Dec 22 17:54:42 2017 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 19875] When & is in the title of a search result, subscribing via rss can be broken Date: Fri, 22 Dec 2017 16:54:21 +0000 Message-ID: <bug-19875-70-XScDtWIQw9@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5498041565300021407==" --===============5498041565300021407== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D19875 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org>= --- Hi Christophe, do you plan to attach a patch? --=20 You are receiving this mail because: You are watching all bug changes. --===============5498041565300021407==-- From bugzilla-daemon@bugs.koha-community.org Tue Dec 26 15:02:01 2017 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 19875] When & is in the title of a search result, subscribing via rss can be broken Date: Tue, 26 Dec 2017 14:01:39 +0000 Message-ID: <bug-19875-70-HBujTVg4IC@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4124112539581907718==" --===============4124112539581907718== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D19875 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois@bibl | |ibre.com Assignee|oleonard@myacpl.org |christophe.croullebois@bibl | |ibre.com Status|NEW |Needs Signoff --- Comment #2 from Christophe Croullebois <christophe.croullebois@biblibre.c= om> --- Created attachment 70155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D70155&action=3D= edit patch thx to test --=20 You are receiving this mail because: You are watching all bug changes. --===============4124112539581907718==-- From bugzilla-daemon@bugs.koha-community.org Tue Dec 26 15:03:08 2017 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 19875] When & is in the title of a search result, subscribing via rss can be broken Date: Tue, 26 Dec 2017 14:03:05 +0000 Message-ID: <bug-19875-70-PQuQMnL4hy@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5818354006430017914==" --===============5818354006430017914== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D19875 --- Comment #3 from Christophe Croullebois <christophe.croullebois@biblibre.c= om> --- (In reply to Jonathan Druart from comment #1) > Hi Christophe, do you plan to attach a patch? Hi Jonathan, done, thx --=20 You are receiving this mail because: You are watching all bug changes. --===============5818354006430017914==-- From bugzilla-daemon@bugs.koha-community.org Sat Jan 13 00:41:59 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 19875] When & is in the title of a search result, subscribing via rss can be broken Date: Fri, 12 Jan 2018 23:41:37 +0000 Message-ID: <bug-19875-70-HpLjaL3zwn@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5776337676148022249==" --===============5776337676148022249== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roch.damour@inlibro.com --- Comment #4 from Roch D'Amour <roch.damour@inlibro.com> --- I applied the patch, searched for results with a "&" in the title, and subscribed to the RSS feed. The feed show up, but I only get entrys up untill the records with the "&" in the title. After this records, nothing else show up. I followed the test plan, and I was wondering what do you meant by "subscribe is ok | nok"? -- You are receiving this mail because: You are watching all bug changes. --===============5776337676148022249==-- From bugzilla-daemon@bugs.koha-community.org Thu Jan 25 11:39:45 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 19875] When & is in the title of a search result, subscribing via rss can be broken Date: Thu, 25 Jan 2018 10:39:42 +0000 Message-ID: <bug-19875-70-qtJ5au6bgc@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8256331755397722265==" --===============8256331755397722265== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D19875 --- Comment #5 from Christophe Croullebois <christophe.croullebois@biblibre.c= om> --- (In reply to Roch D'Amour from comment #4) > I applied the patch, searched for results with a "&" in the title, and > subscribed to the RSS feed. The feed show up, but I only get entrys up > untill the records with the "&" in the title. After this records, nothing > else show up. I followed the test plan, and I was wondering what do you > meant by "subscribe is ok | nok"? Hello, what you describe is the result without patch =3D>nok Effectively if you have 10 result in the search and if a title with "&" is in the row 5, you'll see only the 5 firt rows. After applying the patch you'll see the 10 result and your subscribe must be = ok (you can see links active in your browser). Hoping be clearer. Thx for your test Regards --=20 You are receiving this mail because: You are watching all bug changes. --===============8256331755397722265==-- From bugzilla-daemon@bugs.koha-community.org Thu Jan 25 11:49:32 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 19875] When & is in the title of a search result, subscribing via rss can be broken Date: Thu, 25 Jan 2018 10:49:08 +0000 Message-ID: <bug-19875-70-qLQI2r73vo@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5698950702284493167==" --===============5698950702284493167== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D19875 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70155|0 |1 is obsolete| | --- Comment #6 from Christophe Croullebois <christophe.croullebois@biblibre.c= om> --- Created attachment 70911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D70911&action=3D= edit Bug 19875: escape & in rss feed --=20 You are receiving this mail because: You are watching all bug changes. --===============5698950702284493167==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 27 16:17:49 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 19875] When & is in the title of a search result, subscribing via rss can be broken Date: Tue, 27 Feb 2018 15:17:44 +0000 Message-ID: <bug-19875-70-3PgNwJ4Rvb@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3478923508873591026==" --===============3478923508873591026== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Christophe, I am not sure why, but your change breaks the rendering of the RSS is in the browser for me. :( -- You are receiving this mail because: You are watching all bug changes. --===============3478923508873591026==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 27 16:39:51 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 19875] When & is in the title of a search result, subscribing via rss can be broken Date: Tue, 27 Feb 2018 15:39:47 +0000 Message-ID: <bug-19875-70-hlEYMH0a1A@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5100295235782937894==" --===============5100295235782937894== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D19875 --- Comment #8 from Christophe Croullebois <christophe.croullebois@biblibre.c= om> --- (In reply to Katrin Fischer from comment #7) > Hi Christophe,=20 >=20 > I am not sure why, but your change breaks the rendering of the RSS is in the > browser for me. :( Hi Katrin, in fact I had to close this one because now it is obsolete due to 19568 and h= is correction on 20286. I have seen when reporting 20286 that there is no more issues with the '&'. So I close this one, thx Katrine. --=20 You are receiving this mail because: You are watching all bug changes. --===============5100295235782937894==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 27 16:40:24 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 19875] When & is in the title of a search result, subscribing via rss can be broken Date: Tue, 27 Feb 2018 15:40:10 +0000 Message-ID: <bug-19875-70-eblq32VmS5@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4192859748400487865==" --===============4192859748400487865== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. --===============4192859748400487865==--