From bugzilla-daemon@bugs.koha-community.org Thu Jun 27 15:35:55 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23227] New: Remove type attribute from script	tags: Reports
Date: Thu, 27 Jun 2019 13:35:50 +0000
Message-ID: <bug-23227-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4773419483591624262=="

--===============4773419483591624262==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227

            Bug ID: 23227
           Summary: Remove type attribute from script tags: Reports
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Keywords: Academy
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard@myacpl.org
          Reporter: oleonard@myacpl.org
        QA Contact: testopia@bugs.koha-community.org
                CC: testopia@bugs.koha-community.org
            Blocks: 22956

This patch will remove the obsolete "type" attribute from <script> tags in the
following reports templates:

 - intranet-tmpl\prog\en\modules\reports\dictionary.tt
 - intranet-tmpl\prog\en\modules\reports\itemslost.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22956
[Bug 22956] Omnibus: Remove type attribute from script tags
-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4773419483591624262==--


From bugzilla-daemon@bugs.koha-community.org Thu Jun 27 15:47:10 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23227] Remove type attribute from script tags:	Reports
Date: Thu, 27 Jun 2019 13:47:07 +0000
Message-ID: <bug-23227-70-j82vMhsqG3@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23227-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2541890611055483169=="

--===============2541890611055483169==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2541890611055483169==--


From bugzilla-daemon@bugs.koha-community.org Thu Jun 27 15:47:15 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23227] Remove type attribute from script tags:	Reports
Date: Thu, 27 Jun 2019 13:47:09 +0000
Message-ID: <bug-23227-70-IEYUMFObKq@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23227-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7406631397849743992=="

--===============7406631397849743992==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227

--- Comment #1 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 91054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91054&action=edit
Bug 23227: Remove type attribute from script tags: Reports

This patch removes the "type" attribute from <script> tags in two
reports templates.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Reports -> Dictionary
   - Delete
   - Specifying a date range for a date column
 - Reports -> Items lost
   - Report results
     -> Datatables functionality
     -> Selection tools for export

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7406631397849743992==--


From bugzilla-daemon@bugs.koha-community.org Thu Jul  4 21:16:14 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23227] Remove type attribute from script tags:	Reports
Date: Thu, 04 Jul 2019 19:16:11 +0000
Message-ID: <bug-23227-70-GRIVOkVk4B@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23227-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6544414934513121185=="

--===============6544414934513121185==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227

M. Tompsett <mtompset@hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6544414934513121185==--


From bugzilla-daemon@bugs.koha-community.org Thu Jul  4 21:16:17 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23227] Remove type attribute from script tags:	Reports
Date: Thu, 04 Jul 2019 19:16:13 +0000
Message-ID: <bug-23227-70-hiceWhYQGI@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23227-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8800721204764590293=="

--===============8800721204764590293==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227

M. Tompsett <mtompset@hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91054|0                           |1
        is obsolete|                            |

--- Comment #2 from M. Tompsett <mtompset@hotmail.com> ---
Created attachment 91299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91299&action=edit
Bug 23227: Remove type attribute from script tags: Reports

This patch removes the "type" attribute from <script> tags in two
reports templates.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Reports -> Dictionary
   - Delete
   - Specifying a date range for a date column
 - Reports -> Items lost
   - Report results
     -> Datatables functionality
     -> Selection tools for export

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8800721204764590293==--


From bugzilla-daemon@bugs.koha-community.org Fri Jul  5 20:15:35 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23227] Remove type attribute from script tags:	Reports
Date: Fri, 05 Jul 2019 18:15:32 +0000
Message-ID: <bug-23227-70-VE1ZlUVVY6@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23227-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1449236821996757914=="

--===============1449236821996757914==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227

Bin Wen <bin.wen@inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91299|0                           |1
        is obsolete|                            |

--- Comment #3 from Bin Wen <bin.wen@inlibro.com> ---
Created attachment 91352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91352&action=edit
Bug 23227: Remove type attribute from script tags: Reports

This patch removes the "type" attribute from <script> tags in two
reports templates.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Reports -> Dictionary
   - Delete
   - Specifying a date range for a date column
 - Reports -> Items lost
   - Report results
     -> Datatables functionality
     -> Selection tools for export

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Bin Wen <bin.wen@inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1449236821996757914==--


From bugzilla-daemon@bugs.koha-community.org Fri Jul  5 20:17:16 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23227] Remove type attribute from script tags:	Reports
Date: Fri, 05 Jul 2019 18:17:09 +0000
Message-ID: <bug-23227-70-YtqQdRkq9n@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23227-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0400691535500934282=="

--===============0400691535500934282==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227

Frédérik Chénier <frederik.chenier@inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91352|0                           |1
        is obsolete|                            |

--- Comment #4 from Frédérik Chénier <frederik.chenier@inlibro.com> ---
Created attachment 91353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91353&action=edit
Bug 23227: Remove type attribute from script tags: Reports

This patch removes the "type" attribute from <script> tags in two
reports templates.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Reports -> Dictionary
   - Delete
   - Specifying a date range for a date column
 - Reports -> Items lost
   - Report results
     -> Datatables functionality
     -> Selection tools for export

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: frederik chenier <frederik.chenier@inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0400691535500934282==--


From bugzilla-daemon@bugs.koha-community.org Sat Jul  6 11:20:43 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23227] Remove type attribute from script tags:	Reports
Date: Sat, 06 Jul 2019 09:20:40 +0000
Message-ID: <bug-23227-70-hEG9NdgIIw@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23227-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9010153274782323582=="

--===============9010153274782323582==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============9010153274782323582==--


From bugzilla-daemon@bugs.koha-community.org Sat Jul  6 11:20:49 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23227] Remove type attribute from script tags:	Reports
Date: Sat, 06 Jul 2019 09:20:45 +0000
Message-ID: <bug-23227-70-9joBOxtKII@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23227-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6264938145734231267=="

--===============6264938145734231267==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91353|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 91387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91387&action=edit
Bug 23227: Remove type attribute from script tags: Reports

This patch removes the "type" attribute from <script> tags in two
reports templates.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Reports -> Dictionary
   - Delete
   - Specifying a date range for a date column
 - Reports -> Items lost
   - Report results
     -> Datatables functionality
     -> Selection tools for export

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: frederik chenier <frederik.chenier@inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6264938145734231267==--


From bugzilla-daemon@bugs.koha-community.org Mon Jul 15 13:23:16 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23227] Remove type attribute from script tags:	Reports
Date: Mon, 15 Jul 2019 11:22:19 +0000
Message-ID: <bug-23227-70-LBPjXMnIA1@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23227-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0084917235969147355=="

--===============0084917235969147355==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227

--- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0084917235969147355==--


From bugzilla-daemon@bugs.koha-community.org Mon Jul 15 13:23:16 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23227] Remove type attribute from script tags:	Reports
Date: Mon, 15 Jul 2019 11:22:17 +0000
Message-ID: <bug-23227-70-5PfLoLKzDX@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23227-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0177004410272971570=="

--===============0177004410272971570==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227

Martin Renvoize <martin.renvoize@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |19.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0177004410272971570==--


From bugzilla-daemon@bugs.koha-community.org Tue Jul 30 07:41:35 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23227] Remove type attribute from script tags:	Reports
Date: Tue, 30 Jul 2019 05:41:33 +0000
Message-ID: <bug-23227-70-B9aRThEGri@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23227-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6381966405670160240=="

--===============6381966405670160240==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227

Fridolin SOMERS <fridolin.somers@biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers@biblibre.co
                   |                            |m
         Version(s)|19.11.00                    |19.11.00,19.05.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> ---
Pushed to 19.05.x for 19.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6381966405670160240==--


From bugzilla-daemon@bugs.koha-community.org Tue Aug  6 18:24:41 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23227] Remove type attribute from script tags: Reports
Date: Tue, 06 Aug 2019 16:24:40 +0000
Message-ID: <bug-23227-70-CzVrZMGLjg@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23227-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3161708829579611409=="

--===============3161708829579611409==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227

Lucas Gass <lucas@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas@bywatersolutions.com

--- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> ---
backported to 18.11.x for 18.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3161708829579611409==--