From bugzilla-daemon@bugs.koha-community.org Thu Feb 12 14:30:49 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] New: Translated item search not working Date: Thu, 12 Feb 2015 13:30:43 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0670884394547720291==" --===============0670884394547720291== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D13700 Bug ID: 13700 Summary: Translated item search not working Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Testing the new item search from available from the advanced search page in t= he staff client I found it only working in English, but not in its German translation. This is a 3.18.3 installation with current templates. The Javascript errors shown in Firebug are very unspecific - I haven't been able yet to find the source of the problem. Any help much appreciated. --=20 You are receiving this mail because: You are watching all bug changes. --===============0670884394547720291==-- From bugzilla-daemon@bugs.koha-community.org Thu Feb 12 14:31:02 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Thu, 12 Feb 2015 13:30:59 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6440240254576450397==" --===============6440240254576450397== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes. --===============6440240254576450397==-- From bugzilla-daemon@bugs.koha-community.org Thu Feb 12 18:17:31 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Thu, 12 Feb 2015 17:17:26 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6470937512858931405==" --===============6470937512858931405== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D13700 --- Comment #1 from Owen Leonard --- I see this problem too. I checked out 3.18.3, installed and switched to the German templates, and tried the item search. The search results table never renders. I don't see any errors in the Firebug console, but looking at the da= ta being sent to DataTables I see some differences in the English versus the German output. English: [ "Endless ocean by ", "", "Nintendo of America,", "", "33000000094272", "Wii Endless", "The Plains", "The Plains", "", "", "", "0", "Edit" ] German: [ "Endless ocean von ", "", "Nintendo of America,", "", "33000000094272", "Wii Endless", "The Plains", "The Plains", "", "", "", "0", "Bearbeiten" ] In the German version the quotes around HTML attributes are double quotes instead of the single quotes seen in the English version. I assume that is wh= at is breaking things. --=20 You are receiving this mail because: You are watching all bug changes. --===============6470937512858931405==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 13 09:36:41 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Fri, 13 Feb 2015 08:36:38 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5529174141945849477==" --===============5529174141945849477== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 --- Comment #2 from Katrin Fischer --- Thx Owen for taking the time to look at this! I fixed a few problems with the strings, but it still doesn't work. And the problem with the quotes does not seem to exist in the po file? I went through all strings for this template, but had no luck finding anything that would explain it. -- You are receiving this mail because: You are watching all bug changes. --===============5529174141945849477==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 13 09:48:44 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Fri, 13 Feb 2015 08:48:41 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7341293672043810619==" --===============7341293672043810619== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 --- Comment #3 from Katrin Fischer --- I think this appears to be a problem with the translation script. It appears other translations that I tested this with are not complete - only in the German version of the file some things appear as translated, but not in fr-FR, nb-NO etc. -- You are receiving this mail because: You are watching all bug changes. --===============7341293672043810619==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 13 09:56:06 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Fri, 13 Feb 2015 08:56:02 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0883179231782885536==" --===============0883179231782885536== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 --- Comment #4 from Katrin Fischer --- The problem also exists in the more complete es-ES translation. -- You are receiving this mail because: You are watching all bug changes. --===============0883179231782885536==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 13 09:56:17 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Fri, 13 Feb 2015 08:56:15 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7990498218844609845==" --===============7990498218844609845== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com, | |frederic@tamil.fr Component|Searching |I18N/L10N Assignee|gmcharlt@gmail.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============7990498218844609845==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 13 10:02:11 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Fri, 13 Feb 2015 09:02:06 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7885392090957070897==" --===============7885392090957070897== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============7885392090957070897==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 13 10:42:31 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Fri, 13 Feb 2015 09:42:28 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4581983375035810073==" --===============4581983375035810073== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 --- Comment #5 from Julian Maurice --- I think there is two different ways to fix this: 1/ Fix tmpl_process3.pl to put the same quotes (single or double) as in the original file 2/ exclude includes/catalogue/itemsearch_item.json.inc from the list of files to translate (by changing its extension ?) and use Koha::I18N for translatable text in this file My preferences goes to 2. What do you think ? -- You are receiving this mail because: You are watching all bug changes. --===============4581983375035810073==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 13 10:57:59 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Fri, 13 Feb 2015 09:57:52 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2650113547732868595==" --===============2650113547732868595== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D13700 --- Comment #6 from Julian Maurice --- Template parsing is done by HTML::Parser and I can't find in the doc how to know if attributes values were specified with single or double quotes. So may= be (1) is not even a solution. --=20 You are receiving this mail because: You are watching all bug changes. --===============2650113547732868595==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 13 11:32:36 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Fri, 13 Feb 2015 10:32:34 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8623305003367470730==" --===============8623305003367470730== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 --- Comment #7 from Katrin Fischer --- Hm, What about 3)? Could we rewrite the file in a way, that will avoid the multiple quotes? Like building the string separately and then using a variable? -- You are receiving this mail because: You are watching all bug changes. --===============8623305003367470730==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 13 11:33:47 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Fri, 13 Feb 2015 10:33:42 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8732128351408644641==" --===============8732128351408644641== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 --- Comment #8 from Katrin Fischer --- I think changing the file ending would work - I have used this trick to avoid auto-translations in some other place in the past. But not a 'nice' solution. -- You are receiving this mail because: You are watching all bug changes. --===============8732128351408644641==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 13 12:28:18 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Fri, 13 Feb 2015 11:28:15 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1904808034453762664==" --===============1904808034453762664== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 --- Comment #9 from Julian Maurice --- (2) will fail anyway, in case the translated string contains single quotes ... :/ -- You are receiving this mail because: You are watching all bug changes. --===============1904808034453762664==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 13 13:37:27 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Fri, 13 Feb 2015 12:37:20 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7500063720211357487==" --===============7500063720211357487== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 --- Comment #10 from Julian Maurice --- Created attachment 35897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35897&action=edit Bug 13700: Fix item search templates for translation Since translator rebuild HTML tags with double quotes for attributes values, use double quotes in english template too and escape them with backslash. -- You are receiving this mail because: You are watching all bug changes. --===============7500063720211357487==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 13 13:37:37 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Fri, 13 Feb 2015 12:37:33 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0108802994912563549==" --===============0108802994912563549== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============0108802994912563549==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 13 13:46:00 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Fri, 13 Feb 2015 12:45:55 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0360382618467691536==" --===============0360382618467691536== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 --- Comment #11 from Katrin Fischer --- Yay! Thx Julian! -- You are receiving this mail because: You are watching all bug changes. --===============0360382618467691536==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 13 14:49:32 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Fri, 13 Feb 2015 13:49:26 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4616743442577159644==" --===============4616743442577159644== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35897|0 |1 is obsolete| | --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 35899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35899&action=edit [SIGNED-OFF] Bug 13700: Fix item search templates for translation Since translator rebuild HTML tags with double quotes for attributes values, use double quotes in english template too and escape them with backslash. Signed-off-by: Bernardo Gonzalez Kriegel It works well!! Test: 1) Intall translation (de-DE, es-ES) 2) to Go to item search, in english, do a search that gives results 3) Switch language, repeat search, result's table does not render 4) Apply patch 5) Install translation again 6) Repeat 3, now results are displayed No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. --===============4616743442577159644==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 13 14:49:50 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Fri, 13 Feb 2015 13:49:44 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1122366172158687419==" --===============1122366172158687419== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============1122366172158687419==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 13 16:47:06 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Fri, 13 Feb 2015 15:46:24 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5179981984000411158==" --===============5179981984000411158== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35899|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 35907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35907&action=edit [PASSED QA] Bug 13700: Fix item search templates for translation Since translator rebuild HTML tags with double quotes for attributes values, use double quotes in english template too and escape them with backslash. Signed-off-by: Bernardo Gonzalez Kriegel It works well!! Test: 1) Intall translation (de-DE, es-ES) 2) to Go to item search, in english, do a search that gives results 3) Switch language, repeat search, result's table does not render 4) Apply patch 5) Install translation again 6) Repeat 3, now results are displayed No koha-qa errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. --===============5179981984000411158==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 13 16:47:29 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Fri, 13 Feb 2015 15:46:22 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3066389069400985056==" --===============3066389069400985056== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============3066389069400985056==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 17 03:45:42 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Tue, 17 Feb 2015 02:45:39 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3104493722625857598==" --===============3104493722625857598== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #14 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Julian! -- You are receiving this mail because: You are watching all bug changes. --===============3104493722625857598==-- From bugzilla-daemon@bugs.koha-community.org Sun Feb 22 23:57:09 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Sun, 22 Feb 2015 22:57:02 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1889294284874027582==" --===============1889294284874027582== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #15 from Chris Cormack --- String changes, held for 3.18.5 -- You are receiving this mail because: You are watching all bug changes. --===============1889294284874027582==-- From bugzilla-daemon@bugs.koha-community.org Sun Mar 1 03:27:51 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 13700] Translated item search not working Date: Sun, 01 Mar 2015 02:27:45 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7780612378770378357==" --===============7780612378770378357== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #16 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.5 -- You are receiving this mail because: You are watching all bug changes. --===============7780612378770378357==--