From bugzilla-daemon@bugs.koha-community.org Fri Nov  6 19:36:54 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26960] New: Move batch item modification template
 JavaScript to the footer
Date: Fri, 06 Nov 2020 18:36:53 +0000
Message-ID: <bug-26960-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8257787527656852526=="

--===============8257787527656852526==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960

            Bug ID: 26960
           Summary: Move batch item modification template JavaScript to
                    the footer
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard@myacpl.org
          Reporter: oleonard@myacpl.org
        QA Contact: testopia@bugs.koha-community.org
                CC: testopia@bugs.koha-community.org
        Depends on: 26959

In order to conform to best practices for performance, staff client template
JavaScript should be in the footer instead of the header.

This patch will do so for the batch item modification template.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26959
[Bug 26959] Reindent batch item modification template
-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8257787527656852526==--


From bugzilla-daemon@bugs.koha-community.org Fri Nov  6 21:02:53 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26960] Move batch item modification template
 JavaScript to the footer
Date: Fri, 06 Nov 2020 20:02:52 +0000
Message-ID: <bug-26960-70-T590OdHwqj@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26960-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7229251226855036098=="

--===============7229251226855036098==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7229251226855036098==--


From bugzilla-daemon@bugs.koha-community.org Fri Nov  6 21:03:03 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26960] Move batch item modification template
 JavaScript to the footer
Date: Fri, 06 Nov 2020 20:02:55 +0000
Message-ID: <bug-26960-70-dhqYa4E0GG@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26960-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7572010877388834600=="

--===============7572010877388834600==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960

--- Comment #1 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 113280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113280&action=edit
Bug 26960: Move batch item modification template JavaScript to the footer

This patch modifies the batch item modification template so that the
JavaScript is in the footer, conforming with best practices.

The items form can contain <script> tags injected by cataloging plugins.
These are moved from the body of the page into the footer be repeating
the template loop that previously output the script tag.

To test, apply the patch and test the process of submitting items for
batch modification.

After submitting a batch of items, test the "Edit items" form.
Confirm that JavaScript-dependent interactions work correctly:

 - Select2-styled dropdowns
 - RegEx checkboxes
 - Datepicker
 - Plugins like:
   - dateaccessioned.pl on 952d
   - stocknumberam123.pl on 952i
   - callnumber.pl on 952o

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7572010877388834600==--


From bugzilla-daemon@bugs.koha-community.org Wed Feb  3 16:03:38 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26960] Move batch item modification template
 JavaScript to the footer
Date: Wed, 03 Feb 2021 15:03:37 +0000
Message-ID: <bug-26960-70-SAeP66mkY4@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26960-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0000709360298214976=="

--===============0000709360298214976==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #113280|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 116266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116266&action=edit
Bug 26960: Move batch item modification template JavaScript to the footer

This patch modifies the batch item modification template so that the
JavaScript is in the footer, conforming with best practices.

The items form can contain <script> tags injected by cataloging plugins.
These are moved from the body of the page into the footer be repeating
the template loop that previously output the script tag.

To test, apply the patch and test the process of submitting items for
batch modification.

After submitting a batch of items, test the "Edit items" form.
Confirm that JavaScript-dependent interactions work correctly:

 - Select2-styled dropdowns
 - RegEx checkboxes
 - Datepicker
 - Plugins like:
   - dateaccessioned.pl on 952d
   - stocknumberam123.pl on 952i
   - callnumber.pl on 952o

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0000709360298214976==--


From bugzilla-daemon@bugs.koha-community.org Thu Feb 25 01:59:32 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26960] Move batch item modification template
 JavaScript to the footer
Date: Thu, 25 Feb 2021 00:59:31 +0000
Message-ID: <bug-26960-70-mT0TKHXFEI@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26960-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2697224087883040652=="

--===============2697224087883040652==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960

David Nind <david@davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2697224087883040652==--


From bugzilla-daemon@bugs.koha-community.org Thu Feb 25 01:59:42 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26960] Move batch item modification template
 JavaScript to the footer
Date: Thu, 25 Feb 2021 00:59:34 +0000
Message-ID: <bug-26960-70-oSasICm2Y1@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26960-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0169044850014458036=="

--===============0169044850014458036==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960

David Nind <david@davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116266|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david@davidnind.com> ---
Created attachment 117285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117285&action=edit
Bug 26960: Move batch item modification template JavaScript to the footer

This patch modifies the batch item modification template so that the
JavaScript is in the footer, conforming with best practices.

The items form can contain <script> tags injected by cataloging plugins.
These are moved from the body of the page into the footer be repeating
the template loop that previously output the script tag.

To test, apply the patch and test the process of submitting items for
batch modification.

After submitting a batch of items, test the "Edit items" form.
Confirm that JavaScript-dependent interactions work correctly:

 - Select2-styled dropdowns
 - RegEx checkboxes
 - Datepicker
 - Plugins like:
   - dateaccessioned.pl on 952d
   - stocknumberam123.pl on 952i
   - callnumber.pl on 952o

Signed-off-by: David Nind <david@davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0169044850014458036==--


From bugzilla-daemon@bugs.koha-community.org Sun Feb 28 18:28:05 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26960] Move batch item modification template
 JavaScript to the footer
Date: Sun, 28 Feb 2021 17:28:04 +0000
Message-ID: <bug-26960-70-snxz6GbeW1@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26960-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1836472881312352880=="

--===============1836472881312352880==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1836472881312352880==--


From bugzilla-daemon@bugs.koha-community.org Sun Feb 28 18:28:15 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26960] Move batch item modification template
 JavaScript to the footer
Date: Sun, 28 Feb 2021 17:28:07 +0000
Message-ID: <bug-26960-70-AklZvrTV6v@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26960-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4639640068619854980=="

--===============4639640068619854980==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117285|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 117417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117417&action=edit
Bug 26960: Move batch item modification template JavaScript to the footer

This patch modifies the batch item modification template so that the
JavaScript is in the footer, conforming with best practices.

The items form can contain <script> tags injected by cataloging plugins.
These are moved from the body of the page into the footer be repeating
the template loop that previously output the script tag.

To test, apply the patch and test the process of submitting items for
batch modification.

After submitting a batch of items, test the "Edit items" form.
Confirm that JavaScript-dependent interactions work correctly:

 - Select2-styled dropdowns
 - RegEx checkboxes
 - Datepicker
 - Plugins like:
   - dateaccessioned.pl on 952d
   - stocknumberam123.pl on 952i
   - callnumber.pl on 952o

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4639640068619854980==--


From bugzilla-daemon@bugs.koha-community.org Sun Feb 28 18:29:18 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26960] Move batch item modification template
 JavaScript to the footer
Date: Sun, 28 Feb 2021 17:29:18 +0000
Message-ID: <bug-26960-70-FuKh6pxUWF@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26960-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8192541004508176189=="

--===============8192541004508176189==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960

--- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
This works well in my tests. 

There is only one small glitch: with and without the patch the pull down for
the Yes/No for local holds priority is too short to fit the text. Not relevant
for this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8192541004508176189==--


From bugzilla-daemon@bugs.koha-community.org Thu Mar  4 17:26:44 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26960] Move batch item modification template
 JavaScript to the footer
Date: Thu, 04 Mar 2021 16:25:20 +0000
Message-ID: <bug-26960-70-b32HsalWg3@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26960-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9206204677675623862=="

--===============9206204677675623862==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960

Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============9206204677675623862==--


From bugzilla-daemon@bugs.koha-community.org Thu Mar  4 17:26:54 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26960] Move batch item modification template
 JavaScript to the footer
Date: Thu, 04 Mar 2021 16:25:22 +0000
Message-ID: <bug-26960-70-W4cf4ro2cr@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26960-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2461081363225817319=="

--===============2461081363225817319==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D26960

--- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org>=
 ---
Pushed to master for 21.05, thanks to everybody involved!

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============2461081363225817319==--


From bugzilla-daemon@bugs.koha-community.org Mon Mar  8 16:39:10 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26960] Move batch item modification template
 JavaScript to the footer
Date: Mon, 08 Mar 2021 15:39:09 +0000
Message-ID: <bug-26960-70-dfaM1OiRww@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26960-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0590683577429347166=="

--===============0590683577429347166==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960

Fridolin Somers <fridolin.somers@biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers@biblibre.co
                   |                            |m

--- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> ---
Enhancement not pushed to 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0590683577429347166==--