From bugzilla-daemon@bugs.koha-community.org Wed Oct 29 06:12:12 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41128] New: ratings.js creating "undefined" text for screen readers Date: Wed, 29 Oct 2025 05:12:11 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0412471098505896841==" --===============0412471098505896841== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D41128 Bug ID: 41128 Summary: ratings.js creating "undefined" text for screen readers Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org If you try to print the user summary table, you'll likely see a bunch of "undefined" text in the table. It looks like ./koha-tmpl/opac-tmpl/bootstrap/js/ratings.js iterates through some of the HTML and tries to create spans with text from the data-rating-val= ue attribute, but that attribute doesn't exist, so it uses the text "undefined" instead:
undefined undefined undefined undefined undefined
--=20 You are receiving this mail because: You are watching all bug changes. --===============0412471098505896841==-- From bugzilla-daemon@bugs.koha-community.org Wed Oct 29 06:12:41 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41128] ratings.js creating "undefined" text for screen readers Date: Wed, 29 Oct 2025 05:12:41 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3326580532514341950==" --===============3326580532514341950== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41128 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39706 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39706 [Bug 39706] Accessibility: Missing text alternative for the star rating. -- You are receiving this mail because: You are watching all bug changes. --===============3326580532514341950==-- From bugzilla-daemon@bugs.koha-community.org Wed Oct 29 06:19:02 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41128] ratings.js creating "undefined" text for screen readers Date: Wed, 29 Oct 2025 05:19:01 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3950717622918177191==" --===============3950717622918177191== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41128 --- Comment #1 from David Cook --- Created attachment 188544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188544&action=edit Screenshot of "undefined" text in print output -- You are receiving this mail because: You are watching all bug changes. --===============3950717622918177191==-- From bugzilla-daemon@bugs.koha-community.org Wed Oct 29 06:24:36 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41128] ratings.js creating "undefined" text for screen readers Date: Wed, 29 Oct 2025 05:24:36 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2000546455440531899==" --===============2000546455440531899== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41128 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. --===============2000546455440531899==-- From bugzilla-daemon@bugs.koha-community.org Wed Oct 29 06:24:52 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41128] ratings.js creating "undefined" text for screen readers and print output Date: Wed, 29 Oct 2025 05:24:52 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2293552650149590161==" --===============2293552650149590161== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41128 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ratings.js creating |ratings.js creating |"undefined" text for screen |"undefined" text for screen |readers |readers and print output -- You are receiving this mail because: You are watching all bug changes. --===============2293552650149590161==-- From bugzilla-daemon@bugs.koha-community.org Wed Oct 29 06:26:43 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41128] ratings.js creating "undefined" text for screen readers and print output Date: Wed, 29 Oct 2025 05:26:43 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7445352723307630794==" --===============7445352723307630794== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41128 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============7445352723307630794==-- From bugzilla-daemon@bugs.koha-community.org Wed Oct 29 06:26:53 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41128] ratings.js creating "undefined" text for screen readers and print output Date: Wed, 29 Oct 2025 05:26:45 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5946262880548377722==" --===============5946262880548377722== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41128 --- Comment #2 from David Cook --- Created attachment 188545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188545&action=edit Bug 41128: Only use data rating if it's available This patch prevents span elements being filled with "undefined" which are then shown to screen readers and print output. Test plan: 0. Apply the patch 1. Enable the following system preference: OpacStarRatings (results, details, and patron). 2. Check out an item to a user you can log in as (e.g. koha user) 3. Go to /cgi-bin/koha/opac-user.pl in the OPAC 4. Click "Print" on the toolbar above the summary table 5. Note that 5 occurrences of "undefined" do not appear next to the title in the print output -- You are receiving this mail because: You are watching all bug changes. --===============5946262880548377722==-- From bugzilla-daemon@bugs.koha-community.org Wed Oct 29 13:18:45 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41128] ratings.js creating "undefined" text for screen readers and print output Date: Wed, 29 Oct 2025 12:18:44 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7338367745531580811==" --===============7338367745531580811== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41128 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============7338367745531580811==-- From bugzilla-daemon@bugs.koha-community.org Wed Oct 29 13:18:55 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41128] ratings.js creating "undefined" text for screen readers and print output Date: Wed, 29 Oct 2025 12:18:49 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3401948844134430522==" --===============3401948844134430522== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41128 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188545|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 188547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188547&action=edit Bug 41128: Only use data rating if it's available This patch prevents span elements being filled with "undefined" which are then shown to screen readers and print output. Test plan: 0. Apply the patch 1. Enable the following system preference: OpacStarRatings (results, details, and patron). 2. Check out an item to a user you can log in as (e.g. koha user) 3. Go to /cgi-bin/koha/opac-user.pl in the OPAC 4. Click "Print" on the toolbar above the summary table 5. Note that 5 occurrences of "undefined" do not appear next to the title in the print output Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. --===============3401948844134430522==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 31 15:35:30 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41128] ratings.js creating "undefined" text for screen readers and print output Date: Fri, 31 Oct 2025 14:35:29 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4234771629562270883==" --===============4234771629562270883== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41128 Paul Derscheid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============4234771629562270883==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 31 15:35:40 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41128] ratings.js creating "undefined" text for screen readers and print output Date: Fri, 31 Oct 2025 14:35:31 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2850410466103844247==" --===============2850410466103844247== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41128 Paul Derscheid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188547|0 |1 is obsolete| | --- Comment #4 from Paul Derscheid --- Created attachment 188825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188825&action=edit Bug 41128: Only use data rating if it's available This patch prevents span elements being filled with "undefined" which are then shown to screen readers and print output. Test plan: 0. Apply the patch 1. Enable the following system preference: OpacStarRatings (results, details, and patron). 2. Check out an item to a user you can log in as (e.g. koha user) 3. Go to /cgi-bin/koha/opac-user.pl in the OPAC 4. Click "Print" on the toolbar above the summary table 5. Note that 5 occurrences of "undefined" do not appear next to the title in the print output Signed-off-by: Owen Leonard Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. --===============2850410466103844247==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 31 15:40:18 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41128] ratings.js creating "undefined" text for screen readers and print output Date: Fri, 31 Oct 2025 14:39:52 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1597631057852884223==" --===============1597631057852884223== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41128 Paul Derscheid changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | -- You are receiving this mail because: You are watching all bug changes. --===============1597631057852884223==-- From bugzilla-daemon@bugs.koha-community.org Wed Nov 5 15:15:18 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41128] ratings.js creating "undefined" text for screen readers and print output Date: Wed, 05 Nov 2025 14:14:49 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8019576715613709823==" --===============8019576715613709823== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41128 Lucas Gass (lukeg) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. --===============8019576715613709823==-- From bugzilla-daemon@bugs.koha-community.org Wed Nov 5 15:15:28 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41128] ratings.js creating "undefined" text for screen readers and print output Date: Wed, 05 Nov 2025 14:14:55 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5469141443093640753==" --===============5469141443093640753== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41128 --- Comment #5 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. --===============5469141443093640753==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 17 20:14:48 2026 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41128] ratings.js creating "undefined" text for screen readers and print output Date: Tue, 17 Feb 2026 19:14:47 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6628688816449133020==" --===============6628688816449133020== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41128 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com Version(s)|25.11.00 |25.11.00, 25.05.08 released in| | --- Comment #6 from Laura Escamilla --- Backported to 25.05 thanks all! -- You are receiving this mail because: You are watching all bug changes. --===============6628688816449133020==-- From bugzilla-daemon@bugs.koha-community.org Wed Feb 18 15:21:58 2026 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41128] ratings.js creating "undefined" text for screen readers and print output Date: Wed, 18 Feb 2026 14:20:46 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1809234738216735703==" --===============1809234738216735703== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41128 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers --- Depends on Bug 39706 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes. --===============1809234738216735703==--