From bugzilla-daemon@bugs.koha-community.org Tue Oct 25 19:30:54 2016
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 17498] New: Expose system preference values to
 JavaScript in the OPAC
Date: Tue, 25 Oct 2016 17:30:50 +0000
Message-ID: <bug-17498-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0772648399046166299=="

--===============0772648399046166299==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D17498

            Bug ID: 17498
           Summary: Expose system preference values to JavaScript in the
                    OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard@myacpl.org
          Reporter: oleonard@myacpl.org
        QA Contact: testopia@bugs.koha-community.org

We process a lot of JavaScript in the OPAC templates, usually because there a=
re
template variable which need to be processed. Some of these variable, like
system preferences, are a global setting which is common to many pages in the
OPAC. I propose that these settings be defined in embedded JavaScript so that
the scripts themselves can be moved to a separate file.

In my proposal, opac-bottom.inc will contain a section like this:

<script type=3D"text/javascript">
    if (typeof KOHA =3D=3D "undefined" || !KOHA) {
        var KOHA =3D {};
    }
    KOHA.paths =3D {
        "interface_theme":"[% interface %]/[% theme %]"
    }
    KOHA.preferences =3D {
        "BakerTaylorEnabled" : [% IF ( Koha.Preference( 'BakerTaylorEnabled' )
=3D=3D 1 ) %]1[% ELSE %]0[% END %],

...and then an separate JS file will use those variables to conditionally load
resources:

if( KOHA.preferences.Coce && KOHA.preferences.CoceProviders ){
    KOHA.externalResources.push( KOHA.paths.interface_theme + "/js/coce.js" );
    var NO_COCE_JACKET =3D _("No cover image available");
}

if( KOHA.externalResources.length > 0 ){
    Modernizr.load({
        load: KOHA.externalResources
    });
}

I'd appreciate comments anyone might have on this system. My goal, if this
works well, is to then add a JavaScript concatenation/minification task for
OPAC js assets. Moving as much JS as possible out of the templates will help =
us
take advantage of that minification.

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============0772648399046166299==--


From bugzilla-daemon@bugs.koha-community.org Tue Oct 25 19:41:01 2016
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 17498] Expose system preference values to JavaScript
 in the OPAC
Date: Tue, 25 Oct 2016 17:40:58 +0000
Message-ID: <bug-17498-70-Frf9pONbmT@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-17498-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7246628397782429178=="

--===============7246628397782429178==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D17498

--- Comment #1 from Owen Leonard <oleonard@myacpl.org> ---
I feel I should clarify: This wouldn't expose any private system preference
data like API keys. It would be used primarily to expose "on" or "off" settin=
gs
for various features.

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============7246628397782429178==--


From bugzilla-daemon@bugs.koha-community.org Tue Oct 25 22:38:08 2016
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 17498] Expose system preference values to JavaScript
 in the OPAC
Date: Tue, 25 Oct 2016 20:38:05 +0000
Message-ID: <bug-17498-70-fbmm5WZCCN@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-17498-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8416280083868945520=="

--===============8416280083868945520==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17498

Chris Cormack <chris@bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris@bigballofwax.co.nz

--- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> ---
As long as it's an opt in thing, IE we have to define in opac-bottom.inc which
preferences we want exposed, and only do ones that it is safe to do so. Then I
think it is a great idea.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8416280083868945520==--


From bugzilla-daemon@bugs.koha-community.org Wed Oct 26 00:55:49 2016
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 17498] Expose system preference values to JavaScript
 in the OPAC
Date: Tue, 25 Oct 2016 22:55:45 +0000
Message-ID: <bug-17498-70-Zneuc0gFf7@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-17498-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6299791371167769623=="

--===============6299791371167769623==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17498

Frédéric Demians <frederic@tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic@tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6299791371167769623==--


From bugzilla-daemon@bugs.koha-community.org Tue Aug 13 20:52:41 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 17498] Expose system preference values to JavaScript
 in the OPAC
Date: Tue, 13 Aug 2019 18:52:40 +0000
Message-ID: <bug-17498-70-0XxWUV8VzU@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-17498-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0848607549455793202=="

--===============0848607549455793202==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17498

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0848607549455793202==--


From bugzilla-daemon@bugs.koha-community.org Tue Nov 12 19:04:34 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 17498] Expose system preference values to JavaScript
 in the OPAC
Date: Tue, 12 Nov 2019 18:04:33 +0000
Message-ID: <bug-17498-70-AabENggFut@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-17498-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4060430024874778952=="

--===============4060430024874778952==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17498

Tomás Cohen Arazi <tomascohen@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen@gmail.com

--- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> ---
I'm not sure we should expose system preferences to the public front end.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4060430024874778952==--


From bugzilla-daemon@bugs.koha-community.org Fri Nov 15 09:43:58 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 17498] Expose system preference values to JavaScript
 in the OPAC
Date: Wed, 13 Nov 2019 12:20:47 +0000
Message-ID: <bug-17498-70-hitqqbASer@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-17498-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2474237557856331909=="

--===============2474237557856331909==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17498

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer@bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
I agree it should be a 'whitelist' for the OPAC related features if we do this
- some of the preferences might contain critical information.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2474237557856331909==--


From bugzilla-daemon@bugs.koha-community.org Wed Jan 14 19:57:31 2026
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 17498] Expose system preference values to JavaScript
 in the OPAC
Date: Wed, 14 Jan 2026 18:57:31 +0000
Message-ID: <bug-17498-70-IVP53ub1YB@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-17498-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5186900505003431704=="

--===============5186900505003431704==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17498

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #5 from Owen Leonard <oleonard@myacpl.org> ---


*** This bug has been marked as a duplicate of bug 41562 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5186900505003431704==--