From bugzilla-daemon@bugs.koha-community.org Tue May 21 20:22:35 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22957] New: Remove type attribute from script tags:
 Staff client includes 1/2
Date: Tue, 21 May 2019 18:22:32 +0000
Message-ID: <bug-22957-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6989875460890455648=="

--===============6989875460890455648==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D22957

            Bug ID: 22957
           Summary: Remove type attribute from script tags: Staff client
                    includes 1/2
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard@myacpl.org
          Reporter: oleonard@myacpl.org
        QA Contact: testopia@bugs.koha-community.org
            Blocks: 22956
  Target Milestone: ---

This patch will remove the "type" attribute from <script> tags in the followi=
ng
staff client include files:

 - intranet-tmpl\prog\en\includes\acquisitions-toolbar.inc
 - intranet-tmpl\prog\en\includes\additem.js.inc
 - intranet-tmpl\prog\en\includes\browser-strings.inc
 - intranet-tmpl\prog\en\includes\catalog-strings.inc
 - intranet-tmpl\prog\en\includes\datatables.inc
 - intranet-tmpl\prog\en\includes\format_price.inc
 - intranet-tmpl\prog\en\includes\greybox.inc


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D22956
[Bug 22956] Omnibus: Remove type attribute from script tags
--=20
You are receiving this mail because:
You are watching all bug changes.

--===============6989875460890455648==--


From bugzilla-daemon@bugs.koha-community.org Tue May 21 20:55:28 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff
 client includes 1/2
Date: Tue, 21 May 2019 18:55:25 +0000
Message-ID: <bug-22957-70-1vyOWHxEWq@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22957-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6716159655930796130=="

--===============6716159655930796130==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957

--- Comment #1 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 89950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89950&action=edit
Bug 22957: Remove type attribute from script tags: Staff client includes 1/2

This patch removes the "type" attribute from <script> tags in several
staff client include files. Also removed: Obsolete "//<![CDATA[ //]]>"
markers.

This patch also makes minor indentation changes, so diff using the "-w"
flag.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Acquisitions -> Vendor (uses acuisitions-toolbar.inc)
 - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record
   (uses additem.js.inc)
 - Catalog -> Search results -> Bibliographic detail view. (uses
   browser-strings.inc, catalog-strings.inc, datatables.inc, and
   format_price.inc )
 - Tools -> Label creator -> Manage -> Label batches -> Export batch
   (uses greybox.inc)

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6716159655930796130==--


From bugzilla-daemon@bugs.koha-community.org Tue May 21 20:55:52 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff
 client includes 1/2
Date: Tue, 21 May 2019 18:55:22 +0000
Message-ID: <bug-22957-70-Xo6T5oU09f@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22957-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5461757183492650201=="

--===============5461757183492650201==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5461757183492650201==--


From bugzilla-daemon@bugs.koha-community.org Thu May 23 14:34:36 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff
 client includes 1/2
Date: Thu, 23 May 2019 12:34:04 +0000
Message-ID: <bug-22957-70-ZXDp8Saydw@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22957-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8516922288896589458=="

--===============8516922288896589458==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22973

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8516922288896589458==--


From bugzilla-daemon@bugs.koha-community.org Thu May 23 17:43:57 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff
 client includes 1/2
Date: Thu, 23 May 2019 15:43:48 +0000
Message-ID: <bug-22957-70-C9SsRDmobs@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22957-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7116203927740069518=="

--===============7116203927740069518==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7116203927740069518==--


From bugzilla-daemon@bugs.koha-community.org Thu May 23 20:51:27 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff
 client includes 1/2
Date: Thu, 23 May 2019 18:51:20 +0000
Message-ID: <bug-22957-70-hKGp73zu2f@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22957-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2098601199380353021=="

--===============2098601199380353021==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2098601199380353021==--


From bugzilla-daemon@bugs.koha-community.org Thu Jul  4 21:10:26 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff
 client includes 1/2
Date: Thu, 04 Jul 2019 19:09:56 +0000
Message-ID: <bug-22957-70-HYxBEgTyLB@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22957-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3020590541574638613=="

--===============3020590541574638613==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957

M. Tompsett <mtompset@hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset@hotmail.com

--- Comment #2 from M. Tompsett <mtompset@hotmail.com> ---
Quick question about & vs &amp; and HTML vs XML validation with respect to the
removal of CDATA in acquisitions-toolbar.inc?
Are we ever validating as XML or XHTML? If not, okay. If so, then why remove
CDATA?

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3020590541574638613==--


From bugzilla-daemon@bugs.koha-community.org Fri Jul  5 13:53:29 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff
 client includes 1/2
Date: Fri, 05 Jul 2019 11:52:59 +0000
Message-ID: <bug-22957-70-uGy7WFcCei@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22957-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1193161567837409946=="

--===============1193161567837409946==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957

--- Comment #3 from Owen Leonard <oleonard@myacpl.org> ---
(In reply to M. Tompsett from comment #2)

> Are we ever validating as XML or XHTML? If not, okay. If so, then why remove
> CDATA?

As of version 3.12 Koha uses an HTML5 doctype:
https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML_Templates. HTML5
documents are not required to be well-formed XML.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1193161567837409946==--


From bugzilla-daemon@bugs.koha-community.org Fri Jul  5 19:42:30 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff
 client includes 1/2
Date: Fri, 05 Jul 2019 17:42:26 +0000
Message-ID: <bug-22957-70-Mb1r4Ekz05@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22957-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2316119297637016570=="

--===============2316119297637016570==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957

Nadine Pierre <nadine.pierre@InLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89950|0                           |1
        is obsolete|                            |

--- Comment #4 from Nadine Pierre <nadine.pierre@InLibro.com> ---
Created attachment 91337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91337&action=edit
Bug 22957: Remove type attribute from script tags: Staff client includes 1/2

This patch removes the "type" attribute from <script> tags in several
staff client include files. Also removed: Obsolete "//<![CDATA[ //]]>"
markers.

This patch also makes minor indentation changes, so diff using the "-w"
flag.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Acquisitions -> Vendor (uses acuisitions-toolbar.inc)
 - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record
   (uses additem.js.inc)
 - Catalog -> Search results -> Bibliographic detail view. (uses
   browser-strings.inc, catalog-strings.inc, datatables.inc, and
   format_price.inc )
 - Tools -> Label creator -> Manage -> Label batches -> Export batch
   (uses greybox.inc)

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2316119297637016570==--


From bugzilla-daemon@bugs.koha-community.org Fri Jul  5 19:43:02 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff
 client includes 1/2
Date: Fri, 05 Jul 2019 17:42:56 +0000
Message-ID: <bug-22957-70-Z8YouGNE14@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22957-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2088201192273005021=="

--===============2088201192273005021==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957

Nadine Pierre <nadine.pierre@InLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |nadine.pierre@InLibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2088201192273005021==--


From bugzilla-daemon@bugs.koha-community.org Sat Jul  6 08:42:29 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff
 client includes 1/2
Date: Sat, 06 Jul 2019 06:42:26 +0000
Message-ID: <bug-22957-70-OLUXAOXUN4@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22957-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8919195137899873631=="

--===============8919195137899873631==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8919195137899873631==--


From bugzilla-daemon@bugs.koha-community.org Sat Jul  6 08:42:35 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff
 client includes 1/2
Date: Sat, 06 Jul 2019 06:42:30 +0000
Message-ID: <bug-22957-70-fC7pJ9pBmL@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22957-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2149472183183664182=="

--===============2149472183183664182==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91337|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 91382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91382&action=edit
Bug 22957: Remove type attribute from script tags: Staff client includes 1/2

This patch removes the "type" attribute from <script> tags in several
staff client include files. Also removed: Obsolete "//<![CDATA[ //]]>"
markers.

This patch also makes minor indentation changes, so diff using the "-w"
flag.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Acquisitions -> Vendor (uses acuisitions-toolbar.inc)
 - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record
   (uses additem.js.inc)
 - Catalog -> Search results -> Bibliographic detail view. (uses
   browser-strings.inc, catalog-strings.inc, datatables.inc, and
   format_price.inc )
 - Tools -> Label creator -> Manage -> Label batches -> Export batch
   (uses greybox.inc)

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2149472183183664182==--


From bugzilla-daemon@bugs.koha-community.org Mon Jul 15 13:22:24 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff
 client includes 1/2
Date: Mon, 15 Jul 2019 11:21:51 +0000
Message-ID: <bug-22957-70-Fk3oSg52Cy@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22957-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6662656057582638705=="

--===============6662656057582638705==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957

Martin Renvoize <martin.renvoize@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |19.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6662656057582638705==--


From bugzilla-daemon@bugs.koha-community.org Mon Jul 15 13:22:29 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff
 client includes 1/2
Date: Mon, 15 Jul 2019 11:21:53 +0000
Message-ID: <bug-22957-70-kdz7N8otel@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22957-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8657614032121506686=="

--===============8657614032121506686==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957

--- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8657614032121506686==--


From bugzilla-daemon@bugs.koha-community.org Tue Jul 30 07:40:56 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff
 client includes 1/2
Date: Tue, 30 Jul 2019 05:40:54 +0000
Message-ID: <bug-22957-70-GtGMrdPBvZ@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22957-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7210483796084076716=="

--===============7210483796084076716==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957

Fridolin SOMERS <fridolin.somers@biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |fridolin.somers@biblibre.co
                   |                            |m
         Version(s)|19.11.00                    |19.11.00,19.05.03
        released in|                            |

--- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> ---
Pushed to 19.05.x for 19.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7210483796084076716==--


From bugzilla-daemon@bugs.koha-community.org Tue Aug  6 18:21:13 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff
 client includes 1/2
Date: Tue, 06 Aug 2019 16:21:12 +0000
Message-ID: <bug-22957-70-5B4ivA6dY9@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22957-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4294700199757977537=="

--===============4294700199757977537==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957

Lucas Gass <lucas@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas@bywatersolutions.com

--- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> ---
backported to 18.11.x for 18.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4294700199757977537==--