From bugzilla-daemon@bugs.koha-community.org Tue May  2 01:15:57 2017
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 11122] Fix display of publication year/
 copyrightdate and publishercode on various pages in acquisitions
Date: Mon, 01 May 2017 23:15:53 +0000
Message-ID: <bug-11122-70-OM0JLwTOTa@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-11122-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5986432538862553280=="

--===============5986432538862553280==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D11122

--- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 62935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D62935&action=3D=
edit
[SIGNED OFF] Bug 11122 - publisher code and publication year not fetched in a=
cq
orders

In acquisition, several templates try to display publisher code and publicati=
on
year : invoice.tt, parcel.tt, transferorder.tt.
Thoses pages use C4::Acquisition methods GetPendingOrders or GetInvoiceDetail=
s.
The bug is that in the SQL query of those methods, biblioitems.publishercode
and biblioitems.publicationyear.
In uncertainprice.pl those datas are fetch using GetBiblioData.
It whould be better to fetch them in GetPendingOrders and GetInvoiceDetails.

This patch changes SQL queries to fetch wanted datas :
aqorders.*,biblio.title,biblio.author,biblioitems.isbn,biblioitems.publisherc=
ode,biblioitems.publicationyear.
GetInvoiceDetails also needs : biblio.seriestitle,biblioitems.volume.
This patch also unifies the way biblio datas are displayed :
  <a href=3D"link to catalog using biblionumber">[title]</a> <em>by</em> [aut=
hor]
&ndash; [isbn]
  <em>Publisher:</em> [publishercode], [publicationyear]

Test plan :
- Choose a biblio record containing a data in :
    biblio.title,
    biblio.author,
    biblioitems.isbn,
    biblioitems.publishercode,
    biblioitems.publicationyear,
    biblio.seriestitle,
    biblioitems.volume.
- Create an order using this biblio.
- Look at this order in pages : parcel.pl, transferorder.pl, uncertainprice.pl
=3D> You see publisher code and publication year
- Look at this order in page : invoice.pl
=3D> You see publisher code, publication year, series title and volume

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============5986432538862553280==--