From bugzilla-daemon@bugs.koha-community.org Wed May 31 22:48:18 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33875] New: Missing closing tag a in API key management page Date: Wed, 31 May 2023 20:48:17 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3039485217257481449==" --===============3039485217257481449== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D33875 Bug ID: 33875 Summary: Missing closing tag a in API key management page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In API key management page, anchor closing tag is missing in :
No keys defined for the current patron. Generate a new client id/secret pair
--=20 You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============3039485217257481449==-- From bugzilla-daemon@bugs.koha-community.org Wed May 31 22:48:29 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page Date: Wed, 31 May 2023 20:48:23 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8112123318024924816==" --===============8112123318024924816== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20568 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 [Bug 20568] Add API key management interface for patrons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============8112123318024924816==-- From bugzilla-daemon@bugs.koha-community.org Wed May 31 22:50:47 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page Date: Wed, 31 May 2023 20:50:45 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1788937908396980838==" --===============1788937908396980838== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============1788937908396980838==-- From bugzilla-daemon@bugs.koha-community.org Wed May 31 23:04:04 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page Date: Wed, 31 May 2023 21:04:02 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2167356426246086899==" --===============2167356426246086899== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. --===============2167356426246086899==-- From bugzilla-daemon@bugs.koha-community.org Wed May 31 23:04:15 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page Date: Wed, 31 May 2023 21:04:04 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6415626585129514010==" --===============6415626585129514010== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 --- Comment #1 from Fridolin Somers --- Created attachment 151888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151888&action=edit Bug 33875: Fix missing closing tag a in API key management page In API key management page, anchor closing tag is missing in message "No keys defined for the current patron". This patch fixes that. Also changes display with link on a new line. Translatable text is on purpose surrounded by span or div. Test plan : 1) Enable system preference RESTOAuth2ClientCredentials 2) Go to a patron page 3) Click More > Manage API Keys 4) Look at page source HTML code => Check code is OK -- You are receiving this mail because: You are watching all bug changes. --===============6415626585129514010==-- From bugzilla-daemon@bugs.koha-community.org Wed May 31 23:05:58 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page Date: Wed, 31 May 2023 21:05:57 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9106076743575559691==" --===============9106076743575559691== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 --- Comment #2 from Fridolin Somers --- Created attachment 151889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151889&action=edit Screenshot with patch I choose to propose a minor change in display to move link on a new line. This looks better I think. Also each translatable text is surrounded by span or div to ease translation. -- You are receiving this mail because: You are watching all bug changes. --===============9106076743575559691==-- From bugzilla-daemon@bugs.koha-community.org Thu Jun 1 18:58:13 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page Date: Thu, 01 Jun 2023 16:58:12 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5342136264697620898==" --===============5342136264697620898== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============5342136264697620898==-- From bugzilla-daemon@bugs.koha-community.org Thu Jun 1 18:58:23 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page Date: Thu, 01 Jun 2023 16:58:14 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8472577649601278315==" --===============8472577649601278315== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151888|0 |1 is obsolete| | --- Comment #3 from Sam Lau --- Created attachment 151950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151950&action=edit Bug 33875: Fix missing closing tag a in API key management page In API key management page, anchor closing tag is missing in message "No keys defined for the current patron". This patch fixes that. Also changes display with link on a new line. Translatable text is on purpose surrounded by span or div. Test plan : 1) Enable system preference RESTOAuth2ClientCredentials 2) Go to a patron page 3) Click More > Manage API Keys 4) Look at page source HTML code => Check code is OK Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. --===============8472577649601278315==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 2 03:22:47 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page Date: Fri, 02 Jun 2023 01:22:46 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6742657329444690209==" --===============6742657329444690209== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33883 -- You are receiving this mail because: You are watching all bug changes. --===============6742657329444690209==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 2 03:25:06 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page Date: Fri, 02 Jun 2023 01:25:05 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7923358987065034176==" --===============7923358987065034176== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============7923358987065034176==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 2 03:25:16 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page Date: Fri, 02 Jun 2023 01:25:08 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4127434527589249618==" --===============4127434527589249618== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151950|0 |1 is obsolete| | --- Comment #4 from David Cook --- Created attachment 151956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151956&action=edit Bug 33875: Fix missing closing tag a in API key management page In API key management page, anchor closing tag is missing in message "No keys defined for the current patron". This patch fixes that. Also changes display with link on a new line. Translatable text is on purpose surrounded by span or div. Test plan : 1) Enable system preference RESTOAuth2ClientCredentials 2) Go to a patron page 3) Click More > Manage API Keys 4) Look at page source HTML code => Check code is OK Signed-off-by: Sam Lau Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. --===============4127434527589249618==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 2 16:13:59 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page Date: Fri, 02 Jun 2023 14:13:48 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2215761038036460072==" --===============2215761038036460072== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33883 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 [Bug 33883] "Make sure to copy your API secret" message overlaps text -- You are receiving this mail because: You are watching all bug changes. --===============2215761038036460072==-- From bugzilla-daemon@bugs.koha-community.org Mon Jun 5 19:38:47 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page Date: Mon, 05 Jun 2023 17:37:25 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6715492522216625510==" --===============6715492522216625510== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. --===============6715492522216625510==-- From bugzilla-daemon@bugs.koha-community.org Mon Jun 5 19:38:58 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page Date: Mon, 05 Jun 2023 17:37:27 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2540528640977114218==" --===============2540528640977114218== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. --===============2540528640977114218==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 9 16:10:58 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page Date: Fri, 09 Jun 2023 14:08:19 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1795725965504939368==" --===============1795725965504939368== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.01 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. --===============1795725965504939368==-- From bugzilla-daemon@bugs.koha-community.org Mon Jun 12 12:16:46 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page Date: Mon, 12 Jun 2023 10:15:20 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2603800526427223734==" --===============2603800526427223734== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.01 |23.11.00,23.05.01,22.11.07 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. --===============2603800526427223734==-- From bugzilla-daemon@bugs.koha-community.org Mon Jun 12 12:16:56 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page Date: Mon, 12 Jun 2023 10:15:22 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3062212642139895301==" --===============3062212642139895301== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 --- Comment #6 from Matt Blenkinsop --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. --===============3062212642139895301==--