From bugzilla-daemon@bugs.koha-community.org Wed May 23 15:43:17 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] New: Column settings issues for holdshistory-table Date: Wed, 23 May 2018 13:42:47 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2161848185726903400==" --===============2161848185726903400== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Bug ID: 20806 Summary: Column settings issues for holdshistory-table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: severine.queune@bulac.fr QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com There is 2 display issues with the table "Holds history" tab : - no change when modifying "Column settings > Patrons > (id=holdshistory-table)". I don't know if it is linked, but the on the tab is "table_holdshistory". - column "Item type" is always empty -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============2161848185726903400==-- From bugzilla-daemon@bugs.koha-community.org Mon May 28 20:16:22 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Column settings issues for holdshistory-table Date: Mon, 28 May 2018 18:16:18 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0589895989483732095==" --===============0589895989483732095== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14919 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 [Bug 14919] Holds history for patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============0589895989483732095==-- From bugzilla-daemon@bugs.koha-community.org Tue May 29 10:44:21 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Column settings issues for holdshistory-table Date: Tue, 29 May 2018 08:43:51 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5530411054294707568==" --===============5530411054294707568== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20806 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9573 Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | CC| |josef.moravec@gmail.com --- Comment #1 from Josef Moravec --- (In reply to S=C3=A9verine Queune from comment #0) > There is 2 display issues with the table "Holds history" tab : > - no change when modifying "Column settings > Patrons > > (id=3Dholdshistory-table)". I don't know if it is linked, but the
> on the tab is "table_holdshistory". This is caused by bug 9573, where the first parameter of KohaTable function w= as changed from selector to id > - column "Item type" is always empty Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D9573 [Bug 9573] Ability to download items lost report --=20 You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============5530411054294707568==-- From bugzilla-daemon@bugs.koha-community.org Tue May 29 10:47:44 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Column settings issues for holdshistory-table Date: Tue, 29 May 2018 08:47:36 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4903755909569881111==" --===============4903755909569881111== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20831 -- You are receiving this mail because: You are watching all bug changes. --===============4903755909569881111==-- From bugzilla-daemon@bugs.koha-community.org Tue May 29 11:09:29 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Column settings issues for holdshistory-table Date: Tue, 29 May 2018 09:09:26 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8497725262179334167==" --===============8497725262179334167== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20806 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|9573 |20831 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D9573 [Bug 9573] Ability to download items lost report https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20831 [Bug 20831] (Bug 9573 follow-up) Pass id as first parameter instead of select= or --=20 You are receiving this mail because: You are watching all bug changes. --===============8497725262179334167==-- From bugzilla-daemon@bugs.koha-community.org Tue May 29 13:52:26 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Column settings issues for holdshistory-table Date: Tue, 29 May 2018 11:52:23 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4983163727365924170==" --===============4983163727365924170== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============4983163727365924170==-- From bugzilla-daemon@bugs.koha-community.org Tue May 29 13:52:28 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Column settings issues for holdshistory-table Date: Tue, 29 May 2018 11:52:26 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0704354900928933859==" --===============0704354900928933859== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 --- Comment #2 from Josef Moravec --- Created attachment 75625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75625&action=edit Bug 20806: Add item type description holds history page Test plan: 0) Do not apply the patch 1) Set AllowHoldItemTypeSelection to Allow 2) Place some hold for a patron, some with specific item type and some without item typ 3) On holds history page you should see blank or item type code in item type column 4) Apply the patch 5) Now you should see description in item type column -- You are receiving this mail because: You are watching all bug changes. --===============0704354900928933859==-- From bugzilla-daemon@bugs.koha-community.org Tue May 29 13:53:20 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code Date: Tue, 29 May 2018 11:53:17 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3156205882299539178==" --===============3156205882299539178== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement Summary|Column settings issues for |Item type in holds history |holdshistory-table |table should be write as | |description, not code -- You are receiving this mail because: You are watching all bug changes. --===============3156205882299539178==-- From bugzilla-daemon@bugs.koha-community.org Tue May 29 14:45:17 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code Date: Tue, 29 May 2018 12:44:46 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8861907220481144764==" --===============8861907220481144764== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20806 S=C3=A9verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #3 from S=C3=A9verine Queune --- I'm quite confused... If I understand correctly the patch, the (new) column "Request item type" is filled with the hold level. Personally, I though to see the 'items.itype' value. As we only authorised it= em level holds because of our local use, it would have been more useful because with this patch we will only have "Any item itype" displayed. Can you confirm this is the behaviour you were waiting for ? If so, as patch applies correctly, I will sign it. PS : sorting option for the table is a good idea ! --=20 You are receiving this mail because: You are watching all bug changes. --===============8861907220481144764==-- From bugzilla-daemon@bugs.koha-community.org Tue May 29 16:37:45 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code Date: Tue, 29 May 2018 14:37:36 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1177040667642885877==" --===============1177040667642885877== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20831 | -- You are receiving this mail because: You are watching all bug changes. --===============1177040667642885877==-- From bugzilla-daemon@bugs.koha-community.org Thu May 31 17:43:52 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code Date: Thu, 31 May 2018 15:43:49 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1783878792109325805==" --===============1783878792109325805== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20806 --- Comment #4 from Jonathan Druart = --- S=C3=A9verine is right, the column is confusing. Maybe we should display it only when AllowHoldItemTypeSelection is set? --=20 You are receiving this mail because: You are watching all bug changes. --===============1783878792109325805==-- From bugzilla-daemon@bugs.koha-community.org Sat Jun 2 23:56:58 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code Date: Sat, 02 Jun 2018 21:56:55 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5163288151574851198==" --===============5163288151574851198== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20806 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer --- I think this might be related to AllowHoldItemTypeSelection that allows you to pick an itemtype when placing the hold? Maybe we can make the visibility of t= he column depend on that? --=20 You are receiving this mail because: You are watching all bug changes. --===============5163288151574851198==-- From bugzilla-daemon@bugs.koha-community.org Sun Jun 3 21:36:15 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code Date: Sun, 03 Jun 2018 19:36:12 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8886521908399450424==" --===============8886521908399450424== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 --- Comment #6 from Katrin Fischer --- ... which is exactly what Jonathan suggested. -- You are receiving this mail because: You are watching all bug changes. --===============8886521908399450424==-- From bugzilla-daemon@bugs.koha-community.org Thu Jun 7 09:21:00 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code Date: Thu, 07 Jun 2018 07:20:29 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3352558520001628136==" --===============3352558520001628136== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20806 Bug 20806 depends on bug 20831, which changed state. Bug 20831 Summary: (Bug 9573 follow-up) Pass id as first parameter instead of= selector https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20831 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --=20 You are receiving this mail because: You are watching all bug changes. --===============3352558520001628136==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 19 23:29:18 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code Date: Tue, 19 Jun 2018 21:29:15 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0642226445747499169==" --===============0642226445747499169== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #7 from Katrin Fischer --- I think with the change to "Requested item type" the patch makes sense to me. Only thing I'd is a check for the AllowHoldItemTypeSelection system preference to decide about showing it or not. -- You are receiving this mail because: You are watching all bug changes. --===============0642226445747499169==-- From bugzilla-daemon@bugs.koha-community.org Wed Jun 20 15:43:36 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code Date: Wed, 20 Jun 2018 13:43:30 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8211850157368900011==" --===============8211850157368900011== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds History for patrons in OPAC -- You are receiving this mail because: You are watching all bug changes. --===============8211850157368900011==-- From bugzilla-daemon@bugs.koha-community.org Mon Jun 25 13:55:20 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code Date: Mon, 25 Jun 2018 11:55:17 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8735568393913163491==" --===============8735568393913163491== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============8735568393913163491==-- From bugzilla-daemon@bugs.koha-community.org Mon Jun 25 13:55:26 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code Date: Mon, 25 Jun 2018 11:55:22 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5772245694784332165==" --===============5772245694784332165== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75625|0 |1 is obsolete| | --- Comment #8 from Josef Moravec --- Created attachment 76370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76370&action=edit Bug 20806: Add item type description holds history page Test plan: 0) Do not apply the patch 1) Set AllowHoldItemTypeSelection to Allow 2) Place some hold for a patron, some with specific item type and some without item type 3) On holds history page you should see blank or item type code in item type column 4) Apply the patch 5) Now you should see description in item type column 6) Set AllowHoldItemTypeSelection to Don't Allow 7) You shold not see the item type column, but column visibility settings should continue working ;) -- You are receiving this mail because: You are watching all bug changes. --===============5772245694784332165==-- From bugzilla-daemon@bugs.koha-community.org Mon Jun 25 13:56:39 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code Date: Mon, 25 Jun 2018 11:56:36 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8680173168572446421==" --===============8680173168572446421== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 --- Comment #9 from Josef Moravec --- Thanks all for comments/suggestions. I added the check of AllowHoldItemTypeSelection system preference -- You are receiving this mail because: You are watching all bug changes. --===============8680173168572446421==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 29 21:36:00 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code Date: Fri, 29 Jun 2018 19:35:57 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3244833412348538747==" --===============3244833412348538747== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============3244833412348538747==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 29 21:36:06 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code Date: Fri, 29 Jun 2018 19:36:01 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2887297891273279986==" --===============2887297891273279986== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76370|0 |1 is obsolete| | --- Comment #10 from Maryse Simard --- Created attachment 76585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76585&action=edit Bug 20806: Add item type description holds history page Test plan: 0) Do not apply the patch 1) Set AllowHoldItemTypeSelection to Allow 2) Place some hold for a patron, some with specific item type and some without item type 3) On holds history page you should see blank or item type code in item type column 4) Apply the patch 5) Now you should see description in item type column 6) Set AllowHoldItemTypeSelection to Don't Allow 7) You shold not see the item type column, but column visibility settings should continue working ;) Signed-off-by: Maryse Simard Followed the test plan and it works. -- You are receiving this mail because: You are watching all bug changes. --===============2887297891273279986==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 29 22:31:51 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code Date: Fri, 29 Jun 2018 20:31:48 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7484860677668079251==" --===============7484860677668079251== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============7484860677668079251==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 29 22:31:57 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code Date: Fri, 29 Jun 2018 20:31:55 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1483244131090031110==" --===============1483244131090031110== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76585|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 76591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D76591&action=3D= edit Bug 20806: Add item type description holds history page Test plan: 0) Do not apply the patch 1) Set AllowHoldItemTypeSelection to Allow 2) Place some hold for a patron, some with specific item type and some without item type 3) On holds history page you should see blank or item type code in item type column 4) Apply the patch 5) Now you should see description in item type column 6) Set AllowHoldItemTypeSelection to Don't Allow 7) You shold not see the item type column, but column visibility settings should continue working ;) Signed-off-by: Maryse Simard Followed the test plan and it works. Signed-off-by: Jonathan Druart --=20 You are receiving this mail because: You are watching all bug changes. --===============1483244131090031110==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 29 22:32:04 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code Date: Fri, 29 Jun 2018 20:31:59 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2985308159657793937==" --===============2985308159657793937== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20806 --- Comment #12 from Jonathan Druart --- Created attachment 76592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D76592&action=3D= edit Bug 20806: Do not rely on column position It is not the first time we have this splice call, it seems safer to rely on the column's name instead of the column's position Signed-off-by: Jonathan Druart --=20 You are receiving this mail because: You are watching all bug changes. --===============2985308159657793937==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 29 22:37:16 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code Date: Fri, 29 Jun 2018 20:37:14 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7419852300143772919==" --===============7419852300143772919== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20806 --- Comment #13 from Jonathan Druart --- Created attachment 76593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D76593&action=3D= edit Bug 20806: Surround string by span tag to help translation Signed-off-by: Jonathan Druart --=20 You are receiving this mail because: You are watching all bug changes. --===============7419852300143772919==-- From bugzilla-daemon@bugs.koha-community.org Wed Jul 18 14:20:43 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code Date: Wed, 18 Jul 2018 12:20:40 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8047937165146137208==" --===============8047937165146137208== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Bug 20806 depends on bug 14919, which changed state. Bug 14919 Summary: Holds history for patrons https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. --===============8047937165146137208==-- From bugzilla-daemon@bugs.koha-community.org Wed Jul 18 21:16:27 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code Date: Wed, 18 Jul 2018 19:16:24 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7338016009186017850==" --===============7338016009186017850== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #14 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. --===============7338016009186017850==-- From bugzilla-daemon@bugs.koha-community.org Wed Jul 18 21:32:53 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be written as description, not code Date: Wed, 18 Jul 2018 19:32:50 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4803633043848919776==" --===============4803633043848919776== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Item type in holds history |Item type in holds history |table should be write as |table should be written as |description, not code |description, not code -- You are receiving this mail because: You are watching all bug changes. --===============4803633043848919776==-- From bugzilla-daemon@bugs.koha-community.org Thu Aug 2 14:16:44 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be written as description, not code Date: Thu, 02 Aug 2018 12:16:41 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2806593319156124318==" --===============2806593319156124318== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable Severity|enhancement |minor --- Comment #15 from Martin Renvoize --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes. --===============2806593319156124318==-- From bugzilla-daemon@bugs.koha-community.org Fri Sep 21 09:25:22 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be written as description, not code Date: Fri, 21 Sep 2018 07:24:51 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2453023523076299311==" --===============2453023523076299311== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #16 from Fridolin SOMERS --- Depends on Bug 20831 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. --===============2453023523076299311==--