From bugzilla-daemon@bugs.koha-community.org Wed Jan 10 17:09:17 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 19946] New: Update popup window templates to use
Bootstrap grid: Authority Z39.50 search
Date: Wed, 10 Jan 2018 16:09:14 +0000
Message-ID:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1606658159588601545=="
--===============1606658159588601545==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946
Bug ID: 19946
Summary: Update popup window templates to use Bootstrap grid:
Authority Z39.50 search
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: ASSIGNED
Severity: enhancement
Priority: P5 - low
Component: Templates
Assignee: oleonard@myacpl.org
Reporter: oleonard@myacpl.org
QA Contact: testopia@bugs.koha-community.org
Blocks: 19931
This bug falls under the omnibus Bug 19931, "Update popup window templates to
use Bootstrap grid." Updated in this patch will be z3950_auth_search.tt, the
template for Z39.50 searches from the authorities interface.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931
[Bug 19931] Update popup window templates to use Bootstrap grid
--
You are receiving this mail because:
You are watching all bug changes.
--===============1606658159588601545==--
From bugzilla-daemon@bugs.koha-community.org Wed Jan 10 17:31:21 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use
Bootstrap grid: Authority Z39.50 search
Date: Wed, 10 Jan 2018 16:30:59 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0474831346147852431=="
--===============0474831346147852431==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
--===============0474831346147852431==--
From bugzilla-daemon@bugs.koha-community.org Wed Jan 10 17:31:22 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use
Bootstrap grid: Authority Z39.50 search
Date: Wed, 10 Jan 2018 16:31:01 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0689846100128813330=="
--===============0689846100128813330==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946
--- Comment #1 from Owen Leonard ---
Created attachment 70411
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70411&action=edit
Bug 19946: Update popup window templates to use Bootstrap grid: Authority
Z39.50 search
This patch updates the authority Z39.50 search template to use the
Bootstrap grid instead of the YUI grid.
Also fixed: Some capitalization corrections, better
handling. This patch does not fix Bug 17119.
To test, apply the patch and go to Authorities -> New from Z39.50.
In the popup window, both the search form and search results pages
should look correct.
--
You are receiving this mail because:
You are watching all bug changes.
--===============0689846100128813330==--
From bugzilla-daemon@bugs.koha-community.org Wed Jan 17 13:44:31 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use
Bootstrap grid: Authority Z39.50 search
Date: Wed, 17 Jan 2018 12:44:17 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4463126179750153767=="
--===============4463126179750153767==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |Academy
--
You are receiving this mail because:
You are watching all bug changes.
--===============4463126179750153767==--
From bugzilla-daemon@bugs.koha-community.org Thu Jan 18 22:01:05 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use
Bootstrap grid: Authority Z39.50 search
Date: Thu, 18 Jan 2018 21:01:02 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4582451715878826465=="
--===============4582451715878826465==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946
Te Rauhina Jackson changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #70411|0 |1
is obsolete| |
--- Comment #2 from Te Rauhina Jackson ---
Created attachment 70716
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70716&action=edit
Bug 19946: Update popup window templates to use Bootstrap grid: Authority
Z39.50 search
This patch updates the authority Z39.50 search template to use the
Bootstrap grid instead of the YUI grid.
Also fixed: Some capitalization corrections, better
handling. This patch does not fix Bug 17119.
To test, apply the patch and go to Authorities -> New from Z39.50.
In the popup window, both the search form and search results pages
should look correct.
Signed-off-by: Te Rauhina Jackson
Signed-off-by: Te Rauhina Jackson
--
You are receiving this mail because:
You are watching all bug changes.
--===============4582451715878826465==--
From bugzilla-daemon@bugs.koha-community.org Thu Jan 18 22:01:06 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use
Bootstrap grid: Authority Z39.50 search
Date: Thu, 18 Jan 2018 21:01:00 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2321775519138345986=="
--===============2321775519138345986==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946
Te Rauhina Jackson changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
--===============2321775519138345986==--
From bugzilla-daemon@bugs.koha-community.org Sun Feb 4 16:49:58 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use
Bootstrap grid: Authority Z39.50 search
Date: Sun, 04 Feb 2018 15:49:37 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7905126299365170449=="
--===============7905126299365170449==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
--===============7905126299365170449==--
From bugzilla-daemon@bugs.koha-community.org Sun Feb 4 16:50:02 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use
Bootstrap grid: Authority Z39.50 search
Date: Sun, 04 Feb 2018 15:49:40 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2055167526727229003=="
--===============2055167526727229003==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #70716|0 |1
is obsolete| |
--- Comment #3 from Katrin Fischer ---
Created attachment 71204
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71204&action=edit
Bug 19946: Update popup window templates to use Bootstrap grid: Authority
Z39.50 search
This patch updates the authority Z39.50 search template to use the
Bootstrap grid instead of the YUI grid.
Also fixed: Some capitalization corrections, better
handling. This patch does not fix Bug 17119.
To test, apply the patch and go to Authorities -> New from Z39.50.
In the popup window, both the search form and search results pages
should look correct.
Signed-off-by: Te Rauhina Jackson
Signed-off-by: Te Rauhina Jackson
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
--===============2055167526727229003==--
From bugzilla-daemon@bugs.koha-community.org Thu Feb 8 18:21:16 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use
Bootstrap grid: Authority Z39.50 search
Date: Thu, 08 Feb 2018 17:21:12 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8083194677802772682=="
--===============8083194677802772682==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D19946
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart@bugs.koha-c
| |ommunity.org
--- Comment #4 from Jonathan Druart =
---
Did not we agree that the action buttons should be grouped only if there are
more than 2?
I also see this:
https://screenshots.firefox.com/jDHvackVDkBUUjlC/pro.kohadev.org
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============8083194677802772682==--
From bugzilla-daemon@bugs.koha-community.org Thu Feb 8 18:28:53 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use
Bootstrap grid: Authority Z39.50 search
Date: Thu, 08 Feb 2018 17:28:31 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5172522886827432720=="
--===============5172522886827432720==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D19946
--- Comment #5 from Jonathan Druart =
---
(In reply to Jonathan Druart from comment #4)
> Did not we agree that the action buttons should be grouped only if there are
> more than 2?
It is displayed when a row is clicked, so it is not valid here.
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============5172522886827432720==--
From bugzilla-daemon@bugs.koha-community.org Fri Feb 9 14:21:37 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use
Bootstrap grid: Authority Z39.50 search
Date: Fri, 09 Feb 2018 13:21:33 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8609136739873083166=="
--===============8609136739873083166==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
--===============8609136739873083166==--
From bugzilla-daemon@bugs.koha-community.org Fri Feb 9 14:21:43 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use
Bootstrap grid: Authority Z39.50 search
Date: Fri, 09 Feb 2018 13:21:35 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4359866402656648974=="
--===============4359866402656648974==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946
--- Comment #6 from Owen Leonard ---
Created attachment 71384
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71384&action=edit
Bug 19946: (Follow-up) Add fixed footer to authorities Z39.50 popup
This patch adds additional Bootstrap framework markup to the search form
so that the "Save" and "Cancel" controls are in a fixed footer at the
bottom of the window. This prevents the controls from disappearing down
off screen.
This patch also adds some whitespace to the "Author
(meeting/conference)" label to enable better word wrapping.
To test, apply the patch and go to Authorities -> New from Z39.50/SRU.
In the popup window, both the search form and search results pages
should look correct.
--
You are receiving this mail because:
You are watching all bug changes.
--===============4359866402656648974==--
From bugzilla-daemon@bugs.koha-community.org Mon Mar 26 02:19:07 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use
Bootstrap grid: Authority Z39.50 search
Date: Mon, 26 Mar 2018 00:19:04 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3865776305726262557=="
--===============3865776305726262557==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946
Dilan Johnpullé changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
--===============3865776305726262557==--
From bugzilla-daemon@bugs.koha-community.org Mon Mar 26 02:19:11 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use
Bootstrap grid: Authority Z39.50 search
Date: Mon, 26 Mar 2018 00:19:08 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5968026674704656739=="
--===============5968026674704656739==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946
Dilan Johnpullé changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #71384|0 |1
is obsolete| |
--- Comment #7 from Dilan Johnpullé ---
Created attachment 73274
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73274&action=edit
Bug 19946: (Follow-up) Add fixed footer to authorities Z39.50 popup
This patch adds additional Bootstrap framework markup to the search form
so that the "Save" and "Cancel" controls are in a fixed footer at the
bottom of the window. This prevents the controls from disappearing down
off screen.
This patch also adds some whitespace to the "Author
(meeting/conference)" label to enable better word wrapping.
To test, apply the patch and go to Authorities -> New from Z39.50/SRU.
In the popup window, both the search form and search results pages
should look correct.
Patch applies, form resizes, displays and functions as expected.
Signed-off-by: Dilan Johnpullé
--
You are receiving this mail because:
You are watching all bug changes.
--===============5968026674704656739==--
From bugzilla-daemon@bugs.koha-community.org Mon Mar 26 07:21:27 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use
Bootstrap grid: Authority Z39.50 search
Date: Mon, 26 Mar 2018 05:21:24 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7495111574842864577=="
--===============7495111574842864577==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
--===============7495111574842864577==--
From bugzilla-daemon@bugs.koha-community.org Mon Mar 26 07:21:35 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use
Bootstrap grid: Authority Z39.50 search
Date: Mon, 26 Mar 2018 05:21:28 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4300739683655694623=="
--===============4300739683655694623==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #71204|0 |1
is obsolete| |
Attachment #73274|0 |1
is obsolete| |
--- Comment #8 from Katrin Fischer ---
Created attachment 73275
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73275&action=edit
Bug 19946: Update popup window templates to use Bootstrap grid: Authority
Z39.50 search
This patch updates the authority Z39.50 search template to use the
Bootstrap grid instead of the YUI grid.
Also fixed: Some capitalization corrections, better
handling. This patch does not fix Bug 17119.
To test, apply the patch and go to Authorities -> New from Z39.50.
In the popup window, both the search form and search results pages
should look correct.
Signed-off-by: Te Rauhina Jackson
Signed-off-by: Te Rauhina Jackson
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
--===============4300739683655694623==--
From bugzilla-daemon@bugs.koha-community.org Mon Mar 26 07:21:56 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use
Bootstrap grid: Authority Z39.50 search
Date: Mon, 26 Mar 2018 05:21:53 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7437633771095838119=="
--===============7437633771095838119==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946
--- Comment #9 from Katrin Fischer ---
Created attachment 73276
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73276&action=edit
Bug 19946: (Follow-up) Add fixed footer to authorities Z39.50 popup
This patch adds additional Bootstrap framework markup to the search form
so that the "Save" and "Cancel" controls are in a fixed footer at the
bottom of the window. This prevents the controls from disappearing down
off screen.
This patch also adds some whitespace to the "Author
(meeting/conference)" label to enable better word wrapping.
To test, apply the patch and go to Authorities -> New from Z39.50/SRU.
In the popup window, both the search form and search results pages
should look correct.
Patch applies, form resizes, displays and functions as expected.
Signed-off-by: Dilan Johnpullé
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
--===============7437633771095838119==--
From bugzilla-daemon@bugs.koha-community.org Mon Mar 26 22:36:42 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use
Bootstrap grid: Authority Z39.50 search
Date: Mon, 26 Mar 2018 20:36:36 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3079961788043368908=="
--===============3079961788043368908==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D19946
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #10 from Jonathan Druart ---
Pushed to master for 18.05, thanks to everybody involved!
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============3079961788043368908==--
From bugzilla-daemon@bugs.koha-community.org Tue Apr 24 00:51:53 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use
Bootstrap grid: Authority Z39.50 search
Date: Mon, 23 Apr 2018 22:51:49 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4434478397808316856=="
--===============4434478397808316856==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to Master |RESOLVED
CC| |nick@bywatersolutions.com
--- Comment #11 from Nick Clemens ---
Awesome work all, enhancement, not backported for stable
--
You are receiving this mail because:
You are watching all bug changes.
--===============4434478397808316856==--