From bugzilla-daemon@bugs.koha-community.org Wed Feb 29 14:33:27 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] New: OPACNoResult, add search string to available parameters Date: Wed, 29 Feb 2012 13:36:53 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6135825343752958002==" --===============6135825343752958002== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7620 Bug #: 7620 Summary: OPACNoResult, add search string to available parameters Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC AssignedTo: paul.poulain@biblibre.com ReportedBy: paul.poulain@biblibre.com QAContact: koha.sekjal@gmail.com When OPACNoResult contain something, it would be usefull to be able to have t= he search string entered by the patron --=20 Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab= =3Demail ------- You are receiving this mail because: ------- You are watching all bug changes. --===============6135825343752958002==-- From bugzilla-daemon@bugs.koha-community.org Wed Feb 29 14:50:41 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Wed, 29 Feb 2012 13:54:07 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8569931270946903521==" --===============8569931270946903521== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7620 --- Comment #1 from Koha Team Lyon 3 2012-02-29 13:54:07= UTC --- Created attachment 7941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D7941 Bug 7620 OPACNoResult, add search string to available parameters This patch add the string entered by the user to OPACNoResultFound Test plan: * activate OPACNoResultFound and use "query_kw" somewhere. For example : Search on Google * try a search that return no result * you should see the link to search the query on google --=20 Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab= =3Demail ------- You are receiving this mail because: ------- You are watching all bug changes. --===============8569931270946903521==-- From bugzilla-daemon@bugs.koha-community.org Wed Feb 29 14:52:29 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Wed, 29 Feb 2012 13:55:55 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4946371329507218558==" --===============4946371329507218558== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7620 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --=20 Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab= =3Demail ------- You are receiving this mail because: ------- You are watching all bug changes. --===============4946371329507218558==-- From bugzilla-daemon@bugs.koha-community.org Wed Feb 29 14:52:48 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Wed, 29 Feb 2012 13:56:15 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0857560121001279751==" --===============0857560121001279751== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7620 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|paul.poulain@biblibre.com |koha@univ-lyon3.fr --=20 Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab= =3Demail ------- You are receiving this mail because: ------- You are watching all bug changes. --===============0857560121001279751==-- From bugzilla-daemon@bugs.koha-community.org Thu Mar 1 14:55:49 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Thu, 01 Mar 2012 13:59:19 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0812313700502418667==" --===============0812313700502418667== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7620 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #2 from Nicole C. Engard 2012-03-01 13:59:19 = UTC --- I have not tested this yet, but we should probably follow the style set forth in other preferences so instead of "query_kw" it should be "{query_kw}" maybe even in all caps. That's how it's done on the other preferences where we ent= er placeholders. Nicole --=20 Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab= =3Demail ------- You are receiving this mail because: ------- You are watching all bug changes. --===============0812313700502418667==-- From bugzilla-daemon@bugs.koha-community.org Sat Mar 10 19:06:33 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Sat, 10 Mar 2012 18:10:28 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8624137607711578324==" --===============8624137607711578324== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7620 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jcamins@cpbibliography.com --- Comment #3 from Jared Camins-Esakov --- I agree with Nicole. Using a literal string is inconsistent and just asking f= or trouble. --=20 You are receiving this mail because: You are watching all bug changes. --===============8624137607711578324==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 30 11:10:17 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Fri, 30 Mar 2012 09:15:12 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1848801584578180580==" --===============1848801584578180580== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7941|0 |1 is obsolete| | --- Comment #4 from Koha Team Lyon 3 --- Created attachment 8713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8713&action=edit OPACNoResults, add keyword to search string The same patch redone with place holder -- You are receiving this mail because: You are watching all bug changes. --===============1848801584578180580==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 30 11:11:04 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Fri, 30 Mar 2012 09:15:59 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4651640949239752199==" --===============4651640949239752199== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============4651640949239752199==-- From bugzilla-daemon@bugs.koha-community.org Mon Apr 9 12:30:49 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Mon, 09 Apr 2012 10:36:14 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6134700724218688609==" --===============6134700724218688609== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7620 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack --- I like the idea of this patch, but unfortunately it adds an xss vulnerability. For example, if I searched on=20 > th= at would be substituted and output (and run). OPACNoResult is not piped through the html filter, because then it couldn't have links in it, so it's not a simple fix to just change that. Probably the easiest fix is to run the $query_kw through HTML::Scrubber before substituting it in the syspref. --=20 You are receiving this mail because: You are watching all bug changes. --===============6134700724218688609==-- From bugzilla-daemon@bugs.koha-community.org Wed May 23 10:03:48 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Wed, 23 May 2012 08:11:25 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0139857510948114156==" --===============0139857510948114156== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7620 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Koha Team Lyon 3 --- Well, I try to see how to proceed with C4::Scrubber and how it had been alrea= dy used in other koha scripts like opac-tags.pl but I don't really get how to adapt it to the present case. However, if it's a question of sanitizing the $query_kw string before substitution, you 'll note that the regexp used to extract keywords does it since it keeps only alphanumeric characters (plus -): To pick your example, it goes like this : my $query_kw=3D''; then after theese lines : my @query_kw=3D($query_kw=3D~ /([-\w]+\b)(?:[^,:]|$)/g); my $query_kw=3Djoin('+',@query_kw); the output to be substituted will be : my $query_kw=3D'script+type+text+javascript+src+link+to+evil+js+script' may be, that could do the trick anyway ? --=20 You are receiving this mail because: You are watching all bug changes. --===============0139857510948114156==-- From bugzilla-daemon@bugs.koha-community.org Sun Jun 10 13:10:02 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Sun, 10 Jun 2012 11:18:36 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3713491361141864539==" --===============3713491361141864539== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7620 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |francois.charbonnier@biblib | |re.com --- Comment #7 from Francois Charbonnier = --- The patch does not apply : OPACNoResults, add keyword to search string Apply? [yn] y Applying: OPACNoResult, Add keyword to query string Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging opac/opac-search.pl CONFLICT (content): Merge conflict in opac/opac-search.pl Failed to merge in the changes. Patch failed at 0001 OPACNoResult, Add keyword to query string When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/OPACNoResults-add-keyword-to-search-string-cfak79.patch --=20 You are receiving this mail because: You are watching all bug changes. --===============3713491361141864539==-- From bugzilla-daemon@bugs.koha-community.org Mon Jun 11 16:42:42 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Mon, 11 Jun 2012 14:51:19 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1260867114629341464==" --===============1260867114629341464== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7620 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8713|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 10219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D10219&action=3De= dit OPACNoResult, Add keyword to query string This patch add the keywords to the string entered by the user to OPACNoResultFound Signed-off-by: Katrin Fischer Rebased 2012-06-11 Note: Patch does not work for search terms containing umlauts like =C3=A4=C3= =BC=C3=B6. Those characters are lost from the displayed search term. --=20 You are receiving this mail because: You are watching all bug changes. --===============1260867114629341464==-- From bugzilla-daemon@bugs.koha-community.org Mon Jun 11 16:42:57 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Mon, 11 Jun 2012 14:51:34 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2223476419464746712==" --===============2223476419464746712== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. --===============2223476419464746712==-- From bugzilla-daemon@bugs.koha-community.org Mon Jun 11 18:26:29 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Mon, 11 Jun 2012 16:35:07 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1348255222731819634==" --===============1348255222731819634== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 --- Comment #9 from Koha Team Lyon 3 --- Ok,I think I see the reason why now : The \w class can match accentuated characters (as it does at lyon3) but unfortunately only if the adequate set of locales is installed on the system. -- You are receiving this mail because: You are watching all bug changes. --===============1348255222731819634==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 12 18:46:30 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Tue, 12 Jun 2012 16:55:10 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1121441496253281103==" --===============1121441496253281103== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10219|0 |1 is obsolete| | --- Comment #10 from Koha Team Lyon 3 --- Created attachment 10253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10253&action=edit OPACNoResultsFound, Add keyword to query string Further investigations showed that was not a question of \w class with locales but an encoding problem on the keywords extracted -- You are receiving this mail because: You are watching all bug changes. --===============1121441496253281103==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 12 18:46:52 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Tue, 12 Jun 2012 16:55:32 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0285966147087172044==" --===============0285966147087172044== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============0285966147087172044==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 12 19:50:20 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Tue, 12 Jun 2012 17:59:00 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0184436153934938440==" --===============0184436153934938440== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #11 from Katrin Fischer --- I am sorry, but I think should be "needs signoff" for the improved patch. Thx for fixing it! -- You are receiving this mail because: You are watching all bug changes. --===============0184436153934938440==-- From bugzilla-daemon@bugs.koha-community.org Wed Jun 13 09:44:59 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Wed, 13 Jun 2012 07:53:41 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1150555241553173815==" --===============1150555241553173815== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 --- Comment #12 from Koha Team Lyon 3 --- Do you mean I declared "Signed Off" status instead of "Needs Signoff" ? If so, I'm sorry. -- You are receiving this mail because: You are watching all bug changes. --===============1150555241553173815==-- From bugzilla-daemon@bugs.koha-community.org Sat Jul 7 17:29:19 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Sat, 07 Jul 2012 15:39:13 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8322742351278801809==" --===============8322742351278801809== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Jared Camins-Esakov --- I just tested, and this patch does not work for me. Adding {QUERY_KW} to OPACNoResultsFound does not change the output at all (without this patch, the text {QUERY_KW} showed up). -- You are receiving this mail because: You are watching all bug changes. --===============8322742351278801809==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 9 09:43:46 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Mon, 09 Jul 2012 07:53:45 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3634677080835013595==" --===============3634677080835013595== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 --- Comment #14 from Koha Team Lyon 3 --- (In reply to comment #13) > I just tested, and this patch does not work for me. Adding {QUERY_KW} to > OPACNoResultsFound does not change the output at all (without this patch, > the text {QUERY_KW} showed up). strange... it works perfectly on our system, could you mention the query you had tested in OPACNoResultsFound and the keywords used ? -- You are receiving this mail because: You are watching all bug changes. --===============3634677080835013595==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 9 13:30:17 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Mon, 09 Jul 2012 11:40:16 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7476261004993982203==" --===============7476261004993982203== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 --- Comment #15 from Jared Camins-Esakov --- (In reply to comment #14) > (In reply to comment #13) > > I just tested, and this patch does not work for me. Adding {QUERY_KW} to > > OPACNoResultsFound does not change the output at all (without this patch, > > the text {QUERY_KW} showed up). > > strange... it works perfectly on our system, could you mention the query you > had tested in OPACNoResultsFound and the keywords used ? asflfsjsfja (no, that was not a typo) -- You are receiving this mail because: You are watching all bug changes. --===============7476261004993982203==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 9 13:58:56 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Mon, 09 Jul 2012 12:08:56 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4784100958434378157==" --===============4784100958434378157== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7620 --- Comment #16 from Koha Team Lyon 3 --- (In reply to comment #15) > (In reply to comment #14) > > (In reply to comment #13) > > > I just tested, and this patch does not work for me. Adding {QUERY_KW} to > > > OPACNoResultsFound does not change the output at all (without this patc= h, > > > the text {QUERY_KW} showed up). > >=20 > > strange... it works perfectly on our system, could you mention the query = you > > had tested in OPACNoResultsFound and the keywords used ? >=20 > asflfsjsfja (no, that was not a typo) Thanks for the keyword but what was your full query (the one you put in OPACNoResultsFound) ? --=20 You are receiving this mail because: You are watching all bug changes. --===============4784100958434378157==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 9 14:06:44 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Mon, 09 Jul 2012 12:16:43 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8878602575489815652==" --===============8878602575489815652== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7620 --- Comment #17 from Jared Camins-Esakov --- (In reply to comment #16) > (In reply to comment #15) > > (In reply to comment #14) > > > (In reply to comment #13) > > > > I just tested, and this patch does not work for me. Adding {QUERY_KW}= to > > > > OPACNoResultsFound does not change the output at all (without this pa= tch, > > > > the text {QUERY_KW} showed up). > > >=20 > > > strange... it works perfectly on our system, could you mention the quer= y you > > > had tested in OPACNoResultsFound and the keywords used ? > >=20 > > asflfsjsfja (no, that was not a typo) >=20 > Thanks for the keyword but what was your full query (the one you put in > OPACNoResultsFound) ? Sorry, I thought you meant the query I entered into Koha. I tried it with the following in OPACNoResultsFound: Search elsewhere: Google for {QUERY_KW}. --=20 You are receiving this mail because: You are watching all bug changes. --===============8878602575489815652==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 9 15:53:48 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Mon, 09 Jul 2012 14:03:48 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5072067111328573270==" --===============5072067111328573270== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7620 --- Comment #18 from Koha Team Lyon 3 --- (In reply to comment #15) > (In reply to comment #14) > > (In reply to comment #13) > > > I just tested, and this patch does not work for me. Adding {QUERY_KW} to > > > OPACNoResultsFound does not change the output at all (without this patc= h, > > > the text {QUERY_KW} showed up). > >=20 > > strange... it works perfectly on our system, could you mention the query = you > > had tested in OPACNoResultsFound and the keywords used ? >=20 > asflfsjsfja (no, that was not a typo) Thanks for the keyword but what was your full query (the one you put in OPACNoResultsFound) ?(In reply to comment #17) > (In reply to comment #16) > > (In reply to comment #15) > > > (In reply to comment #14) > > > > (In reply to comment #13) > > > > > I just tested, and this patch does not work for me. Adding {QUERY_K= W} to > > > > > OPACNoResultsFound does not change the output at all (without this = patch, > > > > > the text {QUERY_KW} showed up). > > > >=20 > > > > strange... it works perfectly on our system, could you mention the qu= ery you > > > > had tested in OPACNoResultsFound and the keywords used ? > > >=20 > > > asflfsjsfja (no, that was not a typo) > >=20 > > Thanks for the keyword but what was your full query (the one you put in > > OPACNoResultsFound) ? >=20 > Sorry, I thought you meant the query I entered into Koha. I tried it with > the following in OPACNoResultsFound: Search elsewhere: href=3D"www.google.com/?q=3D{QUERY_KW}">Google for {QUERY_KW}. Your url and keyword works on our system, the substitution is done : www.google.com/?q=3Dasflfsjsfja I have no idea why it doesn't on your system. But I noted another point to be fixed : without the http mention in href attribute (href=3D"http://www.google...) the address is searched in the web directory of koha. --=20 You are receiving this mail because: You are watching all bug changes. --===============5072067111328573270==-- From bugzilla-daemon@bugs.koha-community.org Tue Jul 10 07:52:50 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Tue, 10 Jul 2012 06:02:51 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7112433036097792726==" --===============7112433036097792726== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 --- Comment #19 from Katrin Fischer --- Hi, I retested this on my system and it works nicely - could it be some kind of configuration issue? I tried: - simple keyword searches - searches from the advanced search page with different indexes - Umlaut searches The content of my system preference is: Something {QUERY_KW} -- You are receiving this mail because: You are watching all bug changes. --===============7112433036097792726==-- From bugzilla-daemon@bugs.koha-community.org Wed Aug 22 16:09:27 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Wed, 22 Aug 2012 14:21:39 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1926324897341196060==" --===============1926324897341196060== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #20 from Jonathan Druart --- "It works for me" But (qa comment): it is useless to generate $query_kw if the syspref does not match {QUERY_KW}, please use if( $var =~ m/{QUERY_KW}/ ). -- You are receiving this mail because: You are watching all bug changes. --===============1926324897341196060==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 11 16:11:44 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Thu, 11 Oct 2012 14:26:27 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6690715458421382912==" --===============6690715458421382912== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10253|0 |1 is obsolete| | --- Comment #21 from Koha Team Lyon 3 --- Created attachment 12773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12773&action=edit OPACNoResult Add keyword to query string patch redone according to your suggestion -- You are receiving this mail because: You are watching all bug changes. --===============6690715458421382912==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 11 16:11:51 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Thu, 11 Oct 2012 14:26:35 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1834937670092066320==" --===============1834937670092066320== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============1834937670092066320==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 25 11:06:23 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Thu, 25 Oct 2012 09:21:47 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5651018257586494700==" --===============5651018257586494700== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============5651018257586494700==-- From bugzilla-daemon@bugs.koha-community.org Fri Dec 21 16:41:51 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Fri, 21 Dec 2012 15:41:41 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8607290976729327784==" --===============8607290976729327784== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12773|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall --- Created attachment 14236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14236&action=edit [SIGNED-OFF] OPACNoResult, Add keyword to query string When search failed, this patch gets the keyword(s) and add them to the string entered by the user to OPACNoResultFound http://bugs.koha-community.org/show_bug.cgi?id=7620 Signed-off-by: Kyle M Hall Tested by setting OPACNoResultsFound to 'Search elsewhere: Google for {QUERY_KW}' -- You are receiving this mail because: You are watching all bug changes. --===============8607290976729327784==-- From bugzilla-daemon@bugs.koha-community.org Fri Dec 21 16:42:40 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Fri, 21 Dec 2012 15:42:36 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1590717411188464894==" --===============1590717411188464894== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. --===============1590717411188464894==-- From bugzilla-daemon@bugs.koha-community.org Fri Dec 21 16:50:31 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Fri, 21 Dec 2012 15:50:25 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0797639744068158185==" --===============0797639744068158185== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|koha.sekjal@gmail.com |jonathan.druart@biblibre.co | |m --- Comment #23 from Jonathan Druart --- QA Comments: Now it is ok for me. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. --===============0797639744068158185==-- From bugzilla-daemon@bugs.koha-community.org Fri Dec 21 16:51:06 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Fri, 21 Dec 2012 15:50:52 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2766631894720462539==" --===============2766631894720462539== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14236|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 14240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14240&action=edit OPACNoResult, Add keyword to query string When search failed, this patch gets the keyword(s) and add them to the string entered by the user to OPACNoResultFound http://bugs.koha-community.org/show_bug.cgi?id=7620 Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. --===============2766631894720462539==-- From bugzilla-daemon@bugs.koha-community.org Sat Dec 22 22:46:36 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters Date: Sat, 22 Dec 2012 21:46:29 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1089466735019477991==" --===============1089466735019477991== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #25 from Jared Camins-Esakov --- This patch has been pushed to master. As a reminder for future patches, please be sure to include the bug number in the patch subject (first line of the commit message) -- You are receiving this mail because: You are watching all bug changes. --===============1089466735019477991==--