From bugzilla-daemon@bugs.koha-community.org Sun Nov  6 06:31:59 2011
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 7181] New: Template indentation
Date: Sun, 06 Nov 2011 05:31:57 +0000
Message-ID: <bug-7181-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7659289221800399059=="

--===============7659289221800399059==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7181

             Bug #: 7181
           Summary: Template indentation
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: master
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P3
         Component: Architecture, internals, and plumbing
        AssignedTo: paul.poulain@biblibre.com
        ReportedBy: paul.poulain@biblibre.com
         QAContact: ian.walls@bywatersolutions.com
            Blocks: 7119


The template indentation make it very hard to read. For example, in
circulation.tt:
    [% IF ( MARCURLS ) %]
    <div class=3D"results_summary"><span class=3D"label">Online Resources:</s=
pan>
    <ul>    [% FOREACH MARCurl IN MARCURLS %]
        <li>[% IF ( MARCurl.part ) %][% MARCurl.part %]
            <br />[% END %]=20
        <!-- here you might do a tmpl_if name=3D"toc" and use greybox or
equivalent for table of contents -->

        [% IF ( MARCurl.OPACurlOpenInNewWindow ) %]<a href=3D"[% MARCurl.MARC=
URL
%]" title=3D"[% MARCurl.MARCURL %]" target=3D"_blank">[% ELSE %]<a href=3D"[%
MARCurl.MARCURL %]" title=3D"[% MARCurl.MARCURL %]">[% END %]

        [% MARCurl.linktext %]</a>
            [% IF ( MARCurl.notes ) %]<ul>[% FOREACH note IN MARCurl.notes
%]<li>[% note.note %]</li>[% END %]</ul>[% END %]</li>
            [% END %]</ul>
    </div>
    [% END %]

The last end, that is aligned with the first [IF] don't close this if...

During kohacon11 hackfest, we tried to investigate how to indent templates.
We haven't found THE solution, but here are a few links (thanks mason) :
http://www.perlmonks.org/?node_id=3D887632
http://wiki.dandascalescu.com/howtos/indenting_tt_and_html

--=20
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=
=3Demail
------- You are receiving this mail because: -------
You are watching all bug changes.

--===============7659289221800399059==--


From bugzilla-daemon@bugs.koha-community.org Wed Jan 20 04:15:57 2016
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 7181] Template indentation
Date: Wed, 20 Jan 2016 03:15:50 +0000
Message-ID: <bug-7181-70-awsPEMIkOH@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-7181-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4866467156550973254=="

--===============4866467156550973254==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7181

natasha <tasham_8@hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|paul.poulain@biblibre.com   |tasham_8@hotmail.com
                 CC|                            |tasham_8@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4866467156550973254==--


From bugzilla-daemon@bugs.koha-community.org Wed Jan 20 22:03:56 2016
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 7181] Template indentation
Date: Wed, 20 Jan 2016 21:03:53 +0000
Message-ID: <bug-7181-70-3M0bClTjOZ@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-7181-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5123922635458630083=="

--===============5123922635458630083==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7181

--- Comment #1 from natasha <tasham_8@hotmail.com> ---
Created attachment 47050
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47050&action=edit
Screenshot of code

This looks like it has already been fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5123922635458630083==--