From bugzilla-daemon@bugs.koha-community.org Tue Oct 31 21:04:31 2017
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to	Circulation
 and OPAC
Date: Tue, 31 Oct 2017 20:04:26 +0000
Message-ID: <bug-7317-70-6e5x85SPpm@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0500714130539409726=="

--===============0500714130539409726==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7317

--- Comment #167 from Magnus Enger <magnus@libriotech.no> ---
As far as I can see, these are the remaining problems pointed to by the qa
script, that can actually be fixed:

 FAIL   Koha/Exceptions/Ill.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=3DPackageName -e666
   OK     spelling
   OK     valid

I think Tomas introduced this in a followup. He can probably add a little bit
of POD to it.=20

 FAIL   Koha/Illrequestattributes.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
                POD is missing for 'object_class'
   OK     spelling
   OK     valid

 FAIL   Koha/Illrequests.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
                POD is missing for 'object_class'
   OK     spelling
   OK     valid

These two files do have some subs that are missing POD. I can look at that
again tomorrow.=20

 FAIL   installer/data/mysql/atomicupdate/ill_tables.sql
   FAIL   git manipulation
                The file has been added and deleted in the same patchset

Not sure how we can fix this without redoing completely the patches from Alex=
?=20

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   FAIL   tt_valid
                lines 665
   FAIL   valid_template
                : not found

The codes mixes TT directives and HTML rather intimately:=20

665                   <table
666                       [% FOREACH filter IN prefilters %]
667                       data-filter-[% filter.name %]=3D"[% filter.value %]"
668                       [% END %]
669                       id=3D"ill-requests">

Not sure how we can do it differently, though?

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============0500714130539409726==--