From bugzilla-daemon@bugs.koha-community.org Fri Apr 27 22:22:20 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20675] New: Bad html in message_queue.content
 corrupts members/notices.pl
Date: Fri, 27 Apr 2018 20:22:17 +0000
Message-ID: <bug-20675-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0327248189954517094=="

--===============0327248189954517094==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20675

            Bug ID: 20675
           Summary: Bad html in message_queue.content corrupts
                    members/notices.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs@lists.koha-community.org
          Reporter: barton@bywatersolutions.com
        QA Contact: testopia@bugs.koha-community.org

Bad html in letter.content will be written to message_queue.content, which can
corrupt the display of members/notices.pl

To re-create:

1) Edit a notice which will show up in the message queue.
2) Make sure 'HTML message' is checked.
3) Add <a href="http://example.com>example.com</a>
   (notice the missing quotes at the end of 
    http://example.com>example.com in the 
    href attribute)
4) Trigger the notice for a given patron
5) Go to the patron's notices tab
6) Trying to expand any of the notices is now broken due to html corruption.

This affects users directly, furthermore, simply fixing the letter template
isn't enough because the corrupted html stays in message_queue.content. It can
only be fixed by updating message_queue.content directly via the database.

We should validate html on any page where the 'HTML message' box is checked in
tools/letter.pl.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============0327248189954517094==--


From bugzilla-daemon@bugs.koha-community.org Fri Apr 27 22:25:07 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20675] Bad html in message_queue.content corrupts
 members/notices.pl
Date: Fri, 27 Apr 2018 20:25:04 +0000
Message-ID: <bug-20675-70-Abz7Bhn9AW@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20675-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8425544024944020674=="

--===============8425544024944020674==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20675

Barton Chittenden <barton@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============8425544024944020674==--


From bugzilla-daemon@bugs.koha-community.org Mon Apr 30 00:18:31 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20675] Bad html in message_queue.content corrupts
 members/notices.pl
Date: Sun, 29 Apr 2018 22:18:00 +0000
Message-ID: <bug-20675-70-GoDbTHJOU0@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20675-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3378724816479541510=="

--===============3378724816479541510==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20675

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer@bsz-bw.de
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
This was just fixed recently (bug 12123)

*** This bug has been marked as a duplicate of bug 12123 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============3378724816479541510==--