From bugzilla-daemon@bugs.koha-community.org Fri Jan 29 11:51:47 2016
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client
Date: Fri, 29 Jan 2016 10:51:44 +0000
Message-ID: <bug-12051-70-qWMRwGapbi@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-12051-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6924723948566252730=="

--===============6924723948566252730==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D12051

--- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org=
> ---
Aleisha,
I have amended your patch to remove files where only 1 line where
added/removed.
I have also fixed a 3 vs 2:

+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/suggestions-add-search.inc
@@ -23,10 +23,11 @@
                </form>
        </div>
        [% END %]
+
                        <ul>
             <li><a href=3D"#suggestions_search">Search suggestions</a></li>
             [% IF ( CAN_user_circulate ) %]<li><a onclick=3D"keep_text(0)"
href=3D"#circ_search">Check out</a></li>[% END %]
-            [% IF ( CAN_user_catalogue ) %]<li><a onclick=3D"keep_text(1)"
href=3D"#catalog_search">Search the catalog</a></li>[% END %]
+            [% IF ( CAN_user_catalogue ) %]<li><a onclick=3D"keep_text(2)"
href=3D"#catalog_search">Search the catalog</a></li>[% END %]
             </ul>
 </div>


I was going to pass QA on this patch, but I am wondering if the permission
should not be CAN_user_circulate_circulate_remaining_permissions instead of
CAN_user_circulate. Indeed the circ/renew.pl script needs only this subperm.

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============6924723948566252730==--