From bugzilla-daemon@bugs.koha-community.org Thu May  5 13:03:37 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 30689] New: Incorrect Babeltheque setting can cause
 console warning
Date: Thu, 05 May 2022 11:03:36 +0000
Message-ID: <bug-30689-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7013317869942842302=="

--===============7013317869942842302==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30689

            Bug ID: 30689
           Summary: Incorrect Babeltheque setting can cause console
                    warning
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: trivial
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard@myacpl.org
          Reporter: oleonard@myacpl.org
        QA Contact: testopia@bugs.koha-community.org

If you have the "Babeltheque" system preference enabled but the
"Babeltheque_url_js" preference is empty, the template will generate an empty
<script> tag. This triggers a warning in the browser console.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7013317869942842302==--


From bugzilla-daemon@bugs.koha-community.org Thu May  5 13:25:46 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 30689] Incorrect Babeltheque setting can cause
 console warning
Date: Thu, 05 May 2022 11:25:46 +0000
Message-ID: <bug-30689-70-ywGaDHXgX3@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-30689-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0757963537132021141=="

--===============0757963537132021141==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30689

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0757963537132021141==--


From bugzilla-daemon@bugs.koha-community.org Thu May  5 13:25:56 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 30689] Incorrect Babeltheque setting can cause
 console warning
Date: Thu, 05 May 2022 11:25:49 +0000
Message-ID: <bug-30689-70-tsdKLpBIYM@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-30689-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7535170679882999335=="

--===============7535170679882999335==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30689

--- Comment #1 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 134635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134635&action=edit
Bug 30689: Incorrect Babeltheque setting can cause console warning

This patch adds an additional system preference check to the part of the
OPAC bibliographic detail template which conditionally loads Babelthèque
JavaScript. The script tag should not be output if there is no
Babeltheque_url_js setting to use.

To test, apply the patch and search for "Babeltheque" in system
preferences.

 - Set "Babeltheque" to "Do" include information.
 - Enter a path in the "Babeltheque_url_js" preference, e.g.
   "https://www.example.com/example.js" It doesn't have to be a valid
   Babeltheque URL.
 - In the OPAC, view the bibliographic detail page for any title. If you
   used a dummy URL for the js preference you should see an error in the
   console about the file not being found. This confirms that the
   template logic is working. If you used a working Babeltheque URL then
   the corresponding content should load.
 - Return to system preferences and remove the URL from the
   "Babeltheque_url_js" preference.
 - Return to the bibliographic detail page in the OPAC and confirm that
   there is no warning in the console about "'src' attribute of <script>
   element is empty."

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7535170679882999335==--


From bugzilla-daemon@bugs.koha-community.org Mon May  9 07:59:22 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 30689] Incorrect Babeltheque setting can cause
 console warning
Date: Mon, 09 May 2022 05:59:21 +0000
Message-ID: <bug-30689-70-EI30OlrSKd@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-30689-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3181762567470748184=="

--===============3181762567470748184==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30689

David Nind <david@davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3181762567470748184==--


From bugzilla-daemon@bugs.koha-community.org Mon May  9 07:59:32 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 30689] Incorrect Babeltheque setting can cause
 console warning
Date: Mon, 09 May 2022 05:59:26 +0000
Message-ID: <bug-30689-70-J7RQlxGu7h@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-30689-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7721991901148246257=="

--===============7721991901148246257==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30689

David Nind <david@davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134635|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david@davidnind.com> ---
Created attachment 134773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134773&action=edit
Bug 30689: Incorrect Babeltheque setting can cause console warning

This patch adds an additional system preference check to the part of the
OPAC bibliographic detail template which conditionally loads Babelthèque
JavaScript. The script tag should not be output if there is no
Babeltheque_url_js setting to use.

To test, apply the patch and search for "Babeltheque" in system
preferences.

 - Set "Babeltheque" to "Do" include information.
 - Enter a path in the "Babeltheque_url_js" preference, e.g.
   "https://www.example.com/example.js" It doesn't have to be a valid
   Babeltheque URL.
 - In the OPAC, view the bibliographic detail page for any title. If you
   used a dummy URL for the js preference you should see an error in the
   console about the file not being found. This confirms that the
   template logic is working. If you used a working Babeltheque URL then
   the corresponding content should load.
 - Return to system preferences and remove the URL from the
   "Babeltheque_url_js" preference.
 - Return to the bibliographic detail page in the OPAC and confirm that
   there is no warning in the console about "'src' attribute of <script>
   element is empty."

Signed-off-by: David Nind <david@davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7721991901148246257==--


From bugzilla-daemon@bugs.koha-community.org Mon May  9 08:18:23 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 30689] Incorrect Babeltheque setting can cause
 console warning
Date: Mon, 09 May 2022 06:18:23 +0000
Message-ID: <bug-30689-70-T9ern0qQ3X@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-30689-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6675388832069080469=="

--===============6675388832069080469==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D30689

David Nind <david@davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david@davidnind.com

--- Comment #3 from David Nind <david@davidnind.com> ---
Testing notes (koha-testing-docker):

- Warning message in browser console before patch applied: =E2=80=98src=E2=80=
=99 attribute of
<script> element is empty.

- There was then an empty script tag in the browser source file for the page:
<script src=3D" "></script>

- This was just after this text in the browser source file:

      <div class=3D"babeltheque_adds">
           <div id=3D"BW_critiques_aj"></div>
            <div id=3D"BW_citations_aj"></div>
      </div>

- When patch applied, these were the console error messages:
  . GET https://www.example.com/example.js [HTTP/2 404 Not Found 1554ms]
  . Loading failed for the <script> with source
=E2=80=9Chttps://www.example.com/example.js=E2=80=9D.

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============6675388832069080469==--


From bugzilla-daemon@bugs.koha-community.org Fri May 13 09:17:30 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 30689] Incorrect Babeltheque setting can cause
 console warning
Date: Fri, 13 May 2022 07:17:30 +0000
Message-ID: <bug-30689-70-BIJ6xA7SVy@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-30689-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8322005591961915472=="

--===============8322005591961915472==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30689

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8322005591961915472==--


From bugzilla-daemon@bugs.koha-community.org Fri May 13 09:17:41 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 30689] Incorrect Babeltheque setting can cause
 console warning
Date: Fri, 13 May 2022 07:17:33 +0000
Message-ID: <bug-30689-70-cd4fqoyWXH@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-30689-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6753477605017693437=="

--===============6753477605017693437==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30689

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134773|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 134944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134944&action=edit
Bug 30689: Incorrect Babeltheque setting can cause console warning

This patch adds an additional system preference check to the part of the
OPAC bibliographic detail template which conditionally loads Babelthèque
JavaScript. The script tag should not be output if there is no
Babeltheque_url_js setting to use.

To test, apply the patch and search for "Babeltheque" in system
preferences.

 - Set "Babeltheque" to "Do" include information.
 - Enter a path in the "Babeltheque_url_js" preference, e.g.
   "https://www.example.com/example.js" It doesn't have to be a valid
   Babeltheque URL.
 - In the OPAC, view the bibliographic detail page for any title. If you
   used a dummy URL for the js preference you should see an error in the
   console about the file not being found. This confirms that the
   template logic is working. If you used a working Babeltheque URL then
   the corresponding content should load.
 - Return to system preferences and remove the URL from the
   "Babeltheque_url_js" preference.
 - Return to the bibliographic detail page in the OPAC and confirm that
   there is no warning in the console about "'src' attribute of <script>
   element is empty."

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6753477605017693437==--


From bugzilla-daemon@bugs.koha-community.org Fri May 13 10:17:31 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 30689] Incorrect Babeltheque setting can cause
 console warning
Date: Fri, 13 May 2022 08:17:17 +0000
Message-ID: <bug-30689-70-JFDyU39i9K@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-30689-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8280239308722929321=="

--===============8280239308722929321==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30689

Fridolin Somers <fridolin.somers@biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8280239308722929321==--


From bugzilla-daemon@bugs.koha-community.org Fri May 13 10:17:41 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 30689] Incorrect Babeltheque setting can cause
 console warning
Date: Fri, 13 May 2022 08:17:19 +0000
Message-ID: <bug-30689-70-UgG09WeRkk@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-30689-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1090810877587523166=="

--===============1090810877587523166==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30689

--- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> ---
Pushed to master for 22.05, thanks to everybody involved 🦄

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1090810877587523166==--