From bugzilla-daemon@bugs.koha-community.org Thu May 23 17:49:44 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22979] New: Remove type attribute from script	tags:
 Authorities
Date: Thu, 23 May 2019 15:49:41 +0000
Message-ID: <bug-22979-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2269643212325262244=="

--===============2269643212325262244==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22979

            Bug ID: 22979
           Summary: Remove type attribute from script tags: Authorities
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard@myacpl.org
          Reporter: oleonard@myacpl.org
        QA Contact: testopia@bugs.koha-community.org
                CC: testopia@bugs.koha-community.org
            Blocks: 22956
  Target Milestone: ---

This patch will remove the obsolete "type" attribute from <script> tags in the
following authorities templates:

 - intranet-tmpl\prog\en\modules\authorities\auth_finder.tt
 - intranet-tmpl\prog\en\modules\authorities\authorities.tt
 - intranet-tmpl\prog\en\modules\authorities\blinddetail-biblio-search.tt
 - intranet-tmpl\prog\en\modules\authorities\detail.tt
 - intranet-tmpl\prog\en\modules\authorities\searchresultlist-auth.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22956
[Bug 22956] Omnibus: Remove type attribute from script tags
-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2269643212325262244==--


From bugzilla-daemon@bugs.koha-community.org Thu May 23 19:45:52 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22979] Remove type attribute from script tags:	Authorities
Date: Thu, 23 May 2019 17:45:49 +0000
Message-ID: <bug-22979-70-M657xM3dL0@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22979-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5672047177674595042=="

--===============5672047177674595042==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22979

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5672047177674595042==--


From bugzilla-daemon@bugs.koha-community.org Thu May 23 19:45:55 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22979] Remove type attribute from script tags:	Authorities
Date: Thu, 23 May 2019 17:45:51 +0000
Message-ID: <bug-22979-70-cQNdETaA39@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22979-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4492091283886520342=="

--===============4492091283886520342==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22979

--- Comment #1 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 90045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90045&action=edit
Bug 22979: Remove type attribute from script tags: Authorities

This patch removes the "type" attribute from <script> tags in several
authorities templates. Also removed: Obsolete "//<![CDATA[ //]]>"
markers.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Authorities -> Search -> View authority record
 - Authorities -> Search -> Edit authority record
 - Cataloging -> New record
   - Trigger the authority search form by clicking the plugin link next
     to a tag which has been linked to an authority type (e.g. 100a ->
     Personal name).
   - Search for an authority record.
   - Select an authority record.

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4492091283886520342==--


From bugzilla-daemon@bugs.koha-community.org Thu May 23 20:51:22 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22979] Remove type attribute from script tags:	Authorities
Date: Thu, 23 May 2019 18:51:19 +0000
Message-ID: <bug-22979-70-hGd8hDBHRm@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22979-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7794195583458554675=="

--===============7794195583458554675==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22979

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7794195583458554675==--


From bugzilla-daemon@bugs.koha-community.org Fri May 24 01:27:52 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22979] Remove type attribute from script tags:	Authorities
Date: Thu, 23 May 2019 23:27:50 +0000
Message-ID: <bug-22979-70-CGohhR9is2@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22979-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7963149797227110517=="

--===============7963149797227110517==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22979

Hayley Mapley <hayleymapley@catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7963149797227110517==--


From bugzilla-daemon@bugs.koha-community.org Fri May 24 01:27:57 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22979] Remove type attribute from script tags:	Authorities
Date: Thu, 23 May 2019 23:27:53 +0000
Message-ID: <bug-22979-70-oadvxS7tLl@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22979-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1276241231921845104=="

--===============1276241231921845104==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22979

Hayley Mapley <hayleymapley@catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90045|0                           |1
        is obsolete|                            |

--- Comment #2 from Hayley Mapley <hayleymapley@catalyst.net.nz> ---
Created attachment 90057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90057&action=edit
Bug 22979: Remove type attribute from script tags: Authorities

This patch removes the "type" attribute from <script> tags in several
authorities templates. Also removed: Obsolete "//<![CDATA[ //]]>"
markers.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Authorities -> Search -> View authority record
 - Authorities -> Search -> Edit authority record
 - Cataloging -> New record
   - Trigger the authority search form by clicking the plugin link next
     to a tag which has been linked to an authority type (e.g. 100a ->
     Personal name).
   - Search for an authority record.
   - Select an authority record.

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1276241231921845104==--


From bugzilla-daemon@bugs.koha-community.org Mon May 27 22:52:24 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22979] Remove type attribute from script tags:	Authorities
Date: Mon, 27 May 2019 20:52:22 +0000
Message-ID: <bug-22979-70-XuHVBbmmfe@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22979-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3065640900078725692=="

--===============3065640900078725692==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22979

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90057|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 90126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90126&action=edit
Bug 22979: Remove type attribute from script tags: Authorities

This patch removes the "type" attribute from <script> tags in several
authorities templates. Also removed: Obsolete "//<![CDATA[ //]]>"
markers.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Authorities -> Search -> View authority record
 - Authorities -> Search -> Edit authority record
 - Cataloging -> New record
   - Trigger the authority search form by clicking the plugin link next
     to a tag which has been linked to an authority type (e.g. 100a ->
     Personal name).
   - Search for an authority record.
   - Select an authority record.

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

https://bugs.koha-community.org/show_bug.cgi?id=22797

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3065640900078725692==--


From bugzilla-daemon@bugs.koha-community.org Mon May 27 22:52:48 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22979] Remove type attribute from script tags:	Authorities
Date: Mon, 27 May 2019 20:52:18 +0000
Message-ID: <bug-22979-70-riLuxVyFUp@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22979-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1287264629273999133=="

--===============1287264629273999133==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22979

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1287264629273999133==--


From bugzilla-daemon@bugs.koha-community.org Thu May 30 12:40:10 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22979] Remove type attribute from script tags:	Authorities
Date: Thu, 30 May 2019 10:40:07 +0000
Message-ID: <bug-22979-70-ZxeR6dDa2d@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22979-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6585949310095329373=="

--===============6585949310095329373==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22979

Nick Clemens <nick@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick@bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Nick Clemens <nick@bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6585949310095329373==--