From bugzilla-daemon@bugs.koha-community.org Wed Aug 7 16:59:49 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37595] New: Double HTML escaped ampersand in pagination bar Date: Wed, 07 Aug 2024 14:59:47 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3130809464541539223==" --===============3130809464541539223== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D37595 Bug ID: 37595 Summary: Double HTML escaped ampersand in pagination bar Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Since Bug 30969 pagination bar contains double HTML escaped ampersand '&'. For example in reports page 2 link is : 2 --=20 You are receiving this mail because: You are watching all bug changes. --===============3130809464541539223==-- From bugzilla-daemon@bugs.koha-community.org Wed Aug 7 16:59:59 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37595] Double HTML escaped ampersand in pagination bar Date: Wed, 07 Aug 2024 14:59:54 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5397348684067477406==" --===============5397348684067477406== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37595 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30969 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30969 [Bug 30969] Cross site scripting (XSS) attack in OPAC authority search ( opac-authorities-home.pl ) -- You are receiving this mail because: You are watching all bug changes. --===============5397348684067477406==-- From bugzilla-daemon@bugs.koha-community.org Wed Aug 7 17:00:41 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37595] Double HTML escaped ampersand in pagination bar Date: Wed, 07 Aug 2024 15:00:40 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5537371267317958584==" --===============5537371267317958584== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37595 --- Comment #1 from Fridolin Somers --- Looks like Firefox deals with it but still a bug right ? -- You are receiving this mail because: You are watching all bug changes. --===============5537371267317958584==-- From bugzilla-daemon@bugs.koha-community.org Wed Aug 7 18:08:14 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37595] Double HTML escaped ampersand in pagination bar Date: Wed, 07 Aug 2024 16:08:14 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8264395235612062618==" --===============8264395235612062618== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D37595 --- Comment #2 from Owen Leonard --- For this particular case it looks like we can convert the '&' to '&' in guided_reports.pl between line 974 and 979. Generally, it looks like we're using '&' in a lot of Perl code where I don't think we need to. For instance at line 345 of basketgroup.pl: print $input->redirect('/cgi-bin/koha/acqui/basketgroup.pl?booksellerid=3D' . $booksellerid.'&listclosed=3D1'); There's no need to encode that &. I'm guessing that in most places we use &am= p; it's because obsolete XHTML validator rules required us to. A current validat= or won't complain about it and I question whether there are places that require = it for other reasons. --=20 You are receiving this mail because: You are watching all bug changes. --===============8264395235612062618==-- From bugzilla-daemon@bugs.koha-community.org Thu Aug 8 01:58:00 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37595] Double HTML escaped ampersand in pagination bar Date: Wed, 07 Aug 2024 23:57:59 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8383257805948152893==" --===============8383257805948152893== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37595 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #3 from David Cook --- (In reply to Owen Leonard from comment #2) > For this particular case it looks like we can convert the '&' to '&' in > guided_reports.pl between line 974 and 979. > Generally, it looks like we're using '&' in a lot of Perl code where I > don't think we need to. For instance at line 345 of basketgroup.pl: > There's no need to encode that &. I'm guessing that in most places we use > & it's because obsolete XHTML validator rules required us to. A current > validator won't complain about it and I question whether there are places > that require it for other reasons. +1 -- You are receiving this mail because: You are watching all bug changes. --===============8383257805948152893==-- From bugzilla-daemon@bugs.koha-community.org Thu Aug 8 02:00:06 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37595] Double HTML escaped ampersand in pagination bar Date: Thu, 08 Aug 2024 00:00:05 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6973697307560944023==" --===============6973697307560944023== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37595 --- Comment #4 from David Cook --- I'm not sure about bug 30969 either but... -- You are receiving this mail because: You are watching all bug changes. --===============6973697307560944023==-- From bugzilla-daemon@bugs.koha-community.org Thu Aug 8 20:01:31 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37595] Double HTML escaped ampersand in pagination bar Date: Thu, 08 Aug 2024 18:01:30 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2145143140997069582==" --===============2145143140997069582== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37595 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============2145143140997069582==-- From bugzilla-daemon@bugs.koha-community.org Thu Aug 8 20:01:41 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37595] Double HTML escaped ampersand in pagination bar Date: Thu, 08 Aug 2024 18:01:32 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2507976668329156825==" --===============2507976668329156825== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D37595 --- Comment #5 from Owen Leonard --- Created attachment 170162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D170162&action= =3Dedit Bug 37595: Double HTML escaped ampersand in pagination bar This patch removes escaping of ampersands in the part of guided_reports.pl that builds information for the pagination routine. The information is going to be escaped in a later step. To test, apply the patch and go to Reports. - If necessary, create a report which will return more than 20 results. - Run the report. You should see a pagination bar at the top of the table of results. - View the page source and look for the markup for the pagination menu. Searching for 'rel=3D"start"' works well. - Confirm that you see '&' between the link parameters instead of '&', e.g. =20 guided_reports.pl?id=3D347&op=3Drun&limit=3D20&want_full_chart=3D= 0&page=3D1 --=20 You are receiving this mail because: You are watching all bug changes. --===============2507976668329156825==-- From bugzilla-daemon@bugs.koha-community.org Fri Aug 9 10:18:45 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37595] Double HTML escaped ampersand in pagination bar Date: Fri, 09 Aug 2024 08:18:44 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8016419625375773859==" --===============8016419625375773859== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37595 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============8016419625375773859==-- From bugzilla-daemon@bugs.koha-community.org Fri Aug 9 10:18:55 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37595] Double HTML escaped ampersand in pagination bar Date: Fri, 09 Aug 2024 08:18:47 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2541751734054497197==" --===============2541751734054497197== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D37595 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170162|0 |1 is obsolete| | --- Comment #6 from Fridolin Somers --- Created attachment 170170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D170170&action= =3Dedit Bug 37595: Double HTML escaped ampersand in pagination bar This patch removes escaping of ampersands in the part of guided_reports.pl that builds information for the pagination routine. The information is going to be escaped in a later step. To test, apply the patch and go to Reports. - If necessary, create a report which will return more than 20 results. - Run the report. You should see a pagination bar at the top of the table of results. - View the page source and look for the markup for the pagination menu. Searching for 'rel=3D"start"' works well. - Confirm that you see '&' between the link parameters instead of '&', e.g. =20 guided_reports.pl?id=3D347&op=3Drun&limit=3D20&want_full_chart=3D= 0&page=3D1 Signed-off-by: Fridolin Somers --=20 You are receiving this mail because: You are watching all bug changes. --===============2541751734054497197==-- From bugzilla-daemon@bugs.koha-community.org Fri Aug 16 09:27:35 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37595] Double HTML escaped ampersand in pagination bar Date: Fri, 16 Aug 2024 07:27:34 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2485334158780693795==" --===============2485334158780693795== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37595 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============2485334158780693795==-- From bugzilla-daemon@bugs.koha-community.org Fri Aug 16 09:27:46 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37595] Double HTML escaped ampersand in pagination bar Date: Fri, 16 Aug 2024 07:27:36 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5038233011199922678==" --===============5038233011199922678== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D37595 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170170|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 170432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D170432&action= =3Dedit Bug 37595: Double HTML escaped ampersand in pagination bar This patch removes escaping of ampersands in the part of guided_reports.pl that builds information for the pagination routine. The information is going to be escaped in a later step. To test, apply the patch and go to Reports. - If necessary, create a report which will return more than 20 results. - Run the report. You should see a pagination bar at the top of the table of results. - View the page source and look for the markup for the pagination menu. Searching for 'rel=3D"start"' works well. - Confirm that you see '&' between the link parameters instead of '&', e.g. =20 guided_reports.pl?id=3D347&op=3Drun&limit=3D20&want_full_chart=3D= 0&page=3D1 Signed-off-by: Fridolin Somers Signed-off-by: Marcel de Rooy --=20 You are receiving this mail because: You are watching all bug changes. --===============5038233011199922678==-- From bugzilla-daemon@bugs.koha-community.org Fri Aug 16 09:27:57 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37595] Double HTML escaped ampersand in pagination bar Date: Fri, 16 Aug 2024 07:27:48 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4162463491468434315==" --===============4162463491468434315== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37595 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. --===============4162463491468434315==-- From bugzilla-daemon@bugs.koha-community.org Fri Aug 16 17:41:47 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37595] Double HTML escaped ampersand in pagination bar Date: Fri, 16 Aug 2024 15:37:40 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7231138771141939456==" --===============7231138771141939456== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37595 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. --===============7231138771141939456==-- From bugzilla-daemon@bugs.koha-community.org Fri Aug 16 17:41:57 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37595] Double HTML escaped ampersand in pagination bar Date: Fri, 16 Aug 2024 15:37:42 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8716709836324272587==" --===============8716709836324272587== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37595 --- Comment #8 from Katrin Fischer --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. --===============8716709836324272587==-- From bugzilla-daemon@bugs.koha-community.org Mon Nov 18 19:47:53 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37595] Double HTML escaped ampersand in pagination bar Date: Mon, 18 Nov 2024 18:47:52 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8628444406405193954==" --===============8628444406405193954== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37595 Lucas Gass (lukeg) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #9 from Lucas Gass (lukeg) --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes. --===============8628444406405193954==-- From bugzilla-daemon@bugs.koha-community.org Thu Dec 5 19:33:36 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37595] Double HTML escaped ampersand in pagination bar Date: Thu, 05 Dec 2024 18:32:28 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7868793553260032413==" --===============7868793553260032413== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37595 Lucas Gass (lukeg) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. --===============7868793553260032413==-- From bugzilla-daemon@bugs.koha-community.org Fri Dec 6 10:19:17 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37595] Double HTML escaped ampersand in pagination bar Date: Fri, 06 Dec 2024 09:19:16 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6758140867461856591==" --===============6758140867461856591== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37595 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | --- Comment #10 from Fridolin Somers --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes. --===============6758140867461856591==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 24 04:05:01 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37595] Double HTML escaped ampersand in pagination bar Date: Tue, 24 Jun 2025 02:05:01 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7823785942907297832==" --===============7823785942907297832== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37595 Wainui Witika-Park changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #11 from Wainui Witika-Park --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes. --===============7823785942907297832==--