From bugzilla-daemon@bugs.koha-community.org Sat Jul 25 01:10:04 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26065] New: Move translatable strings out of
 marc_modification_templates.tt and into marc_modification_templates.js
Date: Fri, 24 Jul 2020 23:10:04 +0000
Message-ID: <bug-26065-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1200009954011793265=="

--===============1200009954011793265==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26065

            Bug ID: 26065
           Summary: Move translatable strings out of
                    marc_modification_templates.tt and into
                    marc_modification_templates.js
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: oleonard@myacpl.org
          Reporter: oleonard@myacpl.org
        QA Contact: testopia@bugs.koha-community.org
                CC: frederic@tamil.fr, testopia@bugs.koha-community.org
        Depends on: 21156

Strings defined for translation in marc_modification_templates.tt can now be
wrapped in the new translation function and put in
marc_modification_templates.js.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156
[Bug 21156] Internationalization: plural forms, context, and more for JS files
-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1200009954011793265==--


From bugzilla-daemon@bugs.koha-community.org Mon Jul 27 16:25:24 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26065] Move translatable strings out of
 marc_modification_templates.tt and into marc_modification_templates.js
Date: Mon, 27 Jul 2020 14:25:24 +0000
Message-ID: <bug-26065-70-isik7Cyde7@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26065-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4868192655089258592=="

--===============4868192655089258592==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26065

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4868192655089258592==--


From bugzilla-daemon@bugs.koha-community.org Mon Jul 27 16:25:35 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26065] Move translatable strings out of
 marc_modification_templates.tt and into marc_modification_templates.js
Date: Mon, 27 Jul 2020 14:25:27 +0000
Message-ID: <bug-26065-70-mVc1WsIuwj@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26065-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4337749252722116082=="

--===============4337749252722116082==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26065

--- Comment #1 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 107430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107430&action=edit
Bug 26065: Move translatable strings out of marc_modification_templates.tt and
into marc_modification_templates.js

This patch removes the <script> block in the MARC modification
templates template in which strings are defined for translation
purposes.

Strings are now in place in the JavaScript file and wrapped in the new
__() function.

To test, apply the patch and clear your browser cache if necessary.

- Perform some actions which will trigger translated strings, for
  example:
  - Create a new template
  - Add an action to the template and then delete it.
    - The confirmation should appear correctly
  - Add an action. Select "Copy" as the operation and click "Add action"
    without filling in any fields.
    - You should see a message, "Both subfield values should be filled
      or empty"

TESTING TRANSLATABILITY

- Update a translation, e.g. fr-FR:

> cd misc/translator
> perl translate update fr-FR

- Open the corresponding .po file for JavaScript strings, e.g.
  misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
  koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js for
  translation, e.g.:

  msgid "Both subfield values should be filled or empty."
  msgstr ""

- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:

> perl translate install fr-FR

- Switch to your newly translated language in the staff client and
  repeat the test plan above. The translated string should appear.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4337749252722116082==--


From bugzilla-daemon@bugs.koha-community.org Mon Jul 27 16:30:54 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26065] Move translatable strings out of
 marc_modification_templates.tt and into marc_modification_templates.js
Date: Mon, 27 Jul 2020 14:30:43 +0000
Message-ID: <bug-26065-70-Vcqmh1lc2b@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26065-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0221046022172871679=="

--===============0221046022172871679==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26065

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |25694


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25694
[Bug 25694] Add ability to delete a Marc Modification Template when viewing
-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0221046022172871679==--


From bugzilla-daemon@bugs.koha-community.org Thu Jul 30 00:21:02 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26065] Move translatable strings out of
 marc_modification_templates.tt and into marc_modification_templates.js
Date: Wed, 29 Jul 2020 22:21:01 +0000
Message-ID: <bug-26065-70-zsAUCqqYpZ@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26065-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1606481766161120526=="

--===============1606481766161120526==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26065

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1606481766161120526==--


From bugzilla-daemon@bugs.koha-community.org Thu Jul 30 00:21:12 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26065] Move translatable strings out of
 marc_modification_templates.tt and into marc_modification_templates.js
Date: Wed, 29 Jul 2020 22:21:05 +0000
Message-ID: <bug-26065-70-bY3t8FwNzR@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26065-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3698152398800457296=="

--===============3698152398800457296==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26065

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107430|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 107550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107550&action=edit
Bug 26065: Move translatable strings out of marc_modification_templates.tt and
into marc_modification_templates.js

This patch removes the <script> block in the MARC modification
templates template in which strings are defined for translation
purposes.

Strings are now in place in the JavaScript file and wrapped in the new
__() function.

To test, apply the patch and clear your browser cache if necessary.

- Perform some actions which will trigger translated strings, for
  example:
  - Create a new template
  - Add an action to the template and then delete it.
    - The confirmation should appear correctly
  - Add an action. Select "Copy" as the operation and click "Add action"
    without filling in any fields.
    - You should see a message, "Both subfield values should be filled
      or empty"

TESTING TRANSLATABILITY

- Update a translation, e.g. fr-FR:

> cd misc/translator
> perl translate update fr-FR

- Open the corresponding .po file for JavaScript strings, e.g.
  misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
  koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js for
  translation, e.g.:

  msgid "Both subfield values should be filled or empty."
  msgstr ""

- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:

> perl translate install fr-FR

- Switch to your newly translated language in the staff client and
  repeat the test plan above. The translated string should appear.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3698152398800457296==--


From bugzilla-daemon@bugs.koha-community.org Tue Aug 18 12:10:06 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26065] Move translatable strings out of
 marc_modification_templates.tt and into marc_modification_templates.js
Date: Tue, 18 Aug 2020 10:10:05 +0000
Message-ID: <bug-26065-70-CZrTJg0nN0@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26065-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4001514065476465129=="

--===============4001514065476465129==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D26065

Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart@bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Passed QA

--- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org>=
 ---
Skipping QA, I will review it myself.

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============4001514065476465129==--


From bugzilla-daemon@bugs.koha-community.org Tue Aug 18 17:51:44 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26065] Move translatable strings out of
 marc_modification_templates.tt and into marc_modification_templates.js
Date: Tue, 18 Aug 2020 15:47:10 +0000
Message-ID: <bug-26065-70-8NDSuMznPf@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26065-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7903497730113726642=="

--===============7903497730113726642==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26065

Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7903497730113726642==--


From bugzilla-daemon@bugs.koha-community.org Tue Aug 18 17:51:54 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26065] Move translatable strings out of
 marc_modification_templates.tt and into marc_modification_templates.js
Date: Tue, 18 Aug 2020 15:47:12 +0000
Message-ID: <bug-26065-70-F9yB0m1uS8@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26065-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8614551207418727974=="

--===============8614551207418727974==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D26065

--- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org>=
 ---
Pushed to master for 20.11, thanks to everybody involved!

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============8614551207418727974==--


From bugzilla-daemon@bugs.koha-community.org Fri Sep  4 17:26:30 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26065] Move translatable strings out of
 marc_modification_templates.tt and into marc_modification_templates.js
Date: Fri, 04 Sep 2020 15:26:30 +0000
Message-ID: <bug-26065-70-GBei1WM0zB@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26065-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7105619719004066381=="

--===============7105619719004066381==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26065

Lucas Gass <lucas@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas@bywatersolutions.com

--- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> ---
enhancement will not be backported to 20.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7105619719004066381==--