From bugzilla-daemon@bugs.koha-community.org Thu Jun 7 12:47:34 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] New: Lists in staff don't load when \ was used in the description Date: Thu, 07 Jun 2018 10:47:31 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6786447937304044624==" --===============6786447937304044624== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Bug ID: 20891 Summary: Lists in staff don't load when \ was used in the description Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When someone uses \ in the description of a list, the datatable in staff won't load and keeps processing. Tested in 16.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============6786447937304044624==-- From bugzilla-daemon@bugs.koha-community.org Thu Jun 7 17:20:21 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Thu, 07 Jun 2018 15:20:16 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5161407908655553382==" --===============5161407908655553382== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============5161407908655553382==-- From bugzilla-daemon@bugs.koha-community.org Thu Jun 7 17:20:23 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Thu, 07 Jun 2018 15:20:19 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4181860709152441134==" --===============4181860709152441134== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20891 --- Comment #1 from Jonathan Druart = --- Created attachment 75887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D75887&action=3D= edit Bug 20891: Escape list's names in JSON When someone uses \ in the description of a list, the datatable in staff won't load and keeps processing. Test plan: - Create a list named "" - Create another list named "k\o\h\a" - Hit /cgi-bin/koha/virtualshelves/shelves.pl =3D> Without this patch the lists will not be displayed, JSON is malformated =3D> With this patch everything is ok --=20 You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============4181860709152441134==-- From bugzilla-daemon@bugs.koha-community.org Thu Jun 7 17:21:07 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Thu, 07 Jun 2018 15:21:05 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5616376490527918085==" --===============5616376490527918085== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============5616376490527918085==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 8 07:51:58 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Fri, 08 Jun 2018 05:51:54 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7401011333151275843==" --===============7401011333151275843== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75887|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy --- Created attachment 75890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75890&action=edit Bug 20891: Escape list's names in JSON When someone uses \ in the description of a list, the datatable in staff won't load and keeps processing. Test plan: - Create a list named "" - Create another list named "k\o\h\a" - Hit /cgi-bin/koha/virtualshelves/shelves.pl => Without this patch the lists will not be displayed, JSON is malformated => With this patch everything is ok Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. --===============7401011333151275843==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 8 07:52:21 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Fri, 08 Jun 2018 05:51:51 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5381684065022324857==" --===============5381684065022324857== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============5381684065022324857==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 8 07:52:46 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Fri, 08 Jun 2018 05:52:39 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3329843694434477038==" --===============3329843694434477038== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #3 from Marcel de Rooy --- Combining SO and QA for trivial patch -- You are receiving this mail because: You are watching all bug changes. --===============3329843694434477038==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 8 15:05:50 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Fri, 08 Jun 2018 13:05:19 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1349809537013574821==" --===============1349809537013574821== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens --- I took your test plant too literally, if your list name is surrounded by quotes: "" it works before this patch, but not after. I think the JSON conversion doesn't like the quotes -- You are receiving this mail because: You are watching all bug changes. --===============1349809537013574821==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 8 17:23:38 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Fri, 08 Jun 2018 15:23:35 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0060753144172204261==" --===============0060753144172204261== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20891 --- Comment #5 from Jonathan Druart = --- Created attachment 75922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D75922&action=3D= edit Bug 20891: Escape html then JSON To my understanding we need to escape first html chars then to JSON. If this patch works we will need to rethink the 'To' TT plugin. It was originally designed to have several escape methods, but with these changes it will not make sense to name it 'To' if used only to escape JSON IIRC we should keep the 2 different ways to use it: * [% To.json( string ) %] * [% string | $To %] otherwise it will be hard to use it when called in argument of patron-title.inc (`git grep To.json`) --=20 You are receiving this mail because: You are watching all bug changes. --===============0060753144172204261==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 8 17:26:02 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Fri, 08 Jun 2018 15:25:32 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2626521127641575993==" --===============2626521127641575993== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #6 from Jonathan Druart = --- Good catch Nick. From trivial it is becoming a complex one now. Last patch for discussion and review before a full rewrite of the TT plugin. --=20 You are receiving this mail because: You are watching all bug changes. --===============2626521127641575993==-- From bugzilla-daemon@bugs.koha-community.org Mon Jun 11 16:54:44 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Mon, 11 Jun 2018 14:54:15 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1163588429511662641==" --===============1163588429511662641== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes. --===============1163588429511662641==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 19 00:07:02 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Mon, 18 Jun 2018 22:06:32 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4214640987609086116==" --===============4214640987609086116== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 --- Comment #7 from Katrin Fischer --- I think we had similar problems on patron search - anything we could pick from there? -- You are receiving this mail because: You are watching all bug changes. --===============4214640987609086116==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 19 14:53:17 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Tue, 19 Jun 2018 12:53:14 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3947906091582914463==" --===============3947906091582914463== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20891 --- Comment #8 from Jonathan Druart = --- (In reply to Katrin Fischer from comment #7) > I think we had similar problems on patron search - anything we could pick > from there? We are using the same code for lists and patrons, so I supposed patron's resu= lt will explode if '\' is contained in the surname/firstname, which certainly do= es not exist in a production DB :) --=20 You are receiving this mail because: You are watching all bug changes. --===============3947906091582914463==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 19 15:02:10 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Tue, 19 Jun 2018 13:02:05 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6157733931859908047==" --===============6157733931859908047== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20891 --- Comment #9 from Katrin Fischer --- (In reply to Jonathan Druart from comment #8) > (In reply to Katrin Fischer from comment #7) > > I think we had similar problems on patron search - anything we could pick > > from there? >=20 > We are using the same code for lists and patrons, so I supposed patron's > result will explode if '\' is contained in the surname/firstname, which > certainly does not exist in a production DB :) Actually, we had a lot of issues with patron search on migrating a lot of libraries recently. You never know what is in the data you get and it's hard = to debug the JSON errors in some cases. --=20 You are receiving this mail because: You are watching all bug changes. --===============6157733931859908047==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 19 15:32:48 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Tue, 19 Jun 2018 13:32:44 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5047191696558822641==" --===============5047191696558822641== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20891 --- Comment #10 from Jonathan Druart --- (In reply to Katrin Fischer from comment #9) > (In reply to Jonathan Druart from comment #8) > > (In reply to Katrin Fischer from comment #7) > > > I think we had similar problems on patron search - anything we could pi= ck > > > from there? > >=20 > > We are using the same code for lists and patrons, so I supposed patron's > > result will explode if '\' is contained in the surname/firstname, which > > certainly does not exist in a production DB :) >=20 > Actually, we had a lot of issues with patron search on migrating a lot of > libraries recently. You never know what is in the data you get and it's hard > to debug the JSON errors in some cases. open the web dev console, get the answer from the server, copy/paste it on a JSON validator website, and you will know exactly where the problem is. --=20 You are receiving this mail because: You are watching all bug changes. --===============5047191696558822641==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 19 17:13:33 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Tue, 19 Jun 2018 15:13:30 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8615197430350726294==" --===============8615197430350726294== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20891 --- Comment #11 from Katrin Fischer --- The number of patrons in this libraries is so big that the answer is cut off = in the developer tools in the browser... so you have to page until you can limit it to the right 'area'. I am open for ideas ;) --=20 You are receiving this mail because: You are watching all bug changes. --===============8615197430350726294==-- From bugzilla-daemon@bugs.koha-community.org Thu Jun 21 09:42:46 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Thu, 21 Jun 2018 07:42:43 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1248959758136037286==" --===============1248959758136037286== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 --- Comment #12 from Katrin Fischer --- We have checked recent migration scripts that we adapted for several problems with patron search. Problematic are afawk: backslash, double quotes, non-printable and for some reason we also have \x11 to ae in there, but not sure if that was just a presentation problem. -- You are receiving this mail because: You are watching all bug changes. --===============1248959758136037286==-- From bugzilla-daemon@bugs.koha-community.org Thu Jan 3 10:59:15 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Thu, 03 Jan 2019 09:59:12 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8390445493073280504==" --===============8390445493073280504== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20891 --- Comment #13 from Katrin Fischer --- We've had a similar issue now with the item search where a publisher is spell= ed with a \ in the name. I think we can't rule \ appearing in real data and for patrons. Can we have another go here? --=20 You are receiving this mail because: You are watching all bug changes. --===============8390445493073280504==-- From bugzilla-daemon@bugs.koha-community.org Thu Feb 14 20:32:18 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Thu, 14 Feb 2019 19:32:15 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5985053632287130717==" --===============5985053632287130717== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20891 --- Comment #14 from Jonathan Druart --- Small steps, can we make sure the proposed patches fix the original issue reported? --=20 You are receiving this mail because: You are watching all bug changes. --===============5985053632287130717==-- From bugzilla-daemon@bugs.koha-community.org Sun Feb 17 16:48:50 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Sun, 17 Feb 2019 15:48:45 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7561564250813329132==" --===============7561564250813329132== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22316 -- You are receiving this mail because: You are watching all bug changes. --===============7561564250813329132==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 26 07:29:10 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Tue, 26 Feb 2019 06:28:59 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7686267505796679732==" --===============7686267505796679732== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. --===============7686267505796679732==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 26 07:32:45 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Tue, 26 Feb 2019 06:32:15 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3717525876694966271==" --===============3717525876694966271== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20891 --- Comment #15 from Fridolin SOMERS --- I reported in Bug 22369 that combination of To.JSON and |html is wrong for double quotes. JSON converts to \" and then html converts to \" which is= a non valid JSON. You may test it also in list description. --=20 You are receiving this mail because: You are watching all bug changes. --===============3717525876694966271==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 26 18:03:07 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Tue, 26 Feb 2019 17:03:04 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6761485214370103713==" --===============6761485214370103713== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20891 --- Comment #16 from Jonathan Druart --- (In reply to Fridolin SOMERS from comment #15) > I reported in Bug 22369 that combination of To.JSON and |html is wrong for > double quotes. JSON converts to \" and then html converts to \" which > is a non valid JSON. > You may test it also in list description. Read and tried the patch? --=20 You are receiving this mail because: You are watching all bug changes. --===============6761485214370103713==-- From bugzilla-daemon@bugs.koha-community.org Wed Feb 27 09:51:53 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Wed, 27 Feb 2019 08:51:50 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2040338030055966895==" --===============2040338030055966895== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 --- Comment #17 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #16) > (In reply to Fridolin SOMERS from comment #15) > > I reported in Bug 22369 that combination of To.JSON and |html is wrong for > > double quotes. JSON converts to \" and then html converts to \" which > > is a non valid JSON. > > You may test it also in list description. > > Read and tried the patch? Ha sorry I missed the second patch which looks great. I see this issue as already been spotted in comment 4. The problem is in good hands ;) -- You are receiving this mail because: You are watching all bug changes. --===============2040338030055966895==-- From bugzilla-daemon@bugs.koha-community.org Wed Apr 24 05:00:15 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Wed, 24 Apr 2019 03:00:11 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1439304012704769682==" --===============1439304012704769682== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22715 -- You are receiving this mail because: You are watching all bug changes. --===============1439304012704769682==-- From bugzilla-daemon@bugs.koha-community.org Wed Apr 24 17:29:39 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Wed, 24 Apr 2019 15:29:36 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6176057129739726748==" --===============6176057129739726748== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75890|0 |1 is obsolete| | Attachment #75922|0 |1 is obsolete| | --- Comment #18 from Liz Rea --- Created attachment 88637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88637&action=edit Bug 20891: Escape list's names in JSON When someone uses \ in the description of a list, the datatable in staff won't load and keeps processing. Test plan: - Create a list named "" - Create another list named "k\o\h\a" - Hit /cgi-bin/koha/virtualshelves/shelves.pl => Without this patch the lists will not be displayed, JSON is malformated => With this patch everything is ok Signed-off-by: Marcel de Rooy Signed-off-by: Liz Rea Resolved minor merge issues, QA plz check they are ok - but it works. -- You are receiving this mail because: You are watching all bug changes. --===============6176057129739726748==-- From bugzilla-daemon@bugs.koha-community.org Wed Apr 24 17:29:56 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Wed, 24 Apr 2019 15:29:53 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7150610387828165030==" --===============7150610387828165030== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 --- Comment #19 from Liz Rea --- Created attachment 88638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88638&action=edit Bug 20891: Escape html then JSON To my understanding we need to escape first html chars then to JSON. If this patch works we will need to rethink the 'To' TT plugin. It was originally designed to have several escape methods, but with these changes it will not make sense to name it 'To' if used only to escape JSON IIRC we should keep the 2 different ways to use it: * [% To.json( string ) %] * [% string | $To %] otherwise it will be hard to use it when called in argument of patron-title.inc (`git grep To.json`) Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. --===============7150610387828165030==-- From bugzilla-daemon@bugs.koha-community.org Wed Apr 24 17:30:03 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Wed, 24 Apr 2019 15:29:33 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7042832358563406421==" --===============7042832358563406421== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============7042832358563406421==-- From bugzilla-daemon@bugs.koha-community.org Thu Apr 25 07:44:16 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Thu, 25 Apr 2019 05:43:46 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1033962271637844022==" --===============1033962271637844022== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 --- Comment #20 from Katrin Fischer --- Tested with a little meaner version: \ Seems to work like a charm! -- You are receiving this mail because: You are watching all bug changes. --===============1033962271637844022==-- From bugzilla-daemon@bugs.koha-community.org Thu Apr 25 07:44:33 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Thu, 25 Apr 2019 05:44:30 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8914912872044005652==" --===============8914912872044005652== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============8914912872044005652==-- From bugzilla-daemon@bugs.koha-community.org Thu Apr 25 07:45:06 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Thu, 25 Apr 2019 05:44:34 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1123913804851286927==" --===============1123913804851286927== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88637|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer --- Created attachment 88675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88675&action=edit Bug 20891: Escape list's names in JSON When someone uses \ in the description of a list, the datatable in staff won't load and keeps processing. Test plan: - Create a list named "" - Create another list named "k\o\h\a" - Hit /cgi-bin/koha/virtualshelves/shelves.pl => Without this patch the lists will not be displayed, JSON is malformated => With this patch everything is ok Signed-off-by: Marcel de Rooy Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. --===============1123913804851286927==-- From bugzilla-daemon@bugs.koha-community.org Thu Apr 25 07:45:07 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Thu, 25 Apr 2019 05:44:38 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9043801952090571727==" --===============9043801952090571727== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88638|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer --- Created attachment 88676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88676&action=edit Bug 20891: Escape html then JSON To my understanding we need to escape first html chars then to JSON. If this patch works we will need to rethink the 'To' TT plugin. It was originally designed to have several escape methods, but with these changes it will not make sense to name it 'To' if used only to escape JSON IIRC we should keep the 2 different ways to use it: * [% To.json( string ) %] * [% string | $To %] otherwise it will be hard to use it when called in argument of patron-title.inc (`git grep To.json`) Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. --===============9043801952090571727==-- From bugzilla-daemon@bugs.koha-community.org Thu Apr 25 07:45:16 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Thu, 25 Apr 2019 05:45:12 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4027753187046544234==" --===============4027753187046544234== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal --- Comment #23 from Katrin Fischer --- Updating severity a little bit - broken searches can be quite an issue for the library and are hard to fix without SQL access. -- You are receiving this mail because: You are watching all bug changes. --===============4027753187046544234==-- From bugzilla-daemon@bugs.koha-community.org Thu Apr 25 07:45:51 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Thu, 25 Apr 2019 05:45:49 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2615190622478060175==" --===============2615190622478060175== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21716 -- You are receiving this mail because: You are watching all bug changes. --===============2615190622478060175==-- From bugzilla-daemon@bugs.koha-community.org Thu Apr 25 13:23:16 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Thu, 25 Apr 2019 11:23:12 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2539188472895939094==" --===============2539188472895939094== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22715 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search -- You are receiving this mail because: You are watching all bug changes. --===============2539188472895939094==-- From bugzilla-daemon@bugs.koha-community.org Thu Apr 25 13:53:09 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Thu, 25 Apr 2019 11:52:39 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8136399159234542574==" --===============8136399159234542574== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. --===============8136399159234542574==-- From bugzilla-daemon@bugs.koha-community.org Fri Apr 26 17:20:14 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Fri, 26 Apr 2019 15:20:10 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2494467188465500402==" --===============2494467188465500402== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #25 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. --===============2494467188465500402==-- From bugzilla-daemon@bugs.koha-community.org Fri May 24 17:32:11 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Fri, 24 May 2019 15:32:08 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0204504796904757846==" --===============0204504796904757846== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #26 from Lucas Gass --- backported to 18.05.x for 18.05.13 -- You are receiving this mail because: You are watching all bug changes. --===============0204504796904757846==-- From bugzilla-daemon@bugs.koha-community.org Fri Aug 9 14:46:13 2019 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description Date: Fri, 09 Aug 2019 12:46:12 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0226357310265277896==" --===============0226357310265277896== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. --===============0226357310265277896==--