From bugzilla-daemon@bugs.koha-community.org Tue Jan 17 17:49:50 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] New: Variables showing in patron messaging preferences Date: Tue, 17 Jan 2023 16:49:49 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7319498824962083461==" --===============7319498824962083461== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 Bug ID: 32655 Summary: Variables showing in patron messaging preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 145363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145363&action=edit Your variables are showing If you collapse the patron messaging preferences when editing the patron, you see two variables listed above the table in the section. See attachment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============7319498824962083461==-- From bugzilla-daemon@bugs.koha-community.org Tue Jan 17 17:50:05 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences Date: Tue, 17 Jan 2023 16:50:05 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6353954440256771568==" --===============6353954440256771568== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============6353954440256771568==-- From bugzilla-daemon@bugs.koha-community.org Tue Jan 17 19:39:10 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences Date: Tue, 17 Jan 2023 18:39:09 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3682866222932692785==" --===============3682866222932692785== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D32655 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #1 from Lucas Gass --- There is a script that is being toggled to 'display:block': We could change the jQuery selector but maybe it is easier to move the script to somewhere more appropriate. --=20 You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============3682866222932692785==-- From bugzilla-daemon@bugs.koha-community.org Tue Jan 17 19:40:46 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences Date: Tue, 17 Jan 2023 18:40:46 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2743722609440995392==" --===============2743722609440995392== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D32655 --- Comment #2 from Lucas Gass --- The script is coming from the messaging-preference-from.inc which is included in these templates: koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt =20 koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt = =20 koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt --=20 You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============2743722609440995392==-- From bugzilla-daemon@bugs.koha-community.org Tue Jan 17 19:41:28 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences Date: Tue, 17 Jan 2023 18:41:27 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5170920443138217766==" --===============5170920443138217766== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============5170920443138217766==-- From bugzilla-daemon@bugs.koha-community.org Tue Jan 17 19:50:33 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences Date: Tue, 17 Jan 2023 18:50:32 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7742557247896857511==" --===============7742557247896857511== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============7742557247896857511==-- From bugzilla-daemon@bugs.koha-community.org Tue Jan 17 19:50:43 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences Date: Tue, 17 Jan 2023 18:50:36 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3242025207986819557==" --===============3242025207986819557== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 --- Comment #3 from Lucas Gass --- Created attachment 145367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145367&action=edit Bug 32655: Move phone and itiva variables into templates To test: 1. Go to a patron record or create a new one. 2. Toggle the 'Patron messaging preferences' fieldset so it is hidden. 3. Notice the variables. 4. Apply patch 5. Try steps 1 & 2 again, no varibales. 6. Attempt to toggle on/off options for email/sms. When email/sms are off the digest option next to it should be disabled. 7. Go to Administration > Patron categories and try step 6 there as well. -- You are receiving this mail because: You are watching all bug changes. --===============3242025207986819557==-- From bugzilla-daemon@bugs.koha-community.org Tue Jan 17 22:35:02 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences Date: Tue, 17 Jan 2023 21:35:01 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4769198557467658277==" --===============4769198557467658277== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============4769198557467658277==-- From bugzilla-daemon@bugs.koha-community.org Tue Jan 17 22:35:12 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences Date: Tue, 17 Jan 2023 21:35:07 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5869562360205869507==" --===============5869562360205869507== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145367|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 145374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145374&action=edit Bug 32655: Move phone and itiva variables into templates To test: 1. Go to a patron record or create a new one. 2. Toggle the 'Patron messaging preferences' fieldset so it is hidden. 3. Notice the variables. 4. Apply patch 5. Try steps 1 & 2 again, no varibales. 6. Attempt to toggle on/off options for email/sms. When email/sms are off the digest option next to it should be disabled. 7. Go to Administration > Patron categories and try step 6 there as well. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. --===============5869562360205869507==-- From bugzilla-daemon@bugs.koha-community.org Fri Jan 20 00:00:59 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences Date: Thu, 19 Jan 2023 23:00:59 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6574678146994380369==" --===============6574678146994380369== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D32655 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31166 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D31166 [Bug 31166] Digest option is not selectable for phone when PhoneNotification = is enabled --=20 You are receiving this mail because: You are watching all bug changes. --===============6574678146994380369==-- From bugzilla-daemon@bugs.koha-community.org Wed Feb 1 14:22:38 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences Date: Wed, 01 Feb 2023 13:22:37 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2131077643290009159==" --===============2131077643290009159== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145374|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 145939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145939&action=edit Bug 32655: Move phone and itiva variables into templates To test: 1. Go to a patron record or create a new one. 2. Toggle the 'Patron messaging preferences' fieldset so it is hidden. 3. Notice the variables. 4. Apply patch 5. Try steps 1 & 2 again, no varibales. 6. Attempt to toggle on/off options for email/sms. When email/sms are off the digest option next to it should be disabled. 7. Go to Administration > Patron categories and try step 6 there as well. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. --===============2131077643290009159==-- From bugzilla-daemon@bugs.koha-community.org Wed Feb 1 14:23:01 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences Date: Wed, 01 Feb 2023 13:23:00 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4158770257892732336==" --===============4158770257892732336== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- No regressions, cleanup works. Passing QA -- You are receiving this mail because: You are watching all bug changes. --===============4158770257892732336==-- From bugzilla-daemon@bugs.koha-community.org Wed Feb 1 14:23:11 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences Date: Wed, 01 Feb 2023 13:23:06 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8798410275914060396==" --===============8798410275914060396== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. --===============8798410275914060396==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 3 14:17:36 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences Date: Fri, 03 Feb 2023 13:17:25 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1203434867321600522==" --===============1203434867321600522== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi --- LOL -- You are receiving this mail because: You are watching all bug changes. --===============1203434867321600522==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 3 14:34:36 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences Date: Fri, 03 Feb 2023 13:33:01 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9189239505933506783==" --===============9189239505933506783== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. --===============9189239505933506783==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 3 14:34:47 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences Date: Fri, 03 Feb 2023 13:33:05 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4020080073160976500==" --===============4020080073160976500== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. --===============4020080073160976500==-- From bugzilla-daemon@bugs.koha-community.org Mon Feb 6 17:29:09 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences Date: Mon, 06 Feb 2023 16:28:11 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1203195314365719215==" --===============1203195314365719215== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. --===============1203195314365719215==-- From bugzilla-daemon@bugs.koha-community.org Mon Feb 6 17:29:19 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences Date: Mon, 06 Feb 2023 16:28:13 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8635635242327356171==" --===============8635635242327356171== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 --- Comment #9 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. --===============8635635242327356171==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 14 23:16:28 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences Date: Tue, 14 Feb 2023 22:16:27 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0851662441263079326==" --===============0851662441263079326== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | --- Comment #10 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes. --===============0851662441263079326==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 17 11:35:39 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences Date: Fri, 17 Feb 2023 10:35:38 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3749531343122659253==" --===============3749531343122659253== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|23.05.00,22.11.03,22.05.10 |23.05.00,22.11.03,22.05.10, released in| |21.11.16 --- Comment #11 from Arthur Suzuki --- applied to 21.11.x for 21.11.16 -- You are receiving this mail because: You are watching all bug changes. --===============3749531343122659253==-- From bugzilla-daemon@bugs.koha-community.org Wed Mar 15 02:46:11 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences Date: Wed, 15 Mar 2023 01:46:10 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8054824675854520086==" --===============8054824675854520086== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #12 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. --===============8054824675854520086==--