From bugzilla-daemon@bugs.koha-community.org Fri Jul 6 12:44:37 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] New: Show HTML5 video/ audio in OPAC for media
files in 856
Date: Fri, 06 Jul 2012 10:54:27 +0000
Message-ID:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3982666417196785536=="
--===============3982666417196785536==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Priority: P5 - low
Change sponsored?: ---
Bug ID: 8377
Assignee: 5p4m@gmx.de
Summary: Show HTML5 video/ audio in OPAC for media files in 856
Severity: enhancement
Classification: Unclassified
OS: All
Reporter: 5p4m@gmx.de
Hardware: All
Status: ASSIGNED
Version: master
Component: OPAC
Product: Koha
With HTML5 it is possible to integrate audio and video content into websites
easily. This enhancement uses information from MARC field 856 to generate the
appropriate HTML5 code to embed the file(s) in a tab in the opac-detail view,
including a fullscreen option.
This enhancement introduces two sysprefs: one to enable the feature, one to
specify file extensions to be recognizes as media files.
This patch supports the HTML5 and element.
Additionally it gives basic support for the element. This element is
not supported very well by recent browsers. It is possible to use javascript
polyfills to support it, this may be an option to be introduced in a seperate
enhancement.
The basic functions of this enhancement are MARC agnostic because MARC21 and
UNIMARC both use field 856 for electronic resources. There are minor
differences regarding subfields.
A test plan and sample MARC files will be added soon.
--
You are receiving this mail because:
You are watching all bug changes.
--===============3982666417196785536==--
From bugzilla-daemon@bugs.koha-community.org Fri Jul 6 17:15:16 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio in OPAC for media files in 856
Date: Fri, 06 Jul 2012 15:25:07 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2762659918114021500=="
--===============2762659918114021500==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
--- Comment #1 from Mirko Tietgen <5p4m@gmx.de> ---
HTML5 media RFC http://wiki.koha=
-community.org/wiki/HTML5_Media_RFC
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============2762659918114021500==--
From bugzilla-daemon@bugs.koha-community.org Sat Jul 7 17:02:08 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio in OPAC for media files in 856
Date: Sat, 07 Jul 2012 15:12:02 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8610395886245200454=="
--===============8610395886245200454==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
--- Comment #2 from Mirko Tietgen <5p4m@gmx.de> ---
Created attachment 10684
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10684&action=edit
Bug 8377 [ENH] Show HTML5 video/ audio in OPAC for media files in 856
This enhancement uses information from MARC field 856 to generate the
appropriate HTML5 code
to embed a media player for the file(s) in a tab in the opac-detail view. This
patch supports
the HTML5 and element. Additionally it gives basic support for
the
element. This element is not supported very well by recent browsers. Please
consider the patch
working when you get working video or audio.
--
You are receiving this mail because:
You are watching all bug changes.
--===============8610395886245200454==--
From bugzilla-daemon@bugs.koha-community.org Sat Jul 7 17:04:54 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio in OPAC for media files in 856
Date: Sat, 07 Jul 2012 15:14:48 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7133379682968999350=="
--===============7133379682968999350==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
--- Comment #3 from Mirko Tietgen <5p4m@gmx.de> ---
Created attachment 10685
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D10685&action=3De=
dit
Bug 8377 test data (MARC21)
Test data MARC21
Bug 8377 Test 01: Video, using subfields a, d, f
Bug 8377 Test 02: Video, using subfield u
Bug 8377 Test 03: Video, using subfields a, d, f, login, pass in l, k
Bug 8377 Test 04: Audio, using subfield u
Test plan
- Import attached test data. [I chose media typ 'bk' because it's probably
present on most systems. It's not appropriate for the data but that doesn't
matter.]
- Rebuild zebra -b -z
- Go to sysprefs->enhanced content->html5 media and set HTML5MediaEnabled to
'Show', save preferences.
- Search the OPAC for 'bug 8377'
- Get 4 results
- Open one result after the other. Observe working video (1-3) or audio (4)
player on opac-detail page
Note that the video files don't have sound, that is not an error. Also note
that the audio file is a trombone so turn down the volume before you try it :)
If you feel adventurous, go to sysprefs->enhanced content->html5 media and
delete the entry for 'ogv' from HTML5MediaExtensions. Try the four biblios
again and observe that only the audio example (4) shows a media player. You m=
ay
have to empty your cache and restart Plack if you use that.
Some files contain subtitles to be displayed in a element. These are
not generally supported by browsers at the moment. You can see them in the
source code of the opac-detail pages. Chrome/ Chromium can play them, but only
if they are set as 'default'. There is no option to do that in this patch, so
it won't work. Firefox can't play them yet. Opera can't play them yet. Intern=
et
Explorer 10 may be able to play them, but I don't have one. I included basic
track support anyway and plan to continue working on that later. There is more
on that matter in the Wiki. Please consider this patch working if you get
working video or audio.
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============7133379682968999350==--
From bugzilla-daemon@bugs.koha-community.org Sat Jul 7 17:22:18 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio in OPAC for media files in 856
Date: Sat, 07 Jul 2012 15:32:12 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3602269404842382578=="
--===============3602269404842382578==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Mirko Tietgen <5p4m@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--- Comment #4 from Mirko Tietgen <5p4m@gmx.de> ---
This patch can be tested in a sandbox.
http://wiki.koha-community.org/wiki/Sandboxes
--
You are receiving this mail because:
You are watching all bug changes.
--===============3602269404842382578==--
From bugzilla-daemon@bugs.koha-community.org Sat Jul 7 19:37:34 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio in OPAC for media files in 856
Date: Sat, 07 Jul 2012 17:47:28 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4060893428769094449=="
--===============4060893428769094449==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
--- Comment #5 from Mirko Tietgen <5p4m@gmx.de> ---
Created attachment 10688
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D10688&action=3De=
dit
Bug 8377 [ENH] Show HTML5 video/ audio in OPAC for media files in 856
This enhancement uses information from MARC field 856 to generate the
appropriate HTML5 code to embed am media player for the file(s) in a tab in t=
he
opac-detail view. This patch supports the HTML5 and element.
Additionally it gives basic support for the element. This element is
not supported very well by recent browsers. Please consider the patch working
when you get working video or audio. Fixed a typo in this second patch.
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============4060893428769094449==--
From bugzilla-daemon@bugs.koha-community.org Sat Jul 7 19:42:50 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio in OPAC for media files in 856
Date: Sat, 07 Jul 2012 17:52:44 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4496102326565640729=="
--===============4496102326565640729==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Mirko Tietgen <5p4m@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #10684|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
--===============4496102326565640729==--
From bugzilla-daemon@bugs.koha-community.org Wed Jul 11 21:57:47 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio in OPAC for media files in 856
Date: Wed, 11 Jul 2012 20:07:53 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4739283709984539426=="
--===============4739283709984539426==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
Mirko Tietgen <5p4m@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #10688|0 |1
is obsolete| |
--- Comment #6 from Mirko Tietgen <5p4m@gmx.de> ---
Created attachment 10776
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D10776&action=3De=
dit
Bug 8377 [ENH] Show HTML5 video/ audio in OPAC for media files in 856
This enhancement uses information from MARC field 856 to generate the
appropriate HTML5 code to embed am media player for the file(s) in a tab in t=
he
opac-detail view. This patch supports the HTML5 and element.
Additionally it gives basic support for the element. This element is
not supported very well by recent browsers. Please consider the patch working
when you get working video or audio. Fixed a typo in this second patch.
rebased to master
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============4739283709984539426==--
From bugzilla-daemon@bugs.koha-community.org Wed Jul 11 21:59:37 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio in OPAC for media files in 856
Date: Wed, 11 Jul 2012 20:09:44 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0572242335652286426=="
--===============0572242335652286426==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
--- Comment #7 from Mirko Tietgen <5p4m@gmx.de> ---
Test plan
- Import attached test data. [I chose media typ 'bk' because it's probably
present on most systems. It's not appropriate for the data but that doesn't
matter.]
- Rebuild zebra -b -z
- Go to sysprefs->enhanced content->html5 media and set HTML5MediaEnabled to
'Show', save preferences.
- Search the OPAC for 'bug 8377'
- Get 4 results
- Open one result after the other. Observe working video (1-3) or audio (4)
player on opac-detail page
--
You are receiving this mail because:
You are watching all bug changes.
--===============0572242335652286426==--
From bugzilla-daemon@bugs.koha-community.org Thu Jul 12 01:19:23 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio in OPAC for media files in 856
Date: Wed, 11 Jul 2012 23:29:29 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3288792893967566611=="
--===============3288792893967566611==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Robin Sheat changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |robin@catalyst.net.nz
--
You are receiving this mail because:
You are watching all bug changes.
--===============3288792893967566611==--
From bugzilla-daemon@bugs.koha-community.org Tue Jul 17 18:43:28 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio in OPAC for media files in 856
Date: Tue, 17 Jul 2012 16:53:52 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4917522123312914204=="
--===============4917522123312914204==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #8 from Owen Leonard ---
This looks like it's working well with the examples provided. The examples
worked well in Firefox and Chrome. I also tested a record with an mp4 video
attached in order to test Safari on Windows and Internet Explorer (9)--both
working.
A couple of problems: The "HTML5 Media" tab is selected by default if HTML5
media is attached, which I don't think is correct. What is the reasoning behi=
nd
changing the default tab in this case?
Also, I think labeling the tab "HTML5 Media" is not user-friendly at all. The
"HTML5" aspect of it is useless information as far as a patron is concerned.
Perhaps "Related media?"
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============4917522123312914204==--
From bugzilla-daemon@bugs.koha-community.org Sat Jul 21 04:12:14 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio in OPAC for media files in 856
Date: Sat, 21 Jul 2012 02:22:48 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1573131236479262181=="
--===============1573131236479262181==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
--- Comment #9 from Mirko Tietgen <5p4m@gmx.de> ---
Created attachment 11056
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11056&action=edit
Remove previous version of sysprefs for this enhancement
If you tested a patch for this bug before, you can use this file to delete the
previous version of the sysprefs for this bug. They have changed in the new
version - sorry.
--
You are receiving this mail because:
You are watching all bug changes.
--===============1573131236479262181==--
From bugzilla-daemon@bugs.koha-community.org Sat Jul 21 04:16:02 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Sat, 21 Jul 2012 02:26:36 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3427099583364224966=="
--===============3427099583364224966==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Mirko Tietgen <5p4m@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Show HTML5 video/ audio in |Show HTML5 video/ audio for
|OPAC for media files in 856 |media files in OPAC and
| |staff client
--
You are receiving this mail because:
You are watching all bug changes.
--===============3427099583364224966==--
From bugzilla-daemon@bugs.koha-community.org Sat Jul 21 04:29:31 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Sat, 21 Jul 2012 02:40:04 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0106613056014478066=="
--===============0106613056014478066==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
Mirko Tietgen <5p4m@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #10776|0 |1
is obsolete| |
--- Comment #10 from Mirko Tietgen <5p4m@gmx.de> ---
Created attachment 11057
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D11057&action=3De=
dit
Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff clie=
nt
This enhancement uses information from MARC field 856 to generate the
appropriate HTML5 code to embed am media player for the file(s) in a tab in t=
he
OPAC and staff client detail view. This patch supports the HTML5 and
element. Additionally it gives basic support for the element.
This element is not supported very well by recent browsers. Please consider t=
he
patch working when you get working video or audio.
Changes since last version:
- failed QA: removed default view for media tab, changed tab name to "Play
audio" resp. "Play video".
- put most of the code in separate module and access it from OPAC and staff
client now, so the feature works in both
- added mp3 to default media types
- had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or
'both'; HTML5MediaExtensions has additional 'mp3' as default
If you tested this before, you need to delete the old syspref entries from yo=
ur
database. There is an attachment to do this, use exactly like
upgradedatabase.pl.
Test plan
- Import attached test data. [I chose media typ 'bk' because it's probably
present on most systems. It's not appropriate for the data but that doesn't
matter.]
- Rebuild zebra -b -z
- Go to Administration->System preferences->enhanced content->HTML5 Media and
set HTML5MediaEnabled to an appropriate setting, save preferences.
- Search the OPAC or staff client for 'bug 8377'
- Get 4 results
- Open detail pages for results. Observe working video (1-3) or audio (4)
player on detail page.
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============0106613056014478066==--
From bugzilla-daemon@bugs.koha-community.org Sat Jul 21 04:41:34 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Sat, 21 Jul 2012 02:52:07 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7445327847813326083=="
--===============7445327847813326083==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
Mirko Tietgen <5p4m@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11057|0 |1
is obsolete| |
--- Comment #11 from Mirko Tietgen <5p4m@gmx.de> ---
Created attachment 11058
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D11058&action=3De=
dit
Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff clie=
nt
This enhancement uses information from MARC field 856 to generate the
appropriate HTML5 code to embed am media player for the file(s) in a tab in t=
he
OPAC and staff client detail view. This patch supports the HTML5 and
element. Additionally it gives basic support for the element.
This element is not supported very well by recent browsers. Please consider t=
he
patch working when you get working video or audio.
Changes since last version:
- failed QA: removed default view for media tab, changed tab name to "Play
audio" resp. "Play video".
- put most of the code in separate module and access it from OPAC and staff
client now, so the feature works in both
- added mp3 to default media types
- had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or
'both'; HTML5MediaExtensions has additional 'mp3' as default
If you tested this before, you need to delete the old syspref entries from yo=
ur
database. There is an attachment to do this, use exactly like
upgradedatabase.pl.
Test plan
- Import attached test data. [I chose media typ 'bk' because it's probably
present on most systems. It's not appropriate for the data but that doesn't
matter.]
- Rebuild zebra -b -z
- Go to Administration->System preferences->enhanced content->HTML5 Media and
set HTML5MediaEnabled to an appropriate setting, save preferences.
- Search the OPAC or staff client for 'bug 8377'
- Get 4 results
- Open detail pages for results. Observe working video (1-3) or audio (4)
player on detail page.
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============7445327847813326083==--
From bugzilla-daemon@bugs.koha-community.org Sat Jul 21 04:48:33 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Sat, 21 Jul 2012 02:59:07 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6594317684128891143=="
--===============6594317684128891143==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
Mirko Tietgen <5p4m@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11058|0 |1
is obsolete| |
--- Comment #12 from Mirko Tietgen <5p4m@gmx.de> ---
Created attachment 11059
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D11059&action=3De=
dit
Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff clie=
nt
This enhancement uses information from MARC field 856 to generate the
appropriate HTML5 code to embed am media player for the file(s) in a tab in t=
he
OPAC and staff client detail view. This patch supports the HTML5 and
element. Additionally it gives basic support for the element.
This element is not supported very well by recent browsers. Please consider t=
he
patch working when you get working video or audio.
Changes since last version:
- failed QA: removed default view for media tab, changed tab name to "Play
audio" resp. "Play video".
- put most of the code in separate module and access it from OPAC and staff
client now, so the feature works in both
- added mp3 to default media types
- had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or
'both'; HTML5MediaExtensions has additional 'mp3' as default
If you tested this before, you need to delete the old syspref entries from yo=
ur
database. There is an attachment to do this, use exactly like
upgradedatabase.pl.
Test plan
- Import attached test data. [I chose media typ 'bk' because it's probably
present on most systems. It's not appropriate for the data but that doesn't
matter.]
- Rebuild zebra -b -z
- Go to Administration->System preferences->enhanced content->HTML5 Media and
set HTML5MediaEnabled to an appropriate setting, save preferences.
- Search the OPAC or staff client for 'bug 8377'
- Get 4 results
- Open detail pages for results. Observe working video (1-3) or audio (4)
player on detail page.
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============6594317684128891143==--
From bugzilla-daemon@bugs.koha-community.org Sat Jul 21 04:59:45 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Sat, 21 Jul 2012 03:10:19 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6750326683163088707=="
--===============6750326683163088707==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Mirko Tietgen <5p4m@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
--===============6750326683163088707==--
From bugzilla-daemon@bugs.koha-community.org Sun Jul 22 06:41:11 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Sun, 22 Jul 2012 04:51:48 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1575358933429197743=="
--===============1575358933429197743==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
Mirko Tietgen <5p4m@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11059|0 |1
is obsolete| |
--- Comment #13 from Mirko Tietgen <5p4m@gmx.de> ---
Created attachment 11067
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D11067&action=3De=
dit
Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff clie=
nt
This enhancement uses information from MARC field 856 to generate the
appropriate HTML5 code to embed am media player for the file(s) in a tab in t=
he
OPAC and staff client detail view. This patch supports the HTML5 and
element. Additionally it gives basic support for the element.
This element is not supported very well by recent browsers. Please consider t=
he
patch working when you get working video or audio.
Changes since last version:
- failed QA: removed default view for media tab, changed tab name to "Play
audio" resp. "Play video".
- put most of the code in separate module and access it from OPAC and staff
client now, so the feature works in both
- had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or
'both'
* Removed default entry for mp3 again to not imply it is widely supported or
going to be by free software browsers.
If you tested this before, you need to delete the old syspref entries from yo=
ur
database. There is an attachment to do this, use exactly like
upgradedatabase.pl.
Test plan
- Import attached test data. [I chose media typ 'bk' because it's probably
present on most systems. It's not appropriate for the data but that doesn't
matter.]
- Rebuild zebra -b -z
- Go to Administration->System preferences->enhanced content->HTML5 Media and
set HTML5MediaEnabled to an appropriate setting, save preferences.
- Search the OPAC or staff client for 'bug 8377'
- Get 4 results
- Open detail pages for results. Observe working video (1-3) or audio (4)
player on detail page.
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============1575358933429197743==--
From bugzilla-daemon@bugs.koha-community.org Mon Jul 23 00:48:03 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Sun, 22 Jul 2012 22:58:42 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8307523016098170019=="
--===============8307523016098170019==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
--- Comment #14 from Mirko Tietgen <5p4m@gmx.de> ---
Created attachment 11068
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D11068&action=3De=
dit
Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff clie=
nt
Follow-up patch, changing the tab text.
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============8307523016098170019==--
From bugzilla-daemon@bugs.koha-community.org Fri Jul 27 11:27:09 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Fri, 27 Jul 2012 09:38:02 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3225485826042329668=="
--===============3225485826042329668==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
Mirko Tietgen changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11067|0 |1
is obsolete| |
Attachment #11068|0 |1
is obsolete| |
--- Comment #15 from Mirko Tietgen ---
Created attachment 11153
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D11153&action=3De=
dit
Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff clie=
nt
This enhancement uses information from MARC field 856 to generate the
appropriate HTML5 code to embed am media player for the file(s) in a tab in t=
he
OPAC and staff client detail view. This patch supports the HTML5 and
element. Additionally it gives basic support for the element.
This element is not supported very well by recent browsers. Please consider t=
he
patch working when you get working video or audio.
Changes since last version:
- failed QA: removed default view for media tab, changed tab name to "Play
audio" resp. "Play video".
- put most of the code in separate module and access it from OPAC and staff
client now, so the feature works in both
- had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or
'both'
* Removed default entry for mp3 again to not imply it is widely supported or
going to be by free software browsers.
If you tested this before, you need to delete the old syspref entries from yo=
ur
database. There is an attachment to do this, use exactly like
upgradedatabase.pl.
Test plan
- Import attached test data. [I chose media typ 'bk' because it's probably
present on most systems. It's not appropriate for the data but that doesn't
matter.]
- Rebuild zebra -b -z
- Go to Administration->System preferences->enhanced content->HTML5 Media and
set HTML5MediaEnabled to an appropriate setting, save preferences.
- Search the OPAC or staff client for 'bug 8377'
- Get 4 results
- Open detail pages for results. Observe working video (1-3) or audio (4)
player on detail page.
Squashed both patches together
Rebased to master
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============3225485826042329668==--
From bugzilla-daemon@bugs.koha-community.org Fri Aug 10 18:04:58 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Fri, 10 Aug 2012 16:16:32 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0604735487608161656=="
--===============0604735487608161656==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
--- Comment #16 from Mirko Tietgen ---
Created attachment 11545
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D11545&action=3De=
dit
Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff clie=
nt
This enhancement uses information from MARC field 856 to generate the
appropriate HTML5 code to embed am media player for the file(s) in a tab in t=
he
OPAC and staff client detail view. This patch supports the HTML5 and
element. Additionally it gives basic support for the element.
This element is not supported very well by recent browsers. Please consider t=
he
patch working when you get working video or audio.
Changes since last version:
- failed QA: removed default view for media tab, changed tab name to "Play
audio" resp. "Play video".
- put most of the code in separate module and access it from OPAC and staff
client now, so the feature works in both
- had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or
'both'
* Removed default entry for mp3 again to not imply it is widely supported or
going to be by free software browsers.
If you tested this before, you need to delete the old syspref entries from yo=
ur
database. There is an attachment to do this, use exactly like
upgradedatabase.pl.
Test plan
- Import attached test data. [I chose media typ 'bk' because it's probably
present on most systems. It's not appropriate for the data but that doesn't
matter.]
- Rebuild zebra -b -z
- Go to Administration->System preferences->enhanced content->HTML5 Media and
set HTML5MediaEnabled to an appropriate setting, save preferences.
- Search the OPAC or staff client for 'bug 8377'
- Get 4 results
- Open detail pages for results. Observe working video (1-3) or audio (4)
player on detail page.
Squashed both patches together
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============0604735487608161656==--
From bugzilla-daemon@bugs.koha-community.org Fri Aug 10 18:07:03 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Fri, 10 Aug 2012 16:18:39 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8467596088180303065=="
--===============8467596088180303065==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
Mirko Tietgen changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11153|0 |1
is obsolete| |
Attachment #11545|0 |1
is obsolete| |
--- Comment #17 from Mirko Tietgen ---
Created attachment 11546
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D11546&action=3De=
dit
Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff clie=
nt
This enhancement uses information from MARC field 856 to generate the
appropriate HTML5 code to embed am media player for the file(s) in a tab in t=
he
OPAC and staff client detail view. This patch supports the HTML5 and
element. Additionally it gives basic support for the element.
This element is not supported very well by recent browsers. Please consider t=
he
patch working when you get working video or audio.
Changes since last version:
- failed QA: removed default view for media tab, changed tab name to "Play
audio" resp. "Play video".
- put most of the code in separate module and access it from OPAC and staff
client now, so the feature works in both
- had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or
'both'
* Removed default entry for mp3 again to not imply it is widely supported or
going to be by free software browsers.
If you tested this before, you need to delete the old syspref entries from yo=
ur
database. There is an attachment to do this, use exactly like
upgradedatabase.pl.
Test plan
- Import attached test data. [I chose media typ 'bk' because it's probably
present on most systems. It's not appropriate for the data but that doesn't
matter.]
- Rebuild zebra -b -z
- Go to Administration->System preferences->enhanced content->HTML5 Media and
set HTML5MediaEnabled to an appropriate setting, save preferences.
- Search the OPAC or staff client for 'bug 8377'
- Get 4 results
- Open detail pages for results. Observe working video (1-3) or audio (4)
player on detail page.
Squashed both patches together
rebased again
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============8467596088180303065==--
From bugzilla-daemon@bugs.koha-community.org Fri Aug 10 21:56:12 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Fri, 10 Aug 2012 20:07:48 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3810783815430525611=="
--===============3810783815430525611==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11546|0 |1
is obsolete| |
--- Comment #18 from Chris Cormack ---
Created attachment 11548
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D11548&action=3De=
dit
Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff clie=
nt
This enhancement uses information from MARC field 856 to generate the
appropriate HTML5 code to embed am media player for the file(s) in a tab in t=
he
OPAC and staff client detail view. This patch supports the HTML5 and
element. Additionally it gives basic support for the element.
This element is not supported very well by recent browsers. Please consider t=
he
patch working when you get working video or audio.
Changes since last version:
- failed QA: removed default view for media tab, changed tab name to "Play
audio" resp. "Play video".
- put most of the code in separate module and access it from OPAC and staff
client now, so the feature works in both
- had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or
'both'
* Removed default entry for mp3 again to not imply it is widely supported or
going to be by free software browsers.
If you tested this before, you need to delete the old syspref entries from yo=
ur
database. There is an attachment to do this, use exactly like
upgradedatabase.pl.
Test plan
- Import attached test data. [I chose media typ 'bk' because it's probably
present on most systems. It's not appropriate for the data but that doesn't
matter.]
- Rebuild zebra -b -z
- Go to Administration->System preferences->enhanced content->HTML5 Media and
set HTML5MediaEnabled to an appropriate setting, save preferences.
- Search the OPAC or staff client for 'bug 8377'
- Get 4 results
- Open detail pages for results. Observe working video (1-3) or audio (4)
player on detail page.
Squashed both patches together
Signed-off-by: Chris Cormack
Followed test plan, works well.
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============3810783815430525611==--
From bugzilla-daemon@bugs.koha-community.org Fri Aug 10 21:57:13 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Fri, 10 Aug 2012 20:08:50 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8435281688473385042=="
--===============8435281688473385042==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |chris@bigballofwax.co.nz
--
You are receiving this mail because:
You are watching all bug changes.
--===============8435281688473385042==--
From bugzilla-daemon@bugs.koha-community.org Sat Sep 15 07:39:08 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Sat, 15 Sep 2012 05:52:33 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5743882003869571693=="
--===============5743882003869571693==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
Paul Poulain changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
CC| |paul.poulain@biblibre.com
--- Comment #19 from Paul Poulain ---
QA comment:
This patch has one problem that must be solved before being pushed :
the Koha:: namespace must contain OO code only, the Koha/HTML5Media.pm is not
OO
I also think that this file (an OO version) should be in a subdirectory, but
I've nothing to propose for now.
I've checked that the HTML5Media.pm passes perlcritic
2 options to earn passed QA :
* rewritte HTML5Media.pm for an OO version
* move it to C4/
failing QA for now.
note I haven't tested it, and it also not apply cleanly anymore:
CONFLICT (content): Merge conflict in opac/opac-detail.pl
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pr=
ef
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Auto-merging catalogue/detail.pl
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============5743882003869571693==--
From bugzilla-daemon@bugs.koha-community.org Thu Sep 20 11:07:14 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Thu, 20 Sep 2012 09:20:54 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2531099182417882286=="
--===============2531099182417882286==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
--- Comment #20 from Mirko Tietgen ---
Created attachment 12372
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12372&action=edit
Bug 8377 [ENH] Followup: Move perl module to C4
--
You are receiving this mail because:
You are watching all bug changes.
--===============2531099182417882286==--
From bugzilla-daemon@bugs.koha-community.org Thu Sep 20 11:18:45 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Thu, 20 Sep 2012 09:32:24 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2915874699828804244=="
--===============2915874699828804244==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
Mirko Tietgen changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11548|0 |1
is obsolete| |
Attachment #12372|0 |1
is obsolete| |
--- Comment #21 from Mirko Tietgen ---
Created attachment 12373
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D12373&action=3De=
dit
Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff clie=
nt
This enhancement uses information from MARC field 856 to generate the
appropriate HTML5 code to embed am media player for the file(s) in a tab in t=
he
OPAC and staff client detail view. This patch supports the HTML5 and
element. Additionally it gives basic support for the element.
This element is not supported very well by recent browsers. Please consider t=
he
patch working when you get working video or audio.
Changes since last version:
- failed QA: removed default view for media tab, changed tab name to "Play
audio" resp. "Play video".
- put most of the code in separate module and access it from OPAC and staff
client now, so the feature works in both
- had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or
'both'
* Removed default entry for mp3 again to not imply it is widely supported or
going to be by free software browsers.
If you tested this before, you need to delete the old syspref entries from yo=
ur
database. There is an attachment to do this, use exactly like
upgradedatabase.pl.
Test plan
- Import attached test data. [I chose media typ 'bk' because it's probably
present on most systems. It's not appropriate for the data but that doesn't
matter.]
- Rebuild zebra -b -z
- Go to Administration->System preferences->enhanced content->HTML5 Media and
set HTML5MediaEnabled to an appropriate setting, save preferences.
- Search the OPAC or staff client for 'bug 8377'
- Get 4 results
- Open detail pages for results. Observe working video (1-3) or audio (4)
player on detail page.
Squashed both patches together
Bug 8377 [ENH] Followup: Move perl module to C4
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============2915874699828804244==--
From bugzilla-daemon@bugs.koha-community.org Thu Sep 20 12:11:44 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Thu, 20 Sep 2012 10:25:23 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2383708812271178198=="
--===============2383708812271178198==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
Mirko Tietgen changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #12373|0 |1
is obsolete| |
--- Comment #22 from Mirko Tietgen ---
Created attachment 12378
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D12378&action=3De=
dit
Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff clie=
nt
This enhancement uses information from MARC field 856 to generate the
appropriate HTML5 code to embed am media player for the file(s) in a tab in t=
he
OPAC and staff client detail view. This patch supports the HTML5 and
element. Additionally it gives basic support for the element.
This element is not supported very well by recent browsers. Please consider t=
he
patch working when you get working video or audio.
Changes since last version:
- failed QA: removed default view for media tab, changed tab name to "Play
audio" resp. "Play video".
- put most of the code in separate module and access it from OPAC and staff
client now, so the feature works in both
- had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or
'both'
* Removed default entry for mp3 again to not imply it is widely supported or
going to be by free software browsers.
If you tested this before, you need to delete the old syspref entries from yo=
ur
database. There is an attachment to do this, use exactly like
upgradedatabase.pl.
Test plan
- Import attached test data. [I chose media typ 'bk' because it's probably
present on most systems. It's not appropriate for the data but that doesn't
matter.]
- Rebuild zebra -b -z
- Go to Administration->System preferences->enhanced content->HTML5 Media and
set HTML5MediaEnabled to an appropriate setting, save preferences.
- Search the OPAC or staff client for 'bug 8377'
- Get 4 results
- Open detail pages for results. Observe working video (1-3) or audio (4)
player on detail page.
Squashed both patches together
Bug 8377 [ENH] Followup: Move perl module to C4
Bug 8377 [ENH] Followup: fix call for moved module
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============2383708812271178198==--
From bugzilla-daemon@bugs.koha-community.org Thu Sep 20 12:21:42 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Thu, 20 Sep 2012 10:35:22 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4380905309110008711=="
--===============4380905309110008711==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Mirko Tietgen changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--- Comment #23 from Mirko Tietgen ---
Hi Paul,
thanks a lot for reviewing the patch. I have
- rebased to master
- moved HTML5Media.pm to C4
- changed references to C4::HTML5Media.pm in catalogue/detail.pl and
opac/opac-detail.pl
- set up a sandbox to verify everything is OK
http://catalogue.test7.biblibre.com/cgi-bin/koha/opac-search.pl?q=8377
http://pro.test7.biblibre.com/cgi-bin/koha/catalogue/search.pl?q=8377
--
You are receiving this mail because:
You are watching all bug changes.
--===============4380905309110008711==--
From bugzilla-daemon@bugs.koha-community.org Fri Sep 21 20:38:33 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Fri, 21 Sep 2012 18:52:17 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6469143648209131571=="
--===============6469143648209131571==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
Mirko Tietgen changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #12378|0 |1
is obsolete| |
--- Comment #24 from Mirko Tietgen ---
Created attachment 12447
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D12447&action=3De=
dit
Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff clie=
nt
This enhancement uses information from MARC field 856 to generate the
appropriate HTML5 code to embed am media player for the file(s) in a tab in t=
he
OPAC and staff client detail view. This patch supports the HTML5 and
element. Additionally it gives basic support for the element.
This element is not supported very well by recent browsers. Please consider t=
he
patch working when you get working video or audio.
Changes since last version:
- failed QA: removed default view for media tab, changed tab name to "Play
audio" resp. "Play video".
- put most of the code in separate module and access it from OPAC and staff
client now, so the feature works in both
- had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or
'both'
* Removed default entry for mp3 again to not imply it is widely supported or
going to be by free software browsers.
If you tested this before, you need to delete the old syspref entries from yo=
ur
database. There is an attachment to do this, use exactly like
upgradedatabase.pl.
Test plan
- Import attached test data. [I chose media typ 'bk' because it's probably
present on most systems. It's not appropriate for the data but that doesn't
matter.]
- Rebuild zebra -b -z
- Go to Administration->System preferences->enhanced content->HTML5 Media and
set HTML5MediaEnabled to an appropriate setting, save preferences.
- Search the OPAC or staff client for 'bug 8377'
- Get 4 results
- Open detail pages for results. Observe working video (1-3) or audio (4)
player on detail page.
Squashed both patches together
Bug 8377 [ENH] Followup: Move perl module to C4
Bug 8377 [ENH] Followup: fix call for moved module
Rebased to Master
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============6469143648209131571==--
From bugzilla-daemon@bugs.koha-community.org Sat Sep 29 01:05:12 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Fri, 28 Sep 2012 23:19:16 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8156906060235053465=="
--===============8156906060235053465==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
Mirko Tietgen changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #12447|0 |1
is obsolete| |
--- Comment #25 from Mirko Tietgen ---
Created attachment 12603
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D12603&action=3De=
dit
Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff clie=
nt
This enhancement uses information from MARC field 856 to generate the
appropriate HTML5 code to embed am media player for the file(s) in a tab in t=
he
OPAC and staff client detail view. This patch supports the HTML5 and
element. Additionally it gives basic support for the element.
This element is not supported very well by recent browsers. Please consider t=
he
patch working when you get working video or audio.
Rebased to Master
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============8156906060235053465==--
From bugzilla-daemon@bugs.koha-community.org Sat Oct 6 06:16:23 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Sat, 06 Oct 2012 04:30:50 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1144941663683056296=="
--===============1144941663683056296==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Jared Camins-Esakov changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|master |rel_3_12
--- Comment #26 from Jared Camins-Esakov ---
Changing target version so this bug report will show up in the list of
3.12-targeted features and doesn't get lost in the shuffle during feature
freeze.
--
You are receiving this mail because:
You are watching all bug changes.
--===============1144941663683056296==--
From bugzilla-daemon@bugs.koha-community.org Fri Nov 9 15:16:53 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Fri, 09 Nov 2012 14:16:49 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7791157620103329201=="
--===============7791157620103329201==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
--- Comment #27 from Jonathan Druart ---
Created attachment 13343
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13343&action=edit
Bug 8377: Followup move style in a css file and do not pass template to a pm
1/ It's better to set style of the video marked in a css file.
2/ Replace some
for my $i in (0..#$array)
with
for my $element in (@array)
3/ the routine in a pm returns a hash not the $template variable
--
You are receiving this mail because:
You are watching all bug changes.
--===============7791157620103329201==--
From bugzilla-daemon@bugs.koha-community.org Fri Nov 9 15:19:30 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Fri, 09 Nov 2012 14:19:24 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5997899630752788822=="
--===============5997899630752788822==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Needs Signoff
CC| |jonathan.druart@biblibre.co
| |m
--- Comment #28 from Jonathan Druart ---
Hi Mirko,
Please take a look to my patch and test it. I change some code, I hope you are
ok with it.
--
You are receiving this mail because:
You are watching all bug changes.
--===============5997899630752788822==--
From bugzilla-daemon@bugs.koha-community.org Fri Nov 9 15:19:37 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Fri, 09 Nov 2012 14:19:32 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4493529057305862671=="
--===============4493529057305862671==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact| |jonathan.druart@biblibre.co
| |m
--
You are receiving this mail because:
You are watching all bug changes.
--===============4493529057305862671==--
From bugzilla-daemon@bugs.koha-community.org Fri Nov 23 13:22:31 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Thu, 22 Nov 2012 12:29:01 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2720600848708068971=="
--===============2720600848708068971==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Mirko Tietgen changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #12603|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
--===============2720600848708068971==--
From bugzilla-daemon@bugs.koha-community.org Fri Nov 23 13:22:54 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Thu, 22 Nov 2012 08:28:03 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9040967871644672564=="
--===============9040967871644672564==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #13343|0 |1
is obsolete| |
--- Comment #30 from Jonathan Druart ---
Created attachment 13623
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13623&action=edit
Bug 8377: Followup move style in a css file and do not pass template to a pm
1/ It's better to set style of the video marked in a css file.
2/ Replace some
for my $i in (0..#$array)
with
for my $element in (@array)
3/ the routine in a pm returns a hash not the $template variable
--
You are receiving this mail because:
You are watching all bug changes.
--===============9040967871644672564==--
From bugzilla-daemon@bugs.koha-community.org Fri Nov 23 13:25:30 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Wed, 21 Nov 2012 22:08:15 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9089850032716251838=="
--===============9089850032716251838==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
--- Comment #29 from Mirko Tietgen ---
Hi Jonathan,
with your followup I get
Can't locate object method "field" via package "C4::Templates" at
/home/mirko/koha/C4/HTML5Media.pm line 47.
in both OPAC and staff client.
--
You are receiving this mail because:
You are watching all bug changes.
--===============9089850032716251838==--
From bugzilla-daemon@bugs.koha-community.org Fri Nov 23 13:26:14 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Thu, 22 Nov 2012 12:31:35 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6531857908912951085=="
--===============6531857908912951085==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Mirko Tietgen changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #13623|0 |1
is obsolete| |
--- Comment #33 from Mirko Tietgen ---
Created attachment 13636
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13636&action=edit
Bug 8377: Followup move style in a css file and do not pass template to a pm
1/ It's better to set style of the video marked in a css file.
2/ Replace some
for my $i in (0..#$array)
with
for my $element in (@array)
3/ the routine in a pm returns a hash not the $template variable
Signed-off-by: Mirko Tietgen
--
You are receiving this mail because:
You are watching all bug changes.
--===============6531857908912951085==--
From bugzilla-daemon@bugs.koha-community.org Fri Nov 23 13:26:57 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Thu, 22 Nov 2012 12:33:53 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1784690742110016571=="
--===============1784690742110016571==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Mirko Tietgen changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--- Comment #34 from Mirko Tietgen ---
Rebased my patch, signed off the followup. Thanks Jonathan.
--
You are receiving this mail because:
You are watching all bug changes.
--===============1784690742110016571==--
From bugzilla-daemon@bugs.koha-community.org Fri Nov 23 13:30:20 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Thu, 22 Nov 2012 08:28:55 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5901927977398396773=="
--===============5901927977398396773==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
--- Comment #31 from Jonathan Druart ---
(In reply to comment #29)
> Hi Jonathan,
>
> with your followup I get
>
> Can't locate object method "field" via package "C4::Templates" at
> /home/mirko/koha/C4/HTML5Media.pm line 47.
>
> in both OPAC and staff client.
Sorry Mirko, could you please test with this new patch please ?
--
You are receiving this mail because:
You are watching all bug changes.
--===============5901927977398396773==--
From bugzilla-daemon@bugs.koha-community.org Fri Nov 23 13:35:40 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Thu, 22 Nov 2012 12:26:53 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3488334247720612074=="
--===============3488334247720612074==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
--- Comment #32 from Mirko Tietgen ---
Created attachment 13635
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D13635&action=3De=
dit
Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff clie=
nt
This enhancement uses information from MARC field 856 to generate the
appropriate HTML5 code to embed am media player for the file(s) in a tab in t=
he
OPAC and staff client detail view. This patch supports the HTML5 and
element. Additionally it gives basic support for the element.
This element is not supported very well by recent browsers. Please consider t=
he
patch working when you get working video or audio.
Rebased to Master 22.11.2012
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============3488334247720612074==--
From bugzilla-daemon@bugs.koha-community.org Thu Dec 20 09:48:53 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Thu, 20 Dec 2012 08:48:48 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6694421746621472852=="
--===============6694421746621472852==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy@rijksmuseum.nl
QA Contact|jonathan.druart@biblibre.co |m.de.rooy@rijksmuseum.nl
|m |
--- Comment #35 from M. de Rooy ---
Jonathan:
This patch was now first on the list for QA.=20
It seems to me however that you forgot to sign off on the first patch of Mirk=
o.
Could you do that now?
Thanks.
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============6694421746621472852==--
From bugzilla-daemon@bugs.koha-community.org Thu Dec 20 14:38:11 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Thu, 20 Dec 2012 13:38:03 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6495321171344625492=="
--===============6495321171344625492==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Needs Signoff
--- Comment #36 from Jonathan Druart ---
(In reply to comment #35)
> Jonathan:
> This patch was now first on the list for QA.
> It seems to me however that you forgot to sign off on the first patch of
> Mirko. Could you do that now?
> Thanks.
I never signed off this patch :)
Back to "Needs Signoff"
--
You are receiving this mail because:
You are watching all bug changes.
--===============6495321171344625492==--
From bugzilla-daemon@bugs.koha-community.org Thu Dec 20 15:31:50 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Thu, 20 Dec 2012 14:31:44 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8200087756139971052=="
--===============8200087756139971052==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
--- Comment #37 from M. de Rooy ---
Chris:
Looking at the history, I see that you did a signoff on this patch sometime
ago. Could you please resign the current version?
Marcel
--
You are receiving this mail because:
You are watching all bug changes.
--===============8200087756139971052==--
From bugzilla-daemon@bugs.koha-community.org Wed Dec 26 22:03:50 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Wed, 26 Dec 2012 21:03:40 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4440933485937258104=="
--===============4440933485937258104==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #13635|0 |1
is obsolete| |
--- Comment #38 from Chris Cormack ---
Created attachment 14279
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D14279&action=3De=
dit
Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff clie=
nt
This enhancement uses information from MARC field 856 to generate the
appropriate HTML5 code to embed am media player for the file(s) in a tab in t=
he
OPAC and staff client detail view. This patch supports the HTML5 and
element. Additionally it gives basic support for the element.
This element is not supported very well by recent browsers. Please consider t=
he
patch working when you get working video or audio.
Rebased to Master 22.11.2012
Signed-off-by: Chris Cormack
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============4440933485937258104==--
From bugzilla-daemon@bugs.koha-community.org Wed Dec 26 22:07:07 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Wed, 26 Dec 2012 21:07:01 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3638998507263432319=="
--===============3638998507263432319==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
--===============3638998507263432319==--
From bugzilla-daemon@bugs.koha-community.org Wed Dec 26 22:07:14 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Wed, 26 Dec 2012 21:07:04 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7145548542813228221=="
--===============7145548542813228221==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #13636|0 |1
is obsolete| |
--- Comment #39 from Chris Cormack ---
Created attachment 14280
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14280&action=edit
Bug 8377: Followup move style in a css file and do not pass template to a pm
1/ It's better to set style of the video marked in a css file.
2/ Replace some
for my $i in (0..#$array)
with
for my $element in (@array)
3/ the routine in a pm returns a hash not the $template variable
Signed-off-by: Mirko Tietgen
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
--===============7145548542813228221==--
From bugzilla-daemon@bugs.koha-community.org Wed Dec 26 22:07:35 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Wed, 26 Dec 2012 21:07:31 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1996951087816080238=="
--===============1996951087816080238==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Medium patch
--
You are receiving this mail because:
You are watching all bug changes.
--===============1996951087816080238==--
From bugzilla-daemon@bugs.koha-community.org Thu Dec 27 10:02:54 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Thu, 27 Dec 2012 09:02:45 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2441130860478758117=="
--===============2441130860478758117==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
QA Contact|m.de.rooy@rijksmuseum.nl |jonathan.druart@biblibre.co
| |m
--- Comment #40 from Jonathan Druart ---
QA Comments:
The code is clean, nothing to add.
I proposed a followup for a little part of the code that required minor
modifications.
Thanks for the test plan and the test data, it was very useful!
Marked as Passed QA.
--
You are receiving this mail because:
You are watching all bug changes.
--===============2441130860478758117==--
From bugzilla-daemon@bugs.koha-community.org Thu Dec 27 10:03:08 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Thu, 27 Dec 2012 09:03:03 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3317081780900308520=="
--===============3317081780900308520==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8377
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14279|0 |1
is obsolete| |
--- Comment #41 from Jonathan Druart ---
Created attachment 14284
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D14284&action=3De=
dit
Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff clie=
nt
This enhancement uses information from MARC field 856 to generate the
appropriate HTML5 code to embed am media player for the file(s) in a tab in t=
he
OPAC and staff client detail view. This patch supports the HTML5 and
element. Additionally it gives basic support for the element.
This element is not supported very well by recent browsers. Please consider t=
he
patch working when you get working video or audio.
Rebased to Master 22.11.2012
Signed-off-by: Chris Cormack
Signed-off-by: Jonathan Druart
--=20
You are receiving this mail because:
You are watching all bug changes.
--===============3317081780900308520==--
From bugzilla-daemon@bugs.koha-community.org Thu Dec 27 10:03:29 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Thu, 27 Dec 2012 09:03:20 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2818222791377166617=="
--===============2818222791377166617==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14280|0 |1
is obsolete| |
--- Comment #42 from Jonathan Druart ---
Created attachment 14285
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14285&action=edit
Bug 8377: Followup move style in a css file and do not pass template to a pm
1/ It's better to set style of the video marked in a css file.
2/ Replace some
for my $i in (0..#$array)
with
for my $element in (@array)
3/ the routine in a pm returns a hash not the $template variable
Signed-off-by: Mirko Tietgen
Signed-off-by: Chris Cormack
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
--===============2818222791377166617==--
From bugzilla-daemon@bugs.koha-community.org Thu Dec 27 15:29:08 2012
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Thu, 27 Dec 2012 14:29:00 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7721519603620772653=="
--===============7721519603620772653==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Jared Camins-Esakov changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #43 from Jared Camins-Esakov ---
This patch has been pushed to master.
--
You are receiving this mail because:
You are watching all bug changes.
--===============7721519603620772653==--
From bugzilla-daemon@bugs.koha-community.org Sun Mar 24 10:03:17 2013
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in
OPAC and staff client
Date: Sun, 24 Mar 2013 09:03:08 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4151722746626704034=="
--===============4151722746626704034==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer@bsz-bw.de
Severity|enhancement |new feature
--
You are receiving this mail because:
You are watching all bug changes.
--===============4151722746626704034==--