From bugzilla-daemon@bugs.koha-community.org Thu Mar  7 20:20:52 2013
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 9764] New: Replace YUI buttons on the authority
 search popup with Bootstrap
Date: Thu, 07 Mar 2013 19:20:30 +0000
Message-ID: <bug-9764-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0675260863100663735=="

--===============0675260863100663735==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D9764

            Bug ID: 9764
           Summary: Replace YUI buttons on the authority search popup with
                    Bootstrap
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/authorities/auth_finder.pl
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard@myacpl.org
          Reporter: oleonard@myacpl.org

The authority search popup has several buttons which are styled with YUI. A
couple of these ("Submit," "Cancel") should not be styled at all to conform
with general practice. The others ("Clear field," "Create new") can be moved =
to
a toolbar div and styled with Bootstrap.

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============0675260863100663735==--


From bugzilla-daemon@bugs.koha-community.org Thu Mar  7 20:31:30 2013
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 9764] Replace YUI buttons on the authority search
 popup with Bootstrap
Date: Thu, 07 Mar 2013 19:31:09 +0000
Message-ID: <bug-9764-70-1E2vyBb6RF@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-9764-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6169861480915901328=="

--===============6169861480915901328==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6169861480915901328==--


From bugzilla-daemon@bugs.koha-community.org Thu Mar  7 20:31:32 2013
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 9764] Replace YUI buttons on the authority search
 popup with Bootstrap
Date: Thu, 07 Mar 2013 19:31:11 +0000
Message-ID: <bug-9764-70-J63ZbfmMvF@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-9764-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8786374206266174820=="

--===============8786374206266174820==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764

--- Comment #1 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 15953
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15953&action=edit
Bug 9764 - Replace YUI buttons on authority search popup with Bootstrap

The authority search popup styles several buttons with YUI. Bootstrap
should be used instead.

This patch removes YUI styling from two buttons ("Submit" and "Cancel")
in favor of default styling for consistency's sake. The other buttons
("Clear field" and "Create new") have been moved to a standard toolbar
div and styled with Bootstrap.

Some inline JavaScript has been moved to the <script> tag in order to
eliminate undesirable javascript: pseudo-protocol links.

To test, open a bibliographic record for editing and click the authority
edit link next to a field with authority-linked data in it.
- Confirm that buttons in the popup window look correct.
- Confirm that the "Clear field" button clears the field in the MARC
  editor.
- Confirm that the "Create new authority" button launches a blank
  authority editor.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8786374206266174820==--


From bugzilla-daemon@bugs.koha-community.org Fri Mar  8 00:17:59 2013
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 9764] Replace YUI buttons on the authority search
 popup with Bootstrap
Date: Thu, 07 Mar 2013 23:17:38 +0000
Message-ID: <bug-9764-70-3PZigA4r3z@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-9764-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6001770097644351996=="

--===============6001770097644351996==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764

Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15953|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> ---
Created attachment 15958
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15958&action=edit
[SIGNED-OFF] Bug 9764 - Replace YUI buttons on authority search popup with
Bootstrap

The authority search popup styles several buttons with YUI. Bootstrap
should be used instead.

This patch removes YUI styling from two buttons ("Submit" and "Cancel")
in favor of default styling for consistency's sake. The other buttons
("Clear field" and "Create new") have been moved to a standard toolbar
div and styled with Bootstrap.

Some inline JavaScript has been moved to the <script> tag in order to
eliminate undesirable javascript: pseudo-protocol links.

To test, open a bibliographic record for editing and click the authority
edit link next to a field with authority-linked data in it.
- Confirm that buttons in the popup window look correct.
- Confirm that the "Clear field" button clears the field in the MARC
  editor.
- Confirm that the "Create new authority" button launches a blank
  authority editor.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work as described. No errors.
All buttons works: look correct, clear works, create works.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6001770097644351996==--


From bugzilla-daemon@bugs.koha-community.org Fri Mar  8 00:18:13 2013
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 9764] Replace YUI buttons on the authority search
 popup with Bootstrap
Date: Thu, 07 Mar 2013 23:17:54 +0000
Message-ID: <bug-9764-70-fhGIC5J8JW@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-9764-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8104507006257068288=="

--===============8104507006257068288==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764

Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |bgkriegel@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8104507006257068288==--


From bugzilla-daemon@bugs.koha-community.org Sun Mar 10 14:28:40 2013
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 9764] Replace YUI buttons on the authority search
 popup with Bootstrap
Date: Sun, 10 Mar 2013 13:28:24 +0000
Message-ID: <bug-9764-70-oK6JZI9qEs@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-9764-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2651894772991742603=="

--===============2651894772991742603==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |9779

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2651894772991742603==--


From bugzilla-daemon@bugs.koha-community.org Thu Mar 21 10:08:45 2013
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 9764] Replace YUI buttons on the authority search
 popup with Bootstrap
Date: Thu, 21 Mar 2013 09:08:34 +0000
Message-ID: <bug-9764-70-ICd21noRyf@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-9764-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2180454088965889063=="

--===============2180454088965889063==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer@bsz-bw.de
         QA Contact|                            |katrin.fischer@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2180454088965889063==--


From bugzilla-daemon@bugs.koha-community.org Thu Mar 21 10:13:09 2013
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 9764] Replace YUI buttons on the authority search
 popup with Bootstrap
Date: Thu, 21 Mar 2013 09:12:58 +0000
Message-ID: <bug-9764-70-wTst0zY5fE@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-9764-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3878740554821121555=="

--===============3878740554821121555==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3878740554821121555==--


From bugzilla-daemon@bugs.koha-community.org Thu Mar 21 10:13:15 2013
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 9764] Replace YUI buttons on the authority search
 popup with Bootstrap
Date: Thu, 21 Mar 2013 09:13:01 +0000
Message-ID: <bug-9764-70-mfYhzXpiQr@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-9764-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1343548602359980706=="

--===============1343548602359980706==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15958|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 16583
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16583&action=edit
[PASSED QA] Bug 9764 - Replace YUI buttons on authority search popup with
Bootstrap

The authority search popup styles several buttons with YUI. Bootstrap
should be used instead.

This patch removes YUI styling from two buttons ("Submit" and "Cancel")
in favor of default styling for consistency's sake. The other buttons
("Clear field" and "Create new") have been moved to a standard toolbar
div and styled with Bootstrap.

Some inline JavaScript has been moved to the <script> tag in order to
eliminate undesirable javascript: pseudo-protocol links.

To test, open a bibliographic record for editing and click the authority
edit link next to a field with authority-linked data in it.
- Confirm that buttons in the popup window look correct.
- Confirm that the "Clear field" button clears the field in the MARC
  editor.
- Confirm that the "Create new authority" button launches a blank
  authority editor.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work as described. No errors.
All buttons works: look correct, clear works, create works.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and QA script pass.
Tests done according to test plan.

http://bugs.koha-community.org/show_bug.cgi?id=9765

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1343548602359980706==--


From bugzilla-daemon@bugs.koha-community.org Thu Mar 21 14:55:39 2013
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 9764] Replace YUI buttons on the authority search
 popup with Bootstrap
Date: Thu, 21 Mar 2013 13:55:30 +0000
Message-ID: <bug-9764-70-Dz0c8uFz5s@http.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-9764-70@http.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6485649580406075740=="

--===============6485649580406075740==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764

Jared Camins-Esakov <jcamins@cpbibliography.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6485649580406075740==--