From bugzilla-daemon@bugs.koha-community.org Fri Jul 27 12:06:27 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8513] New: OPAC detail page broken with XSLT Date: Fri, 27 Jul 2012 10:17:20 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7727625419688709635==" --===============7727625419688709635== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Priority: P5 - low Change sponsored?: --- Bug ID: 8513 Assignee: oleonard@myacpl.org Summary: OPAC detail page broken with XSLT Severity: major Classification: Unclassified OS: All Reporter: fridolyn.somers@biblibre.com Hardware: All Status: NEW Version: master Component: OPAC Product: Koha Created attachment 11158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11158&action=edit OPAC detail page broken When using OPACXSLTDetailsDisplay = default, the OPAC detail page includes the HTML code of a result page, see screen shot. Very odd. -- You are receiving this mail because: You are watching all bug changes. --===============7727625419688709635==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 30 11:38:27 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT Date: Mon, 30 Jul 2012 09:49:29 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5288721352583564083==" --===============5288721352583564083== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6314 -- You are receiving this mail because: You are watching all bug changes. --===============5288721352583564083==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 30 14:42:14 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT Date: Mon, 30 Jul 2012 12:53:16 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2953544869048334242==" --===============2953544869048334242== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 11191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11191&action=edit Proposed patch I found the problem : In some cases, the XSLT generates an empty a tag : This brakes the page. The concerned code is the building of subjects. Correction : ------------ Subject field with authority code ($9) : if the content of is empty (= $display variable), it is set with the $9 value. Subject field without authority code ($9) : added a test on $a not empty, to avoid the same problem. Test plan : ----------- Bug appears on a record with a subject field (ie 606) containing a $9 as last subfield. Check also a record with a subject field containing some fields but not $9 nor $a. -- You are receiving this mail because: You are watching all bug changes. --===============2953544869048334242==-- From bugzilla-daemon@bugs.koha-community.org Mon Aug 6 09:52:23 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT Date: Mon, 06 Aug 2012 08:03:47 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5039927950367338726==" --===============5039927950367338726== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack --- Fridolyn, does this only occur in UNIMARC, or does NORMARC and MARC21 have the same problem? -- You are receiving this mail because: You are watching all bug changes. --===============5039927950367338726==-- From bugzilla-daemon@bugs.koha-community.org Mon Aug 6 11:53:52 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT Date: Mon, 06 Aug 2012 10:05:16 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8076514911794567762==" --===============8076514911794567762== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11191|0 |1 is obsolete| | --- Comment #3 from Fridolyn SOMERS --- Created attachment 11378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11378&action=edit Proposed patch (all MARC) Added same control on 'm880Select' template used in MARC21 and NORMARC. -- You are receiving this mail because: You are watching all bug changes. --===============8076514911794567762==-- From bugzilla-daemon@bugs.koha-community.org Mon Aug 6 11:56:30 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT Date: Mon, 06 Aug 2012 10:07:54 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3840988421110274292==" --===============3840988421110274292== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 --- Comment #4 from Fridolyn SOMERS --- Note that there are a lot of links in intranet XSLT, the problem can appear there. For me, the problem could be solved by changing XSTL output method. I send a mail 'XSLT output method' to koha-devel to open the discussion. -- You are receiving this mail because: You are watching all bug changes. --===============3840988421110274292==-- From bugzilla-daemon@bugs.koha-community.org Thu Aug 9 11:27:04 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT Date: Thu, 09 Aug 2012 09:38:37 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5690418793820849055==" --===============5690418793820849055== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============5690418793820849055==-- From bugzilla-daemon@bugs.koha-community.org Thu Aug 9 11:41:01 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT Date: Thu, 09 Aug 2012 09:52:33 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7976503047491281987==" --===============7976503047491281987== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11378|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 11478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11478&action=edit Bug 8513: OPAC detail page broken with XSLT Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. --===============7976503047491281987==-- From bugzilla-daemon@bugs.koha-community.org Fri Aug 10 07:19:29 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT Date: Fri, 10 Aug 2012 05:31:04 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3739101166362741244==" --===============3739101166362741244== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com --- Comment #6 from Mason James --- (In reply to comment #5) > Created attachment 11478 [details] > Bug 8513: OPAC detail page broken with XSLT > > Signed-off-by: Chris Cormack patch looks good and applies, passing QA fyi: we need to add some xsl, xml and javascript tests to the Koha qa-tools... :) -- You are receiving this mail because: You are watching all bug changes. --===============3739101166362741244==-- From bugzilla-daemon@bugs.koha-community.org Fri Aug 10 07:31:45 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT Date: Fri, 10 Aug 2012 05:43:21 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0671624406215484925==" --===============0671624406215484925== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 --- Comment #7 from Chris Cormack --- Check xt and xt/author tests for the xml and xslt already exist -- You are receiving this mail because: You are watching all bug changes. --===============0671624406215484925==-- From bugzilla-daemon@bugs.koha-community.org Fri Aug 10 23:51:23 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT Date: Fri, 10 Aug 2012 22:02:58 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9215478129733334961==" --===============9215478129733334961== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 --- Comment #8 from Chris Cormack --- prove t/00-valid-xml.t t/00-valid-xml.t .. ok All tests successful. Files=1, Tests=94, 5 wallclock secs ( 0.10 usr 0.01 sys + 0.47 cusr 0.68 csys = 1.26 CPU) Result: PASS Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. --===============9215478129733334961==-- From bugzilla-daemon@bugs.koha-community.org Wed Aug 29 15:18:33 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT Date: Wed, 29 Aug 2012 13:31:07 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8412086705447651364==" --===============8412086705447651364== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #9 from Paul Poulain --- Patch pushed, but the same problem also exist in staff interface I think, I just checked intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl, and the same code is here. -- You are receiving this mail because: You are watching all bug changes. --===============8412086705447651364==-- From bugzilla-daemon@bugs.koha-community.org Wed Aug 29 22:48:21 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT Date: Wed, 29 Aug 2012 21:00:56 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2035063183380400441==" --===============2035063183380400441== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack --- Paul is there a bug for the staff side? -- You are receiving this mail because: You are watching all bug changes. --===============2035063183380400441==-- From bugzilla-daemon@bugs.koha-community.org Wed Aug 29 22:52:30 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT Date: Wed, 29 Aug 2012 21:05:05 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1048023957528217410==" --===============1048023957528217410== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8678 --- Comment #11 from Jared Camins-Esakov --- (In reply to comment #10) > Paul is there a bug for the staff side? This will be fixed by bug 8678. -- You are receiving this mail because: You are watching all bug changes. --===============1048023957528217410==-- From bugzilla-daemon@bugs.koha-community.org Wed Sep 19 10:41:01 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT Date: Wed, 19 Sep 2012 08:54:38 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3177763418173778381==" --===============3177763418173778381== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8615 -- You are receiving this mail because: You are watching all bug changes. --===============3177763418173778381==--