From bugzilla-daemon@bugs.koha-community.org Wed Aug 17 16:37:03 2016
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 13736] Enable EDS Plugin Patch
Date: Wed, 17 Aug 2016 14:36:58 +0000
Message-ID: <bug-13736-70-QCWkHvpRjy@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-13736-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1373555719453246989=="

--===============1373555719453246989==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D13736

--- Comment #5 from M. Tompsett <mtompset@hotmail.com> ---
Comment on attachment 42894
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D42894
EDS Plugin Patches Code checks to see if  setting EDSEnabled is ON and
integrates the EDS Plugin to the Opac

Review of attachment 42894:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=3Dsplinter.html&b=
ug=3D13736&attachment=3D42894)
-----------------------------------------------------------------

I'm pretty sure something jquery/ajax-y could be written to get the plugin to
accomplish the same thing. I too, like Katrin in comment #4, have some
misgivings about this implementation.

::: C4/Auth.pm
@@ +471,4 @@
>              AuthorisedValueImages                 =3D> C4::Context->prefer=
ence("AuthorisedValueImages"),
>              BranchesLoop                          =3D> GetBranchesLoop($op=
ac_name),
>              BranchCategoriesLoop                  =3D> GetBranchCategories=
( 'searchdomain', 1, $opac_name ),
> +	    EDSEnabled                            =3D> C4::Context->preference("E=
DSEnabled"),

Never needed.
Access [% Koha.Preference('EDSEnabled') %] in template files.

::: koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc
@@ +48,4 @@
>      function _(s) { return s } // dummy function for gettext
>  </script>
>  <script type=3D"text/javascript" src=3D"[% interface %]/[% theme %]/lib/mo=
dernizr.min.js"></script>
> +[% IF ( EDSEnabled ) %]<script type=3D"text/javascript" language=3D"javasc=
ript" src=3D"/plugin/Koha/Plugin/EDS/js/EDSScript.js"></script>[% END %]

Including a plugin javascript link should be possible in the OPACUserJS system
preference. Make sure to carefully add/remove as needed!

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============1373555719453246989==--