From bugzilla-daemon@bugs.koha-community.org Fri Dec 20 02:26:43 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item
 from a group of titles
Date: Fri, 20 Dec 2024 01:26:40 +0000
Message-ID: <bug-15516-70-NFCIv2XIjt@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7030364860128816951=="

--===============7030364860128816951==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D15516

--- Comment #475 from David Cook <dcook@prosentient.com.au> ---
Comment on attachment 162079
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D162079
Bug 15516: Allow to reserve first available item from a group of titles

Review of attachment 162079:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=3Dsplinter.html&b=
ug=3D15516&attachment=3D162079)
-----------------------------------------------------------------

::: circ/view_holdsqueue.pl
@@ +63,5 @@
> +                biblionumber   =3D> $item->{biblionumber}
> +            },
> +            { order_by =3D> 'reservedate' }
> +        )->next;
> +        $item->{hold_group_id} =3D $related_hold ? $related_hold->hold_gro=
up_id : undef;

Ah, the lack of this block is why view_holdsqueue.tt doesn't work anymore...

This is problematic anyways. I wonder if the tmp_holdsqueue table should store
the reserve_id, although I don't quite understand the point of the
tmp_holdsqueue table...

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
@@ +197,4 @@
>                              [% ELSE %]
>                                  <strong><a href=3D"/cgi-bin/koha/catalogue=
/moredetail.pl?itemnumber=3D[% itemsloo.itemnumber | uri %]&biblionumber=3D[%=
 itemsloo.biblionumber | uri %]#item[% itemsloo.itemnumber | uri %]">[% items=
loo.barcode | uri %]</a></strong> <em>or any available</em>
>                              [% END %]
> +                            [% IF itemsloo.hold_group_id %]

This doesn't work because hold_group_id doesn't appear in the tmp_holdsqueue
table. With this patch, the Holds Queue will throw a 500 error if it has any
content to show.

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============7030364860128816951==--