From bugzilla-daemon@bugs.koha-community.org Fri Sep 10 11:14:23 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28993] New: Switch magnifying class in staff detail pages to FA icon Date: Fri, 10 Sep 2021 09:14:23 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6380575768712304754==" --===============6380575768712304754== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 Bug ID: 28993 Summary: Switch magnifying class in staff detail pages to FA icon Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org It appears that bug 13327 switched the magnifying class shown on authority links in the OPAC detail pages to a FA icon. It would be nice to make the same change to the staff detail pages. -- You are receiving this mail because: You are watching all bug changes. --===============6380575768712304754==-- From bugzilla-daemon@bugs.koha-community.org Fri Sep 10 18:23:33 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28993] Switch magnifying class in staff detail pages to FA icon Date: Fri, 10 Sep 2021 16:23:32 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8678831578721226113==" --===============8678831578721226113== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. --===============8678831578721226113==-- From bugzilla-daemon@bugs.koha-community.org Fri Sep 10 20:32:20 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28993] Switch magnifying class in staff detail pages to FA icon Date: Fri, 10 Sep 2021 18:32:20 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5320538364610916828==" --===============5320538364610916828== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 --- Comment #1 from Owen Leonard --- I'd like to also replace the image on the authority detail page but I'm confused by this section of the template (authorities/detail.tt): [% IF ( subfiel.link ) %] [% END %] [% IF ( subfiel.authority ) %] Auth [% END %] Are subfiel.link and subfiel.authority really relevant to an authority record? I'm wondering if it's actually copy and paste from the MARC view. -- You are receiving this mail because: You are watching all bug changes. --===============5320538364610916828==-- From bugzilla-daemon@bugs.koha-community.org Mon Sep 20 16:25:30 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28993] Switch magnifying class in staff detail pages to FA icon Date: Mon, 20 Sep 2021 14:25:29 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1246843180499522332==" --===============1246843180499522332== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 --- Comment #2 from Katrin Fischer --- Authorities can also be linked to each other hierarchically - could that have to do with it? -- You are receiving this mail because: You are watching all bug changes. --===============1246843180499522332==-- From bugzilla-daemon@bugs.koha-community.org Wed Jan 12 18:02:39 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28993] Switch magnifying class in staff detail pages to FA icon Date: Wed, 12 Jan 2022 17:02:39 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4209663070341004016==" --===============4209663070341004016== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. --===============4209663070341004016==-- From bugzilla-daemon@bugs.koha-community.org Wed Jan 12 18:02:50 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28993] Switch magnifying class in staff detail pages to FA icon Date: Wed, 12 Jan 2022 17:02:43 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4210897836816505288==" --===============4210897836816505288== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D28993 --- Comment #3 from Owen Leonard --- Created attachment 129355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D129355&action= =3Dedit Bug 28993: Switch magnifying class in staff detail pages to FA icon This patch modifies the staff interface's bibliographic detail XSL so that a Font Awesome is used instead of a magnifying glass image when listing authority subject headings. The patch also corrects two other places where the image is used so that the image can be removed. Some markup from authorities.detail.tt is removed because it appears to be unused (a copy and paste from catalogue/detail.tt). To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff= _client). - To view the changes to the staff interface bibliographic detail page, locate a record which has at least one subject heading which is linked to a subject authority record. - The subject heading link should be followed by a magifying glass (Font Awesome) icon which links to the authority record's detail page. - View a similar change to the MARC detail page for the record. Confirm that the subject headings are followed by a link to the authority detail page. - Follow the authority search link to locate and view an authority record. The information on the authority detail page should be correct. --=20 You are receiving this mail because: You are watching all bug changes. --===============4210897836816505288==-- From bugzilla-daemon@bugs.koha-community.org Sun Jan 23 21:53:30 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28993] Switch magnifying class in staff detail pages to FA icon Date: Sun, 23 Jan 2022 20:53:29 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5852709340442072865==" --===============5852709340442072865== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============5852709340442072865==-- From bugzilla-daemon@bugs.koha-community.org Sun Jan 23 21:53:40 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28993] Switch magnifying class in staff detail pages to FA icon Date: Sun, 23 Jan 2022 20:53:33 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5179255102597462753==" --===============5179255102597462753== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D28993 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129355|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 129715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D129715&action= =3Dedit Bug 28993: Switch magnifying class in staff detail pages to FA icon This patch modifies the staff interface's bibliographic detail XSL so that a Font Awesome is used instead of a magnifying glass image when listing authority subject headings. The patch also corrects two other places where the image is used so that the image can be removed. Some markup from authorities.detail.tt is removed because it appears to be unused (a copy and paste from catalogue/detail.tt). To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff= _client). - To view the changes to the staff interface bibliographic detail page, locate a record which has at least one subject heading which is linked to a subject authority record. - The subject heading link should be followed by a magifying glass (Font Awesome) icon which links to the authority record's detail page. - View a similar change to the MARC detail page for the record. Confirm that the subject headings are followed by a link to the authority detail page. - Follow the authority search link to locate and view an authority record. The information on the authority detail page should be correct. Signed-off-by: David Nind --=20 You are receiving this mail because: You are watching all bug changes. --===============5179255102597462753==-- From bugzilla-daemon@bugs.koha-community.org Sun Jan 30 14:28:51 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28993] Switch magnifying class in staff detail pages to FA icon Date: Sun, 30 Jan 2022 13:28:50 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0478007563453915772==" --===============0478007563453915772== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============0478007563453915772==-- From bugzilla-daemon@bugs.koha-community.org Sun Jan 30 14:29:01 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28993] Switch magnifying class in staff detail pages to FA icon Date: Sun, 30 Jan 2022 13:28:54 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8478213218542948218==" --===============8478213218542948218== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D28993 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129715|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 129981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D129981&action= =3Dedit Bug 28993: Switch magnifying class in staff detail pages to FA icon This patch modifies the staff interface's bibliographic detail XSL so that a Font Awesome is used instead of a magnifying glass image when listing authority subject headings. The patch also corrects two other places where the image is used so that the image can be removed. Some markup from authorities.detail.tt is removed because it appears to be unused (a copy and paste from catalogue/detail.tt). To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff= _client). - To view the changes to the staff interface bibliographic detail page, locate a record which has at least one subject heading which is linked to a subject authority record. - The subject heading link should be followed by a magifying glass (Font Awesome) icon which links to the authority record's detail page. - View a similar change to the MARC detail page for the record. Confirm that the subject headings are followed by a link to the authority detail page. - Follow the authority search link to locate and view an authority record. The information on the authority detail page should be correct. Signed-off-by: David Nind Signed-off-by: Katrin Fischer --=20 You are receiving this mail because: You are watching all bug changes. --===============8478213218542948218==-- From bugzilla-daemon@bugs.koha-community.org Sun Jan 30 14:29:36 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28993] Switch magnifying class in staff detail pages to FA icon Date: Sun, 30 Jan 2022 13:29:35 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3596304186876747438==" --===============3596304186876747438== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 --- Comment #6 from Katrin Fischer --- Especially like the newly added aria-label :) -- You are receiving this mail because: You are watching all bug changes. --===============3596304186876747438==-- From bugzilla-daemon@bugs.koha-community.org Wed Feb 2 20:44:20 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28993] Switch magnifying glass in staff detail pages to FA icon Date: Wed, 02 Feb 2022 19:44:20 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7050747769074084808==" --===============7050747769074084808== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Switch magnifying class in |Switch magnifying glass in |staff detail pages to FA |staff detail pages to FA |icon |icon CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. --===============7050747769074084808==-- From bugzilla-daemon@bugs.koha-community.org Wed Feb 2 20:45:37 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28993] Switch magnifying glass in staff detail pages to FA icon Date: Wed, 02 Feb 2022 19:45:36 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7146549343187387035==" --===============7146549343187387035== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 --- Comment #7 from Fridolin Somers --- magnifying "glass" 🔍 I'll fix commit message when pushing to master -- You are receiving this mail because: You are watching all bug changes. --===============7146549343187387035==-- From bugzilla-daemon@bugs.koha-community.org Thu Feb 10 09:03:51 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28993] Switch magnifying glass in staff detail pages to FA icon Date: Thu, 10 Feb 2022 08:03:05 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5407264657583888330==" --===============5407264657583888330== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. --===============5407264657583888330==-- From bugzilla-daemon@bugs.koha-community.org Thu Feb 10 09:04:01 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28993] Switch magnifying glass in staff detail pages to FA icon Date: Thu, 10 Feb 2022 08:03:07 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9189694661592201973==" --===============9189694661592201973== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 --- Comment #8 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. --===============9189694661592201973==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 11 13:04:29 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28993] Switch magnifying glass in staff detail pages to FA icon Date: Fri, 11 Feb 2022 12:04:28 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1558548241302312259==" --===============1558548241302312259== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. --===============1558548241302312259==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 18 12:01:36 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28993] Switch magnifying glass in staff detail pages to FA icon Date: Fri, 18 Feb 2022 11:01:26 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3753752657792558245==" --===============3753752657792558245== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D28993 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20362 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20362 [Bug 20362] Direct link to authority records missing in staff detail view (1x= x, 7xx) --=20 You are receiving this mail because: You are watching all bug changes. --===============3753752657792558245==--