From bugzilla-daemon@bugs.koha-community.org Thu May 23 14:34:07 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22973] New: Remove type attribute from script tags:
 Staff client includes 2/2
Date: Thu, 23 May 2019 12:34:04 +0000
Message-ID: <bug-22973-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6051653101366985945=="

--===============6051653101366985945==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22973

            Bug ID: 22973
           Summary: Remove type attribute from script tags: Staff client
                    includes 2/2
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard@myacpl.org
          Reporter: oleonard@myacpl.org
        QA Contact: testopia@bugs.koha-community.org
                CC: testopia@bugs.koha-community.org
            Blocks: 22956
  Target Milestone: ---

This patch will remove the obsolete "type" attribute from <script> tags in the
following staff client include files:

 - intranet-tmpl\prog\en\includes\installer-strings.inc
 - intranet-tmpl\prog\en\includes\password_check.inc
 - intranet-tmpl\prog\en\includes\slip-print.inc
 - intranet-tmpl\prog\en\includes\strings.inc
 - intranet-tmpl\prog\en\includes\timepicker.inc
 - intranet-tmpl\prog\en\includes\validator-strings.inc
 - intranet-tmpl\prog\en\includes\z3950_search.inc


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22956
[Bug 22956] Omnibus: Remove type attribute from script tags
-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6051653101366985945==--


From bugzilla-daemon@bugs.koha-community.org Thu May 23 14:34:42 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22973] Remove type attribute from script tags: Staff
 client includes 2/2
Date: Thu, 23 May 2019 12:34:12 +0000
Message-ID: <bug-22973-70-ATsYlO6j5S@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22973-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4074852184658603163=="

--===============4074852184658603163==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22973

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4074852184658603163==--


From bugzilla-daemon@bugs.koha-community.org Thu May 23 15:39:46 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22973] Remove type attribute from script tags: Staff
 client includes 2/2
Date: Thu, 23 May 2019 13:39:42 +0000
Message-ID: <bug-22973-70-pqAneVsVvS@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22973-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6574569319600153114=="

--===============6574569319600153114==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22973

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22974


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22974
[Bug 22974] Patron password update validation broken
-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6574569319600153114==--


From bugzilla-daemon@bugs.koha-community.org Thu May 23 15:44:05 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22973] Remove type attribute from script tags: Staff
 client includes 2/2
Date: Thu, 23 May 2019 13:44:02 +0000
Message-ID: <bug-22973-70-b6VYG4oZUC@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22973-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8757331322823196240=="

--===============8757331322823196240==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22973

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8757331322823196240==--


From bugzilla-daemon@bugs.koha-community.org Thu May 23 15:44:08 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22973] Remove type attribute from script tags: Staff
 client includes 2/2
Date: Thu, 23 May 2019 13:44:04 +0000
Message-ID: <bug-22973-70-VoVJdFadkZ@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22973-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5252786442572091645=="

--===============5252786442572091645==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22973

--- Comment #1 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 90031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90031&action=edit
Bug 22973: Remove type attribute from script tags: Staff client includes 2/2

This patch removes the "type" attribute from <script> tags in several
staff client include files. Also removed: Obsolete "//<![CDATA[ //]]>"
markers.

This patch also makes minor indentation changes, so diff using the "-w"
flag.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Installer -> Onboarding (uses installer-strings.inc,
   validator-strings.inc)
 - Patrons -> Patron details -> Change password (uses
   password_check.inc)
 - Patrons -> Patron details -> Print summary (slip-print.inc)
 - Circulation -> Check out (strings.inc, timepicker.inc)
 - Cataloging -> New from Z39.50/SRU (z3950_search.inc)

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5252786442572091645==--


From bugzilla-daemon@bugs.koha-community.org Thu May 23 20:51:22 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22973] Remove type attribute from script tags: Staff
 client includes 2/2
Date: Thu, 23 May 2019 18:51:19 +0000
Message-ID: <bug-22973-70-aqCjD4Qum0@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22973-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7792892413904715071=="

--===============7792892413904715071==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22973

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7792892413904715071==--


From bugzilla-daemon@bugs.koha-community.org Fri May 24 00:47:21 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22973] Remove type attribute from script tags: Staff
 client includes 2/2
Date: Thu, 23 May 2019 22:47:18 +0000
Message-ID: <bug-22973-70-zGWBhyCO2f@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22973-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7968570193838274589=="

--===============7968570193838274589==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22973

Hayley Mapley <hayleymapley@catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90031|0                           |1
        is obsolete|                            |

--- Comment #2 from Hayley Mapley <hayleymapley@catalyst.net.nz> ---
Created attachment 90055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90055&action=edit
Bug 22973: Remove type attribute from script tags: Staff client includes 2/2

This patch removes the "type" attribute from <script> tags in several
staff client include files. Also removed: Obsolete "//<![CDATA[ //]]>"
markers.

This patch also makes minor indentation changes, so diff using the "-w"
flag.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Installer -> Onboarding (uses installer-strings.inc,
   validator-strings.inc)
 - Patrons -> Patron details -> Change password (uses
   password_check.inc)
 - Patrons -> Patron details -> Print summary (slip-print.inc)
 - Circulation -> Check out (strings.inc, timepicker.inc)
 - Cataloging -> New from Z39.50/SRU (z3950_search.inc)

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7968570193838274589==--


From bugzilla-daemon@bugs.koha-community.org Fri May 24 00:48:05 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22973] Remove type attribute from script tags: Staff
 client includes 2/2
Date: Thu, 23 May 2019 22:48:03 +0000
Message-ID: <bug-22973-70-gQ6tHyycBK@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22973-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4332023185608062926=="

--===============4332023185608062926==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22973

Hayley Mapley <hayleymapley@catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |hayleymapley@catalyst.net.n
                   |                            |z

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4332023185608062926==--


From bugzilla-daemon@bugs.koha-community.org Mon May 27 22:48:16 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22973] Remove type attribute from script tags: Staff
 client includes 2/2
Date: Mon, 27 May 2019 20:48:13 +0000
Message-ID: <bug-22973-70-fLH041pOjU@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22973-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3685243248167622107=="

--===============3685243248167622107==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22973

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3685243248167622107==--


From bugzilla-daemon@bugs.koha-community.org Mon May 27 22:48:20 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22973] Remove type attribute from script tags: Staff
 client includes 2/2
Date: Mon, 27 May 2019 20:48:16 +0000
Message-ID: <bug-22973-70-LZxZmfgHWO@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22973-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4686553972465905699=="

--===============4686553972465905699==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22973

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90055|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 90124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90124&action=edit
Bug 22973: Remove type attribute from script tags: Staff client includes 2/2

This patch removes the "type" attribute from <script> tags in several
staff client include files. Also removed: Obsolete "//<![CDATA[ //]]>"
markers.

This patch also makes minor indentation changes, so diff using the "-w"
flag.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Installer -> Onboarding (uses installer-strings.inc,
   validator-strings.inc)
 - Patrons -> Patron details -> Change password (uses
   password_check.inc)
 - Patrons -> Patron details -> Print summary (slip-print.inc)
 - Circulation -> Check out (strings.inc, timepicker.inc)
 - Cataloging -> New from Z39.50/SRU (z3950_search.inc)

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4686553972465905699==--


From bugzilla-daemon@bugs.koha-community.org Thu May 30 12:39:49 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22973] Remove type attribute from script tags: Staff
 client includes 2/2
Date: Thu, 30 May 2019 10:39:36 +0000
Message-ID: <bug-22973-70-HZFsFxPS6z@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22973-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0967306409002543949=="

--===============0967306409002543949==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22973

Nick Clemens <nick@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick@bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Nick Clemens <nick@bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0967306409002543949==--


From bugzilla-daemon@bugs.koha-community.org Thu May 30 22:14:49 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22973] Remove type attribute from script tags: Staff
 client includes 2/2
Date: Thu, 30 May 2019 20:14:19 +0000
Message-ID: <bug-22973-70-J1Zh88LoQG@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22973-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6995330738382670914=="

--===============6995330738382670914==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22973
Bug 22973 depends on bug 22974, which changed state.

Bug 22974 Summary: Patron password update validation broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22974

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6995330738382670914==--