From bugzilla-daemon@bugs.koha-community.org Fri Mar 10 06:46:12 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] New: Add search history button to advance search form if EnableSearchHistory keep Date: Fri, 10 Mar 2023 05:46:11 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5234122852392295087==" --===============5234122852392295087== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D33190 Bug ID: 33190 Summary: Add search history button to advance search form if EnableSearchHistory keep Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: adam.styles@esa.edu.au QA Contact: testopia@bugs.koha-community.org Created attachment 148047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D148047&action= =3Dedit screen shot of search history button in koha dev box as preview Hi All, I believe the 'search history' feature to be quite useful in daily repeated search work flows, further to this it is a feature fairly hidden behind a drop down UI in the top right when logged in.=20 Therefor to promote the use of this valuable tool and also to improve it's discoverability, I propose the follow new enhancement. User story: * Add 'search history' button to advanced search button groups if 'EnableSearchHistory' sys pref is set to 'keep' Key logic: * If 'EnableSearchHistory' sys pref is set to 'keep' (this is an existing sys pref), an additional 'search history' button will populate at the of the current advance search buttons group * This new button element makes use of the existing syntax for other button on page and loads the font awesome 4.7 history icon which aligns with the buttons action. * The button will not display unless 'EnableSearchHistory' sys pref is set to 'keep', which makes use of a IF statement in the advsearch.tt template file at around line 100 ish (see patch) ``` [% IF Koha.Preference('EnableSearchHistory') %]
= search history
[% END %] ``` I have tested in Koha dev box v22 and all works well. I will create test plan in patch commit message. I am creating my first patch for this very soon, just reading coding guidelin= es to ensure I patch as community expects. See attached screen shot. I welcome feedback. Thanks. --=20 You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============5234122852392295087==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 10 06:50:29 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Fri, 10 Mar 2023 05:50:29 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6336451214934027641==" --===============6336451214934027641== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Adam Styles changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |adam.styles@esa.edu.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============6336451214934027641==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 10 07:29:00 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Fri, 10 Mar 2023 06:28:59 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5145785982588599638==" --===============5145785982588599638== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 --- Comment #1 from Adam Styles --- Created attachment 148048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148048&action=edit Add search history button to advance search form if EnableSearchHistory keep Bug 33190: Add search history button to advance search form if EnableSearchHistory keep Add 'search history' button to advanced search button groups if 'EnableSearchHistory' sys pref is set to 'keep' via added code block to advsearch.tt To test: 1) Login to Koha dev box instance 2) Select 'Advanced search module' '/cgi-bin/koha/catalogue/search.pl' 'Search history' icon will not be visible in tools groups in form. 3) Select 'koha administration' module '/cgi-bin/koha/admin/admin-home.pl' 4) Enter 'EnableSearchHistory' string into top search field 5) Change 'EnableSearchHistory' value to 'keep' 6) Press 'Save all Searching preferences' to save pref changes 7) Navigate back to Koha landing home '/cgi-bin/koha/mainpage.pl' 8) Select 'Advanced search module' '/cgi-bin/koha/catalogue/search.pl' 9) 'Search history' icon will now be visible in tools groups in form 10) SIGN OFF -- You are receiving this mail because: You are watching all bug changes. --===============5145785982588599638==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 10 07:33:06 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Fri, 10 Mar 2023 06:33:06 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7440728586488438562==" --===============7440728586488438562== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 --- Comment #2 from Adam Styles --- Hi All, I could not get BZ to work in order to apply my patch via git from branch 'bug_33190' I created in Koha dev box, so I used built in patch UI here to upload the edited 'advsearch.tt' file from my branch. I will try to get bz working from future bugs. Please let me know what else is required to do in order for this to be tested/reviewed. Thanks in advance for the help. Thanks. -- You are receiving this mail because: You are watching all bug changes. --===============7440728586488438562==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 10 14:39:37 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Fri, 10 Mar 2023 13:39:26 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1888247018420671971==" --===============1888247018420671971== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33165 -- You are receiving this mail because: You are watching all bug changes. --===============1888247018420671971==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 10 14:41:37 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Fri, 10 Mar 2023 13:41:37 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7558461221831060034==" --===============7558461221831060034== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 --- Comment #3 from Katrin Fischer --- Hi Adam, are you actually using kohadevbox? If so, you might want to have a look at the newer koha-testing-docker: https://gitlab.com/koha-community/koha-testing-docker. And in general, feel free to pop into IRC, if you already got that far, I am sure we can help with the last few steps :) -- You are receiving this mail because: You are watching all bug changes. --===============7558461221831060034==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 10 21:14:36 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Fri, 10 Mar 2023 20:14:35 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1947482233832720363==" --===============1947482233832720363== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 --- Comment #4 from Adam Styles --- Hi Katrin, I am running Koha-testing-docker via linux virtualbox setup. I will re-read https://wiki.koha-community.org/wiki/Git_bz_configuration guide and then reach in IRC if git bz still an issue. Thanks. -- You are receiving this mail because: You are watching all bug changes. --===============1947482233832720363==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 10 21:37:42 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Fri, 10 Mar 2023 20:37:40 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4448636716486214909==" --===============4448636716486214909== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 --- Comment #5 from Adam Styles --- Created attachment 148099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148099&action=edit Bug 33190: Add search history button to advance search form if EnableSearchHistory keep Add 'search history' button to advanced search button groups if 'EnableSearchHistory' sys pref is set to 'keep' via added code block to advsearch.tt To test: 1) Login to Koha dev box instance 2) Select 'Advanced search module' '/cgi-bin/koha/catalogue/search.pl' 'Search history' icon will not be visible in tools groups in form. 3) Select 'koha administration' module '/cgi-bin/koha/admin/admin-home.pl' 4) Enter 'EnableSearchHistory' string into top search field 5) Change ' EnableSearchHistory' value to 'keep' 6) Press 'Save all Searching preferences' to save pref changes 7) Navigate back to Koha landing home '/cgi-bin/koha/mainpage.pl' 8) Select 'Advanced search module' '/cgi-bin/koha/catalogue/search.pl' 9) 'Search history' icon will now be visible in tools groups in form 10) SIGN OFF Sponsored-by: N/A -- You are receiving this mail because: You are watching all bug changes. --===============4448636716486214909==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 10 21:43:35 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Fri, 10 Mar 2023 20:43:35 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3532699131765963877==" --===============3532699131765963877== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Adam Styles changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #6 from Adam Styles --- with respect I request sign off for my first patch, or discussion on it's merit. thanks. -- You are receiving this mail because: You are watching all bug changes. --===============3532699131765963877==-- From bugzilla-daemon@bugs.koha-community.org Sat Mar 11 12:38:57 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Sat, 11 Mar 2023 11:38:56 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4277490524023382745==" --===============4277490524023382745== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148048|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes. --===============4277490524023382745==-- From bugzilla-daemon@bugs.koha-community.org Sat Mar 11 12:39:09 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Sat, 11 Mar 2023 11:39:09 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4638030156849650862==" --===============4638030156849650862== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148048|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. --===============4638030156849650862==-- From bugzilla-daemon@bugs.koha-community.org Sat Mar 11 12:42:36 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Sat, 11 Mar 2023 11:42:35 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3264186090658082873==" --===============3264186090658082873== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 --- Comment #7 from Katrin Fischer --- Hi Adam, your new file looks like a patch should, thanks! Some things to note: 1) The older file that was uploaded as 'patch' would have confused our scripts so I have obsoleted and only left your new file. This will make things work with sandboxes and git bz for others. 2) I notice that you code is not using any identation. We use 4 spaces for indentation and it should fit in its spot with the rest of the code. 3) Sponsored-by: N/A is not needed and would show as N/A in release notes, but we can delete this in a later step. You could list your institution as sponsor if you want :) We currently have a big backlog of patches and we rely on volunteers for testing and QA'ing code, so it might take a little while to get feedback. -- You are receiving this mail because: You are watching all bug changes. --===============3264186090658082873==-- From bugzilla-daemon@bugs.koha-community.org Sun Mar 12 02:39:52 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Sun, 12 Mar 2023 01:39:51 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5445663807889552019==" --===============5445663807889552019== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Adam Styles changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148099|0 |1 is obsolete| | --- Comment #8 from Adam Styles --- Created attachment 148105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148105&action=edit Bug 33190: Add search history button to advance search form if EnableSearchHistory keep Add 'search history' button to advanced search button groups if 'EnableSearchHistory' sys pref is set to 'keep' via added code block to advsearch.tt To test: 1) Login to Koha dev box instance 2) Select 'Advanced search module' '/cgi-bin/koha/catalogue/search.pl' 'Search history' icon will not be visible in tools groups in form. 3) Select 'koha administration' module '/cgi-bin/koha/admin/admin-home.pl' 4) Enter 'EnableSearchHistory' string into top search field 5) Change ' EnableSearchHistory' value to 'keep' 6) Press 'Save all Searching preferences' to save pref changes 7) Navigate back to Koha landing home '/cgi-bin/koha/mainpage.pl' 8) Select 'Advanced search module' '/cgi-bin/koha/catalogue/search.pl' 9) 'Search history' icon will now be visible in tools groups in form 10) SIGN OFF -- You are receiving this mail because: You are watching all bug changes. --===============5445663807889552019==-- From bugzilla-daemon@bugs.koha-community.org Sun Mar 12 02:44:41 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Sun, 12 Mar 2023 01:44:41 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5436774143882327138==" --===============5436774143882327138== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 --- Comment #9 from Adam Styles --- Hi Katrin, Thanks so much for this feedback. I have rebuilt my patch with the correct code indentation. It was good practice for patch submission. I can imagine such the list of patches to test is quite long, I am just happy to have possibly contributed. Thanks. -- You are receiving this mail because: You are watching all bug changes. --===============5436774143882327138==-- From bugzilla-daemon@bugs.koha-community.org Mon Mar 13 16:27:17 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Mon, 13 Mar 2023 15:27:17 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7604372089132577768==" --===============7604372089132577768== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D33190 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #10 from Matt Blenkinsop --- Hi Adam, I've just been through your test plan and the patch works as advertised :) Ju= st one small change that needs making - the button is labelled "search history". Koha uses sentence case for strings so this would need to be "Search history". If you can change that and re-submit the patch I can sign it off for you and send it to the QA team. Let me know if you need any assistance --=20 You are receiving this mail because: You are watching all bug changes. --===============7604372089132577768==-- From bugzilla-daemon@bugs.koha-community.org Tue Mar 14 02:28:46 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Tue, 14 Mar 2023 01:28:45 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7480608125453275630==" --===============7480608125453275630== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Adam Styles changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148105|0 |1 is obsolete| | --- Comment #11 from Adam Styles --- Created attachment 148150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148150&action=edit Bug 33190: Add search history button to advance search form if EnableSearchHistory keep Add 'search history' button to advanced search button groups if 'EnableSearchHistory' sys pref is set to 'keep' via added code block to advsearch.tt To test: 1) Login to Koha dev box instance 2) Select 'Advanced search module' '/cgi-bin/koha/catalogue/search.pl' 'Search history' icon will not be visible in tools groups in form. 3) Select 'koha administration' module '/cgi-bin/koha/admin/admin-home.pl' 4) Enter 'EnableSearchHistory' string into top search field 5) Change ' EnableSearchHistory' value to 'keep' 6) Press 'Save all Searching preferences' to save pref changes 7) Navigate back to Koha landing home '/cgi-bin/koha/mainpage.pl' 8) Select 'Advanced search module' '/cgi-bin/koha/catalogue/search.pl' 9) 'Search history' icon will now be visible in tools groups in form 10) SIGN OFF -- You are receiving this mail because: You are watching all bug changes. --===============7480608125453275630==-- From bugzilla-daemon@bugs.koha-community.org Tue Mar 14 02:31:07 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Tue, 14 Mar 2023 01:31:06 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0698326369214406682==" --===============0698326369214406682== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 --- Comment #12 from Adam Styles --- Hi Matt, Thanks so much for the review. I have updated source and re-submitted patch with required naming convention. Thanks so much. -- You are receiving this mail because: You are watching all bug changes. --===============0698326369214406682==-- From bugzilla-daemon@bugs.koha-community.org Tue Mar 14 10:36:32 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Tue, 14 Mar 2023 09:36:31 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5512792199835452957==" --===============5512792199835452957== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============5512792199835452957==-- From bugzilla-daemon@bugs.koha-community.org Tue Mar 14 10:36:42 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Tue, 14 Mar 2023 09:36:33 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7980759810072044318==" --===============7980759810072044318== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148150|0 |1 is obsolete| | --- Comment #13 from Matt Blenkinsop --- Created attachment 148153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148153&action=edit Bug 33190: Add search history button to advance search form if EnableSearchHistory keep Add 'search history' button to advanced search button groups if 'EnableSearchHistory' sys pref is set to 'keep' via added code block to advsearch.tt To test: 1) Login to Koha dev box instance 2) Select 'Advanced search module' '/cgi-bin/koha/catalogue/search.pl' 'Search history' icon will not be visible in tools groups in form. 3) Select 'koha administration' module '/cgi-bin/koha/admin/admin-home.pl' 4) Enter 'EnableSearchHistory' string into top search field 5) Change ' EnableSearchHistory' value to 'keep' 6) Press 'Save all Searching preferences' to save pref changes 7) Navigate back to Koha landing home '/cgi-bin/koha/mainpage.pl' 8) Select 'Advanced search module' '/cgi-bin/koha/catalogue/search.pl' 9) 'Search history' icon will now be visible in tools groups in form 10) SIGN OFF Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. --===============7980759810072044318==-- From bugzilla-daemon@bugs.koha-community.org Thu Mar 16 09:26:25 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Thu, 16 Mar 2023 08:26:24 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7834312590135996961==" --===============7834312590135996961== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D33190 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, oleonard@myacpl.org --- Comment #14 from Martin Renvoize --- This is a great little enhancement, thanks Adam (and thanks for lending some guidance here Matt too). I have one very minor query, and I'm going to ask our resident UI guru to wei= gh in on it. The button placement and style is inline with the actions that take place on the same page. There's already precedents for that with the 'Go to item search' which is also a link to another page. I'm wondering if we aught to distinguish more between 'Link to new page' and 'Actions on current page' her= e? We could make this 'feel' like an action by updating the text to 'View search history', but that lengthens the button and I (and accessability guidelines) tend to prefer less wordy links (I'd actually opt for dropping the 'Go to' in the "Item search" button too). Or perhaps we could distinguish these two buttons somehow.. add a separator before them as a logical group.. or right aligh these two.. or change the style up a bit? Owen, do you have any thoughts? --=20 You are receiving this mail because: You are watching all bug changes. --===============7834312590135996961==-- From bugzilla-daemon@bugs.koha-community.org Sat Mar 18 01:23:58 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Sat, 18 Mar 2023 00:23:57 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7193240570874340023==" --===============7193240570874340023== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D33190 --- Comment #15 from Adam Styles --- Hi Martin, Thanks for considering my UI feature for the community and also thanks for ki= ck starting a UX improvement conversation. I look forward to seeing what can be improved for everyone. Thanks 8-) --=20 You are receiving this mail because: You are watching all bug changes. --===============7193240570874340023==-- From bugzilla-daemon@bugs.koha-community.org Fri Apr 21 17:41:32 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Fri, 21 Apr 2023 15:41:31 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0401174440627555272==" --===============0401174440627555272== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. --===============0401174440627555272==-- From bugzilla-daemon@bugs.koha-community.org Fri Apr 21 17:56:05 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Fri, 21 Apr 2023 15:56:04 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8783790179906560687==" --===============8783790179906560687== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============8783790179906560687==-- From bugzilla-daemon@bugs.koha-community.org Fri Apr 21 17:56:15 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Fri, 21 Apr 2023 15:56:06 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2840741358546094455==" --===============2840741358546094455== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148153|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 150057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150057&action=edit Bug 33190: Add search history button to advance search form if EnableSearchHistory keep Add 'search history' button to advanced search button groups if 'EnableSearchHistory' sys pref is set to 'keep' via added code block to advsearch.tt To test: 1) Login to Koha dev box instance 2) Select 'Advanced search module' '/cgi-bin/koha/catalogue/search.pl' 'Search history' icon will not be visible in tools groups in form. 3) Select 'koha administration' module '/cgi-bin/koha/admin/admin-home.pl' 4) Enter 'EnableSearchHistory' string into top search field 5) Change ' EnableSearchHistory' value to 'keep' 6) Press 'Save all Searching preferences' to save pref changes 7) Navigate back to Koha landing home '/cgi-bin/koha/mainpage.pl' 8) Select 'Advanced search module' '/cgi-bin/koha/catalogue/search.pl' 9) 'Search history' icon will now be visible in tools groups in form 10) SIGN OFF Signed-off-by: Matt Blenkinsop Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. --===============2840741358546094455==-- From bugzilla-daemon@bugs.koha-community.org Fri Apr 21 17:56:50 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Fri, 21 Apr 2023 15:56:49 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3270377150028323078==" --===============3270377150028323078== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 --- Comment #17 from Kyle M Hall --- After trying half a dozen different things, I've come to the conclusion that the link is sufficiently self-explanatory as-is. -- You are receiving this mail because: You are watching all bug changes. --===============3270377150028323078==-- From bugzilla-daemon@bugs.koha-community.org Tue May 16 15:18:42 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Tue, 16 May 2023 13:18:08 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4935777746051229366==" --===============4935777746051229366== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. --===============4935777746051229366==-- From bugzilla-daemon@bugs.koha-community.org Tue May 16 15:18:53 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Tue, 16 May 2023 13:18:10 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5248387261458460239==" --===============5248387261458460239== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 --- Comment #18 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. --===============5248387261458460239==-- From bugzilla-daemon@bugs.koha-community.org Wed Jun 7 13:35:17 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Wed, 07 Jun 2023 11:35:06 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6652416440511148282==" --===============6652416440511148282== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31761 -- You are receiving this mail because: You are watching all bug changes. --===============6652416440511148282==-- From bugzilla-daemon@bugs.koha-community.org Wed Jun 7 13:44:55 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Wed, 07 Jun 2023 11:44:55 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1868744509249893205==" --===============1868744509249893205== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #19 from Pedro Amorim --- Enhancement. Not pushing to 22.11.x. -- You are receiving this mail because: You are watching all bug changes. --===============1868744509249893205==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 20 18:23:56 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Fri, 20 Oct 2023 16:23:55 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6030369748320905724==" --===============6030369748320905724== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com Documentation| |Kelly McElligott contact| | -- You are receiving this mail because: You are watching all bug changes. --===============6030369748320905724==-- From bugzilla-daemon@bugs.koha-community.org Thu Jul 25 13:58:32 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Thu, 25 Jul 2024 11:15:11 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5165888386713114040==" --===============5165888386713114040== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes. --===============5165888386713114040==-- From bugzilla-daemon@bugs.koha-community.org Wed Nov 19 09:00:03 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep Date: Wed, 19 Nov 2025 08:00:02 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9069853921753844545==" --===============9069853921753844545== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D33190 Adam Styles changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #20 from Adam Styles --- Hi All, I note the 'needs documenting' status on this enhancement added in 2023. I checked the koha 24.11 manual and see documenation is now provided for this feauture. https://koha-community.org/manual/24.11/en/html/searching.html#advanced-searc= hing If it's ok I will update status on this one to 'resolved' Thanks. --=20 You are receiving this mail because: You are watching all bug changes. --===============9069853921753844545==--