From bugzilla-daemon@bugs.koha-community.org Fri Mar 27 16:11:51 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 25002] New: JS Includes should be wrapped with
 template comments
Date: Fri, 27 Mar 2020 15:11:50 +0000
Message-ID: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7125316323654795212=="

--===============7125316323654795212==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D25002

            Bug ID: 25002
           Summary: JS Includes should be wrapped with template comments
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs@lists.koha-community.org
          Reporter: martin.renvoize@ptfs-europe.com
        QA Contact: testopia@bugs.koha-community.org

When debugging, we are often faced with a nameless <script> area when it comes
to inspecting the page.. it would be helpful to have an HTML comment wrapping
these script in our includes so you can quickly identify where the JS is comi=
ng
from.

--=20
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============7125316323654795212==--


From bugzilla-daemon@bugs.koha-community.org Fri Mar 27 16:15:29 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Fri, 27 Mar 2020 15:15:28 +0000
Message-ID: <bug-25002-70-LZFgIR6Dmp@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7853637045662807485=="

--===============7853637045662807485==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

--- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> ---
See first few minutes of the `Koha Virtual Hackfest - Code Spaghetti` live
stream recording for further context.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============7853637045662807485==--


From bugzilla-daemon@bugs.koha-community.org Fri Mar 27 16:52:21 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Fri, 27 Mar 2020 15:52:10 +0000
Message-ID: <bug-25002-70-4IrqWMaKxr@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0788356853376567475=="

--===============0788356853376567475==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew@bywatersolutions.com

--- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> ---
*** Bug 25003 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============0788356853376567475==--


From bugzilla-daemon@bugs.koha-community.org Fri Mar 27 16:52:31 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Fri, 27 Mar 2020 15:52:28 +0000
Message-ID: <bug-25002-70-TgAMI7QJUK@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1445674719671667083=="

--===============1445674719671667083==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

--- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> ---
Martin beat me to it :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============1445674719671667083==--


From bugzilla-daemon@bugs.koha-community.org Fri Mar 27 17:14:00 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Fri, 27 Mar 2020 16:13:42 +0000
Message-ID: <bug-25002-70-BksLaOYdix@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0297261648242914163=="

--===============0297261648242914163==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Martin Renvoize <martin.renvoize@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |25003


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25003
[Bug 25003] Clearly identify when JavaScript errors are caused by
OPACUserJS/IntranetUserJS
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============0297261648242914163==--


From bugzilla-daemon@bugs.koha-community.org Sat Mar 28 00:36:37 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Fri, 27 Mar 2020 23:36:36 +0000
Message-ID: <bug-25002-70-kARbFRPhXz@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0503461049380090218=="

--===============0503461049380090218==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============0503461049380090218==--


From bugzilla-daemon@bugs.koha-community.org Sat Mar 28 17:43:52 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Sat, 28 Mar 2020 16:43:51 +0000
Message-ID: <bug-25002-70-opY0KPoCwM@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7441257335732597364=="

--===============7441257335732597364==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7441257335732597364==--


From bugzilla-daemon@bugs.koha-community.org Sat Mar 28 17:44:02 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Sat, 28 Mar 2020 16:43:54 +0000
Message-ID: <bug-25002-70-vv1rGOxfFc@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6031875363389403664=="

--===============6031875363389403664==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

--- Comment #4 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 102041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102041&action=edit
Bug 25002: JS Includes should be wrapped with template comments

This patch adds HTML comments to Template::Toolkit include files which
contain <script> tags so that it is clear where the embedded scripts can
be found in the code.

To test, apply the patch and view source on the following pages to
verify the presence of the comments:

Acquisitions home page:
  - acquisitions-toolbar.inc
  - validtor-strings.inc
  - js_includes.inc
  - format-price.inc
Cataloging -> Add/Edit item:
  - additem.js.inc
  - columns_settings.inc
  - strings.inc
  - select2.inc
  - calendar.inc
  - str/cataloging_additem.inc
Authorities home page:
  - authorities_js.inc
Bibliographic detail page:
  - catalog-strings.inc
Cataloging -> Advanced editor:
  - cateditor-ui.inc
  - cateditor-widgets-marc21.inc
Administration -> Item types:
  - greybox.inc
ILL requests:
  - ill-list-table-strings.inc
Web installer
  - installer-intranet-bottom.inc
Web installer -> Onboarding
  - installer-strings.inc
Lists -> List contents -> Merge records
  - merge-record-strings.inc
Patrons -> Patron -> Change password
  - password_check.inc
  - str/members-menu.inc
Patrons -> Patron -> Print summary
  - slip-print.inc
Circulation -> Check out
  - timepicker.inc
Administration -> System preferences:
  - str/tinymce_i18n.inc
  - wysiwyg-systempreferences.inc
Cataloging -> Z39.50 Search:
  - z3950_search.inc

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6031875363389403664==--


From bugzilla-daemon@bugs.koha-community.org Sat Mar 28 17:45:39 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Sat, 28 Mar 2020 16:45:38 +0000
Message-ID: <bug-25002-70-EMpLtUFOfT@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5201108431457784553=="

--===============5201108431457784553==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Small patch                 |---

--- Comment #5 from Owen Leonard <oleonard@myacpl.org> ---
I hope this patch is what you had in mind.

Going through the includes highlights the need to update and/or remove several
of them now that we have proper JS i18n, but I didn't think it hurt to update
them anyway in the meantime.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5201108431457784553==--


From bugzilla-daemon@bugs.koha-community.org Sat Mar 28 17:45:49 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Sat, 28 Mar 2020 16:45:44 +0000
Message-ID: <bug-25002-70-df9Y5HbOIZ@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1051396938092772381=="

--===============1051396938092772381==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1051396938092772381==--


From bugzilla-daemon@bugs.koha-community.org Sat Mar 28 17:45:59 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Sat, 28 Mar 2020 16:45:55 +0000
Message-ID: <bug-25002-70-egKQd3DZwk@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8322695218494796216=="

--===============8322695218494796216==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Architecture, internals,    |Templates
                   |and plumbing                |

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8322695218494796216==--


From bugzilla-daemon@bugs.koha-community.org Mon Mar 30 00:55:28 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Sun, 29 Mar 2020 22:55:27 +0000
Message-ID: <bug-25002-70-n2z8JENNb6@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8336651898428242672=="

--===============8336651898428242672==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D25002

David Roberts <david.roberts@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.roberts@ptfs-europe.c
                   |                            |om

--- Comment #6 from David Roberts <david.roberts@ptfs-europe.com> ---
I've been through this, and have a few comments.

Firstly, I can't see where the additem.js.inc displays - it doesn't seem to be
on the same page as all the other "Cataloging -> Add/Edit item:" comments that
you've added.

Secondly, <!-- / password_check.inc --> and <!-- password_check.inc --> seem =
to
render the wrong way round - i.e. the closing tag displays first.

Thirdly, str/tinymce_i18n.inc doesn't seem to have a closing comment.

I haven't been able to test the web installer pages yet, and I can't get to t=
he
source on the Patrons -> Patron -> Print summary screen because the printer
dialogue blocks access to it.

Everything else seems perfect though :-)

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============8336651898428242672==--


From bugzilla-daemon@bugs.koha-community.org Tue Apr 21 15:44:30 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Tue, 21 Apr 2020 13:44:29 +0000
Message-ID: <bug-25002-70-u19f7OJH0V@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3954622184917417872=="

--===============3954622184917417872==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102041|0                           |1
        is obsolete|                            |

--- Comment #7 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 103374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103374&action=edit
Bug 25002: JS Includes should be wrapped with template comments

This patch adds HTML comments to Template::Toolkit include files which
contain <script> tags so that it is clear where the embedded scripts can
be found in the code.

To test, apply the patch and view source on the following pages to
verify the presence of the comments:

Acquisitions home page:
  - acquisitions-toolbar.inc
  - validtor-strings.inc
  - js_includes.inc
  - format-price.inc
Acquisitions -> Add order from new record,
Acquisitions -> Receive order:
  - additem.js.inc
Cataloging -> Add/Edit item:
  - columns_settings.inc
  - strings.inc
  - select2.inc
  - calendar.inc
  - str/cataloging_additem.inc
Authorities home page:
  - authorities_js.inc
Bibliographic detail page:
  - catalog-strings.inc
Cataloging -> Advanced editor:
  - cateditor-ui.inc
  - cateditor-widgets-marc21.inc
Administration -> Item types:
  - greybox.inc
ILL requests:
  - ill-list-table-strings.inc
Web installer
  - installer-intranet-bottom.inc
Web installer -> Onboarding
  - installer-strings.inc
Lists -> List contents -> Merge records
  - merge-record-strings.inc
Patrons -> Patron -> Change password
  - password_check.inc
  - str/members-menu.inc
Patrons -> Patron -> Print summary
  - slip-print.inc
Circulation -> Check out
  - timepicker.inc
Administration -> System preferences:
  - str/tinymce_i18n.inc
  - wysiwyg-systempreferences.inc
Cataloging -> Z39.50 Search:
  - z3950_search.inc

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3954622184917417872==--


From bugzilla-daemon@bugs.koha-community.org Tue Apr 21 15:46:00 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Tue, 21 Apr 2020 13:45:59 +0000
Message-ID: <bug-25002-70-ojKzKXPOns@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1567448568587516826=="

--===============1567448568587516826==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

--- Comment #8 from Owen Leonard <oleonard@myacpl.org> ---
Thanks for testing, David. And don't hesitate to mark something "Failed QA"
when you see problems. If anything it gets my attention!

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1567448568587516826==--


From bugzilla-daemon@bugs.koha-community.org Tue Apr 28 12:13:52 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Tue, 28 Apr 2020 10:13:51 +0000
Message-ID: <bug-25002-70-qoHXIFDg4F@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2808821303464510201=="

--===============2808821303464510201==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Frédéric Demians <frederic@tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2808821303464510201==--


From bugzilla-daemon@bugs.koha-community.org Tue Apr 28 12:14:03 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Tue, 28 Apr 2020 10:13:55 +0000
Message-ID: <bug-25002-70-l9tpOz6CWa@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0561499471253538166=="

--===============0561499471253538166==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Frédéric Demians <frederic@tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #103374|0                           |1
        is obsolete|                            |

--- Comment #9 from Frédéric Demians <frederic@tamil.fr> ---
Created attachment 103841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103841&action=edit
Bug 25002: JS Includes should be wrapped with template comments

This patch adds HTML comments to Template::Toolkit include files which
contain <script> tags so that it is clear where the embedded scripts can
be found in the code.

To test, apply the patch and view source on the following pages to
verify the presence of the comments:

Acquisitions home page:
  - acquisitions-toolbar.inc
  - validtor-strings.inc
  - js_includes.inc
  - format-price.inc
Acquisitions -> Add order from new record,
Acquisitions -> Receive order:
  - additem.js.inc
Cataloging -> Add/Edit item:
  - columns_settings.inc
  - strings.inc
  - select2.inc
  - calendar.inc
  - str/cataloging_additem.inc
Authorities home page:
  - authorities_js.inc
Bibliographic detail page:
  - catalog-strings.inc
Cataloging -> Advanced editor:
  - cateditor-ui.inc
  - cateditor-widgets-marc21.inc
Administration -> Item types:
  - greybox.inc
ILL requests:
  - ill-list-table-strings.inc
Web installer
  - installer-intranet-bottom.inc
Web installer -> Onboarding
  - installer-strings.inc
Lists -> List contents -> Merge records
  - merge-record-strings.inc
Patrons -> Patron -> Change password
  - password_check.inc
  - str/members-menu.inc
Patrons -> Patron -> Print summary
  - slip-print.inc
Circulation -> Check out
  - timepicker.inc
Administration -> System preferences:
  - str/tinymce_i18n.inc
  - wysiwyg-systempreferences.inc
Cataloging -> Z39.50 Search:
  - z3950_search.inc

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0561499471253538166==--


From bugzilla-daemon@bugs.koha-community.org Tue Apr 28 20:40:05 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Tue, 28 Apr 2020 18:40:05 +0000
Message-ID: <bug-25002-70-UjU7xnXeqG@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1813449046730038668=="

--===============1813449046730038668==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |25003
         Depends on|25003                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25003
[Bug 25003] Clearly identify when JavaScript errors are caused by
OPACUserJS/IntranetUserJS
-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1813449046730038668==--


From bugzilla-daemon@bugs.koha-community.org Tue Apr 28 20:44:03 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Tue, 28 Apr 2020 18:44:02 +0000
Message-ID: <bug-25002-70-uZ1nCJOwo5@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2325655709638813759=="

--===============2325655709638813759==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2325655709638813759==--


From bugzilla-daemon@bugs.koha-community.org Tue Apr 28 20:44:13 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Tue, 28 Apr 2020 18:44:06 +0000
Message-ID: <bug-25002-70-35IlfhLV0t@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5476980432238090301=="

--===============5476980432238090301==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #103841|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 103877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103877&action=edit
Bug 25002: JS Includes should be wrapped with template comments

This patch adds HTML comments to Template::Toolkit include files which
contain <script> tags so that it is clear where the embedded scripts can
be found in the code.

To test, apply the patch and view source on the following pages to
verify the presence of the comments:

Acquisitions home page:
  - acquisitions-toolbar.inc
  - validtor-strings.inc
  - js_includes.inc
  - format-price.inc
Acquisitions -> Add order from new record,
Acquisitions -> Receive order:
  - additem.js.inc
Cataloging -> Add/Edit item:
  - columns_settings.inc
  - strings.inc
  - select2.inc
  - calendar.inc
  - str/cataloging_additem.inc
Authorities home page:
  - authorities_js.inc
Bibliographic detail page:
  - catalog-strings.inc
Cataloging -> Advanced editor:
  - cateditor-ui.inc
  - cateditor-widgets-marc21.inc
Administration -> Item types:
  - greybox.inc
ILL requests:
  - ill-list-table-strings.inc
Web installer
  - installer-intranet-bottom.inc
Web installer -> Onboarding
  - installer-strings.inc
Lists -> List contents -> Merge records
  - merge-record-strings.inc
Patrons -> Patron -> Change password
  - password_check.inc
  - str/members-menu.inc
Patrons -> Patron -> Print summary
  - slip-print.inc
Circulation -> Check out
  - timepicker.inc
Administration -> System preferences:
  - str/tinymce_i18n.inc
  - wysiwyg-systempreferences.inc
Cataloging -> Z39.50 Search:
  - z3950_search.inc

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5476980432238090301==--


From bugzilla-daemon@bugs.koha-community.org Wed Apr 29 18:37:41 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Wed, 29 Apr 2020 16:36:02 +0000
Message-ID: <bug-25002-70-jhyaXV3JKt@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2584925308239296117=="

--===============2584925308239296117==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Martin Renvoize <martin.renvoize@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2584925308239296117==--


From bugzilla-daemon@bugs.koha-community.org Wed Apr 29 18:37:52 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Wed, 29 Apr 2020 16:36:04 +0000
Message-ID: <bug-25002-70-CBINHu8fju@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3140823514853619651=="

--===============3140823514853619651==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

--- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3140823514853619651==--


From bugzilla-daemon@bugs.koha-community.org Mon May 11 10:41:33 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Fri, 08 May 2020 22:39:37 +0000
Message-ID: <bug-25002-70-AmKhogMUA4@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6844791216019163368=="

--===============6844791216019163368==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Joy Nelson <joy@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy@bywatersolutions.com

--- Comment #12 from Joy Nelson <joy@bywatersolutions.com> ---
enhancement not backported to 19.11

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6844791216019163368==--


From bugzilla-daemon@bugs.koha-community.org Wed May 20 11:59:10 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments
Date: Wed, 20 May 2020 09:59:09 +0000
Message-ID: <bug-25002-70-3QpvDeilYf@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4963446540063740942=="

--===============4963446540063740942==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Martin Renvoize <martin.renvoize@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4963446540063740942==--