From bugzilla-daemon@bugs.koha-community.org Thu Nov  5 19:55:51 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] New: TinyMCE in the News Tool is still doing
 some types of automatic code cleanup
Date: Thu, 05 Nov 2020 18:55:50 +0000
Message-ID: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2998328638793004911=="

--===============2998328638793004911==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

            Bug ID: 26942
           Summary: TinyMCE in the News Tool is still doing some types of
                    automatic code cleanup
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs@lists.koha-community.org
          Reporter: lucas@bywatersolutions.com
        QA Contact: testopia@bugs.koha-community.org

To recreate:

-Make sure the sys pref 'NewsToolEditor' is set to TinyMCE
-Go to any news item and add this line:  <link
href="https://fonts.googleapis.com/css?family=Open+Sans” rel=“stylesheet">
-Save the news item
-Re-open the same news item again in TinyMCE.
-The editor has removed that line. Annoying!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============2998328638793004911==--


From bugzilla-daemon@bugs.koha-community.org Thu Nov  5 20:24:12 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Thu, 05 Nov 2020 19:24:11 +0000
Message-ID: <bug-26942-70-ioXaqgEgHk@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6754713165383699804=="

--===============6754713165383699804==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942
--- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> ---
TinyMCE doesn't automatically takes out HTML tags like <link>, <style>, and
<meta> because those are not valid HTML tags inside the HTML body. They belong
in the HTML <head>.

Perhaps we need a new system preference that would allow librarians to insert
things into the HTML <head>. We should be able to easily add this to
doc-head-open.inc

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============6754713165383699804==--


From bugzilla-daemon@bugs.koha-community.org Fri Nov  6 00:09:14 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Thu, 05 Nov 2020 23:09:14 +0000
Message-ID: <bug-26942-70-BxTTvrRxPh@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8833536676917600255=="

--===============8833536676917600255==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

David Cook <dcook@prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook@prosentient.com.au

--- Comment #2 from David Cook <dcook@prosentient.com.au> ---
(In reply to Lucas Gass from comment #1)
> TinyMCE doesn't automatically takes out HTML tags like <link>, <style>, and
> <meta> because those are not valid HTML tags inside the HTML body. They
> belong in the HTML <head>.
> 

That should say "TinyMCE automatically takes out HTML tags like...", right?

That is annoying...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============8833536676917600255==--


From bugzilla-daemon@bugs.koha-community.org Fri Nov  6 01:40:35 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Fri, 06 Nov 2020 00:40:34 +0000
Message-ID: <bug-26942-70-JulGBibgpo@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4828945907261855766=="

--===============4828945907261855766==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D26942

--- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> ---
(In reply to David Cook from comment #2)
> (In reply to Lucas Gass from comment #1)
> > TinyMCE doesn't automatically takes out HTML tags like <link>, <style>, a=
nd
> > <meta> because those are not valid HTML tags inside the HTML body. They
> > belong in the HTML <head>.
> >=20
>=20
> That should say "TinyMCE automatically takes out HTML tags like...", right?
>=20
> That is annoying...

David, correct. I meant it DOES automatically take out HTML tags like...


Thanks for clarifying.

--=20
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============4828945907261855766==--


From bugzilla-daemon@bugs.koha-community.org Fri Nov  6 02:43:12 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Fri, 06 Nov 2020 01:43:10 +0000
Message-ID: <bug-26942-70-JbAfGzHCzL@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4838313215558446938=="

--===============4838313215558446938==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D26942

--- Comment #4 from David Cook <dcook@prosentient.com.au> ---
(In reply to Lucas Gass from comment #3)
> David, correct. I meant it DOES automatically take out HTML tags like...
>=20
>=20
> Thanks for clarifying.

Just to clarify again. I was saying that the TinyMCE behaviour was annoying a=
nd
not the typo heh.=20

If you do a patch for this one, I'd be happy to test it. (Probably not
something I'll look at writing my own fix for any time soon thought.)

--=20
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============4838313215558446938==--


From bugzilla-daemon@bugs.koha-community.org Mon Nov  9 15:36:01 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Mon, 09 Nov 2020 14:36:00 +0000
Message-ID: <bug-26942-70-SmetcS1OtL@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4991970739959868581=="

--===============4991970739959868581==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

Lucas Gass <lucas@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============4991970739959868581==--


From bugzilla-daemon@bugs.koha-community.org Fri Jan 22 23:53:47 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Fri, 22 Jan 2021 22:53:46 +0000
Message-ID: <bug-26942-70-TCaDGliAUr@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0823927106623075453=="

--===============0823927106623075453==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

Lucas Gass <lucas@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0823927106623075453==--


From bugzilla-daemon@bugs.koha-community.org Fri Jan 22 23:53:57 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Fri, 22 Jan 2021 22:53:49 +0000
Message-ID: <bug-26942-70-hfQ6McqBTN@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3323676277533582754=="

--===============3323676277533582754==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

--- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> ---
Created attachment 115715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115715&action=edit
Bug 26942: Allow style and link tags in NewsEditor TinyMCE

To Test:
-Make sure the sys pref 'NewsToolEditor' is set to TinyMCE
-Go to any news item and add this line:  <link
href="https://fonts.googleapis.com/css?family=Open+Sans” rel=“stylesheet">
-Save the news item
-Re-open the same news item again in TinyMCE.
-The editor has removed that line. Annoying!
-Apply patch
-Try again, the <link> should stay now

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3323676277533582754==--


From bugzilla-daemon@bugs.koha-community.org Thu Feb  4 15:47:29 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Thu, 04 Feb 2021 14:45:07 +0000
Message-ID: <bug-26942-70-N2tsWVMxZx@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5156292411198799097=="

--===============5156292411198799097==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

Kyle M Hall <kyle@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5156292411198799097==--


From bugzilla-daemon@bugs.koha-community.org Fri Mar 26 05:52:17 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Fri, 26 Mar 2021 04:52:16 +0000
Message-ID: <bug-26942-70-ZmDx7sRv8D@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5824607472206455857=="

--===============5824607472206455857==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

--- Comment #6 from David Cook <dcook@prosentient.com.au> ---
Just used this in a hot fix. So handy. I'll run up a KTD and sign this off
pronto...

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5824607472206455857==--


From bugzilla-daemon@bugs.koha-community.org Fri Mar 26 13:34:53 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Fri, 26 Mar 2021 12:34:52 +0000
Message-ID: <bug-26942-70-z1PWXo8fJM@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0511235014181353244=="

--===============0511235014181353244==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

Michael Sutherland <sudrland@vt.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sudrland@vt.edu

--- Comment #7 from Michael Sutherland <sudrland@vt.edu> ---
This is plainly awful. As a web developer, I do not want some WYSIWYG editor
telling me I do not know how to write HTML and start taking out HTML I put in
for a reason, such as a <div> or <script> and then have everything break
because the system does not like my HTML. It's not incorrect to have certain
tags in the body and we've done it that way precisely because we do not have
access to add code in the <head>. I understand some of us are a little more
savvy and technically able to write HTML than others and this is attempting to
make something work for everyone, because clearly, not everyone knows how to
write HTML. However, this development is not at all 'handy'. And, I do not
particularly like that everything was moved out of system preferences into the
news section.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0511235014181353244==--


From bugzilla-daemon@bugs.koha-community.org Fri Mar 26 14:42:11 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Fri, 26 Mar 2021 13:42:10 +0000
Message-ID: <bug-26942-70-TKGzSBX6b3@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6381050302309343074=="

--===============6381050302309343074==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

--- Comment #8 from Michael Sutherland <sudrland@vt.edu> ---
If this is meant to fix those issues with the WYSIWYG editing code then it
should be a higher priority. What I intended to say is that the WYSIWYG making
coding changes is not helpful, especially when it does not have a way to log
and recover lost code due to those changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6381050302309343074==--


From bugzilla-daemon@bugs.koha-community.org Fri Mar 26 15:59:42 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Fri, 26 Mar 2021 14:59:42 +0000
Message-ID: <bug-26942-70-zutmrci3fn@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7573645184223347911=="

--===============7573645184223347911==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D26942

--- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> ---
It looks like we could optionally disable validation in TinyMCE:
https://stackoverflow.com/questions/7058623/tinymce-completely-disable-valida=
tion

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============7573645184223347911==--


From bugzilla-daemon@bugs.koha-community.org Fri Mar 26 16:15:56 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Fri, 26 Mar 2021 15:15:55 +0000
Message-ID: <bug-26942-70-gWZ7hGwh2W@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4617878079378379405=="

--===============4617878079378379405==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

--- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> ---
(In reply to Kyle M Hall from comment #9)
> It looks like we could optionally disable validation in TinyMCE:
> https://stackoverflow.com/questions/7058623/tinymce-completely-disable-
> validation

verify_html: false is already set when initializing TinyMCE. Maybe we should
add these other lines to the config:


    cleanup_on_startup: false,
    trim_span_elements: false,
    cleanup: false,
    convert_urls: false

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4617878079378379405==--


From bugzilla-daemon@bugs.koha-community.org Fri Mar 26 16:22:17 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Fri, 26 Mar 2021 15:22:16 +0000
Message-ID: <bug-26942-70-KpfUwOMLnT@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3677050204471406488=="

--===============3677050204471406488==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

Lucas Gass <lucas@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3677050204471406488==--


From bugzilla-daemon@bugs.koha-community.org Sat Mar 27 09:20:01 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Sat, 27 Mar 2021 08:20:00 +0000
Message-ID: <bug-26942-70-mJ5D3mjqnM@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2613274780273987384=="

--===============2613274780273987384==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

Amit Gupta <amitddng135@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115715|0                           |1
        is obsolete|                            |
                 CC|                            |amitddng135@gmail.com

--- Comment #11 from Amit Gupta <amitddng135@gmail.com> ---
Created attachment 118885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118885&action=edit
Bug 26942: Allow style and link tags in NewsEditor TinyMCE

To Test:
-Make sure the sys pref 'NewsToolEditor' is set to TinyMCE
-Go to any news item and add this line:  <link
href="https://fonts.googleapis.com/css?family=Open+Sans” rel=“stylesheet">
-Save the news item
-Re-open the same news item again in TinyMCE.
-The editor has removed that line. Annoying!
-Apply patch
-Try again, the <link> should stay now

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2613274780273987384==--


From bugzilla-daemon@bugs.koha-community.org Sat Mar 27 09:20:20 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Sat, 27 Mar 2021 08:20:19 +0000
Message-ID: <bug-26942-70-RS785SrvA0@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7029788889455601304=="

--===============7029788889455601304==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

Amit Gupta <amitddng135@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7029788889455601304==--


From bugzilla-daemon@bugs.koha-community.org Sat Mar 27 16:16:44 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Sat, 27 Mar 2021 15:16:43 +0000
Message-ID: <bug-26942-70-yNBsE3JmnF@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5065556571871784342=="

--===============5065556571871784342==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D26942

--- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
(In reply to Lucas Gass from comment #10)
> (In reply to Kyle M Hall from comment #9)
> > It looks like we could optionally disable validation in TinyMCE:
> > https://stackoverflow.com/questions/7058623/tinymce-completely-disable-
> > validation
>=20
> verify_html: false is already set when initializing TinyMCE. Maybe we should
> add these other lines to the config:
>=20
> =20
>     cleanup_on_startup: false,
>     trim_span_elements: false,
>     cleanup: false,
>     convert_urls: false

I'd like to see this investigated. Now that both editors can be used alongsid=
e,
it's very bad when one changes what was written with the other. At least this
is unexpected behaviour.

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============5065556571871784342==--


From bugzilla-daemon@bugs.koha-community.org Sat Mar 27 16:28:44 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Sat, 27 Mar 2021 15:28:43 +0000
Message-ID: <bug-26942-70-X31iO4piwS@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3641816726810402557=="

--===============3641816726810402557==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3641816726810402557==--


From bugzilla-daemon@bugs.koha-community.org Sat Mar 27 16:28:54 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Sat, 27 Mar 2021 15:28:46 +0000
Message-ID: <bug-26942-70-fvyvXlGLHW@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0867764895516205805=="

--===============0867764895516205805==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118885|0                           |1
        is obsolete|                            |

--- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 118902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118902&action=edit
Bug 26942: Allow style and link tags in NewsEditor TinyMCE

To Test:
-Make sure the sys pref 'NewsToolEditor' is set to TinyMCE
-Go to any news item and add this line:  <link
href="https://fonts.googleapis.com/css?family=Open+Sans" rel="stylesheet">
-Save the news item
-Re-open the same news item again in TinyMCE.
-The editor has removed that line. Annoying!
-Apply patch
-Try again, the <link> should stay now

Signed-off-by: Amit Gupta <amitddng135@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0867764895516205805==--


From bugzilla-daemon@bugs.koha-community.org Mon Mar 29 04:34:35 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Mon, 29 Mar 2021 02:34:34 +0000
Message-ID: <bug-26942-70-ei0qy2bmFw@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5161753005544894547=="

--===============5161753005544894547==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

--- Comment #14 from David Cook <dcook@prosentient.com.au> ---
Apologies for not doing more last week. I got caught up with other things, but
glad to see it sparked more action!

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5161753005544894547==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr  1 18:55:14 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Thu, 01 Apr 2021 16:53:46 +0000
Message-ID: <bug-26942-70-YsPYg9hyqT@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4888610221157409893=="

--===============4888610221157409893==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4888610221157409893==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr  1 18:55:24 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Thu, 01 Apr 2021 16:53:48 +0000
Message-ID: <bug-26942-70-eWsbrAgTM3@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8323494014842629581=="

--===============8323494014842629581==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D26942

--- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org=
> ---
Pushed to master for 21.05, thanks to everybody involved!

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============8323494014842629581==--


From bugzilla-daemon@bugs.koha-community.org Fri Apr  2 20:28:25 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Fri, 02 Apr 2021 18:28:24 +0000
Message-ID: <bug-26942-70-fKuYkscsDx@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9098226036094225631=="

--===============9098226036094225631==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D26942

--- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> ---
(In reply to Michael Sutherland from comment #7)
> This is plainly awful. As a web developer, I do not want some WYSIWYG editor
> telling me I do not know how to write HTML and start taking out HTML I put
> in for a reason, such as a <div> or <script> and then have everything break
> because the system does not like my HTML. It's not incorrect to have certain
> tags in the body and we've done it that way precisely because we do not have
> access to add code in the <head>. I understand some of us are a little more
> savvy and technically able to write HTML than others and this is attempting
> to make something work for everyone, because clearly, not everyone knows how
> to write HTML. However, this development is not at all 'handy'. And, I do
> not particularly like that everything was moved out of system preferences
> into the news section.

I think Michael brings up a good point here. There is no way to insert script=
s,
links to Google fonts, meta tags into the HTML head and many bypassed this by
adding those things to the OPACHeader.=20

I have filed bug 28080

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============9098226036094225631==--


From bugzilla-daemon@bugs.koha-community.org Wed Apr  7 15:19:29 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Wed, 07 Apr 2021 13:19:28 +0000
Message-ID: <bug-26942-70-sLRAaIU3fm@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6759947780093954557=="

--===============6759947780093954557==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

Fridolin Somers <fridolin.somers@biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers@biblibre.co
                   |                            |m
         Version(s)|21.05.00                    |21.05.00,20.11.05
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> ---
Pushed to 20.11.x for 20.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6759947780093954557==--


From bugzilla-daemon@bugs.koha-community.org Sat Apr 24 14:51:16 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Sat, 24 Apr 2021 12:51:16 +0000
Message-ID: <bug-26942-70-bFOs5QX3YU@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0589063945176383812=="

--===============0589063945176383812==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D26942

Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew@bywatersolutions.com

--- Comment #18 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> ---
I'm still loosing my link on 20.05 with this patch. Can you please take a loo=
k,
Lucas?

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============0589063945176383812==--


From bugzilla-daemon@bugs.koha-community.org Sat Apr 24 15:39:16 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Sat, 24 Apr 2021 13:39:14 +0000
Message-ID: <bug-26942-70-5Syk7iqKbs@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7390489606301174266=="

--===============7390489606301174266==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #19 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> ---
Talked to Lucas, I'd misunderstood the test plan. Pushed to 20.05.x for
20.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7390489606301174266==--


From bugzilla-daemon@bugs.koha-community.org Sat Apr 24 15:39:27 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Sat, 24 Apr 2021 13:39:26 +0000
Message-ID: <bug-26942-70-exwilL3MiT@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0514583451004305042=="

--===============0514583451004305042==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.05.00,20.11.05           |21.05.00,20.11.05,20.05.11
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0514583451004305042==--


From bugzilla-daemon@bugs.koha-community.org Sat Apr 24 18:47:52 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Sat, 24 Apr 2021 16:47:51 +0000
Message-ID: <bug-26942-70-ChU0RPZLlY@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8981804697900452157=="

--===============8981804697900452157==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

Victor Grousset/tuxayo <victor@tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |victor@tuxayo.net

--- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8981804697900452157==--


From bugzilla-daemon@bugs.koha-community.org Thu Aug  3 06:21:45 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some
 types of automatic code cleanup
Date: Thu, 03 Aug 2023 04:21:32 +0000
Message-ID: <bug-26942-70-YbQfk9ZbnZ@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-26942-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8069035629001734382=="

--===============8069035629001734382==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

David Cook <dcook@prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=34463

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8069035629001734382==--


