From bugzilla-daemon@bugs.koha-community.org Wed Feb 19 23:15:02 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 13881] Add desk management
Date: Wed, 19 Feb 2020 22:15:01 +0000
Message-ID: <bug-13881-70-abNPOK2Q5L@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5222365040294029937=="

--===============5222365040294029937==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D13881

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Hi Nicolas,

starting with QA review here:

1) QA test tools

Possibly a false positive:
 FAIL   Koha/Desk.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl=20
-MPod::Coverage=3DPackageName -e666


 FAIL   Koha/Desks.pm
   FAIL   pod coverage
                POD is missing for 'object_class'


Possibly a false positive:
 FAIL   Koha/Schema/Result/Desk.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=3DPackageName -e666


 FAIL   koha-tmpl/intranet-tmpl/prog/en/includes/desks-admin-search.inc
   FAIL   filters
                missing_filter at line 3 (<h1 id=3D"logo"><a
href=3D"/cgi-bin/koha/mainpage.pl">[% LibraryName %]</a></h1><!-- Begin Desks
Resident Search Box -->)
                missing_filter at line 7 (      <form action=3D"[% script_name
%]" method=3D"post">)
                missing_filter at line 8 (        <input class=3D"head-search=
box"
type=3D"text" name=3D"desk_name" value=3D"[% searchfield %]" size=3D"40" />)
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 5)
                forbidden pattern: tab char (line 7)
                forbidden pattern: tab char (line 9)
                forbidden pattern: tab char (line 10)
                forbidden pattern: tab char (line 11)
                forbidden pattern: tab char (line 15)
                forbidden pattern: tab char (line 17)
                forbidden pattern: tab char (line 18)
                forbidden pattern: tab char (line 21)
                forbidden pattern: tab char (line 22)
                forbidden pattern: tab char (line 23)
                forbidden pattern: tab char (line 24)
                forbidden pattern: tab char (line 28)


 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt
   FAIL   filters
                missing_filter at line 79 (                        <option
value=3D"[% branch.branchcode %]" selected=3D"selected">[% branch.branchname
%]</option>)
                missing_filter at line 79 (                        <option
value=3D"[% branch.branchcode %]" selected=3D"selected">[% branch.branchname
%]</option>)
                missing_filter at line 81 (                        <option
value=3D"[% branch.branchcode %]">[% branch.branchname %]</option>)
                missing_filter at line 81 (                        <option
value=3D"[% branch.branchcode %]">[% branch.branchname %]</option>)


2) Quick code review

admin/desks.pl

Are the copyright statements correct?
+# Copyright 2006 SAN OUEST-PROVENCE et Paul POULAIN
+# Copyright 2015 Koha Development Team

Leftover debugging code:
+use Data::Dumper;


The new page requires a new permission: manage_desks

+        flagsrequired   =3D> { parameters =3D> 'manage_desks' },

But the new permission is not properly added. It looks like maybe you were
planning to use manage_libraries here instead?

Check:
 koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc
 koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============5222365040294029937==--