From bugzilla-daemon@bugs.koha-community.org Tue Jun 6 17:59:56 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33916] New: Improve translation of title tags: Labels Date: Tue, 06 Jun 2023 15:59:55 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1017368490637955840==" --===============1017368490637955840== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 Bug ID: 33916 Summary: Improve translation of title tags: Labels Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 33906 This patch will modify label creator templates in the staff client so that translatable strings in the tag are wrapped in the correct translation function, e.g. [% t('Translate me') %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33906 [Bug 33906] [OMNIBUS] Improve translation of title tags -- You are receiving this mail because: You are watching all bug changes. --===============1017368490637955840==-- From bugzilla-daemon@bugs.koha-community.org Tue Aug 22 14:58:30 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33916] Improve translation of title tags: Labels Date: Tue, 22 Aug 2023 12:58:29 +0000 Message-ID: <bug-33916-70-cshfdVLzpE@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-33916-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4165011295532335962==" --===============4165011295532335962== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. --===============4165011295532335962==-- From bugzilla-daemon@bugs.koha-community.org Tue Aug 22 14:58:40 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33916] Improve translation of title tags: Labels Date: Tue, 22 Aug 2023 12:58:31 +0000 Message-ID: <bug-33916-70-JepcoKqQW5@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-33916-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4587819980498741972==" --===============4587819980498741972== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154689&action=edit Bug 33916: Improve translation of title tags: Labels This patch label creator templates so that title tags can be more easily translated. The patch also makes some minor changes to some templates to improve consistency between page title, breadcrumb navigation, and page heading. To test, apply the patch and confirm that the following pages have the correct title tags: - Cataloging -> Label creator home - Manage -> Label batches - Edit -> - Click the "Add item(s)" button without entering any barcodes or item numbers in the form. - Test the search form and search results - Manage -> Layouts - Manage -> Label templates - Manage -> Printer profiles - New -> Label batch - New -> Layout - New -> Label template - New -> Printer profile - New -> Barcode range - Cataloging -> Barcode image generator - Cataloging -> Quick spine label creator -- You are receiving this mail because: You are watching all bug changes. --===============4587819980498741972==-- From bugzilla-daemon@bugs.koha-community.org Tue Sep 12 17:20:15 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33916] Improve translation of title tags: Labels Date: Tue, 12 Sep 2023 15:20:14 +0000 Message-ID: <bug-33916-70-ZKxbfgJZrE@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-33916-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8052679278851524903==" --===============8052679278851524903== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 Salah Ghedda <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============8052679278851524903==-- From bugzilla-daemon@bugs.koha-community.org Tue Sep 12 17:20:25 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33916] Improve translation of title tags: Labels Date: Tue, 12 Sep 2023 15:20:16 +0000 Message-ID: <bug-33916-70-kjp6xzSNxM@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-33916-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2699214572999262159==" --===============2699214572999262159== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 Salah Ghedda <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154689|0 |1 is obsolete| | --- Comment #2 from Salah Ghedda <salah.ghedda@inlibro.com> --- Created attachment 155556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155556&action=edit Bug 33916: Improve translation of title tags: Labels This patch label creator templates so that title tags can be more easily translated. The patch also makes some minor changes to some templates to improve consistency between page title, breadcrumb navigation, and page heading. To test, apply the patch and confirm that the following pages have the correct title tags: - Cataloging -> Label creator home - Manage -> Label batches - Edit -> - Click the "Add item(s)" button without entering any barcodes or item numbers in the form. - Test the search form and search results - Manage -> Layouts - Manage -> Label templates - Manage -> Printer profiles - New -> Label batch - New -> Layout - New -> Label template - New -> Printer profile - New -> Barcode range - Cataloging -> Barcode image generator - Cataloging -> Quick spine label creator Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com> -- You are receiving this mail because: You are watching all bug changes. --===============2699214572999262159==-- From bugzilla-daemon@bugs.koha-community.org Sat Oct 7 16:29:57 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33916] Improve translation of title tags: Labels Date: Sat, 07 Oct 2023 14:29:57 +0000 Message-ID: <bug-33916-70-jJAL3URn1t@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-33916-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3585002668174904874==" --===============3585002668174904874== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. --===============3585002668174904874==-- From bugzilla-daemon@bugs.koha-community.org Sat Oct 7 16:33:41 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33916] Improve translation of title tags: Labels Date: Sat, 07 Oct 2023 14:33:41 +0000 Message-ID: <bug-33916-70-ZWKdobtNXV@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-33916-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4361519468682329651==" --===============4361519468682329651== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Couldn't this be simplified? + [% IF ( label_element == 'layout' ) %] + <h2>[% PROCESS translate_label_element element=label_element_title %]</h2> + [% ELSIF ( label_element == 'template' ) %] + <h2>[% PROCESS translate_label_element element=label_element_title %]</h2> + [% ELSIF ( label_element == 'profile' ) %] + <h2>[% PROCESS translate_label_element element=label_element_title %]</h2> + [% ELSIF ( label_element == 'batch' ) %] + <h2>[% PROCESS translate_label_element element=label_element_title %]</h2> + [% END %] To just be? <h2>[% PROCESS translate_label_element element=label_element_title %]</h2> If the outcome is always the same, why do the if/else? -- You are receiving this mail because: You are watching all bug changes. --===============4361519468682329651==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 9 13:03:12 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33916] Improve translation of title tags: Labels Date: Mon, 09 Oct 2023 11:03:11 +0000 Message-ID: <bug-33916-70-qCL60e46Mq@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-33916-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4779459038843901391==" --===============4779459038843901391== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============4779459038843901391==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 9 13:03:22 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33916] Improve translation of title tags: Labels Date: Mon, 09 Oct 2023 11:03:13 +0000 Message-ID: <bug-33916-70-qEKGlpynji@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-33916-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4794125920494877763==" --===============4794125920494877763== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156731&action=edit Bug 33916: (QA follow-up) Remove redundant template code -- You are receiving this mail because: You are watching all bug changes. --===============4794125920494877763==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 20 22:17:52 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33916] Improve translation of title tags: Labels Date: Fri, 20 Oct 2023 20:17:51 +0000 Message-ID: <bug-33916-70-iu9CypAlMk@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-33916-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4238091154547200962==" --===============4238091154547200962== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============4238091154547200962==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 20 22:18:02 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33916] Improve translation of title tags: Labels Date: Fri, 20 Oct 2023 20:17:54 +0000 Message-ID: <bug-33916-70-8YB3Zhi3Qr@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-33916-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5295643784431789083==" --===============5295643784431789083== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155556|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157569&action=edit Bug 33916: Improve translation of title tags: Labels This patch label creator templates so that title tags can be more easily translated. The patch also makes some minor changes to some templates to improve consistency between page title, breadcrumb navigation, and page heading. To test, apply the patch and confirm that the following pages have the correct title tags: - Cataloging -> Label creator home - Manage -> Label batches - Edit -> - Click the "Add item(s)" button without entering any barcodes or item numbers in the form. - Test the search form and search results - Manage -> Layouts - Manage -> Label templates - Manage -> Printer profiles - New -> Label batch - New -> Layout - New -> Label template - New -> Printer profile - New -> Barcode range - Cataloging -> Barcode image generator - Cataloging -> Quick spine label creator Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. --===============5295643784431789083==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 20 22:18:12 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33916] Improve translation of title tags: Labels Date: Fri, 20 Oct 2023 20:17:56 +0000 Message-ID: <bug-33916-70-m19QkUcVQv@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-33916-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9205859004094849386==" --===============9205859004094849386== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156731|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157570&action=edit Bug 33916: (QA follow-up) Remove redundant template code Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. --===============9205859004094849386==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 20 22:18:22 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33916] Improve translation of title tags: Labels Date: Fri, 20 Oct 2023 20:17:59 +0000 Message-ID: <bug-33916-70-8y3YTTjfm0@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-33916-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7583362518715776098==" --===============7583362518715776098== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157571&action=edit Bug 33916: (QA follow-up) Correct "Label profiles" ... to "Printer profiles" Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. --===============7583362518715776098==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 20 22:38:18 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33916] Improve translation of title tags: Labels Date: Fri, 20 Oct 2023 20:38:17 +0000 Message-ID: <bug-33916-70-iijKaf12oS@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-33916-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3223207666693792769==" --===============3223207666693792769== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. --===============3223207666693792769==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 20 22:38:28 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33916] Improve translation of title tags: Labels Date: Fri, 20 Oct 2023 20:38:19 +0000 Message-ID: <bug-33916-70-4y1duLwiEB@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-33916-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2766868716178875477==" --===============2766868716178875477== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. --===============2766868716178875477==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 26 08:32:20 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33916] Improve translation of title tags: Labels Date: Thu, 26 Oct 2023 06:32:19 +0000 Message-ID: <bug-33916-70-dRNKD2sNLa@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-33916-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6989406441699256692==" --===============6989406441699256692== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. --===============6989406441699256692==--